summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)AuthorFilesLines
2019-03-11tdf#121744 XLSX Export Combinated Chart (Column and Line)Jozsef Szakacs2-0/+15
Each of the Column and Line Chart creates it's own x and y Axes. So now the LineChart Exporter Method uses the same Axes as the BarChart. Thanks for the help: - Balazs Varga - Adam Kovacs Reviewed-on: https://gerrit.libreoffice.org/64146 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-on: https://gerrit.libreoffice.org/65449 (cherry picked from commit d58d92d72b00f45c56a3b0fe55ca9fd837d244a9) Change-Id: Ie763cf831c2ce63ef204d1fdcbff634e7ca8fad5
2019-01-22tdf#122031 Unit test checks pie chart data label format.Gülşah Köse2-0/+16
Change-Id: Ie2f153591e69a7a2718e54a0379725dcd659a737 Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/66668 Tested-by: Jenkins
2019-01-17tdf#42915, NaN in a date axis can destroy the whole chartMarkus Mohrhard3-0/+15
The NaN value forces the scaling of the axis to be based on years and introduces gaps in the rendering. Reviewed-on: https://gerrit.libreoffice.org/64267 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> related tdf#42915, pass NaN through date transformation Many places in chart2 use NaN to mean no available value. Not propagating NaN through the helper disables all this functionality. Reviewed-on: https://gerrit.libreoffice.org/64266 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/64304 (cherry picked from commit 55c5382591305a872b961d54571e3c823728ccb2) Reviewed-on: https://gerrit.libreoffice.org/64310 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0a906dc78b575d696d402fb81900700e6e8e761e) Change-Id: I78219be289d76edb53b5672209e1c031ab62def9 37f966007b5b7cc16778c5c6903710fbd144631b
2019-01-17tdf#121205: Convert <a:br> to newline chars in chart titleVasily Melenchuk2-0/+16
Reviewed-on: https://gerrit.libreoffice.org/62752 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 57d4cd80dcaf01fe4897d79d89e906d355410243) Reviewed-on: https://gerrit.libreoffice.org/62990 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit a1ea94fde40b82d0ec7ec842bf44cdeeea676aca) Change-Id: I43d14025c48878c5bc035d492623f4fc52426e5e
2018-12-10use Image(OUString) instead of Image(Bitmap(OUString))Noel Grandin3-117/+117
which benefits LOOL since we can delay creating the image until we know the dpi setting of the display we are going to write to. Achieved by perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" ) followed by git grep -nP '\bImage\s*\(\s*BitmapEx\s*\(' followed by commenting out the BitmapEx(OUString) constructor and seeing what needed adjusting. Change-Id: I3224e11937d720fa484b0d659d25673a9e809267 Reviewed-on: https://gerrit.libreoffice.org/64760 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/64860 Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-26Put text label outside of the pie if..Tamas Bunth1-1/+12
performLabelBestFitInnerPlacement fails. Change-Id: Ic84e8b42e02da2023b22a9406c44d462170c5305 Reviewed-on: https://gerrit.libreoffice.org/64015 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit 3339c730f8c9a6088a2e8b335185f1bf0b232216) Reviewed-on: https://gerrit.libreoffice.org/64034 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-11-08tools: reimplement SVLIBRARY macro & remove it from solar.hMichael Stahl1-0/+1
Change-Id: I03f8f5fd656d62410821f2f2851f1c584c97d1f4
2018-10-17Resolves: tdf#115182 default Chart percentage format is integerEike Rathke5-50/+54
Regression from commit 0f4b3cb7d3d68906de316a64dcec281da2a641bd CommitDate: Mon Aug 10 17:12:45 2015 +0200 The chart2/qa/extras/xshape/data/reference/tdf90839-?.xml reference files were created with the then wrong default of two decimals so need to be adapted. For chart2/qa/extras/xshape/data/reference/tdf90839-1.xml this meant to regenerate because of the changed positions and sizes of labels. Reviewed-on: https://gerrit.libreoffice.org/61826 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 9672d034b9e760f24ac9a6652ab45dee15ee260a) Change-Id: Ib0c2c862af9399ab2af5178d01510aa5e4fff97c
2018-09-12tdf#108028 OOXML: Fix line breaking of chart titleBalazs Varga1-0/+1
With adding the "TextMaximumFrameWidth" property to the chart title's textbox property, it breaks chart titles longer then the chart width, as in OOXML reference implementation. LibreOffice previously distorted the text and squeezed the chart. This patch will fix it. Change-Id: Ic086d25b49e9c5cf9c6f2c79f141592749adc7d8 Reviewed-on: https://gerrit.libreoffice.org/59991 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 063e92004b65411dbee7fc12ab00c78aa9c69a86)
2018-09-12tdf#94502 Fix overlap export of Stacked Bar Chart to *.xlsxBalazs Varga2-0/+23
Export the Overlap value with 100% for stacked charts, because the default overlap value of the Bar/Column chart is 0% and LibreOffice do nothing with the overlap value in Stacked Chart case, unlike the MS Office. Change-Id: If4e20b88c2b1180f68a8d2b610c407d674a8498b Reviewed-on: https://gerrit.libreoffice.org/59448 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins (cherry picked from commit 17c2b0af97f73b9103be982b15d7111b3980e027)
2018-08-29tdf#96469 Export Data Point properties in Charts on DOCX/XLSXBalazs Varga3-0/+40
If the color or other property of a datapoint in the chart deviates from the dataseries property, this patch will write it into a separate dPt tag and fixing the lost properies during OOXML export. Reviewed-on: https://gerrit.libreoffice.org/58806 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Tested-by: Jenkins (cherry picked from commit 15035b98dc694bde4c4073fa75bdd2ce9d7e6670) Change-Id: I3d975675ac3691fcafe76de16e46851561eb2807 Reviewed-on: https://gerrit.libreoffice.org/58807 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga991@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 6fa9aaaa5dca4d6b79698b55a2f2c956c99c3482)
2018-08-23Resolves: tdf#98558 oom under windows with certain chartsCaolán McNamara1-1/+14
keep the performance fix of i#66963 but clip it to a value larger than appears in that document, but massively smaller than what is necessary for this document Change-Id: I162c03a13ce11e348db8168fed212dfea216c7a4 Reviewed-on: https://gerrit.libreoffice.org/59463 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins (cherry picked from commit b707def5e9696c429cfb1dbe8479d5b63046e800)
2018-08-21Resolves: tdf#117069 crash double clicking in certain chartCaolán McNamara1-0/+3
Change-Id: I4506a3517eff7f73cf793195e9d605d450b84fda Reviewed-on: https://gerrit.libreoffice.org/58997 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins (cherry picked from commit d12a200e69d4bedb4228c7632ec648e4fdc21fc2)
2018-08-10tdf#108078 OOXML Export Chart shapes area fill propertiesBalazs Varga10-0/+102
Verified with color, gradient, bitmap for: Chart Title in DOCX, XLSX and PPTX. Also verified with gradient, bitmap for Chart Legend, Plot Area, Dataseries and Background in DOCX, XLSX and PPTX. Change-Id: I15d29f3ca2d75f45f612766b635d50a29d8551ae Reviewed-on: https://gerrit.libreoffice.org/57880 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 051399740e41c6495ed362e78c63e0868bcd180c) Reviewed-on: https://gerrit.libreoffice.org/58349 Reviewed-by: Balazs Varga <balazs.varga991@gmail.com> (cherry picked from commit e3cad36dbcad73f41b921cd079317c20e770c249)
2018-08-02tdf#119029: also export rotation for data seriesMike Kaganski2-0/+14
Reviewed-on: https://gerrit.libreoffice.org/58401 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 8f90492812d1edac6c91e83b84f3512877dcd552) Change-Id: I6a9895145e0c54d35bf404f209721a0c718e4446 Reviewed-on: https://gerrit.libreoffice.org/58470 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-08-02tdf#115945 oox export: data label writeRunPropertiesJustin Luth1-0/+1
DataLabel font was always returning to the default - black. Change-Id: I6c72a8daa699394b36f69fc54e0ba042f0255c18 Reviewed-on: https://gerrit.libreoffice.org/56616 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit ae2fd281e046b2199ef44777b84518cd3abb2952) Reviewed-on: https://gerrit.libreoffice.org/58468 Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-07-20tdf#114821 import/export/place complex data labels in chartsSzymon Kłos17-18/+620
Change-Id: Ia44abcebb4febcabb1704aef85e396730ac2cd6f Reviewed-on: https://gerrit.libreoffice.org/57530 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-06-01tdf#117864 TransferableHelper::GetSystemClipboard requires a focus windowCaolán McNamara2-1/+6
Change-Id: Ibd9b9218cf12e80db1fc9a70bdbab38d3df950f7 Reviewed-on: https://gerrit.libreoffice.org/55075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit d4c1975fc0411cdd30ea96fa188ac77c099bd58e)
2018-05-23tdf#104658: Fix jumping bitmap-filled chart barsKatarina Behrens1-1/+6
Coincidentally this also resolves almost identical issues in chart wall (tdf#114132) Change-Id: Ib566110639d00aa46463ee592861ce3e15c64f50 Reviewed-on: https://gerrit.libreoffice.org/52624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 2eaa978d135a53abf22df2dc3fcb8d04733fe2d3) Reviewed-on: https://gerrit.libreoffice.org/52978 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 4eed0937c971a21287da639e0708c682d0241ea2)
2018-05-22lok: charts context menu was misplaced + wrong LogicToLogic conversionMarco Cecchetti1-0/+14
Chart context menu was misplaced since the context menu expects a position related to the document window not to the chart window. Moreover map mode is not enabled for chart window, that leads to use the LogicToLogic routine which unfortunately provides a wrong pixel to twips conversion. In fact we gets a 20 twips per pixel conversion since LogicToLogic uses a fixed 72 dpi value, instead of a correctly computed output device real dpi or at least the most commonly used 96 dpi value. Change-Id: Idb4220d03fddd4b6d643c1c0fb52754bafed7e36 Reviewed-on: https://gerrit.libreoffice.org/53118 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/54649
2018-05-17tdf#117596 set the size for Asian and Complex char height tooTomaž Vajngerl1-0/+2
Change-Id: I703fc4d1cf34747d924a7fa44913a4bfe9bff67b Reviewed-on: https://gerrit.libreoffice.org/54406 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit d57c6f5d44ec7a8dff2121bd19103804329af66a) Reviewed-on: https://gerrit.libreoffice.org/54408 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e822afc4989451674ae51df0d3e5ca233e8fd5fa)
2018-04-17Remove Help - Restart in Safe Mode menu itemAndras Timar1-2/+0
Change-Id: I2a3cdbc73a0a4033b60f0d67b3673bd24e4fce50
2018-04-17Remove Help - Donate to LibreOffice menu itemAndras Timar1-2/+0
Change-Id: I7a701173f596306ee628ae4a12ad81d2d756caca
2018-03-27chart2 lok: tunnel context menu of the chart edit viewPranav Kant1-1/+8
Change-Id: I0c8b3cfe1666ad81f808871a87e4b0fa64ef593c Reviewed-on: https://gerrit.libreoffice.org/51345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit eb76e16abba16d88acd342779a8216dd64d60955)
2018-03-27chart2 lok: give parent to data table dialog to tunnel itPranav Kant1-1/+2
Change-Id: Ie82a9a6d9b499e5da34e04f0c2f5fc7c164b098e Reviewed-on: https://gerrit.libreoffice.org/51346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit a7e98725901412aa334a1abe87194e682c1ae836)
2018-03-26lo chart2: The LokChartHelper must post the mouse events too.Jan Holesovsky2-0/+20
Calling directly causes freezes in Execute() when instantiating dialogs. Change-Id: I3aa09b99e5a13027892aeba02860e87e29b172da Reviewed-on: https://gerrit.libreoffice.org/50419 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/50483 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 584fc20be3bb6f90d17ef8a131575af9871cb1c4)
2018-03-20lokdialog: Allow switching language of some of the ResMgr's.Jan Holesovsky4-75/+1
This way, it is possible to have all the strings translated in dialogs even when different users use different languages. [It was already possible to have different languages previously, but not everything in the dialog has switched - like the buttons at the bottom of the dialogs etc.] Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9 Reviewed-on: https://gerrit.libreoffice.org/46417 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/46979 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 101a79cc4d13a1f566c1b97c1329813eb7c61bcf)
2018-03-19chart2: When creating objects prevent setting object rects dirtyTomaž Vajngerl1-0/+19
3D objects using a E3dScene are traversing all object in the tree when setting rects dirty. When we are creating objects, setting properties and adding them to the tree we trigger setting rects dirty which slows down considerably - more are added objects, bigger the slowdown gets. So the solution here is to temporary disable setting object rects dirty during creation of objects. Change-Id: Id068cda9cb798d49b75bf4228cf6460f7e98c033 Reviewed-on: https://gerrit.libreoffice.org/46446 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 55a7e836a2db662a53adc4f8b98d08b06790c758)
2018-03-19chart2: Batch changes to properties when creating 3D objectsTomaž Vajngerl1-123/+152
MultiPropertySet doesn't broadcast ItemSets as often as setting each property separately. This can help when we create a lot of 3D objects. Change-Id: I4eb842a5d8c43963bdceee84468593f5f6b47336 Reviewed-on: https://gerrit.libreoffice.org/46445 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit e1697600253361a26d77a1ef61f8bde16af0ed2c)
2018-03-19tdf#116163: Limit label height in chart if neededSzymon Kłos11-4/+74
Change-Id: Ia84fd0c3b76886bc6124dc3b59035465aa31b020 Reviewed-on: https://gerrit.libreoffice.org/50700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/50830 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 87d8df83efd210a322b42f590aaff3d2e8efe2bc)
2018-03-19tdf#116163 import testSzymon Kłos1-0/+97
Change-Id: Ie4fd1142e1111e4968941a639a265d169aaa6413 Reviewed-on: https://gerrit.libreoffice.org/50814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/50831 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 5c9cd49df8e806d1f0bfd62f62ba057d54186ee8)
2018-03-07Resolves: tdf#113805 insert special character fails in insert footnote...Caolán McNamara1-1/+1
etc. dialogs i.e. since commit 710a39414569995bd5a8631a948c939dc73bcef9 Date: Thu May 11 13:27:38 2017 +0530 GSoC: Glyph View and Recent Characters Control in Special Characters dialog Change-Id: Ia55f3fefe7c14327cff2e996ab0038dc52f9b017 it inserts into the document, extend the fix of commit 4020945651b4f3c636980e2103db440b5c55459c Author: Daniel <danielfaleirosilva@gmail.com> Date: Sun Sep 24 17:55:19 2017 -0300 tdf#111739 fix Selecting a custom character as a bullet symbol insertion to do the old thing that existing code depends on if this is not an "insert" dialog, and bubble that setting around from the callers Change-Id: Id8acf16955d0167beffae43e3b201e500ee7a929 Reviewed-on: https://gerrit.libreoffice.org/50781 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/50799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-28tdf#115859 Export number format for chart seriesSzymon Kłos2-0/+12
Change-Id: I65d30c6b92a530eadbd6fabe87fa8bd3416fee20 Reviewed-on: https://gerrit.libreoffice.org/50395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-01-29fix build with glm 0.9.9Rene Engelhard2-0/+12
In file included from /usr/include/glm/gtx/norm.hpp:18:0, from /data/rene/git/LibreOffice/master/vcl/inc/opengl/VertexUti ls.hxx:16, from /data/rene/git/LibreOffice/master/vcl/inc/opengl/LineRende rUtils.hxx:14, from /data/rene/git/LibreOffice/master/vcl/opengl/LineRenderUti ls.cxx:11: /usr/include/glm/gtx/quaternion.hpp:23:3: error: #error "GLM: GLM_GTX_quaternion is an experimental extension and may change in the future. Use #define GLM_ENABLE_EXPERIMENTAL before including it, if you really want to use it." # error "GLM: GLM_GTX_quaternion is an experimental extension and may change in the future. Use #define GLM_ENABLE_EXPERIMENTAL before including it, if you really want to use it." ^~~~~ so just define it. Change-Id: I981bfb5fd944f32a3774b3f9b183989773bf235f Reviewed-on: https://gerrit.libreoffice.org/48799 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Rene Engelhard <rene@debian.org> Reviewed-by: Rene Engelhard <rene@debian.org>
2018-01-09tdf#114173 Preserve size of chart legend during xlsx exportBartosz Kosiorek1-0/+15
During export chart into .xlsx file, the information about size of legend was not saved. Example of proper size: <c:w val="0.41459448854442293"/> <c:h val="0.23161616722845749"/> another issue was hardcoded "layoutTarget" which was always "inner": <c:layoutTarget val="inner"/> also properties regarding default text style was not preserved: <c:txPr> <a:bodyPr/> <a:lstStyle/> <a:p> <a:pPr> <a:defRPr sz="900" b="0" i="0" u="none" strike="noStrike" kern="1200" baseline="0"> <a:solidFill> <a:schemeClr val="tx1"> <a:lumMod val="65000"/> <a:lumOff val="35000"/> </a:schemeClr> </a:solidFill> </a:defRPr> </a:pPr> <a:endParaRPr lang="pl-PL"/> </a:p> </c:txPr> With this patch all these issues was resolved, and in case of layoutTarget "outer", the field is not availble at all, according to specification. Change-Id: I2c9b7a112bdd911542b5273e660222d7fefa2d88 Reviewed-on: https://gerrit.libreoffice.org/47358 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 84392651d2731cce91c3b2e144bed4ac07e4ddf1) Reviewed-on: https://gerrit.libreoffice.org/47656 Tested-by: Jenkins <ci@libreoffice.org>
2018-01-07tdf#108031 Area chart labels not rotatedJochen Nitschke2-24/+23
This fixes recognition of x-axis or y-axis when the coordinate system is rotated (3D-view). So the labels are rotated correctly. Change-Id: Iaacfec943f3885c58e99a55585714a79f1d0d9d5 Reviewed-on: https://gerrit.libreoffice.org/38355 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> (cherry picked from commit 38bf5f69663f64434a3a0a74e02c1a23f876b677) Reviewed-on: https://gerrit.libreoffice.org/47015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-01-03prevent crash when trying to edit broken chart documentsMarkus Mohrhard1-0/+6
Change-Id: Ie5fb706011ca600b42e5e2d3770e919b56347edd Reviewed-on: https://gerrit.libreoffice.org/46938 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 1d2eb0b64339a771152bb17831c83373830e5c38) Reviewed-on: https://gerrit.libreoffice.org/47004 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-20tdf#105517: overwrite existing scheme colors in vectorAron Budea2-0/+30
Theme overrides stopped working once ClrScheme::maClrScheme was changed to vector, and colors were always appended to it. Regression from f3121049828596b369e3ea844355d61666e49795. Change-Id: Iae850dcabf57b12d8a564e84acf38d9988cfe963 Reviewed-on: https://gerrit.libreoffice.org/44242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 021081823aeebcfa395662d0c04535a243977c2e) Reviewed-on: https://gerrit.libreoffice.org/46828
2017-11-22Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann1-2/+2
...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-22TypedWhichId for SDRATTR* constants (3)Noel Grandin1-24/+24
Change-Id: Iea72cb3a4bbf693096de46269f58259b5952eedb Reviewed-on: https://gerrit.libreoffice.org/45024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22loplugin:simplifybool re-activate the !! warningNoel Grandin3-4/+4
Change-Id: Iac7d82a1c228734177be536e9a6c41803c03637b Reviewed-on: https://gerrit.libreoffice.org/45035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22tdf#39593 deduplicate code in ExplicitValueProvidertagezi3-83/+20
Change-Id: I0525761b0d1359b3e0f249cef02e1818af95156b Reviewed-on: https://gerrit.libreoffice.org/45037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin10-25/+25
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20TypedWhichId for XATTR* constantsNoel Grandin2-5/+3
Change-Id: Ie9d637d701b77a549de3b00956f9c74ee8bd08c1 Reviewed-on: https://gerrit.libreoffice.org/44830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-17TypedWhichId for EE_CHAR* constantsNoel Grandin1-4/+2
Change-Id: I261f8a949ddd858dee196118bb42993a101a2a28 Reviewed-on: https://gerrit.libreoffice.org/44829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-16use implict conversion operator in TypedWhichIdNoel Grandin8-11/+11
instead of spreading calls to Which() everywhere. Change-Id: Ie32d106e44f5cb583908eeebe254ab8b8168ae61 Reviewed-on: https://gerrit.libreoffice.org/44760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-15TypedWhichIdNoel Grandin8-11/+11
use a strong-typedef template to give which IDs a type, which we can carry around to do a (a) little bit more convenience when Get()'ing them and (b) a little bit of enforcement of which PoolItem subclass each ID uses Fix a bug in casting EE_PARA_BULLETSTATE to the wrong subclass in AccessibleEditableTextPara::_correctValues Change-Id: I015ce8b3b0f6d21308af182afa3caf122c877a5b Reviewed-on: https://gerrit.libreoffice.org/44587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-14Fix typosAndrea Gelmini1-1/+1
Change-Id: I53b47cab5cbc603bf11adcda8ac2a8373eef26a8 Reviewed-on: https://gerrit.libreoffice.org/44695 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-13Fix typosAndrea Gelmini1-2/+2
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91 Reviewed-on: https://gerrit.libreoffice.org/44654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-11A user object id is *NOT* a SotClipboardFormatIdEike Rathke2-4/+6
Do not try to squeeze it into such.. especially if SotClipboardFormatId::... enum identifiers are used in a user object id context that is completely not related to the identifier name this is totally confusing. commit fb14be5f8f74f83ba89e15f891ddf1f753dcc62f Date: Thu Mar 12 14:53:28 2015 +0200 create new 'enum class' SotClipboardFormatId to unify types overdid with that. Change-Id: I34b570be9f52b7b94ca8af6b23983393ac3a3a55 Reviewed-on: https://gerrit.libreoffice.org/44612 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 19:39:27 +0000