summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2013-06-24Turn off column storage debugging.Kohei Yoshida1-1/+1
Change-Id: I5d88c94a9cf0bbd194c8c505de7cc34bb9e20500
2013-06-24Adjusted the patch against mdds 0.9.0.Kohei Yoshida3-28/+28
Change-Id: Ia68f49996d4d50142c04d35ef2babb321afc4b3f
2013-06-24These patches are in the upstream.Kohei Yoshida3-46/+0
Change-Id: Ie5dc6b93fbcd65d7763fb9232a984236fb7bd745
2013-06-24Update internal mdds to 0.9.0.Kohei Yoshida2-2/+2
Change-Id: I2f299dd7244e7418959f82f94a56d8cc1749aaba
2013-06-24Use position objects for more efficient element value lookups.Kohei Yoshida1-20/+19
The underlying multi_type_vector didn't have the concept of position objects back when the matrix was reworked. It is now available, and there is no reason why we shouldn't use it to speed things up. Change-Id: Iac75a5584779c16e6eff7fcd577fc3d717c3c2e7
2013-06-24Prevent crash during on-line spell checking.Kohei Yoshida3-5/+32
The new ScHorizontalCellIterator internally uses iterators for each column to track positions. This means that, if a cell value in the iteration range chnages while the iteration is on-going, those internal iterators get invalidated. Allow the client code to rehash the iterators when modifying a cell content during iteration. Having said that, it's best not to modify cells during iteration. Change-Id: Ida453d4f883e1fbcbab4eb0401e37fea8c0b901d
2013-06-24Fix my wrong logic in row info iteration.Kohei Yoshida1-8/+10
Align the array position of RowInfo by comparing its nRowNo value with the current row number. Change-Id: Idd26636cac0ba4ade1b538dd68580b469611da04
2013-06-24Make them officially non-copyable.Kohei Yoshida2-4/+5
Change-Id: Ie8f8c2227b35ffb81f902458ce1b0a732b430b53
2013-06-24A little more cleanup.Kohei Yoshida1-95/+89
Remove CELLINFO macro, and rename nArrX and nArrY to nArrCol and nArrRow. Change-Id: Id105cfefc44e454be2df96a4084dee9185435fab
2013-06-24Rename parameter names for consistency.Kohei Yoshida2-61/+62
nCol and nRow are better than nX and nY etc. Change-Id: Ie92d4e2727a1100736610a3876721d61e8279b15
2013-06-24Incorrect way to initialize a multi_type_vector.Kohei Yoshida1-1/+1
Change-Id: I5db7923be8444db8a0cb1a6766f967d731776535
2013-06-24Don't allow outside code to set text attributes.Kohei Yoshida5-33/+12
Also, use position() to update the value, to avoid performing position lookups twice (once for getting the current value, and once for setting the updated one). Change-Id: Iaa1575a4938b996266c01c8b3170e6a65b871961
2013-06-24Avoid having formula cell directly update text attributes.Kohei Yoshida1-15/+2
This would cause column cell and text attribute arrays to go out of sync, because the formula cells may be stored and interpreted in places such as change track and conditional formatting. We still need to find a good way to mark text attributes "obsolete" when formula cells are re-calculated. Change-Id: Ida612806d3afec23c5ae501f2fc8cc7d52e019a8
2013-06-24Add more calls to CellStorageModified() when it's called for.Kohei Yoshida4-17/+70
Change-Id: Ib7a7abd82060b19f7911f1fef5ccccff5d850055
2013-06-24Remove unused method.Kohei Yoshida2-42/+0
Change-Id: Id49307f8b7050e1f95cd589421f01a85b4e992b2
2013-06-24Fix a bug in "find all" search, and a test to catch it in the future.Kohei Yoshida3-0/+42
Change-Id: I296d2dff65da55cc86e10a78eb9c768a924fcddd
2013-06-24Turns out ScHorizontalIterator was still broken. Fix it for real.Kohei Yoshida3-22/+74
And a unit test to accompany the fix. Change-Id: I41e9451049d3c6ab7b3fd7904bcef3675979884c
2013-06-24Make sure to set the cloned formula cells dirty during undo / redo.Kohei Yoshida4-21/+18
This fixes the last failed unit test from ucalc. Change-Id: I37a79e444084397629cac77e2137377cd555a89c
2013-06-24Fix ScCellIterator, which also fixes matrix handling in the formula engine.Kohei Yoshida2-3/+3
This one alone fixes 2 unit test failures. Change-Id: I3392f4567888447d867ed29f7ecda2474fae1547
2013-06-24Add Dump() method to ScMatrix, which is useful when debugging.Kohei Yoshida2-0/+58
Change-Id: I45e6c28b58a03782814ef1089b49a52b873573a6
2013-06-24Update references on all cells.Kohei Yoshida1-7/+20
Passed row range is the range of moved cells, not the range of cells to update. This alone fixes 3 unit tests. Change-Id: I4cb154879c6c33bc277bc2ab136f7580c35e479e
2013-06-24Fix the horizontal cell iterator.Kohei Yoshida2-24/+61
I got its logic totally wrong. Now it works. Change-Id: I79e556da19c7c0b0d8cecbb4875d6d21d5ec4208
2013-06-24Same fix for fill series & some cleanup.Kohei Yoshida1-16/+3
Change-Id: I2f741305ac64c221c5af8ab99f3ddff0ce56f458
2013-06-24We need to clone the source cell value to prevent crash.Kohei Yoshida3-21/+65
If we don't clone this, the original string value would become invalid after the first insertion, which may cause a reallocation of the array that stores the cell. Change-Id: I5b1bb5f378ed5503169fce75fcbc7aeb85c5ed6e
2013-06-24Don't forget to return true if we are successful.Kohei Yoshida1-0/+1
Else we'd never get out of this inifite loop.... Change-Id: I96e072eb79cce77302b27cad42da31f9a66c3401
2013-06-24Have the clone handler handle the text attr array as well.Kohei Yoshida5-67/+120
In order to handle the special case of cell removal. Change-Id: I7782232ce0fe6c0248c40482ec62d909d2dfe621
2013-06-24Use template functions to remove these duplicate code blocks.Kohei Yoshida1-227/+79
Change-Id: Ica293362fefbe1d8492bdda88dd1a09e4f16c1e6
2013-06-24When deleting cells, be sure to delete the corresponding cell attrs as well.Kohei Yoshida1-4/+16
The cell and cell attr arrays must - be - in - sync - at - all - times. Change-Id: I2854c977eada389e5b9d908b97dd3fa78fc62097
2013-06-24Don't bail out on good condition.Kohei Yoshida2-2/+1
It's a good thing to have found a table to work on. Change-Id: I9b42ebb20041756b6086490dac4264d17369f83f
2013-06-24Leave the RowInfo's for empty cells unfilled.Kohei Yoshida4-4/+20
Else empty cell regions would get skipped and the non-empty cells would get displayed at incorrect row positions. Change-Id: Ica8d1c654458e0ea508e8f00846180d89bfe8804
2013-06-24Fix a bug in the find area position code for the upward direction.Kohei Yoshida2-27/+36
And a test to catch it. Change-Id: I7582b5bca5309f247b44e8cbaa29feda838e6d99
2013-06-24Compiler warnings.Kohei Yoshida2-2/+3
Change-Id: I79b8370429bccaf8467a5c87ee5b68b643fb2f75
2013-06-24Remove these file entries.Kohei Yoshida1-2/+0
Change-Id: I00c6e996d2a533c2434df152752a09edee9a3fa5
2013-06-24Put ScBaseCell, ScValueCell, ScStringCell, ScEditCell to eternal rest.Kohei Yoshida3-526/+0
You had your day. Now it's time for us to part ways. Change-Id: I4bd5797adf2091387cacaf6474069c3f9f20c134
2013-06-24Move ScEditDataArray out of cell.?xx and into its own files.Kohei Yoshida20-127/+171
Change-Id: I107cec7d70f4d00ff52cb071d69a615fbab8d9f2
2013-06-24CELLTYPE_DESTROYED no longer relevant. Chuck it.Kohei Yoshida6-26/+5
Change-Id: Ie56cf8dc87eebd801cdb68ce70ffae7bcd16e4d7
2013-06-24ScFormulaCell is no longer a child class of ScBaseCell.Kohei Yoshida12-46/+12
Change-Id: Id33072f193045e2eaf51373b47dac803f9a5d52c
2013-06-24Switch to using multi_type_vector for cell storage.Kohei Yoshida53-5566/+7885
The old style cell storage is no more. Currently the code is buildable, but crashes during unit test. Change-Id: Ie688e22e95c7fb02b9e97b23df0fc1883a97945f
2013-06-24Add new cell container to ScColumn.Kohei Yoshida1-0/+4
Now the lengthy process of converting the cell storage begins... Change-Id: Ife89547923c73f70f9cf1035a64f8006744bbfce
2013-06-24Re-org the headers a bit. In column?.cxx, column.hxx must be the first.Kohei Yoshida2-27/+27
Change-Id: I5014c06a8dd8335b5dd5c127f86a59331d54af88
2013-06-24Reduce dependency on mtvelements.hxx header.Kohei Yoshida4-12/+23
Because that header includes lots of template definitions which would undoubtedly slow down compilation speed. Change-Id: Ifdd686a250d341a7a6877cca41f042f8dfdbbaf9