summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-04-29tdf#120703 PVS: dereference before nullptr checkMike Kaganski1-149/+104
Use a function to consistently check if gImpl is valid before assigning last exception message. V595 The 'gImpl' pointer was utilized before it was verified against nullptr. Check lines: 2673, 2683. Change-Id: I18fc0d632c84f37b05e9d1c3c83689e6eaa6f66c Reviewed-on: https://gerrit.libreoffice.org/71488 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-28tdf#120703 PVS: dereference before nullptr checkMike Kaganski1-5/+5
V595 The 'ustrFile' pointer was utilized before it was verified against nullptr. Check lines: 83, 107. Change-Id: I874983508fb805b1f0a55b3a5b6d4d78ae1babdb Reviewed-on: https://gerrit.libreoffice.org/71472 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: dereference before nullptr checkMike Kaganski1-1/+1
V595 The 'pDoc' pointer was utilized before it was verified against nullptr. Check lines: 434, 460. Change-Id: Iec92cbb8c4f5e47f7852015bf466b1f8ed195517 Reviewed-on: https://gerrit.libreoffice.org/71471 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: nullptr dereferenceMike Kaganski1-4/+5
V595 The 'GetMedium()' pointer was utilized before it was verified against nullptr. Check lines: 435, 455. bURLChanged is only meaningful when GetMedium() is not nullptr; otherwise bSaveDS could become true where no medium existed, and dereferencing GetMedium() to find its URL would segfault. Change-Id: I6f533acb3b1ca078803aa23bdece0ba2ee1d87c3 Reviewed-on: https://gerrit.libreoffice.org/71467 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: nullptr dereferenceMike Kaganski1-2/+2
V595 The 'pContact' pointer was utilized before it was verified against nullptr. Check lines: 1254, 1256. Change-Id: I5d3d28b3c8a70924f329fde9f020f42d9eb5e9a1 Reviewed-on: https://gerrit.libreoffice.org/71459 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: dereference before nullptr checkMike Kaganski1-1/+3
V595 The 'mpViewShell' pointer was utilized before it was verified against nullptr. Check lines: 96, 125. Change-Id: I824c6cf8a5ed7f0ef20e99df36c83feec7fe54ea Reviewed-on: https://gerrit.libreoffice.org/71468 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: dereference before nullptr checkMike Kaganski1-1/+3
V595 The 'mpViewShell' pointer was utilized before it was verified against nullptr. Check lines: 193, 201. Change-Id: I0d3cfee4d6f7bbb536c463b698361a1d299d2863 Reviewed-on: https://gerrit.libreoffice.org/71469 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: dereference before nullptr checkMike Kaganski1-1/+2
V595 The 'GetActiveWindow()' pointer was utilized before it was verified against nullptr. Check lines: 544, 567. Change-Id: I1ef45fa72542168ba88f24482973a1c660bcc1a8 Reviewed-on: https://gerrit.libreoffice.org/71470 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: Avoid dereferencing nullptrMike Kaganski1-1/+1
V595 The 'pEndIdx' pointer was utilized before it was verified against nullptr. Check lines: 1328, 1347. Change-Id: If9aff472e6ec7429ef2055b44dd11e62d4489ba4 Reviewed-on: https://gerrit.libreoffice.org/71458 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: fix cleanup checksMike Kaganski1-10/+12
pofs is guaranteed to be non-nullptr after getOutputStream, so no need to check that. is_open() only matters to decide if close() is needed. V595 The 'pofs' pointer was utilized before it was verified against nullptr. Check lines: 1033, 1057. Check lines: 1194, 1220. Change-Id: I2dd22d29c465889269f2496f0964bee030cb5964 Reviewed-on: https://gerrit.libreoffice.org/71456 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: Check potentially null pointer before useMike Kaganski1-1/+1
V595 The 'pHdl' pointer was utilized before it was verified against nullptr. Check lines: 192, 197. Change-Id: I52e1d1eadaded8616b8a27e0fcfaf6d1e6baa03e Reviewed-on: https://gerrit.libreoffice.org/71455 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski2-6/+3
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I99117fa7c04a5de565833be7bdc001d97e635d61 Reviewed-on: https://gerrit.libreoffice.org/71453 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: Blind attempt to implement original ideaMike Kaganski1-2/+2
The strange implementation was there ever since commit bd36338009672fdabd5b6d585f8c1092b617196a. The other possibility is to just remove the block above the last assignment to aRet Change-Id: I5bd3bf1f518ab894e5df4cbc7d86a76d325e4600 Reviewed-on: https://gerrit.libreoffice.org/71447 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski10-43/+24
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I11fa13677c7980e6ac17fc4358406472ee784e41 Reviewed-on: https://gerrit.libreoffice.org/71446 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-27tdf#120703 PVS: re-read aPrefSize after updating itMike Kaganski1-0/+1
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 645, 655 Since commit 37aa7d81aacaae12dfe0fd2ade2779235bbf72f1 Change-Id: I7b4d2d58e51cf98ac6294d1feacd28c3a8761d81 Reviewed-on: https://gerrit.libreoffice.org/71431 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-27tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski6-49/+40
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I79c655a072faff0bdb2af031ed1328e684b83aac Reviewed-on: https://gerrit.libreoffice.org/71430 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-14tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski13-81/+38
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I18562d60e33c7ecff14807976dde4cbcae3f665b Reviewed-on: https://gerrit.libreoffice.org/70731 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-14tdf#120703 PVS: Silence V522 warningsMike Kaganski29-49/+103
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie4bc74a734a6d5a73838a27e0d80cc8e51595839 Reviewed-on: https://gerrit.libreoffice.org/70730 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-07tdf#120703 PVS: Silence V522 warningsMike Kaganski8-25/+37
V522 There might be dereferencing of a potential null pointer. Change-Id: I680f1628133216de6336ac5ffa846447ffd55a41 Reviewed-on: https://gerrit.libreoffice.org/70352 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-01tdf#120703 PVS: Silence V575 warningsMike Kaganski1-0/+1
V575 The potential null pointer is passed into 'strcpy' function. Change-Id: Iba2cbf1c94f1744b4e34c0f20d9dc030d52f5d9f Reviewed-on: https://gerrit.libreoffice.org/70024 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-01tdf#120703 PVS: Silence V522 warningsMike Kaganski21-43/+55
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie617b41a8f8d334022cf5313b242a236baedba48 Reviewed-on: https://gerrit.libreoffice.org/70017 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-31tdf#120703 PVS: GetBitmapBits does not return required buffer sizeMike Kaganski1-1/+7
... unlike GetMetaFileBitsEx or GetEnhMetaFileBits, which are used in the other branches. The implementation is trying to pass nullptr to the function since commit 41e72962df83a410986fb48250aaaf1adc827c13 Just calculate the required buffer size using BITMAP struct filled by GetObject call. V575 The null pointer is passed into 'GetBitmapBits' function. Inspect the third argument. Change-Id: I0d164694c99d805fd59b65ea1b4df4919a89e130 Reviewed-on: https://gerrit.libreoffice.org/70012 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-31tdf#120703 PVS: Silence V575 warningsMike Kaganski13-18/+60
V575 The potential null pointer is passed into 'foo' function Add asserts to those cases that are related to OOM cases. There's nothing to be done if the assertions fail anyway. Change-Id: I92ac95d44f512aa1948b1552b0e1f6da695a9f92 Reviewed-on: https://gerrit.libreoffice.org/70008 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-31tdf#120703 PVS: remove redundant static castsMike Kaganski27-77/+47
V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I54976062dc3f62eaaa79f89eff54454f0b24ac2c Reviewed-on: https://gerrit.libreoffice.org/69989 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-17tdf#120703 PVS: remove redundant static castsMike Kaganski10-18/+15
V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I6d1523e71b3e06be1cf41abaabb44e49fe11cd8e Reviewed-on: https://gerrit.libreoffice.org/69369 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-12tdf#120703 PVS: remove redundant static castsMike Kaganski13-57/+43
V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I5fee1c4bebd1972fbb5e43da37149d4e2ff6ce0d Reviewed-on: https://gerrit.libreoffice.org/67664 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski7-58/+52
Change-Id: Ib9ad5b874a210ef3862c668158fcc5d18eeab363 Reviewed-on: https://gerrit.libreoffice.org/67579 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11tdf#120703 PVS: Check object type before static_castMike Kaganski1-4/+2
V560 A part of conditional expression is always false: !pPrevActContent. Change-Id: Ief1b560ea8a4e1d85a693909b6a6a80566fa2f34 Reviewed-on: https://gerrit.libreoffice.org/67547 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski16-53/+34
Change-Id: I4449fead67459bdcbdc0e9320129e7a5b36aecd9 Reviewed-on: https://gerrit.libreoffice.org/67545 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always trueMike Kaganski1-6/+5
Change-Id: I598ba9c49e919c3a521b3062c83b72a1c7949b9e Reviewed-on: https://gerrit.libreoffice.org/67540 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11tdf#120703 PVS: remove obsolete check (leftover from static removal)Mike Kaganski1-15/+15
V560 A part of conditional expression is always true: !pSymbolList. In commit a2cd17d19085d739b979445d7f9ec7158b89df49, pSymbolList and xSymbols were made non-static. The check below was left though. Actually, I don't know if that was a safe move, since it's unclear how the lifetime of the returned pointer is managed now to prevent use-after-free. Change-Id: Ia51a9790503694f909ce7953337d3caaebfabfc1 Reviewed-on: https://gerrit.libreoffice.org/67512 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski6-7/+7
Change-Id: I62cb3b8927d664b3d5359ee6ac7db30d354f4821 Reviewed-on: https://gerrit.libreoffice.org/67496 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11tdf#120703 PVS: The check must be before assignmentMike Kaganski1-1/+3
V560 A part of conditional expression is always false: nType != m_nDialogType. Change-Id: I9182ec170aa41516208f97bb8543d348990f046d Reviewed-on: https://gerrit.libreoffice.org/67488 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski23-71/+47
Change-Id: I67462369d93e9d9ff3c056800947c4b75f71ba5f Reviewed-on: https://gerrit.libreoffice.org/67486 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-08tdf#120703 PVS: fix conditionMike Kaganski1-1/+1
V560 A part of conditional expression is always false: nY == nStartRow. Change-Id: I2d1a809400d48889780ce320be740648f8d9b97f Reviewed-on: https://gerrit.libreoffice.org/67541 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2018-12-24tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski7-12/+12
Change-Id: I5ca32214bab4b26208aecaa98eecc2a6297d9093 Reviewed-on: https://gerrit.libreoffice.org/65592 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-03tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski14-35/+26
Change-Id: Id7af9a6eaefc8b49a790eb299620c4fa97067a11 Reviewed-on: https://gerrit.libreoffice.org/64429 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-03tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski6-22/+15
Change-Id: Ieff0dde4faee209200b8f4e809e8bb4eb1b8f4a6 Reviewed-on: https://gerrit.libreoffice.org/64433 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-02tdf#120703 PVS: logical AND had been used instead of bitwiseMike Kaganski1-2/+2
V560 A part of conditional expression is always true: sal_Int32(0xFF) != 0. Change-Id: I5f19c4ff20e91767d22a85239f9693d68ff360b1 Reviewed-on: https://gerrit.libreoffice.org/64414 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-02tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski14-44/+42
Change-Id: Ia9c496ec93bedb13764969bf21c3f21d84caacef Reviewed-on: https://gerrit.libreoffice.org/64413 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-01tdf#120703 PVS: do not split a band that is just one pixel highMike Kaganski1-2/+2
This is what mentioned in the comment to the line, so implement just that V560 A part of conditional expression is always true: pBand->mnYTop < pBand->mnYBottom. Change-Id: I1027a30a07d49940a31838deddb457b6379eb887 Reviewed-on: https://gerrit.libreoffice.org/64399 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-01tdf#120703 PVS: the condition needs &&, not ||Mike Kaganski1-1/+1
... ever since commit 9ae5a91f7955e44d3b24a3f7741f9bca02ac7f24 V560 A part of conditional expression is always false: nRangeNo < nRCount. The value range of unsigned short type: [0, 65535]. Actually, simple if (nRangeNo < nRCount) would be enough, given that if sal_uInt16 is less than another sal_uInt16, it cannot be equal to greatest sal_uInt16. But let's keep this redundant comparison, in case types or define changes later. Change-Id: I886a0bc847a8c30966dea3ea0670bcee9b43c7f1 Reviewed-on: https://gerrit.libreoffice.org/64021 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-01tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski4-19/+9
Change-Id: I38f3e3243f8cb891c9a0fe2f4c68bc76acd1ef44 Reviewed-on: https://gerrit.libreoffice.org/64020 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-26tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski11-40/+41
Change-Id: I1ac4c52ea51503373644bc58dcd4395c69f1a675 Reviewed-on: https://gerrit.libreoffice.org/64007 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25tdf#120703 PVS: (nArse == 0x2225) condition was maskedMike Kaganski1-2/+2
... since initial commit d791366863cf9659a01b171ce0e727bfe2f28cdf V560 A part of conditional expression is always false: (nArse == 0x2225). Change-Id: I4afb30f0c6c067d0e42e3fa15e5c2b2c1caa73b3 Reviewed-on: https://gerrit.libreoffice.org/63996 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski6-18/+19
Change-Id: I2ae298f49ceba8059cd7236431db9a4d9a46b125 Reviewed-on: https://gerrit.libreoffice.org/63992 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski25-61/+46
Change-Id: I8d98aa7dd77fbd79611b8a4aba77e8c378fd1cae Reviewed-on: https://gerrit.libreoffice.org/63981 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25tdf#120703 PVS: fix possible buffer over-read when iterating stringMike Kaganski1-1/+2
V560 A part of conditional expression is always true: nStartPos < nLen. Change-Id: I2ae8634bd656e857724615d5187a14bd087598eb Reviewed-on: https://gerrit.libreoffice.org/63958 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski37-114/+95
Change-Id: If173f42302553b164267909a0a3156bb25a6d558 Reviewed-on: https://gerrit.libreoffice.org/63957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-22tdf#120703 PVS: V637 rename inconsistent < and == operatorsCaolán McNamara4-26/+29
i.e. lets not have... if (a == b) { if (a < b) } Change-Id: I8ffb8a1e591cbd5f9bf24fbef497660700ed47b0 Reviewed-on: https://gerrit.libreoffice.org/63802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-26 07:03:21 +0000