summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-06-09Hide Default Template icon when resetting default using toolbox menuAkshay Deep2-0/+6
Change-Id: I7a3e7c9413edbdfb74e0415dd7e203d65201eb08 Reviewed-on: https://gerrit.libreoffice.org/26081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-06-08make SvNumberFormatter::IsCompatible() staticEike Rathke4-13/+6
Change-Id: Ic40d0852c8e0a8f0957fc782c85c1084c7fe265f
2016-06-08assert on "forgot to add a jump" for OpCodeEike Rathke1-3/+6
Change-Id: I6c430b8a4079cd0d74e5c9e71a3f7b5b638d4ef5
2016-06-08tdf#48140 Remove unused headers from xlsx import to improve build performanceBartosz Kosiorek5-11/+0
Change-Id: Ie22dc56cceddcb91e946083c6bcf4c041545e75b Reviewed-on: https://gerrit.libreoffice.org/26001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann35-64/+71
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-08loplugin:passstuffbyrefStephan Bergmann2-2/+2
Change-Id: I637e1c9d5af1f9d8ad5141c8d07ea72232656070
2016-06-08tdf#100269 svx: fix undo of table column resizeMiklos Vajna8-2/+131
SdrTableObjImpl::LayoutTable() assumed no re-layout is needed in case the total width of the table and the number of columns is the same, but undo of resize is a situation where we also need to check the individual widths of the columns, otherwise layout won't be up to date. Change-Id: Ia5ebb05af79dda1c0d8c5bb10e7f37f81ee1d035 Reviewed-on: https://gerrit.libreoffice.org/26061 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-08Resolves: Default template is not loaded when starting with Template SelectionAkshay Deep1-5/+4
Change-Id: I378cc64da27a00fb6e2c4197e36864035d2b537a Reviewed-on: https://gerrit.libreoffice.org/26041 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-08remove "trying to resize readonly stream" warningNoel Grandin1-3/+1
some of code appears to rely on this clamping behaviour for correct functioning Change-Id: I3448994967cdc7631476a947fac0c0dda55181d3
2016-06-08Template Manager: Enable "Move" and "Export" buttons on right clickAkshay Deep2-0/+2
Change-Id: Ibdf3d0cd721333730638e71d2d5258092074af93 Reviewed-on: https://gerrit.libreoffice.org/26042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-08Disable multiselection in Impress Template SelectionAkshay Deep3-2/+31
Added possibility to select single item in ThumbnailView. Then, used it in Template Selection dialog. Change-Id: I39b2ea83479ae1536285d4037fb1d24455a52ddc Reviewed-on: https://gerrit.libreoffice.org/25998 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-08PushCellResultToken() with final FormulaDoubleTokenEike Rathke2-10/+28
Change-Id: I3c628527c3e5bb676be791e3a31d617c4cc917ae
2016-06-08Related: tdf#100269 sd xml dump: expose layout of table shapesMiklos Vajna4-0/+54
So that it's possible to assert the layout from cppunit tests. Change-Id: I09631f978ed44bb1c27806089b6d69c70db643c3 Reviewed-on: https://gerrit.libreoffice.org/26054 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-08Resolves: tdf#89394 revert attempt to ditch missing file from recent filesCaolán McNamara1-29/+8
this reverts commit 93eefe54f5d6b6092371bad1e86444489d29eee2 Author: Krisztian Pinter <pin.terminator@gmail.com> Date: Fri Sep 6 14:45:13 2013 +0200 Make SvtHistoryOptions not return files if they can't be opened which seemed like a good idea, but was only really to fix a cosmetic problem, while the outcome was a more serious issue Change-Id: Ic9c9c136e1e50f5e28fe377b64f56e501fb836ca
2016-06-08loplugin:cstylecastNoel Grandin1-1/+1
Change-Id: I412f88094269ba111a984b714202b58d96758a20
2016-06-08convert the final double result to FormulaDoubleTokenEike Rathke1-3/+17
... if it was a FormulaTypedDoubleToken, and set type information. Change-Id: I2debcda4650d621311d5d7670ffdedecb2e25a04
2016-06-08tdf#97103 sw: fix restoring of SetRedlineMode on DOCX/RTF exportMichael Stahl4-38/+67
In order to prevent ~SwIndexReg asserts, this was changed to restore the redline mode not in MSWordExportBase::ExportDocument() but in SwWriter::Write(). Unfortunately only the DOC export actually uses SwWriter::Write(), so fix the original problem differently by moving the cursors onto a EndNode. The m_pCurPam will be deleted anyway, and the m_pOrigPam usually also will be, and in the case it isn't deleted i hope it's not important :) (regression from 0b037361b890a83a735186b98d5a3cef124027f4) Change-Id: Ib3d0cc32862256fdc4363b6035c190cbbcfe5df3
2016-06-08Fix widget's library nameRishabh Kumar3-3/+3
Change-Id: I22c66a63bfc71971da87db00b364e56ec55f7222 Reviewed-on: https://gerrit.libreoffice.org/26052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-08tdf#96099 Remove various smart pointer typedefsMark Page35-187/+165
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f Reviewed-on: https://gerrit.libreoffice.org/26014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08Simplify GfxLink using smart pointersMark Page4-247/+108
Uses std::shared_ptr for sharing graphic data Changed constructor to std::unique_ptr<sal_uInt8[]> to ensure the delete[] operator is called when GfxLink internals takes ownership of the data Change-Id: I4edd4634df8d6ba4d94953260c1a7ac560ccf04a Reviewed-on: https://gerrit.libreoffice.org/25402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08tdf#96099 Remove SfxInterfaceArr_Impl typedefMark Page4-6/+8
Added comment in SfxModule with warning about using smart pointers Change-Id: I1997d41a0a77c7e82e486bcdaee0ea876fdc61ad Reviewed-on: https://gerrit.libreoffice.org/25999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08remove some manual ref-counting in frameworkNoel Grandin1-10/+5
Change-Id: I469439abfa4e9dcd29f2d1693b03d37b3d61c81e Reviewed-on: https://gerrit.libreoffice.org/26047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08gtk3: use window groups so modal dialog are modal to their toplevel frame onlyCaolán McNamara1-5/+19
so e.g. launching help from a modal dialog gives a new toplevel window which is not blocked by the modal dialog on the other window. likesize can go from one blocked e.g. writer window to calc and type away in there happily Change-Id: Id9376b393514e91dfd667dfce132f1f37367084e
2016-06-08try to debug images_tango.zip failure on arm tinderboxDavid Tardon1-0/+6
Change-Id: Ia30069e57e43895ced52b3922d6321e404e78449
2016-06-08merge cond. blocks to oneDavid Tardon1-4/+3
Change-Id: Iad5858955244e12a849336f84938a39b6f3219e0
2016-06-08Resolves: rhbz#1343766 a11y queries during dispose trigger combobox crashesCaolán McNamara1-0/+6
Change-Id: I29863ca95e64ccd31795f78c29c89ff35009d718
2016-06-08tdf#100184 fix the lifecycle of a texture in an atlasTomaž Vajngerl3-18/+27
Previously, when a texture atlas was destroyed we teared down the ImplOpenGLTexture even if there were OpenGLTexture instances around. This caused that we could try to access an already deallocated ImplOpenGLTexture which causes a seg. fault. Now we change this so that a FixedTexture is no different than a OpenGLTexture - we just release the reference, so any existing OpenGLTextures for our texture would still be valid. An additional problem is that FixedTexture registers a callback for slot deallocation so we know when a OpenGLTextures that holds a specific "slot" on the texture is deallocated. However if FixedTexture is not existent anymore, the callback still gets triggered and is trying to access invalid memory. To solve this we need to unregister callbacks before FixedTexture is destroyed. Additionally improve validity of a OpenGLTexture is valid. If ImplOpenGLTexture is not allocated (nullptr) is one case, but in addition to that if ImplOpenGLTexture has an id == 0 it also means that it is not valid (anymore). Change-Id: I87346198e8928e112619da62687d5856cb8aafb8
2016-06-08remove some manual ref-counting in formsNoel Grandin6-36/+15
Change-Id: I6334dca6e98bfd4531033bec203518ca27f64bc0 Reviewed-on: https://gerrit.libreoffice.org/26049 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08remove more "unsupported MetaAction" messages from test logsNoel Grandin1-0/+2
TEXTLANGUAGE is ignored in our other metafile processing code, so ignore it here, too Change-Id: I2fede2f7c45e5a0bbd9aabf7b2aba45432409199
2016-06-08use the new type information we now transport, tdf#35247 relatedEike Rathke1-10/+14
Change-Id: I47e9bf8e7012024f3bf715569ab0192f973d2a2f
2016-06-08use FormulaTypedDoubleToken in PushDouble() for temporary interim resultsEike Rathke2-3/+20
... and extract type information in PopDouble() Change-Id: Ib184a8d893bf1072d051a80259b44f6e28fc9271
2016-06-08introduce FormulaTypedDoubleToken to carry type information of a doubleEike Rathke2-0/+48
Change-Id: I88b4964ca95eefa41d415ed66fc106c834a686b6
2016-06-08ScDPResultTree::ValuesType can be emptyEike Rathke1-1/+1
Change-Id: I1a1213b6d887c1a2f0bfb5c8946e5bd67043cd01
2016-06-08Addition of new controls and their rearrangement in color tabRishabh Kumar3-197/+599
1. Addition of RGB and CMYK fields for the previous/old color. 2. Removal of color mode(RGB/CMYK) listbox and replacement with RadioButtons. 3. Changing color mode should not change the previous selected color. 4. Hide CMYK controls and color mode RadioButtons. 5. Addition of Hexadecimal color values. Change-Id: Iafc51e750e1f08345771edc9a733b91f6c771500 Reviewed-on: https://gerrit.libreoffice.org/25538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-08Get build unstuck for now re missing glm/glm.hppStephan Bergmann1-0/+1
Change-Id: I9fe14cc1e8b3a34142e6f08743fa619babdc8302
2016-06-08use NULL instead of nullptr in external facing codeNoel Grandin1-1/+1
Change-Id: I9f0846f06e0b42af841d575de5196fae78840c53
2016-06-08split AddRemoveListener into two methodsNoel Grandin11-19/+21
Change-Id: I247dc8a9033b39d5e49dc06e725f638644fcd02d
2016-06-08sfx2 classification: use auto where it improves code readabilityMiklos Vajna3-27/+24
std::map<OUString, basegfx::BColor>::iterator itColor = aColors.find(aLevel); vs auto itColor = aColors.find(aLevel); and so on. (And do the same at two other places as well.) Change-Id: I538998c8b8afdf18a7eb139fa4d469205c561370 Reviewed-on: https://gerrit.libreoffice.org/26046 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-08opengl: batch drawing of polylinesTomaž Vajngerl13-494/+750
To get polylines to draw in a batch it was necessary to refactor the polyline code to work with GL_TRIANGLES instead of the previous used GL_TRIANGLE_STRIP. For this and to make the code easier to handle a new class was introduced: LineBuilder, which purpose is to assemble vertices for a polyline (line ends, line joints). In addition we need to know the line width, anti-aliasing (AA) per vertex basis (in addition to color, normal and extrusion) so we can draw many polylines with one draw call. This info is now stored in Vertex struct which is used when drawing lines or triangles (fills). Uploading of vertices has also been changed, previously we uploaded the vertices with the drawcall. a convention in Modern OpenGL is however to use VBO (Vertex Buffer Object) for this. With this we can upload the to the GPU vertices independently and not upload them if this is not needed (which is currently not used yet). A vector of Vertex structs is now uploaded to the GPU using a VBO which is handeled with a new VertexBufferObject class. In addition to reduce the ammount of duplicated vertices, we use a index vector (handled by IndexBufferObject class) where we only define the indices of the vertex buffer which should be drawn. Change-Id: I49dc9c6260b459f4f4ce3a5e4fa4c8ad05a7b878
2016-06-08fix release in ODynamicLoaderNoel Grandin1-2/+3
otherwise, if the refcount goes to zero, we delete the object, and the static pointer is now pointing to freed memory. Change-Id: I0cdd303590e4e70797bfddb8b403db4d831aab04 Reviewed-on: https://gerrit.libreoffice.org/26045 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-08Not sure why loplugin:passstuffbyref did not warn about these cases?Tor Lillqvist2-6/+6
Pass a SalColor by value here, too, for consistency. Change-Id: I17ea621d376670284875d0af4830bf9c6f5da202
2016-06-08remove "object is disposed" warning in OBroadcastHelperVar::removeListenerNoel Grandin22-10/+90
doesn't add anything of value. Change-Id: Ie2dea7c43570640284771c992d0072ab61de425e Reviewed-on: https://gerrit.libreoffice.org/25871 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08Convert ButtonValue to scoped enumNoel Grandin14-71/+71
Change-Id: Ia882914fb99844f21ce89d7218321933ef084b22 Reviewed-on: https://gerrit.libreoffice.org/26036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08remove some manual refcounting in toolsNoel Grandin2-23/+8
Change-Id: Ic911b38f77dda7ce564f315a97624c9054c77a38 Reviewed-on: https://gerrit.libreoffice.org/26010 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08remove some manual refcounting in reportdesignNoel Grandin2-14/+10
Change-Id: I660b94acaf07f7ff79b787a6e7bbbcbdbeae0ac0 Reviewed-on: https://gerrit.libreoffice.org/26009 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08remove some manual refcounting in scNoel Grandin9-85/+45
Change-Id: Ie13b28ffaf861dc85063e5a4b23fef8c929033d9 Reviewed-on: https://gerrit.libreoffice.org/26006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08starmath: The formula tree must be of type SmTableNodeTakeshi Abe6-25/+14
This also omits the last push & pop on m_aNodeStack at the end of parsing. Change-Id: Iefff8fa801ea7cb9015d6cba0d5a972dee675cb7 Reviewed-on: https://gerrit.libreoffice.org/26003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-08loplugin:passstuffbyrefTor Lillqvist1-3/+3
Change-Id: I67f256349cbe63c73c006bf0a8e7cd5b59944136
2016-06-08loplugin:passstuffbyrefTor Lillqvist2-37/+37
Change-Id: Ic14ff3235071f8300c6054000e4b0e397d7c99a3
2016-06-08Apparently a copy/paste typoStephan Bergmann1-1/+1
...introduced with 1ffd7e1accbee482d4bb6698d4ad145d8a6a780d "INTEGRATION: CWS impresstables2". Change-Id: I7303a63c16c819c8fd808ffc43008c3ab3402819