summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-12-05create compile_commands.json in builddirChristian Lohmaier2-3/+2
assuming that nothing breaks for existing users of the compile_commands.json file, since they assume BUILDDIR=SRCDIR, so nothing will change in those cases. For building in a different directory than the source, the compile_commands.json file is the only thing that regularly clobbers my otherwise pristine SRCROOT Change-Id: I344afa0bc7bb3eaa1eb888cd3558d3602090af5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143571 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-12-05gb_LinkTarget_use_clang: only use flto=thin with clang, not with gccChristian Lohmaier1-1/+1
The code always used flto=thin, but gcc doesn't know that switch and fails. The gb_Library_use_clang used by Skia is actually a prefer clang option, and the corresponding gb_LinkTarget_use_clang macro accounts for that by using "$(or clangvalue,gccvalue)" to define variables. This is OK for stuff that defaults to empty value when no clang is found on the system, but gb_CLANG_LTOFLAGS is defined unconditionally (in com_GCC_defs.mk), so using the $(or..) function is completly bypassed, always using the flto=thin switch. Change-Id: I903e5e4818b8ecbe63ed85952b8741140972e8d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143572 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-12-05Revert: "split sw_filters unit test"Xisco Fauli4-217/+4
This commit reverts 1c2ea35b983c1159fe4633e449f8302ac9a7a024 it shouldn't be needed anymore after cdac145768488dc11b32b744bc753ab16aa08c6e "reduce cost of SwpHints::Check" Change-Id: I32a1d963f7bf90838c68db3bfefc8c8750e94128 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143417 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-05tdf#126477 DOCX export: fix lost charts in embedded documentsTünde Tóth3-1/+34
The charts of the embedded documents were not exported. Follow-up to commit a41cf57c1eb4cabe5afc1a45d6fe535dbb935217 "tdf#134987 convert DOCX to ODT: fix lost charts". Change-Id: I20f1cdfa68687043d0822c4bbf59793a208e83d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143495 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-05tdf#152211 PPTX import: fix connector position based on line widthTibor Nagy3-10/+28
Thick shape line changed the connector, e.g. direction of its arrow head. Follow-up to commit d8c89fb920af747ec51ce966b5d7b65e9340afbd "tdf#151891 PPTX import: fix regression of connector position" Regression from commit cbf66ec3e60d07efb7c3cceed9b4f0fb4f0510c8 "tdf#89449 PPTX import: fix line connectors". Change-Id: I99d22409ec65e10609b1e371cc4d301fd73c7c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143467 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-05tdf#148505 Fix COL_AUTO in embedded Math formulasRafael Lima1-1/+2
Change-Id: I8be0289100cbd0921bcb05ffec186155abba8743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143575 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-12-05tdf#86568 Move the scrollbar to the EditWindow in Basic IDERafael Lima9-57/+90
Currently, the Basic IDE has a shared horizontal scrollbar used both for the code editor window and the dialog editor window. However, the problem is that this causes the horizontal scrollbar to be placed at an unintuitive place when the code editor is being used. To avoid this problem the code editor already has its own vertical scrollbar. This patch creates a separate horizontal scrollbar for the code editor window and places it underneath the editor window to make it clearer what this scrollbar is meant to scroll. Change-Id: Ib873c004db902f0f729fd512c51effd8f5e38a9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143580 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2022-12-05ofz#53680 drop workaroundsCaolán McNamara4-75/+1
and add original test-cases which nowadays function without workaround. Change-Id: Ie2366737f9eb82774260b2a57bbf177f2712f485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-05Improve the layout of font features dialogKhaled Hosny1-4/+16
Make sure all sections have the same column alignments. Change-Id: I25bdc0ecf8f971f23d188999167df33476bea1f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143662 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-05tdf#152376: Remove Kacst Book and Kacst Office fontsKhaled Hosny10-52/+2
Change-Id: I979e01ee6cab26431a6e54094c59ea28e886019a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143647 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-12-05tdf#136077 Change OS context menu for new fileBogdan B1-11/+11
Right click on Windows for a new file is 'OpenDocument Text'. With this change would be 'LibreOffice Writer Document', and similar changes for each module. Change-Id: I34634d1f1d26c6a8c2146d03a2ecba357b58e4d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143637 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-12-05Mark ssXX and cvXX off by default in font features dialogKhaled Hosny1-1/+9
We know they are off by default. Change-Id: I77c8ecb0d65d46ec77ccc2570ecf5c05e6e577e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143660 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-05sw: prefix members of SwFootNotePage, SwFormatTablePage, ...Miklos Vajna6-128/+128
... SwOutlineTabDialog and SwTextFlowPage See tdf#94879 for motivation. Change-Id: Ie863c244d0fa5b885e1be1949f997410e27f80d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143661 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-12-05sd: Don't replace table styles on page pastingMaxim Monastirsky1-1/+1
i.e. insert a table, and set its style to anything except default. Then right click on the page in the page pane => Copy. Right click again => Paste. The table on the first page will reset to the default table style. The problem is in SdStyleSheetPool::CopyTableStyles which attempts to replace existing styles with the pasted ones, causing the old ones to be destroyed. But in fact there's absolutely no case where we want to do anything like this. All we want is to keep the formatting of the pasted page, not to change existing styles which might be used in the rest of the document. (And if the pasted style has indeed a different formatting, it can be inserted under a different name. To be handled in a follow-up commit.) Change-Id: I7caaffc72265bb045bf21c831f2da27012e41845 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143644 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-12-05Simplify SdStyleSheetPool::CopyTableStyles a bitMaxim Monastirsky1-32/+21
Change-Id: Ib8bbc8f71b310c1b968f36a94e99cce6019dd6cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143643 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-12-05tdf#136604: Remove Source Serif Pro and Source Code Pro fontsKhaled Hosny11-130/+2
Kept Source Sans Pro for now because it is used in some styles and using also weights that not supported by other fonts we bundle (e.g. light). Change-Id: I2eb9c6a2951e0c39e7021a5c90ed549d03f4a4e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143645 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-04cid#1517258 Dereference null return valueCaolán McNamara1-2/+9
Change-Id: Id8318fa1ae327f53fab61c2d3f5a73fa084771bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-04cid#1517253 Dereference null return valueCaolán McNamara1-0/+1
Change-Id: I222dd5c220de7f0775aa2966bc36c73952605ddc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143633 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-04cid#1517255 Dereference null return valueCaolán McNamara1-6/+4
Change-Id: Idb1a7790851a3416f84e99c7fd95e12e18b449f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143632 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-04tdf#152083: sdext Pre-reverse the text for RTL in Writer pdfimport as wellKevin Suo3-4/+65
Follow up to: commit 3a2f0e4772e7b4646dd518b33aeafb6fd7025179 Author: Kevin Suo Date: Sun Nov 20 00:10:14 2022 +0800 Resolves tdf#152083: Ligatures are incorrectly reversed in Draw pdf import The unit test is adjusted accordingly to reflect this change. Change-Id: I051a76ed38f76ff92197e1dc87cbfa7151b8ac35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143606 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-04cid#708627 Uninitialized scalar fieldCaolán McNamara1-0/+1
since: commit 19e3bab1a8def52d9a60f67bd87697e828e37773 Date: Thu Nov 24 15:19:17 2022 +0100 tdf#77650 Add option to place comments in margin (PDF Export) Change-Id: Ifcdd6caca199cada83c653d835ebce8964a77354 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-04ofz#53842 TimeoutCaolán McNamara1-0/+5
Change-Id: I24e5bf30c93bfe2ebb27c2b01232dbc8a42964a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143630 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-04tdf#147246 sdext: font name returned by font descriptor may be...Kevin Suo1-0/+4
... e.g. "NotoSerifCJKjp-Regular-VKana". Change-Id: I9818579c7678b0dad5ec2d2217ae59d573de88b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-04tdf#152083 related: make the isComplex check block as a separate functionKevin Suo3-18/+22
This is used to check whether a TextElement is rtl. We will need this in WriterXmlOptimizer::optimizeTextElements() as well, in a separate commit. Change-Id: Iee2ff5990450421153bb7c5afe9526c555f2d0ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143598 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-04Update git submodulesMartin Srebotnjak1-0/+0
* Update translations from branch 'master' to 935a5546788045d700b9b1b8ce2eed833e25699c - Updated Slovenian translation Change-Id: I4ce7e14713be2452dea2e2ace5047ee0a5c917fe
2022-12-04rtl bootsratp : use enum classArnaud VERSINI1-12/+12
Change-Id: Iea433a2a7be9b62f04b57883dbefaf25586f21d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143616 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-04osl : remove useless includesArnaud VERSINI1-2/+0
Change-Id: Ic350a924d3e5b58e8f1a60621edc701553d8cbab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-04it is not possible to install color palette extensions in Online or mobile appsAndras Timar1-0/+7
Change-Id: Ibb2e9bfcf4b8e8681f96e6863fd900181c278adf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143309 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit d3f3be20599e66d4d6eacc0fa73b5ab3fa6c2dee) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143581 Tested-by: Jenkins
2022-12-04Resolves: tdf#152196 visible gaps with glyph fallback in Arabic/Persian textCaolán McNamara1-1/+1
Change-Id: I0bf5a10940782f4507e7d632ec37bc4eaa710b03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143624 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-04Related: tdf#152196 adjustLinearPosX takes a doubleCaolán McNamara2-2/+2
Change-Id: I5e32c82b37af3900642199e0af74bf8b48218c2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143623 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-04Related: tdf#152196 adjustLinearPosX takes a doubleCaolán McNamara1-1/+1
Change-Id: I9566904b03b3856dc4092c5d1c15beb35ba7c840 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143622 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-04Some define-to-OUStringLiteral conversion in swMike Kaganski11-2493/+2511
Change-Id: Ib2b0b0b9774b3804db50b4af164c4fcf10b48d1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143629 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-12-04Use better variable namesKhaled Hosny1-6/+6
Change-Id: I99462a1f598affca1fe69908d3091af5fa219829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143618 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-04Check for trailing numeric part in isCharacterVariant/isStylisticSetKhaled Hosny3-42/+13
We want to mach features like “ss01” but not, say, “ssty”. Change-Id: Idc4fdf78c577afe66cf76d7f722dc2009863654e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143614 Tested-by: خالد حسني <khaled@aliftype.com> Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-04Add and use Feature::isCharacterVariant/isStylisticSetKhaled Hosny5-45/+30
Change-Id: Ifd772da1f4b81aa08440025a5c960fb226281194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143613 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-04Seperate Stylistic Sets and Character Variants in Font Features DialogKhaled Hosny3-15/+176
Makes clear what these features are when we use feature names provided by the font. Change-Id: I98a7294d3e1e7fef5293d0444c0fbbfcc131ed44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143611 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-04more_fonts: Update Amiri to version 1.000Khaled Hosny2-5/+5
Change-Id: I98961ed79cdf98449048e8d83e17e97222e71660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143620 Reviewed-by: خالد حسني <khaled@aliftype.com> Tested-by: خالد حسني <khaled@aliftype.com>
2022-12-03Related: tdf#152196 these should be at least DeviceCoordinateCaolán McNamara2-4/+4
Change-Id: I50404aaf522d5361fb2110258020564cb888f44d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143621 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-03tdf#132650 Improve applause.wav soundBogdan B1-0/+0
Change-Id: Id362378ccb179db7f9ce54bcc6769ad9fd816c5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143450 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-12-03Save with newer gladeKhaled Hosny1-65/+36
Change-Id: I23ba9ed200c1336f35f470e2709b153daa0b0aab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143610 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-12-03tdf#147246 sdext.pdfimport: "font-family-asia" -> "font-family-asian"Kevin Suo2-2/+2
This was a typo which causes the asian font in pdf (e.g. Chinese) always shown as the system default font on pdfimport. Change-Id: Ic118f8585fb40dfc4bc5bc12651da95bc7961ae4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-03ofz#53868 Integer-overflowCaolán McNamara1-0/+3
Change-Id: I5d6da712d5db9e0b8b19fca2101626a2a7e2907e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143569 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-03Update git submodulesJulien Nabet1-0/+0
* Update helpcontent2 from branch 'master' to a222befecb3808d06b6ae208cff9a055892051e4 - tdf#131075: LibreLogo Help Incorrect ~ Function Calls Change-Id: I1244cb1068bd86fad989f5b16554ddd63c923ffd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143577 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-12-03Update git submodulesBogdan B1-0/+0
* Update helpcontent2 from branch 'master' to e57b9b4bddcca46e96018ab242fee40ed011bd53 - tdf#152113 Improve Labels - Format page Change-Id: I7c82ecc95878130e8c8bbad54437f8482ac34b48 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142919 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-12-03add license of Thai hyphenation patternsAndras Timar1-0/+10
Change-Id: Ifbe30b6a2643b6724374d2fbc2f5b59f789c1acc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143313 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
2022-12-03Clarify the use of untools::WeakReferenceStephan Bergmann2-3/+16
...which had been introduced in 78040af9acea0ab681aa54ff23844b647bc9b4f3 "loplugin:refcounting in sc" as a variation on css::uno::WeakReference from include/cppuhelper/weakref.hxx, but without giving much of a rationale. And, at least for --with-latest-c++ builds using a capable C++20 compiler, ensure that the given interface_type is such that the static_cast and dynamic_cast in the implementation of unotools::WeakReference::get are actually sound: If interface_type could be a UNO interface type, that would imply that the xInterface obtained from the underlying WeakReferenceHelper::get() could be a proxy from the C++ UNO bridge, which could (a) be a proxy for only a subtype of interface_type (e.g., just for XInterface), so that the static_cast would be broken, and (b) be a proxy for which the vtable's RTTI slot is not set up (see e.g. the ENABLE_RUNTIME_OPTIMIZATIONS code in bridges::cpp_uno::shared::VtableFactory::initializeBlock in bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx), so that the dynamic_cast could crash. (These issues can even happen when the given interface_type is a C++ implementation class type, but the given object has been bridged over some C++ to C++ UNO ("purpose") bridge, but lets leave it at that...) This required adding some cppu::detail::isUnoInterfaceType predicate to the include files generated by cppumaker, which can be useful in other places too. (For the call to isUnoInterfaceType in the requires-clause of unotools::WeakReference<interface_type>::get to give the correct answer, it is important that interface_type is a complete type---i.e., the corresponding codemaker-generated .hpp having been included if interface_type actually were a UNO include type. But that is already nicely required by the call to std::is_convertible_v in the implementation of that function, anyway.) Change-Id: Ia5efd70085d2d6d45fa0995d00dc8def564bbe5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143601 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-03tdf#143123 Port Text Java examples to PythonChenxiong Qi10-0/+1083
The examples inside odk/examples/java/Text are ported to Python: BookmarkInsertion.java -> BookmarkInsertion.py GraphicsInserter.java -> GraphicsInserter.py HardFormatting.java -> HardFormatting.py StyleCreation.java -> StyleCreation.py SWriter.java -> SWriter.py StyleInitialization.java -> StyleInitialization.py TextDocumentStructure.java -> TextDocumentStructure.py TextReplace.java -> TextReplace.py WriterSelector.java -> WriterSelector.py Code format is checked with 'pycodestyle': pycodestyle --ignore=E501,E722 odk/examples/python/Text/*.py Some Java methods are merged when ported to Python. Signed-off-by: Chenxiong Qi <qcxhome@gmail.com> Change-Id: Ic903cfa24ef32f8edaafd7e6e2e0c757b4b1be0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141425 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2022-12-03vcl: simplify ImplFontMetricData::ImplInitTextLineSizeHarfBuzz() a bitKhaled Hosny1-38/+41
Change-Id: I844b4fc39784ac093a3339b8912efd236ae152ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143605 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-03tdf#151548 ContentControls vba: allow search by name/floatJustin Luth4-14/+24
This so-called modern content control is rather terrible for VBA programmers. It has no modifiable ID! Instead, there is a random _signed-integer_ as a unique id. How descriptive... Since it is an integer, it can't be passed to Item(), because then it would be an index lookup. Instead, you can pass it as a float (indicated by a #) or as a _unsigned-integer_ string. Recently the ID was preserved for content control import/export, so we can now round out our VBA to find content controls by name. make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba Change-Id: I387a287505e17d3768bad5ed954136e532ca70e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143196 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-12-03Resolves: tdf#146610 don't reformat MetricSpinButtons if unit didn't changeCaolán McNamara1-1/+4
Change-Id: I58f36b18b456e6d3ccd7482b681e5273ca132499 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>