summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-11-02sw: return SwXFieldmark in SwXFieldEnumerationMichael Stahl11-22/+265
* Implement text::XTextField in SwXFieldmark * That requires overriding XTextContent, just forward to SwXBookmark * Also override XServiceInfo implementation in SwXFieldmark * Add a PropertySetInfo for SwXFieldmark, which doesn't support "Hidden" or "Condition" properties of SwXBookmark * in SwXFieldmark::setFieldType(), only allow sensible new types * fix DomainMapper_Impl assumptions that if it implements XTextField it can't be a fieldmark, which caused CppunitTest_sw_ooxmlexport10 testTdf92157 to fail with a SAXException caused by some disposed SwXTextCursor Change-Id: I1ae2e9cb99ea784040874517e4d1af7e59d24405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105083 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-02SwGrfNode: ModifyNotification no more ...Bjoern Michaelsen3-32/+26
Change-Id: I6c1fda1d92c4e3511113fcd8a8bc09efba96e3e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105180 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-02SwFieldType: ModifyNotification no more ...Bjoern Michaelsen3-14/+17
Change-Id: Idb6c0a6cca5df729037067f6def5594eed2cca19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105178 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-02sw/source/core/undo: ModifyNotification no more ...Bjoern Michaelsen9-41/+23
- also: introduce SwFormat::RemoveAllUnos() as a member function, because that is where this belongs ... - ... and then also use it elsewhere if possible. Change-Id: I9cc073a41ef1077429f648309806fa433bdcec99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105173 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-02Update git submodulesAyhan Yalçınsoy1-0/+0
* Update helpcontent2 from branch 'master' to 12deefd044691e11e71dd58e0b8bd9a28b0b99cc - tdf#137720: Help files-Slide, Page Setup replaced with Slide, Page Properties Change-Id: Iacb7c08c386be0cb950e53d73980d3a90e2c8ec3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/105064 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-11-02tdf#137720: Slide, Page Setup replaced with Slide, Page PropertiesAyhan Yalçınsoy2-2/+2
Change-Id: I69600305698583d64bd9c5d3950b3fb7762fcf8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105044 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-11-02Cell Alignment Dialog updateandreas kainz1-5/+11
Change-Id: I86954c4fa8910d8d7e4d4e815ffcd600e2b11c0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105161 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-02drop the SvXMLExport::Characters method..Noel28-57/+50
in favour of just using the characters() method Change-Id: Iecb2773d488fcf4fa3c2202d0e889015a288fe2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105174 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-02tdf#126700 handle Impress default documentsJan-Marek Glogowski3-5/+14
Impress has a two stage load, eventually because of the optional template manager. Since I don't know, what the 2nd load URL "private:object" is used for otherwise in LO, this just marks the empty and default documents as replaceable in Impress. Regressed-by: 61e1e0413296928d929f99c0f006c6cbbcf4ac40 Change-Id: Ief8d9eeaa65e8fb40400e64c16768d37ca343893 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104581 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-11-02Fix regression after aba06f2c3a39f33007a8f4e6e234254f42e01f0dJulien Nabet3-7/+28
It generated requests like: CHAR CHARACTER SET OCTETS (100) instead of: CHAR(100) CHARACTER SET OCTETS Change-Id: If32723a99d1ca40c765d89b527ec633cc17cf72b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105157 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-02tdf#137620 support surrounding text for calc commentsCaolán McNamara1-0/+21
Change-Id: I362a8ec6cd5de8602863fd2e520c8bd1a3706f00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105171 Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2020-11-02Print dialog alignment fixesandreas kainz1-9/+40
Change-Id: Ife471e062745ce8aa7dd9b806612c00794e4d878 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105159 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-02remove duplicate initialisationNoel1-3/+0
Change-Id: Ia1b99ed420daf5d238082f374eab7b76920714f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105167 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-02sw: prefix members of SwDistance, SwLayIdle, SwOszControl and ...Miklos Vajna5-142/+156
... SwWebColorConfig See tdf#94879 for motivation. Change-Id: I35991a60faaad568ef7b52120c827699db2a5116 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105168 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-11-02-Werror=parenthesesStephan Bergmann1-2/+2
Change-Id: I6f4214a235dbeaade8e58597f784a0e435616682 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105166 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-11-02Windows 7 support is already supportedMike Kaganski1-2/+1
The comment was added in commit e9daae2025279d04155ddeb794bb35952e627ed7 in 2010; Windows 7 support was eventually implemented in 2013 in commit 776db316d271d14e653426e21e66b983ec52100a. Change-Id: I830321ef2131ad56ac664867ac71857fce8d9c75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105061 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-02loplugin:reducevarscope in lotuswordproNoel6-10/+8
Change-Id: Ie0aa6b91fe13d24b5cf60abc14cf43c2106b53da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105165 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-02check-elf-dynamic-objects: allow libgsttag-1.0.so.0Michael Stahl1-1/+1
It's linked in Fedora 33 and apparently exists in gst-plugins-base since 1.0.0. Change-Id: Ifc5d6a6b06e05ef4e250ac26a8588a242f21a034 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105140 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-02Better types for SystemGraphicsData::hDrawable, cairo::X11SysData::hDrawableStephan Bergmann2-3/+2
Both apparently only hold X11 Drawable values. But include/vcl/sysdata.hxx does not include the X11 include files that would define Drawable, so use sal_uIntPtr there, which is also used for other similar SystemEnvData and SystemParentData aWindow members there. Change-Id: Ia136ad1937e2009eb409c3ef8cc41dc81bd338a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105156 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-02missing includeStephan Bergmann1-0/+3
Change-Id: I145d1719728504af1459c1fa1a010cdac9c09956 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105158 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-02toolbox always has flat styleNoel Grandin16-203/+24
ever since commit c1cd6af623e86b5b1b45f9d09dc17d6fbb907f02 Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Mon May 10 14:51:02 2004 +0000 INTEGRATION: CWS nwf (1.64.66); FILE MERGED 2004/03/31 09:28:33 ssa 1.64.66.1: #i25130# force flat toolbox buttons except for a completely and utterly undocumented hack of a registry key, introduced in commit 736dc0956a50315ec72ad126406556657a750d37 Author: Rüdiger Timm <rt@openoffice.org> Date: Thu Apr 17 14:19:46 2003 +0000 INTEGRATION: CWS vcl08 (1.57.2.4.18); FILE MERGED 2003/04/14 17:46:27 ssa 1.57.2.4.18.1: #108699# disabled flat toolbox buttons not exported anymore which only seems to apply to Windows. So just remove this. Change-Id: Idf315b8c89c3119883a5e6880d003d379fe6faec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105155 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-02Resolves tdf#137813 - Status bar info 'PDF selected'Heiko Tietze2-6/+18
Change-Id: I60cc75dfe8e63d7d545211a9bf58efc9d34d51ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104996 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-11-02tdf#130526 Hide "Apply to Master"-button and rename "Slide" to "Page" in DrawSven Lüppken1-0/+8
Both options don't apply in a Draw context and confuse users. This solution was proposed in the bug ticket. Change-Id: I4f55fd68990e4b7ee3fa6f94bf16a531728ee278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105034 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-11-02tdf#105776 Add page-down & page-up navigationdiwanshu8851-0/+24
Change-Id: I558c2555ebdf0569cf6c61e5811c57f111c32d82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105148 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-11-02make SvXMLImport capable of mixing fast- and slow- contexts adhocNoel144-1137/+478
so I can convert even *ImportContext subclasses in the middle of a context stack, and thus break the cyclic dependency nature of the writer import. and adjust the xmlimport loplugin for the new rules. As a consequence of the loplugin:xmlimport's checking, we remove a bunch of now unnecessary overrides of startFastElement. Change-Id: I97464522ede8ec5e345e928cdafa4b18364b1b80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-02use officecfg or MacroRecorderModeNoel Grandin4-45/+10
Change-Id: I2a8d4f401ddfd4368a7b50b4c3c8a72724f9afa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105154 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-02Sidebar Area alignment updateandreas kainz1-5/+7
Change-Id: Ie8155e73adc2c52e8f3ec3455a5cdb4ed596c352 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105160 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-01fix build with ICU 68Rene Engelhard1-1/+8
use standard true. /home/rene/LibreOffice/git/master/i18npool/source/calendar/calendar_gregorian.cxx: In member function 'virtual void i18npool::Calendar_gregorian::setLocalDateTime(double)': /home/rene/LibreOffice/git/master/i18npool/source/calendar/calendar_gregorian.cxx:363:40: error: 'TRUE' was not declared in this scope 363 | body->getTimeZone().getOffset( fR, TRUE, nZoneOffset, nDSTOffset, status ); | ^~~~ /usr/include/unicode/umachine.h says: @deprecated ICU 68 Use standard "true" instead. Change-Id: I45d2b0afa6a9043767af5c2cf41ba24377f2cdc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105151 Tested-by: René Engelhard <rene@debian.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2020-11-01Colibre: Update navigation, mail merge, gallery component, info iconsRizal Muttaqin85-42/+43
Change-Id: If785dc620122ce2acd1b33ffe84d2e6b6294e2b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105149 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-11-01Colibre: Update image/picture/graphic iconsRizal Muttaqin104-56/+48
Delete redundant/unecessary icons Change-Id: Ibd2d54585f328f199050f962ef6919e471fd5269 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105135 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-11-01move UpdateAttr sanity check to DBG_UTILBjoern Michaelsen1-0/+4
Change-Id: I9a6fd1ef8ea704a0ea3f8182d06cbbe938fd1937 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105137 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-01use officecfg for ShowLinkWarningDialogNoel Grandin6-76/+21
Change-Id: I92a42eb2ff48bff4e635f1a37a25c8ecb9ac1347 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01Make SwClient::ModifyNotification non-virtualBjoern Michaelsen4-12/+15
Change-Id: Ic34b0b7a3ad906da5f25103f32a28e2a3efd82fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105150 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-01Resolves: tdf#135108 Allow link updates if loaded document so far had noneEike Rathke3-1/+16
It is the current user who'll add external references, not the creator of the loaded document. Change-Id: I59a6d0b8600a9b299aa54a1efeedfccc16ad69d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105152 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-11-01tdf#137620 support surrounding text for impress outline viewCaolán McNamara2-24/+29
Change-Id: I7136ec4237fe41bd7e795594d66413fc7d8c311c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105146 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-01dynamic_cast followed by static_castCaolán McNamara2-14/+6
Change-Id: I29daabb250d72403ccf751aeeb5fd2fa755e895c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105145 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-01cid#1468697 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: Ibc589c87356781b143088d4231a8c0a2a2671961 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105143 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-01use officecfg for IsPluginsEnabledNoel Grandin3-50/+10
Change-Id: Id80ba8a87af7f87b8232949b70804b1a021b23d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105147 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01sw/source/core/txtnode: ModifyNotification no more ...Bjoern Michaelsen5-25/+23
Change-Id: I380b6c173d35865188c6d65f356a6e5d1165bd1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105138 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-01sw/source/core/crsr: Stop abusing observer pattern for code obfuscation.Bjoern Michaelsen2-11/+11
Change-Id: I2423b70b2d6a9e90388bb7c83d886181cb268c0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105136 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-01Transport Pixmap from GetNativeSurfaceHandle via css::uno::Any as sal_Int64Stephan Bergmann5-6/+6
The values returned from GetNativeSurfaceHandle are only used in cairocanvas::CanvasBitmap::getFastPropertyValue (canvas/source/cairo/cairo_canvasbitmap.cxx), whose consumers in turn are (at least the ones I could identify): * OGLTransitionerImpl::setSlides (slideshow/source/engine/opengl/TransitionerImpl.cxx), passing the values on to X11SalObject::SetLeaveEnterBackgrounds, which extracts the Pixmap value to pass it on to XSetWindowBackgroundPixmap. * X11SalBitmap::Create (vcl/unx/generic/gdi/salbmp.cxx), which extracts the Pixmap value to pass it on to X11SalBitmap::ImplCreateFromDrawable (as a Drawable) and to XFreePixmap. While Pixmap XIDs are apparently 32-bit in the X11 protocol, see e.g. <https://www.x.org/releases/X11R7.7/doc/xproto/x11protocol.html>, Xlib and the underlying /usr/include/X11/Xdefs.h appear to be somewhat confused whether the typedef for XID should be unsigned long (presumably stemming from times when long was universally 32-bit) or CARD32, see e.g. <https://gitlab.freedesktop.org /xorg/proto/xorgproto/-/blob/master/include/X11/Xdefs.h>. So conservatively stick to a 64-bit type here, even if it should only ever contain 32-bit values. Change-Id: I26c3a2ff74cef092042a6e3648cd9a6f4a9e3aac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105144 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-01use officecfg for UseSystemFileDialogNoel Grandin6-83/+30
Change-Id: I1419af229a67d6ebb1cf2c63757656beb3f512db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105142 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01std::set->o3tl::sorted_vector in SwpHintsNoel Grandin1-3/+3
Change-Id: I6affafb9733495c07c322abc9ac7456862df1332 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105134 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for UseSystemPrintDialogNoel Grandin3-58/+10
Change-Id: I0e0bdc925f106884cbcede6405cc6ef7152ad405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01std::set->o3tl::sorted_vector in writerfilterNoel Grandin1-2/+2
Change-Id: I8b4527c8e40687918b3d5193f6c14ee86addab53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105132 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01std::set->o3tl::sorted_vector in ExportFramesNoel Grandin1-8/+6
Change-Id: Ic82a1aad7df2b0088a78c8d82ceb487d8b9e0571 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105133 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for Experimental flagNoel Grandin42-139/+143
move IsShowOutlineContentVisibilityButton out of header to avoid having to add extra include paths to all the unit test makefiles. Change-Id: I2763390e07cd85b8f09b6f2ad7702039daecb22f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01Resolves tdf#137880 - Fix for Windows installer imageHeiko Tietze1-0/+0
Change-Id: I0d57fb54343059bc30d032ae7d4bdbbd3c4c5c70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105131 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-11-01tdf#136814 Fix border padding in Word exportSven Lüppken6-3/+25
While converting twips to points in the Word export filer, information is lost due to integer division. This patch tries to fix this by using floating-point division and (hopefully) proper rounding. The example document attached to the bug ticket works as expected now. Change-Id: I4b5b2163e42932b5e877726d16635d9f02a43cb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105128 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-01Use save_CFLAGS etc in a uniform wayTor Lillqvist1-13/+9
Restore the old CFLAGS (etc) as soon as possible. Always use the same variable names for the saved values. Change-Id: I523bbf66ec5400d24993b7e11e444bb63d61751e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105130 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>