summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-10-06convert equals() to operator== in xmlreader::SpanNoel Grandin10-218/+198
Change-Id: Ic6a8eae344c06be87e2bc4bf7f242a2d18ebc8ad Reviewed-on: https://gerrit.libreoffice.org/80312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-06the PCH in compilerplugins should also depend on the MakefileLuboš Luňák1-1/+1
Otherwise it may not get rebuilt in Jenkins when flags in the Makefile change. Change-Id: I9a06c5bbfd4af2714497c5658d8c523a6c929f68 Reviewed-on: https://gerrit.libreoffice.org/80318 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-06replace throw with abortLuboš Luňák1-2/+8
There is nothing catching the exception anyway, and this fails to compile if compiling the plugin with Clang's CXXFLAGS (which include -fno-exceptions). Change-Id: Iad9316ad9613e4fd66d0e5a16fd71bbb8066cc2b Reviewed-on: https://gerrit.libreoffice.org/80299 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-06tdf#124456: Make Ant configure.ac check more robustDennis Schridde1-1/+1
Change-Id: Iee16dd23c7881756663e8b6a67e4391186a6e430 See-Also: https://bugs.gentoo.org/682156 Reviewed-on: https://gerrit.libreoffice.org/80233 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-06Replace SystemEnvData pToolkit/pPlatformName strings with enumsStephan Bergmann7-25/+24
(and streamline those data members' names) Change-Id: Ifdd596c7a54dd507045d412c30b463468c2f798b Reviewed-on: https://gerrit.libreoffice.org/80313 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-06improve SfxPoolItem operator== implementationsNoel Grandin45-114/+93
(*) make them all call the superclass operator== (*) make the base class check which and typeid to ensure we are only comparing the safe subclasses together (*) remove a couple of operator== that were not doing anything useful Change-Id: Ia6234aed42df04157a5d6a323dc951916a9cb316 Reviewed-on: https://gerrit.libreoffice.org/80308 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-06SystemEnvData::nSize is no longer read and can be removedStephan Bergmann15-26/+4
...since 5926b22b5dc33490d23d594b129eb8a70b94ffb0 "The SystemEnvData passed into the canvas factories appears to be unused". (And the user-provided SvpSalObject ctor can be removed, at which point the use in SvpSalInstance::CreateObject should be written without "()" to avoid loplugin:subtlezeroinit. Change-Id: I4392fa2d697b29c814d7b577a7b1f8c984c05e70 Reviewed-on: https://gerrit.libreoffice.org/80298 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-06Optimize getNamespaceId (xmlreader)Julien Nabet2-0/+12
Adding a map to cache values allows me 20s -> 13s to start LO Change-Id: If343225def253e29696b96f223cdcb54d0d8525d Reviewed-on: https://gerrit.libreoffice.org/80290 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-05Update git submodulesKohei Yoshida1-0/+0
* Update helpcontent2 from branch 'master' - XML Source is no longer an experimental feature. See abb6ee1d2a0f40a4a29c60fb0c71c5644294d658 in the core repository. Change-Id: I486931b9519200a922bd82dfb051c1500ada12d0 Reviewed-on: https://gerrit.libreoffice.org/80309 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-10-05ofz#17212 Floating point exceptionCaolán McNamara1-0/+4
deploy a workaround, bug logged against boost as: https://github.com/boostorg/boost/issues/335 Change-Id: I9791133e926dd474ddc5960a33fd90592ce3dcb3 Reviewed-on: https://gerrit.libreoffice.org/80304 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05Let's bring XML Source out of the list of experimental features.Kohei Yoshida1-6/+1
Change-Id: I872a047fe3791253aa52b19d544fb5f26ff22f9d Reviewed-on: https://gerrit.libreoffice.org/80296 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2019-10-05only MultiLineEditSyntaxHighlight uses UpdateDataCaolán McNamara3-59/+3
and only the VclMultiLineEdit one which hides the Edit one so remove the unused Edit UpdataData related functions leaving the VclMultiLineEdit set Change-Id: Icd9a633d28907b3e5a3d52771b31574984e64d92 Reviewed-on: https://gerrit.libreoffice.org/80228 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05FileControl can be private inside svtoolsCaolán McNamara4-10/+9
Change-Id: I52edd5166edc9aceeafffed898835fe5bc46880c Reviewed-on: https://gerrit.libreoffice.org/80232 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05Resolves: tdf#127946 pass in argument for dialog parentCaolán McNamara1-2/+5
Change-Id: If1e8339277cedf2577934246a568ecc869355a9e Reviewed-on: https://gerrit.libreoffice.org/80291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05The SystemEnvData passed into the canvas factories appears to be unusedStephan Bergmann9-72/+53
It was passed in as aArg[1] ever since d551190e8311242eadda4a3e82efff160175cb04 "INTEGRATION: CWS canvas05", but I can't find any current use of that specific argument in canvas/source/ (assuming that all the factories are implemented there), nor can I find any trace in the git history of it ever havig been used. That means that Window::GetSystemDataAny is unused now and can be removed. Change-Id: I16efe548afb5cc3e0606cffea135f7e6674d5def Reviewed-on: https://gerrit.libreoffice.org/80295 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05tdf#127935 Make double click expand/collapse entry in option treeJim Raykowski2-0/+10
Also makes keyboard use to expand/collapse work Change-Id: I5b9d065ebe4a612ebe9658feb9ff71c504de7982 Reviewed-on: https://gerrit.libreoffice.org/80173 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05don't need button.hxx hereCaolán McNamara1-1/+1
Change-Id: I6c3225e28a05633fb68d5a08e2134c1251308717 Reviewed-on: https://gerrit.libreoffice.org/80231 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05move file picker only code to fpickerCaolán McNamara26-111/+154
Change-Id: I47cc2cb7db396a06a2abeffe4a5d40a039f21c58 Reviewed-on: https://gerrit.libreoffice.org/80222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05The checks should apparenty be maArguments.getLength() >= 5Stephan Bergmann2-2/+2
...given that maArguments[4] is accessed two lines further down, in both cases. Looks like typos in b6a7c4da52acf45a7b69d1e81cf9548f8552752e "INTEGRATION: CWS canvas05". Change-Id: Iee8a111126f2b81c9e586fe8e3c569fbd81dd8f4 Reviewed-on: https://gerrit.libreoffice.org/80289 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05ofz#17448 avoid OOMCaolán McNamara1-1/+5
Change-Id: Ie709eb0ce7c3987081b4b01fd96e7f99e7a48c27 Reviewed-on: https://gerrit.libreoffice.org/80240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05ofz#16306 avoid timeoutCaolán McNamara1-1/+4
Change-Id: I668b590d7abf466b90a1123ef9c8b9fed1a907ed Reviewed-on: https://gerrit.libreoffice.org/80251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05simplify SfxAllEnumItemNoel Grandin4-105/+27
It is just a data carrier for an array of values for SID_ATTR_PATHNAME, it does not need associated enum logic. Change-Id: I547cd5580d02eb9c261feeb3545e31910a4ed644 Reviewed-on: https://gerrit.libreoffice.org/80253 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05Drop bogus memsetStephan Bergmann1-2/+0
..that is both bad and unnecessary since 8003f8694ac7c4bc117f7ce692339534d37681f0 "loplugin:useuniqueptr in oneToOneMappingWithFlag" changed oneToOneMappingWithFlag::mpIndex from an array of raw pointers to an array of std::unique_ptr. Change-Id: I247a619ebd7804a8a4faee2797f8c4753f9c4ec6 Reviewed-on: https://gerrit.libreoffice.org/80288 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05Convert some SID in sd to SfxUInt16ItemNoel Grandin6-25/+27
Some, like SID_NAVIGATOR_PAGE were incorrectly using SfxAllEnumItem, and others did not need to use SfxAllEnumItem. Change-Id: I0f61dcdda8bbc021667db3cf78141778f7b85087 Reviewed-on: https://gerrit.libreoffice.org/80252 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05Convert various FID_VALID_* to SfxUInt16ItemNoel Grandin2-12/+12
Change-Id: Ic21ec69513ee520cedc026b8c2d657464beed19b Reviewed-on: https://gerrit.libreoffice.org/80250 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05Convert various RPTUI_ID_* to SfxUInt16ItemNoel Grandin1-3/+3
Change-Id: I261c30c35d3967ece7078b8529a42e646c00a90f Reviewed-on: https://gerrit.libreoffice.org/80249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05Convert SID_PAPER_START/END to SfxUInt16ItemNoel Grandin3-7/+7
Change-Id: I62067075853b1d5c893c14d72a247b07a3cc5585 Reviewed-on: https://gerrit.libreoffice.org/80248 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05Convert SID_ENUM_PAGE_MODE to SfxUInt16ItemNoel Grandin4-5/+5
Change-Id: I5cffa31b45b7752ba3ff18c8a92da9766fcf8de6 Reviewed-on: https://gerrit.libreoffice.org/80241 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05use SfxUInt16Item for SID_ATTR_TRANSFORM_SIZE_POINTNoel Grandin5-6/+5
Change-Id: Id7762047a17a1652c91761d3c910eadd3393040b Reviewed-on: https://gerrit.libreoffice.org/80237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05Drop bogus memsetStephan Bergmann1-2/+0
...that is both bad and unnecessary since 57871f98d30c0283969de1a41e72f5838d6c0eb0 "loplugin:useuniqueptr in SwNumRule" changed SwNumRule::maFormats from an array of raw pointers to an array of std::unique_ptr. Change-Id: I0cb05f022b2f067c0b62ecd42878377b139ec4fe Reviewed-on: https://gerrit.libreoffice.org/80281 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05Drop bogus memsetStephan Bergmann1-1/+0
...that is both bad and unnecessary since 76643b208c7f0c43b0603e08a3b37f29878c42ea "loplugin:useuniqueptr in SvxNumRule" changed SvxNumRule::aFmts from an array or raw pointers to an array of std::unique_ptr. Change-Id: I889da7973958d5546ded67be4f51f6312b240ea9 Reviewed-on: https://gerrit.libreoffice.org/80275 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05Remove redundant memsetsStephan Bergmann2-7/+0
...since 1f8c2a2e5c8bda6e6e35a868e5ac7afdc7d32317 "coverity#1187868 Uninitialized pointer field" introduced a default ctor zero-initializing all members of SystemEnvData Change-Id: Ifd31282ab4b82e26733afdd74c234a8a1b4dbb4c Reviewed-on: https://gerrit.libreoffice.org/80255 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05Drop bogus memsetsStephan Bergmann2-7/+1
...that are both bad and unnecessary since 54604f01330063635fb974b0ab4335d6af851551 "loplugin:useuniqueptr in SwNumRulesWithName" changed SwNumRulesWithName::aFormats from an array of raw pointers to an array of std::unique_ptr. (GCC -Wclass-memaccess didn't catch that because it apparently fails when the argument is of array instead of pointer type.) Change-Id: I6a4a03b1d16c203118fc83c0c3c44646be39a5b3 Reviewed-on: https://gerrit.libreoffice.org/80254 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05bin/find-most-common-warn-messages.py: Switch to python3Michael Weghorn1-3/+3
python2 is nearing its EOL. (The new version still runs fine with python2 if explicitly called as 'python2 bin/find-most-common-warn-messages.py'). Change-Id: I1153a3e468a7f36c299767a32f683b84efa8af04 Reviewed-on: https://gerrit.libreoffice.org/80286 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-10-04ofz#17675 loop in lwp filterCaolán McNamara1-0/+4
Change-Id: Id0c75e03794a622a9353559453ab5688c31f4b9d Reviewed-on: https://gerrit.libreoffice.org/80238 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04ofz#17992 null derefCaolán McNamara1-4/+7
presumably since... commit f9aac900ada3d507526eeeed5b51fc7a10ab4cae Date: Wed Oct 2 14:57:16 2019 +0200 tdf#81100 DOCX import: repeat header according to table style Change-Id: I4f093606a15909c8e29b18dfb792abd938a80c5b Reviewed-on: https://gerrit.libreoffice.org/80234 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2019-10-04ofz#17823 avoid timeoutCaolán McNamara1-0/+9
Change-Id: I3658d476873a502adc0cbd8be9a4f6ffd5b62c87 Reviewed-on: https://gerrit.libreoffice.org/80236 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04SvtFileView not referenced in any .uis anymoreCaolán McNamara3-18/+0
through the fpicker constructs one directly Change-Id: Ic365231e78ca9425b97006a156273479d104eae9 Reviewed-on: https://gerrit.libreoffice.org/80211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04weld OCollectionViewCaolán McNamara6-93/+165
Change-Id: I3aac2b42442ec3f61c2d18369eae061ae44880a5 Reviewed-on: https://gerrit.libreoffice.org/80205 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04tdf#127529 vertical text not drawn in slideshow canvasCaolán McNamara9-24/+75
because the canvas text drawing impl falls back to using an OutputDevice view of the canvas to use the vcl text drawing apis to achieve vertical text To get an OutputDevice view of the canvas there is a specific VirtualDevice ctor available to create a VirtualDevice that, unlike the normal case, doesn't have its own specific backing buffer, but instead draws to the underlying target provided via the SystemGraphicsData arg The svp/gtk impl missed that understanding and provided an ordinary VirtualDevice with its own backing buffer, not a VirtualDevice that would draw to the expected target surface of the canvas. So the vertical text was drawn to a different surface than the intended one, and was just discarded. The cairo use in the canvas long precedes the use of cairo in vcl itself. Seeing as text is now rendered with cairo in all cases where the canvas uses cairo its probably now pointless for canvas to have its own text rendering path. Change-Id: Ie3b0a43ca2b746cbfe25e2d0415315b3d5403cd2 Reviewed-on: https://gerrit.libreoffice.org/80162 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04drop unnecessary includesCaolán McNamara8-8/+4
Change-Id: I2d6828734cfdf795499d54e1b1e8ba9fc4b5a4d1 Reviewed-on: https://gerrit.libreoffice.org/80197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04drop some unnecessary includesCaolán McNamara4-9/+3
Change-Id: I5bea83184dd900215ca6f60ba23a4d724789c753 Reviewed-on: https://gerrit.libreoffice.org/80190 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04default arg never usedCaolán McNamara2-2/+2
Change-Id: I4b6277f6dd5557f9ae67588c86819666747400bf Reviewed-on: https://gerrit.libreoffice.org/80191 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04Related: tdf#127529 make it harder to misunderstand this VirtualDevice ctorCaolán McNamara8-11/+13
Change-Id: I250bc68da118a994a2e0ff8ab9eb11112827756d Reviewed-on: https://gerrit.libreoffice.org/80158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04document 0 len case of set_max_lengthCaolán McNamara3-5/+4
Change-Id: I8300ff2d68f35da38e2314eefa7f2a2184981eab Reviewed-on: https://gerrit.libreoffice.org/80194 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04sSubFolder contents is always overwrittenCaolán McNamara1-2/+1
Change-Id: Ic2183a81f85dfec5361db9bf42174f2f9218ae5b Reviewed-on: https://gerrit.libreoffice.org/80204 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04Fix typoAndrea Gelmini1-1/+1
Change-Id: I553bbcdeef269317d97bed5242bc64cb1b42f91c Reviewed-on: https://gerrit.libreoffice.org/80227 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-04Removed executable bit on cxx and ods filesAndrea Gelmini4-0/+0
Change-Id: I137af32cdd3a9e145c0f436d98670869f15f6673 Reviewed-on: https://gerrit.libreoffice.org/80226 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-04jsdialogs: hide one number format option initiallySzymon Kłos1-2/+2
For now mobile wizard in online uses static ui structure so avoid showing both types of controls for numbers Change-Id: I433fcf389b0dafb7234061e8d9ca56d132c0f257 Reviewed-on: https://gerrit.libreoffice.org/80209 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-04button icons are always left align not top changedandreas kainz1-1/+0
Change-Id: I28156de7d9adc74b02bfcecec82f282b7b1a35bf Reviewed-on: https://gerrit.libreoffice.org/79593 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-13 20:01:44 +0000