summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-06-18sw: try not to layout in SwShellTableCursor::FillRects()Michael Stahl1-1/+1
This crashes after Undo in tdf#134021 bugdoc, because there's no Action there so a SwTabFrame::RemoveFollowFlowLine() deletes a row and a11y events are sent synchronously, then the a11y code calls back into sw and accesses semi-connected cell frames. Change-Id: I98e8acf4756a44b8776e01d6b831d4b1494792f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96603 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-18sd signature line: teach PDFDocument how to use PDFObjectCopierMiklos Vajna5-5/+45
This will allow using the object copier in PDFDocument::WriteAppearanceObject(), so we can include the signature line pdf export result in a pdf signature of the original pdf. Change-Id: Iabc508081c5820f4ca997a2d264de9bdb06f82bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96607 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-18tdf#133982: sw: Add unittestXisco Fauli2-0/+25
Change-Id: I1a9b0a1150f8e3e1832aaa15a09049622bd83afc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96592 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-18Add missing header after c8bed6445b244a5d9021dbd9a2ff19d80c03917bMike Kaganski1-0/+1
Change-Id: I24d354d8d781da3944044a2895e7d9163c31076f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96601 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-18use jdk11 also for the perfsuite jenkins configChristian Lohmaier1-0/+1
was forgotten when the other config were adjusted in 6cd885b46bf168a1fe0d91231a1b6d283f813ed3 Change-Id: I35de4248a6f835ed13cc1bdb28713b156a4785bd
2020-06-18distinguish active dnd-operation case from simple query caseCaolán McNamara12-27/+33
Change-Id: I1d8e95e46b45c71c0c83316ab4f19ba85eddcf75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96598 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-18tidy up variable namesCaolán McNamara1-6/+6
Change-Id: If41b8bc91d7a22db1de9225b39f7350ffdf68ad4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-18ReleaseMouse if disposed during mouse downCaolán McNamara1-0/+3
Change-Id: I9595e014e639de1b3e71fc9387cea248bb6d74e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-18go for the easy fix and use internal python for the callgrind jobChristian Lohmaier1-0/+1
instead of finding a way to not break it again for others (see https://gerrit.libreoffice.org/c/core/+/91748 and https://gerrit.libreoffice.org/c/core/+/90906 ) Change-Id: I3291dbc1552c7601a93a9b30a98ae43f238e2c5d
2020-06-18Avoid unhelpful -Werror=stringop-truncationStephan Bergmann1-5/+5
...emitted at least by recent GCC 11 trunk (even with --disable-optimized, where optimization level traditionally has some impact on what warnings of this kind are emitted exactly): > tools/source/misc/json_writer.cxx: In member function ‘tools::ScopedJsonWriterNode tools::JsonWriter::startNode(const char*)’: > tools/source/misc/json_writer.cxx:42:12: error: ‘char* strncpy(char*, const char*, size_t)’ output truncated before terminating nul copying 5 bytes from a string of the same length [-Werror=stringop-truncation] > 42 | strncpy(mPos, "\": { ", 5); > | ~~~~~~~^~~~~~~~~~~~~~~~~~~ etc. Change-Id: Id96964b178b61879cf2373c5b418f5c9df4a226f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96593 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-06-18tdf#131353: Fix build with poppler 0.86.0Martin Whitaker1-1/+3
Change-Id: I89b4635a6a3e3a5522172d6f4c3f14e6c14994b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93789 Tested-by: René Engelhard <rene@debian.org> Tested-by: Jenkins Reviewed-by: Tomáš Chvátal <tchvatal@suse.com>
2020-06-18sd signature line: extract copyExternalResources() from the pdf export codeMiklos Vajna6-245/+368
Because I would like to reuse this in the "sign existing pdf" code, in vcl::filter::PDFDocument::WriteAppearanceObject(). Change-Id: Ia5e5c1e452bb0d0486bde2a082375b5131eea8c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96595 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-18Mark external/clucene/patches/c++20.patch as sent upstreamStephan Bergmann1-0/+2
Change-Id: Iaa3e251648afaa4bd3178dcff99594ce609083eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96591 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-18tdf#134035 sw: insert long date format for HungarianLászló Németh2-0/+25
in Writer using Insert->Field->Date or the similar toolbar function. Note: the previously used short date format YYYY-MM-DD is rare in Hungarian text documents, and it is no longer mentioned in the last Hungarian orthographic standard (But it's still default in Calc, as standardized by (MSZ) ISO 8601.) Change-Id: I09f2f3314356e84c73a42be9f06ceaa6769e7338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96112 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-18tdf#133589 Numbertext: fix Hung encoding on WindowsLászló Németh2-6/+21
Workaround to fix non-BMP Unicode characters in the case of Hung (Old Hungarian) module, resulted by std::wstring limitation on Windows. Change-Id: I4f6a72ad0e3d4f70ef7e35910bb4147aedb0e4ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96562 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-18delay and batch calls to StartListeningFormulaCells() (tdf#132165)Luboš Luňák2-0/+22
This is pretty much the same as tdf#133302. Change-Id: I5325b90601f503e572faefc455a38e0f5b055bbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96560 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-18new json writer for LOKNoel Grandin13-72/+442
we shave about 3 memory copies off in the process, and make the class play nicely with our string types. Change-Id: I1f614fb35b1de499ac99e3b33ac638ad81054bed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96393 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-18tdf#128964 Add time pause/resume button to Impress Presenter consoleSrijan Bhatia9-14/+286
Change-Id: I7263c3a8000b4d5930692cd2e32e84a22893dd66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95955 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-18tdf#133982 sw: fix Copy of document that starts with nested tableMichael Stahl1-1/+6
Started to assert with ef8427d12a63127a2eb867637699343d630545dd because a bookmark was created on the wrong node but this never worked. Change-Id: Ife01a3c8041b4c7d08b2d749dde77ced388f7215 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96556 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-18tdf#134009 sw: prevent spurious undos in SwColumnFrame::DestroyImpl()Michael Stahl1-0/+3
SwUndoFrameFormatDelete is created for every destroyed column frame. Change-Id: I11e0399487a41c52768175faf3a3699b302ad317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96558 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-18sw: handle TreatSingleColumnBreakAsPageBreak when replacing compat optionsMiklos Vajna1-1/+1
This was added in commit 93d7fc90b57bb08052299c94fa0a28bb8f494a9c (tdf#76349 writer: make 1column-as-page break a compatibility option, 2016-08-30), it's off by default and on for DOCX documents. Change-Id: I60f6d23feb278e8a234f5c571f9b647c2c08c491 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96561 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-18uitest: Add demo for Writer-commentsShiko1-0/+156
Change-Id: Iaf7c4c646a1f64f0a97c95fd7133da89da44c7d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96295 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-06-17Update git submodulesAlain Romedenne1-0/+0
* Update helpcontent2 from branch 'master' to c4c2ae468886b8a38465b9969d8293b677672481 - fix to deprecated API example cf. https://api.libreoffice.org/docs/idl/ref/interfacecom_1_1sun_1_1star_1_1ui_1_1dialogs_1_1XFilePicker.html#ae368e8b36ffdb8f8f7ba45d93556a60d Change-Id: Ie25dd20111eff943a729cc8c13ce2febd3368811 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96506 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-17Update git submodulesAlain Romedenne1-0/+0
* Update helpcontent2 from branch 'master' to fcf75206c5f8f59ac464dc3b9b9ca869ce3a7bd5 - Basic compiler/runtime options aggregation - Base - Explicit - ClassModule - Compatible - Private Module - VBASupport Change-Id: If5edfe93a744d847bc387d868cbb26292b60ea0a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96493 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-17ignore positions on top of scrollbars for GetTargetAtPointCaolán McNamara3-1/+27
Change-Id: I6d63ac3723b392e7c82836ea5d4455ebde8a8e08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96553 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17translate child co-ords to parent spaceCaolán McNamara1-3/+30
Change-Id: I108187203d284726a9d63712666ddb029525a993 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96552 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17avoid gtk_tree_view_get_dest_row_at_pos: assertion 'drag_x >= 0'Caolán McNamara1-0/+6
Change-Id: I24328c14a666dc580d189ad9475c967ba43cf399 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96551 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17don't highlight the row under the searched for pointCaolán McNamara1-1/+1
Change-Id: I6f3bfdb25c335735a70bc78c5167e88d5dbb4ddb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96550 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17uitest: Add support for Writer commentsShiko4-0/+110
Change-Id: I88ed2894c3665fb421c5d8ea0f278c54ccd0d0e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96230 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-06-17It may also be OBJECTTYPE_DATA_CURVE for a trend lineMike Kaganski1-1/+2
Change-Id: I31760489e267855045e0b3e977240fb2373d8271 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96572 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-17external/clucene: Adapt to C++20 CWG2237Stephan Bergmann2-0/+12
...<http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#2237> "Can a template-id name a constructor?", as implemented by GCC 11 trunk since <https://gcc.gnu.org/git/?p=gcc.git;a=commit; h=4b38d56dbac6742b038551a36ec80200313123a1> "c++: C++20 DR 2237, disallow simple-template-id in cdtor." Change-Id: I507fc5bde20fdf09b4e31a3db8a7554a473f1a9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96549 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-17Adapt to C++20 CWG2237Stephan Bergmann2-2/+2
...<http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#2237> "Can a template-id name a constructor?", as implemented by GCC 11 trunk since <https://gcc.gnu.org/git/?p=gcc.git;a=commit; h=4b38d56dbac6742b038551a36ec80200313123a1> "c++: C++20 DR 2237, disallow simple-template-id in cdtor." Change-Id: I2113a3968549103e1b35fb17d7f12770ba0086d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96547 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-17sd signature line: separate alloc and write of xref entryMiklos Vajna1-10/+18
The problem is that we need an object ID for the appearance object early, but by the time we ask for that we don't yet know the offset of the object, as we typically have object dependencies we have to copy over first. Solve that by separating the ID allocation and the final object update (remembering its offset). Change-Id: I99a242028f6ef2fb907628b96121b6804b8395e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96548 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-17connectivity: fix mysql testMichael Stahl3-12/+25
* rename the gbuild target according to conventions * fix -Werror=unused-but-set-variable * disable assert in testMultipleResultsets() that fails presumably since commit 86c86719782243275b65f1f7f2cfdcc0e56c8cd4 * document how to set up mariadb for dummies like me in README Change-Id: I7f92b80fef90b47e69e4e9a7a02187882a4cab06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96537 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-17allow building as root inside a container without complaintCaolán McNamara1-1/+1
add a check for $container Change-Id: Ib6921c6d771622fb5f4acb82d10aa6fb34e1bbac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96538 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17sd signature line: implement non-empty geometry during pdf signMiklos Vajna2-8/+79
Parse the pdf output which contains just the signature line shape on a page, take the same from it and use it at both places where previously the position / size was just a stub. Change-Id: Ifb2e0ebf7b3514ee027701b9bf360a0c996cdc82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96540 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-17tdf#134063: sw: redesigned support for tab at zero positionVasily Melenchuk3-9/+19
Initial support for tab position at zero (d2e428d1) was not taking into account hack for tab positions below zero. So previous behavior is restored (search is started from 0) but we also taking into account potential tabs at zero position in SwLineInfo::GetTabStop() Change-Id: I8b315ab69f9a53ac15002a41a81e069ff832f692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96526 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-17tdf#134043 DOCX import: DropDown text field instead of ComboBox form controlSerge Krot7-42/+157
Change-Id: Ide9cedefde3b00fa0eeb37a6540e8d4a420b70c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96471 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-17tdf#76817 DOCX: fix round-tripped outline numberingLászló Németh3-2/+172
Fix automatic chapter numbering in DOCX documents created by Writer. Follow-up of commit de1b634a151c198584dc152676183f519c50a2da (tdf#76817: DOCX import: fix custom chapter numbering). Change-Id: I331b7dcf67efdf63b376122ec4da0a2e85bea761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96529 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-17mariadb: the "pvio_socket" plugin turns out to be importantMichael Stahl2-1/+5
... otherwise can't connect to a TCP socket. (regression from fe041bbc343ee08c6e901f63985d55a90da71c8b) Change-Id: I2a1f2968321aae108bfef67f602f06efcf3affd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96536 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-17tdf#43452 indicate when maximum password length has been reachedCaolán McNamara4-51/+209
Change-Id: I58ba5887d41a80aa0ef2be547351f2faeccfa3cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96533 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17tdf#133807 re-present search dialog after a short timeoutCaolán McNamara3-1/+25
Change-Id: Icc6016b3a9e3f25fd4c9e065e9f2d9570ad040c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96524 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17svx: Refactor GalleryTheme classAditya7-52/+74
Change-Id: I60ce3b5a9ca5a28e499015c3ac118d2f6a091f16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96527 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-17notebookbar: send uno items state updateSzymon Kłos2-1/+53
Change-Id: I56b9c64f11631bd28520b9294aef7d6db8da5733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93700 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96525 Tested-by: Jenkins
2020-06-17Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 7af288d0fa90e5e31c29014501f06f776a00366a - tdf#134032 Calling Calc function from basic Change-Id: I7c3c64e0df4d89b46e49afb869f3e2de0825a6e2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96485 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-17Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to 8eb924f68ccbee88e782c135a79c675b8927f73a - tdf#132643 Translate German section IDs Change-Id: I4c2908ad3af91c0196c33a7f454fcfea45ab6cf8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96463 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-17Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to be0cdbd01369daeef3e41c0870f9637bf84343a5 - tdf#132643 Translate German section IDs Change-Id: Iec1083a1da7f83f3d6eef38d1cc3bf055d373ce7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96461 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-17Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to 424385e099927a3b91b9499bf4910af317699dd1 - tdf#132643 Translate German section IDs Change-Id: Ifecc65a0c98d1146cd9b60bffd570034ca40c5df Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96462 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-17Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to de054848fdd963bad31e2d6d065cb570b365925b - tdf#132643 Translate German section IDs Change-Id: I803e4af4b49e4829af10b9da5612a873ecb0898b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96459 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-17Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to 0213f0c63b7ce0b8ed055bf81549b11ca7da54d1 - tdf#132643 Translate German section IDs Change-Id: Icb4bb1a3a41e6c851f356f8ebcaa42b83b33de90 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96460 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>