summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-07-09test: create unit tests for ConfigChris Sherlock4-0/+246
Change-Id: Iaf92f93e169cf7367e3b9fc521f237413a268493 Reviewed-on: https://gerrit.libreoffice.org/53893 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-09tdf117058 - Simplify calls to Menu::CheckItemKevin Dubrulle6-7/+7
Change pGearMenu->CheckItem( pGearMenu->GetItemId("gear_iconOnly") ) style to pGearMenu->CheckItem( "gear_iconOnly" ) style, where it is possible. Change-Id: I6ec77eac51be14a8e5d278bd3604cb65b3d1f006 Reviewed-on: https://gerrit.libreoffice.org/57172 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-09Fix typoTor Lillqvist1-1/+1
Change-Id: I73b808f7dc34f1bdd4b84086b79cf56541e5072c
2018-07-09tdf#100726: Improve readability of OUString/OString concatenationsUlkem Kasapoglu2-4/+2
Change-Id: Ie78ca074a2472a57fb32c43f8dee9cc4cf5614c7 Reviewed-on: https://gerrit.libreoffice.org/56945 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-07-09tdf#102619 writerfilter: first create style, then set FollowStyleJustin Luth2-5/+26
Styles were having FollowStyle set to themselves (Heading 1), not to a defined follow (Text body). The style was being created with a FollowStyle property that identified a style which had not yet been created. So svl code was warning "svl.items", "StyleSheet-Follow not found" This section of code should really be cleaned up, but that will happen in a separate commit. Change-Id: Iae79fac917f64cdaa14ca6568e7d903ec6dc60fa Reviewed-on: https://gerrit.libreoffice.org/57074 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-09uitest: test for ui elements children firstMarkus Mohrhard1-2/+9
Change-Id: I837721533bc40cea55cbccaa14e1f14686aa3e3a Reviewed-on: https://gerrit.libreoffice.org/57165 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-09fix compile_commands.json when generated with modern gccMarkus Mohrhard1-1/+1
Change-Id: I4a17cfb567f5ebec8bb416b9aa4d58763ff36c36
2018-07-09rename UI element to prevent duplicate IDs in same dialogMarkus Mohrhard2-3/+3
Small improvement for the UI testing. Change-Id: I49fa6a7566a492930532719271b6c83005bc85a8 Reviewed-on: https://gerrit.libreoffice.org/57163 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-09added Text transformation in data provider dlgManuj Vashist7-65/+261
Change-Id: I69d8aae9289ad6d1cbdf92307c16299a533fcd56 Reviewed-on: https://gerrit.libreoffice.org/56807 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-08Added XML data providerVikas Mahato7-0/+255
Change-Id: Ib5727912977eb79cdf1f84bf874919beafc693eb Reviewed-on: https://gerrit.libreoffice.org/56356 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-08Added number transformations for external dataVikas3-1/+467
- Round allows you to round the numbers in the column up to a given number of decimal places - Round Up rounds the numbers in the column up to the nearest whole number - Round Down rounds the numbers in the column down to the nearest whole number - Absolute Value returns the absolute value of the numbers in the column - Logarithm - Natural returns the natural logarithm - Base-10 returns the base-10 logarithm - Cube returns the cube of the numbers - Square returns the square of the numbers - Square Root returns the square root of the numbers - Is Even returns TRUE if the values in the column are eve - Is Odd returns TRUE if the values in the column are odd - Sign returns 1 if the values in the column are positive, -1 if they are negative, and 0 otherwise. Change-Id: I7458d0d61da3749fe497b3999449373234391b04 Reviewed-on: https://gerrit.libreoffice.org/56886 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-08tdf#118556 : Respect locale specific decimal separator...Dennis Francis3-2/+9
in Regression dialog box's confidence-level entry. Do not write floating-point numbers to cells as strings using OUString::number() converter if the cell is supposed to be a numeric one. This also amends the uitest document such that the "expected" confidence level cell is numeric and not string. Thanks to Julien Nabet <serval2412@yahoo.fr> for pointing me to the specific issue. Change-Id: I7d12674bf69fc53348366a03b7e6ff0af9588511 Reviewed-on: https://gerrit.libreoffice.org/57151 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
2018-07-08tdf#89893: Enable previous/next track changes in read-only modeXisco Fauli1-2/+2
Change-Id: Ie7dd41b2f79347e9b959a73d58888915379f2e2a Reviewed-on: https://gerrit.libreoffice.org/57100 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-07-08cppcheck: useInitializationList in settings.cxxJochen Nitschke1-165/+88
and remove some default-able constructors Change-Id: I3ff5cb9d68143bb13a362383255da98f7bf6bd86 Reviewed-on: https://gerrit.libreoffice.org/57135 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-08tdf#84323 - sal - add sane sleep interface: cleanup osl_waitThreadKevin Dubrulle13-76/+27
Replace osl_waitThread by osl::Thread::wait. Use std::chrono instead of TimeValue. Change-Id: I71691d014feeeb0c5d0ba29d048bda8e25e6e7dd Reviewed-on: https://gerrit.libreoffice.org/57130 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-08tdf#79878 perf loading docx file, sax improvementsNoel Grandin4-26/+48
these are the smaller improvements, they make about 5% worth of difference - use std::vector instead of std::deque - use std::move on pendingCharacters instead of copying - in FastAttributeList::add, when reallocate the buffer, allocate twice the existing size, instead of increasing to only what we need - in FastAttributeList, create getAttributeIndex and friends, so we can avoid iterating the attribute list more often than necessary Change-Id: I3e3380ea50b77c6845b66e83404e245778ec06eb Reviewed-on: https://gerrit.libreoffice.org/57021 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-08tdf#45904 Move _XSheetCellCursor Java tests to C++Jens Carl7-349/+195
Change-Id: I9d12f9a13d3e0c59b7a28ff91563878efde22b68 Reviewed-on: https://gerrit.libreoffice.org/45067 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-08Fix typoAndrea Gelmini14-21/+21
Change-Id: I1cc4544e807d7c04aa171358ccd1c204040dff55 Reviewed-on: https://gerrit.libreoffice.org/57078 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-08loplugin:passstuffbyrefNoel Grandin20-29/+31
Change-Id: I6e6c47020073ec183c6c8ff9cd026a0bec23b177 Reviewed-on: https://gerrit.libreoffice.org/57088 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-08uitest for bug tdf#117458Zdeněk Crhonek3-0/+165
Change-Id: Ie6316a3b10567d0a291281a2358d4edfc5ab761c Reviewed-on: https://gerrit.libreoffice.org/57107 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-08Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - Mute L10n for embedded specific string Change-Id: I208c5f5e8a7a65d19ce79055cd031f4c8d8921e8 Reviewed-on: https://gerrit.libreoffice.org/57068 Tested-by: Jenkins Reviewed-by: Sophia Schröder <sophia.schroeder@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-07-08KJ icons: ^ envelope, symbol, char style; + toolbar, sendfeedback & donationRizal Muttaqin55-0/+9
Change-Id: I5cfee18784a469b3aa025f9be16d429b04d05ef5 Reviewed-on: https://gerrit.libreoffice.org/57106 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-07-08Resolves: tdf#118561 handle external references as jump matrix resultEike Rathke1-1/+35
Change-Id: I0381179347960293f5d470ed231d626cb6707b5a Reviewed-on: https://gerrit.libreoffice.org/57144 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-07Use UNO ctors for extrusion and fontwork toolbar controlsMaxim Monastirsky7-286/+55
Change-Id: I075b1cbe648dfaf8bb7cee6d353cbdcf26c4465c Reviewed-on: https://gerrit.libreoffice.org/57143 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-07-07Use agile encryption with AES256 and SHA512 by defaultTomaž Vajngerl1-0/+1
Change-Id: I4dcf05a7018f8e15063a20512f4c0b673a62f1de Reviewed-on: https://gerrit.libreoffice.org/57141 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-07oox: Handle agile encryption info "reserved" field correctlyTomaž Vajngerl4-6/+13
The "reserved" filed is written fter the version number major, minor which is used to identify the encryption as agile. The "reserved" field must always have the value 0x00000040. This change writes the reserved filed correctly and when encryption and when decrypting it checks the value an potentially bails out if it desn't contain the expected value. Change-Id: I2045dc64e0c6bbb3318384e25deef2ba8f41b94c Reviewed-on: https://gerrit.libreoffice.org/57140 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-07Add LO standard encryption to the ooxml encryption testsTomaž Vajngerl2-4/+12
Change-Id: I199ed40d409dc4baf9102480eadffde9a7c26a78 Reviewed-on: https://gerrit.libreoffice.org/57139 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-07Drop TEST_FONTS_MISSING for HAVE_MORE_FONTSKhaled Hosny11-86/+14
TEST_FONTS_MISSING is just adding confusion since it tests for hardcoded font names, while what we really want (most of time) is to check whether bundled fonts are enabled or not, and HAVE_MORE_FONTS just does that. Change-Id: I1b00d359c37fa49584ca27c319d6d0e937c3b20b Reviewed-on: https://gerrit.libreoffice.org/57136 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-07-07tdf#101930: Allow page up/down and first/last page in read-only modeXisco Fauli1-4/+4
Change-Id: Iea7d7a234d9904cd31c2a2355297ad8438d82b17 Reviewed-on: https://gerrit.libreoffice.org/57077 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-07-07tdf#112721 sd ppt export: don't adjust first line of tableJustin Luth1-1/+1
Round-tripping ppt files with tables was causing the text content to slowly creep downward as space was being added on each save. No unit test. Something is wrong with saveAndReload for PPT. Plus, I don't know what property contains this padding, or whether it is a cell object or what that contains it. Change-Id: I8918718c4ae2c87856910717c3ca8af1cbd86a6e Reviewed-on: https://gerrit.libreoffice.org/56690 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-07tdf#95114 writerfilter: follow correctly converted stylenameJustin Luth2-1/+9
Using styleIdentifierD works *if* you do an bExtendedSearch. But since we already took the pains of ensuring that sStyleName is not empty, and ExtendedSearch is expensive, just use sStylename. (I don't know *why* we ensure that styleName exists, and this code was originally flakey enough that it might be a fake requirement...) This only affects the few styles which have a different "name" than their ID. The primary one affected is TextBody/Body Text. Change-Id: I77f143760c10be4b7853f16bce2b57474b70d3f1 Reviewed-on: https://gerrit.libreoffice.org/57073 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-07use std::unique_ptr fo CreateObjectSpecificPropertiesNoel Grandin40-65/+67
Change-Id: Ica82eca48719f12535757c81e95d788fe0aaa48e Reviewed-on: https://gerrit.libreoffice.org/57110 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-07fix vecUnaccepted check in printf_packagesNoel Grandin1-0/+1
regression from commit 1b0beef8794210b2af49d8c4a00ca7d4e3ebedb7 Date: Tue Mar 6 22:36:02 2018 +0100 Use for-range loops in desktop (part2) Change-Id: I684462f4473eb57db589033795dd4f91d8897389 Reviewed-on: https://gerrit.libreoffice.org/57109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-07uitest: complete wrapper for SpinField and SpinButtonSaurav Chirania2-2/+38
Change-Id: Ibd28b656792018087478a3c6fb5f5f7ac6686131 Reviewed-on: https://gerrit.libreoffice.org/56813 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-07tdf#118554 sc crash clicking outside of commentsNoel Grandin3-20/+29
regression from commit c7f762973d21118ce3f5b0baab8850dc89bc4765 loplugin:useuniqueptr in ScTabView Change-Id: If7fd580f1a2fedbc6b707f59f196cbceffc95fe3 Reviewed-on: https://gerrit.libreoffice.org/57090 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-07Fix typosAndrea Gelmini5-6/+6
Change-Id: I02edac50950327ca81acbb25ef1830f8e9130984 Reviewed-on: https://gerrit.libreoffice.org/56943 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-07Fix typoAndrea Gelmini1-1/+1
Change-Id: I5c364f44ca86f536b490313f0cce88c6823d0abd Reviewed-on: https://gerrit.libreoffice.org/56965 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-07Fix typosAndrea Gelmini4-4/+4
Change-Id: Ifc035f58ddc958bf7445a81a7fc0cb8f122061a3 Reviewed-on: https://gerrit.libreoffice.org/56316 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-07Removed executable permission on odt fileAndrea Gelmini1-0/+0
Change-Id: I4d67c8b06aeb7ef14471b1d881f985484eab9af0 Reviewed-on: https://gerrit.libreoffice.org/57079 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-07Colibre icons: fix calc home tab (tabbedbar) with missing iconsandreas kainz2-0/+0
Change-Id: Ifb2ff58a82895a55e7e7f3052bf7ac25a4cc50b7 Reviewed-on: https://gerrit.libreoffice.org/57094 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-07tdf#115890 sw: fix invalid cast in SwContentTree::GetEntryAltText()Michael Stahl1-1/+1
AccessibleListBoxEntry calls this for any entry. This was always broken but now we have asserts to tell us about it. Change-Id: I7094a1dfbffd359e0f536ca60cba2478e2a62464 Reviewed-on: https://gerrit.libreoffice.org/57086 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2018-07-06WaE: -Wunused-variableThorsten Behrens5-3/+10
Change-Id: I58f012ddc2c5030b0e3e215b9cab4e89abf06c2b Reviewed-on: https://gerrit.libreoffice.org/57066 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-06sw HTML export: avoid writing <font> in XHTML modeMiklos Vajna5-8/+31
First, it should be <$prefix:font>, not <font>, but then XHTML prefers CSS for font color. Change-Id: I947c0b93a117c8e88e4aec91c3c7f843bd943c59 Reviewed-on: https://gerrit.libreoffice.org/57085 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-06tdf#117261 xmloff: ODF import: convert form:connection-resource URLMichael Stahl1-1/+1
... to absolute on import. (regression from fbb3b60cdb7a22595eec80232bb3ccd83781cf00) Change-Id: I2cd046e44489da86d3d67ff5df6cbad13e8265d0 Reviewed-on: https://gerrit.libreoffice.org/57076 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2018-07-06tdf#118254 Do not rely on XStatusIndicator for SVG importArmin Le Grand1-4/+2
For SVGs loaded as Document and status 'hidden' is used, there is no xStatusIndicator handed over to the SVGFilter. Compared with old filter - there it was used setting it somewhere else, but not required. Remove code that it requires it. Change-Id: I9fbf2b4ea02d8c5aae234f78f96b4acd37b7341b Reviewed-on: https://gerrit.libreoffice.org/57062 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-06uitest logger: log the events calling CallEventListeners()Saurav Chirania4-2/+30
Some events directly call CallEventListeners() instead of calling ImplCallEventListenersAndHandler. This patch thus moves logAction to CallEventListeners() Further, this patch adds logging for EditSelectionChanged which is broadcasted using CallEventListeners(). Change-Id: Ib15367688cdbcdb542f6139d270d8d463f214fde Reviewed-on: https://gerrit.libreoffice.org/56952 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-06uitest interpreter: support opening existing documentSaurav Chirania1-0/+9
In addition, I have imported the mkPropertyValues function which seems to be necessary in almost all test files. Change-Id: Iee44651aaa05fc2ef5da1d7e0f9281f76819d3e4 Reviewed-on: https://gerrit.libreoffice.org/56850 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-06uitest interpreter: handle when parent is empty stringSaurav Chirania1-1/+3
Change-Id: I439e2679ce46872f34e095b7f05fa19d404d2c00 Reviewed-on: https://gerrit.libreoffice.org/56887 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-06Handle protection lock mark in Undo/Redo, tdf#68290 follow-upEike Rathke1-0/+2
Change-Id: Ic88cb375f9f6030c9268fca84de7a5434bb82dc1 Reviewed-on: https://gerrit.libreoffice.org/57063 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-06oox: Agile encryption and data integrity verificationTomaž Vajngerl9-96/+885
This adds agile encryption for OOXML documents. Previously we always used the standard encryption used in MSO 2007 for max. compatibility, but new MSO versions (2010+) use the agile encryption, which allows more strong encryption methods (AES256 with SHA512). With this change we can now use do AES128 with SHA1 or AES256 with SHA512 encryption. In addition the agile encryption has data verification with HMAC hashing. With this change we also now write the data verification hash into the encrypted document and in addition also do data verification when opening / decrypting a document, so to make sure the document is not corrupted. Change-Id: Ib45d397df228c355941eefb76d51e5d6f8925470 Reviewed-on: https://gerrit.libreoffice.org/56974 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>