summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-09-14clang-tidy modernize-use-emplace in swNoel Grandin59-168/+165
Change-Id: I92fd035824f247dc61edfb18c54b960a7733fdf7 Reviewed-on: https://gerrit.libreoffice.org/42244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-14convert ScAttrArray to use std::vectorNoel Grandin11-387/+353
instead of re-implementing it ourselves. Which lead to some changes in Xf::AttrList since the import process wants to donate it's array to ScAttrArray. Change-Id: I176148131fb5f163e25691ad690f63398ba1a556 Reviewed-on: https://gerrit.libreoffice.org/42205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-14lokit: make parts of unstable API public for 6.0Thorsten Behrens3-19/+36
[API CHANGE] publish all of LibreOfficeKitClass, and the getDocumentType callback for the LibreOfficeKitDocumentClass Change-Id: I4d6529a71b29a0014053b797c67255df53a6ccde Reviewed-on: https://gerrit.libreoffice.org/42243 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-13Fix typoAndrea Gelmini1-1/+1
Change-Id: I5924efc90aa59ec948075bbe364858e1e1740ec6 Reviewed-on: https://gerrit.libreoffice.org/42255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-13simplify configure for android that started to bitrot a littleChristian Lohmaier2-154/+50
aarch64 (and mips) for that matter were not updated to adjust for clang As clang now is default and only toolchain, also got rid of some now unnecessary conditionals/variables. additionally group the target-dependent vars in one block instead of spreading them around in the file Change-Id: Ie7fa19d14bf9fc7c05a9bea5345309f42f414db7 Reviewed-on: https://gerrit.libreoffice.org/42252 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-09-13onlineupdate: work around GCC7 -Werror=implicit-fallthroughMichael Stahl2-1/+2
This is pretty stupid, but oh well... Change-Id: I1e605b2858a917f61922df757809a2aceb14a914
2017-09-13upload libwpg 0.3.2David Tardon1-3/+3
Change-Id: Ib4362dc0b520fbb764fdc4b0c6b1e8887a3c0c53 Reviewed-on: https://gerrit.libreoffice.org/42236 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-09-13jpeg-turbo: upgrade to release 1.5.2Michael Stahl4-98/+2
* jpeg-turbo.limits.patch.1, jpeg-turbo.arm_build.patch.1: drop these, merged upstream Change-Id: I755c0216af8ebe93ae9ba5e227fb880c572169c4 Reviewed-on: https://gerrit.libreoffice.org/42248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-13tdf#107267: Fix grand total calculationJean-Sebastien Bevilacqua2-56/+99
To fix the grand total calculation, we add another step. This step loop through all row to find the min and max of each value. These min and max are then used by the grand total. Patch by Linagora Change-Id: If3200840764d0ad9cb63231ac9f67b5d5ed197f1 Reviewed-on: https://gerrit.libreoffice.org/42042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-13tdf#109096 Allow 0 as argument value(s) to GEOMEAN()Winfried Donkers2-9/+124
Both ODFF1.2 and the mathematical definition allow 0 as value(s). Excel does not allow 0 as argument value(s), but IMHO this is to be regarded as an aberration of Excel. Also added tests for no arguments or negative arguments, which is not allowed by ODFF1.2. Change-Id: I330206b6e817e0ec092fe19f713b044578da41d1 Reviewed-on: https://gerrit.libreoffice.org/42107 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-13Silence -Werror,-Wunreachable-codeStephan Bergmann1-3/+3
Change-Id: I87faa8501b14a770194979cd1c575ed05b162e48
2017-09-13Removed quotation marks that destroyed some strings for Pootle exportMatthias Seidel1-3/+3
(cherry picked from commit 4e2b0c14b49d5e74a2c7493ed4bcc1f8080efdb3) Change-Id: I3d5e003a313228188119ee439c858c1ee505c9b0
2017-09-13svx: Simplify SdrHelpLineList with std::unique_ptrTakeshi Abe2-19/+12
This also kills no longer used SdrHelpLineList::GetObject(). Change-Id: I6e08e44214657c536717e96693c89104d7118cfd Reviewed-on: https://gerrit.libreoffice.org/42234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-13EPUB export: add options dialogMiklos Vajna8-3/+383
It just exposes the two options available at libepubgen level already. Change-Id: I428919ffe495b6d7ec2773f542e2fea6733d0a1c Reviewed-on: https://gerrit.libreoffice.org/42241 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-13no need to call GetNumerator() / GetDenominator() for FractionNoel Grandin18-75/+47
simplify the calculations - why have a Fraction and then just split it up for the calculation? Change-Id: I81af95e1ee1633f77e088c0990f308b1c169a6a2 Reviewed-on: https://gerrit.libreoffice.org/42242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13Fraction: make conversion operators and constructor explicitNoel Grandin34-151/+151
and simplify some of the calculations that needed to be changed. Which resulted in one unit test needing to change by one pixel, let's hope not an indication of a real problem. Change-Id: Ie56434f35f4e58d21ee6f671392e93dc7542fca3 Reviewed-on: https://gerrit.libreoffice.org/42240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13clang-tidy modernize-use-emplace in slideshowNoel Grandin13-42/+34
Change-Id: Ice6ab0dcd6785a751be5a66b262690640e0a2780 Reviewed-on: https://gerrit.libreoffice.org/42239 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13Blind macOS -Werror,-Wunreachable-code fixStephan Bergmann1-7/+3
Change-Id: Ice41b6394bc4fc8e4b1d7b9c5689019361883b59
2017-09-13add missing context to translatable strings in ui filesChristian Lohmaier2-2/+2
the context is requires to create translation templates (pot files, using "make translate") to guarantee uniqueness of strings Change-Id: Ie3df130f69c72ad468839235769f55286f4f3e48
2017-09-13having context in strings is not enough, it should also be ~uniqueChristian Lohmaier1-8/+8
using the same context as in datastreams.ui causes duplicate (identical) strings in pot files, and some translation tools stumble over those see also tdf#109258 Change-Id: I88b083f56a45123a6cf7521ceaaefa89f77e0477
2017-09-13icu: do not include non-standardized xlocale.h if U_PLATFORM_IS_LINUX_BASEDEike Rathke2-0/+15
... should be more platforms ... but be conservative. U_PLATFORM_IMPLEMENTS_POSIX does not hold what it promises. "The file and this data structure is not standardized. Don't rely on it. It can go away without warning." ... And since glibc 2.26 it's gone. https://ssl.icu-project.org/trac/ticket/13329 Change-Id: I4c1f6130571f5d094cb35ce70e4d333763cee32a
2017-09-13New rtl::isUnicodeScalarValue, rtl::isSurrogateStephan Bergmann9-19/+40
There are apparently various places that want to check for a Unicode scalar value rather than for a Unicode code point. Changed those uses of rtl::isUnicodeCodePoint where that was obvious. (For changing svtools/source/svrtf/svparser.cxx see 8e0fb74dc01927b60d8b868548ef8fe1d7a80ce3 "Revert 'svtools: HTML import: don't put lone surrogates in OUString'".) Other uses of rtl::isUnicodeCodePoint might also want to use rtl::isUnicodeScalarValue instead. As a side effect, this change also introduces rtl::isSurrogate, which is useful in a few places as well. Change-Id: I9245f4f98b83877145a4d392f0ddb7c5d824a535
2017-09-13Clamp minor/patchlevel when computing CLANG_VERSIONStephan Bergmann1-1/+2
...so it doesn't overflow for odd version numbers like <https://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER &full-log=1505293801.994#53>'s 'clang --version' reportedly returning "Android clang version 5.0.300080 (based on LLVM 5.0.300080) […]" Change-Id: I7e3b3e0fa93d48fbbfa7a9b71e91776f976ed0da
2017-09-13tdf#112133: Drop the Add and Remove labelsMuhammet Kara3-33/+28
and ensure consistent height of the controls in the first row of the Customize dialog. Change-Id: I6c2d75b647cad7a2ead8c875afc4fd38a182eef0 Reviewed-on: https://gerrit.libreoffice.org/42233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-09-13drop first/last link callbackCaolán McNamara4-32/+2
of course this stuff is exposed through uno through com::sun::star::awt::XSpinListener so VclEventId::SpinfieldFirst and VclEventId::SpinfieldLast have to be retained Change-Id: Icbf31cc8c62f2bc3bc0ccf966c0fd4f5c43dcf6b Reviewed-on: https://gerrit.libreoffice.org/42231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-13clang-tidy modernize-use-emplace in svxNoel Grandin23-382/+381
Change-Id: I52f062bf0b4c1af44576546d0593699758d71084 Reviewed-on: https://gerrit.libreoffice.org/42232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13This return value is unused nowTamás Zolnai2-7/+5
Change-Id: I6145e9bd5736b5c48683d0a85d13ad02d66d5084 Reviewed-on: https://gerrit.libreoffice.org/42227 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-13Silence -Werror,-Wunreachable-code on AndroidStephan Bergmann1-2/+4
Change-Id: Ide7591b4012f23e8a3faa705537937efcac435a2
2017-09-13sax: allow some debug logging in FastParserMichael Stahl3-1/+9
Multi-threading makes this difficult; have it print synchronously where it is in the input when setting: SAL_LOG="+INFO.sax.fastparser+WARN" SAX_DISABLE_THREADS=1 Change-Id: I8c77974acb2b4d4e273fc9c0f273c345d8feb2ff
2017-09-13tdf#112311 oox: fix UAF of std::shared_ptrMichael Stahl4-22/+29
OOXMLFastContextHandlerShape::sendShape() deletes the parent context's ShapeTypeContext::mrTypeModel. It looks like the sendShape() can't be delayed because writerfilter wants to import the v:textbox content into a text frame. Keep the shape alive until the end of the containing context. Not sure if it's going to process the v:fill element properly, but at lest valgrind is happy. (probably regression from CWS writerfilter32bugfixes01) Change-Id: Ifeab84751a1b20b2f272c4dd74b7097deb5eece0
2017-09-13sax: improve READMEMichael Stahl1-1/+10
Change-Id: Ide71867ca1ad3ae43c18159585df6d0dafcbe586
2017-09-13clang-tidy modernize-use-emplace in sfx2Noel Grandin12-67/+48
Change-Id: I3d6b9dfa86c3637e5cb6fad81702c15d4c894e72 Reviewed-on: https://gerrit.libreoffice.org/42229 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13sw: prefix members of SwFormatFieldHintMiklos Vajna1-10/+10
Change-Id: I58b2f9680397e7df28a5fde4cb4c90364075b20b Reviewed-on: https://gerrit.libreoffice.org/42228 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-13Enable -Wunreachable-codeStephan Bergmann16-60/+90
...motivated by <https://gerrit.libreoffice.org/#/c/41565/2> adding dead code at the end of a switch statement, after the last case's "break". -Wunreachable-code appears to work well on Clang, while it appears to have no effect on GCC. Most of the affected places are apparently temporary/TODO/FIXME cases of disabling code via "if (false)", which can be written with an extra set of parentheses as "if ((false))" to silence -Wunreachable-code on Clang (which thus needed loplugin:unnecessaryparen to be adapted accordingly). In some cases, the controlling expression was more complex than just "false" and needed to be rewritten by taking it out of the if statement to silence Clang. One noteworthy case where the nature of the disabled code wasn't immediately apparent: Sep 12 16:59:58 <sberg> quikee, is that "if (false)" in ScExponentialSmoothingDialog::ApplyOutput (sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx) some work-in- progress or dead code? Sep 12 17:02:03 <quikee> sberg: WIP, but you can remove it Sep 12 17:04:47 <sberg> quikee, I'll wrap the false in an extra set of parentheses for now, to silence -Wunreachable-code (I wouldn't want to remove it, as I have no idea whether I should then also remove the "Initial value" comment preceding it) Sep 12 17:07:29 <quikee> sberg: both are different ways to calculate the "intital value"... so no Another case where the nature of the dead code, following while (true) loops without breaks, is unclear is sd/source/ui/remotecontrol/BluetoothServer.cxx, where I added TODO markers to the workarounds that silence the warnings for now. basic/source/sbx/sbxvalue.cxx had a variable of type double, of automatic storage duration, and without an initalizer at the top of a switch statement. Clang warning about it is arguably a false positive. Apart from that, this didn't find any cases of genuinely dead code in the existing code base. Change-Id: Ib00b822c8efec94278c048783d5997b8ba86a94c Reviewed-on: https://gerrit.libreoffice.org/42217 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-13Fix a locking bug in our Java ComponentBase class, where after the transitionDamjan Jovanovic1-2/+5
to disposed, the relevant variables (bDisposed and bInDispose) are written to outside a synchronized block. The equivalent C++ implementation in main/cppuhelper/source/implbase.cxx, method WeakComponentImplHelperBase::dispose(), already does this. Patch by: me (cherry picked from commit 2d382cef5450cf1593322184649257d3666cbbd8) Change-Id: I6c3e2ef78bc3c945245fe9fb7b6b713eb83710be Reviewed-on: https://gerrit.libreoffice.org/42189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-13listening to modify is sufficient to get all changesCaolán McNamara2-33/+7
Change-Id: I9dc7301bed990838ac5fbb3bb5394bae5171bc22
2017-09-13Silence warning C4701: potentially uninitialized local variableStephan Bergmann1-1/+1
Change-Id: Ia37347108f9fe7094f055a5c6f2ec9511c3aff1d
2017-09-13Actually no need to make GetASCWriter public.Jan Holesovsky2-2/+2
Change-Id: I6f0f18629c6a61b6a4c52c2b16cc7b45525a5259
2017-09-13Revert "Do not include non-standardized xlocale.h, include locale.h instead"Stephan Bergmann2-15/+0
This reverts commit 274b2aee3bf65f139292d08a46d86f90d5ac8acb, which breaks in external/icu on macOS, <https://ci.libreoffice.org/job/lo_tb_master_mac/20605/>: > digitlst.cpp:497:8: error: unknown type name 'locale_t' > static locale_t gCLocale = (locale_t)0; > ^
2017-09-13rename ScAttrEntry.nRow to nEndRowNoel Grandin8-131/+132
since it's the last row that the pattern applies to Change-Id: I80d6d5787768b1e98e958d7adc4c13c37c560ccd Reviewed-on: https://gerrit.libreoffice.org/42211 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-13tdf#112191: Unit test.Jan Holesovsky1-0/+63
This was the hard part of the fix :-) Change-Id: Iae335c9d41d9b3420472b5d02113e2b42ab825da Reviewed-on: https://gerrit.libreoffice.org/42203 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-09-13tdf#112191: Don't export bullets when only one paragraph is selected.Jan Holesovsky3-4/+6
Change-Id: Ibea54f857e78a850ea05643743884ae2157dae57 Reviewed-on: https://gerrit.libreoffice.org/42202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-09-13Revert "svtools: HTML import: don't put lone surrogates in OUString"Stephan Bergmann1-2/+1
This reverts commit fc670f637d4271246691904fd649358ce2e7be59, which is no longer needed after 08e78607ec6bc820c52ab3df1a5d3738e049b90d "Make reading UTF-8 strict". The bug doc fdo67610-1.doc (aka <https://bugs.documentfoundation.org/attachment.cgi?id=83417>) now opens fine without hitting the assert in OUString::toUtf8.
2017-09-13Make reading UTF-8 strictStephan Bergmann2-53/+352
Consider non-shortest forms, surrogates, and representations of values larger than 0x10FFFF (which can even cover five or six bytes, for historical reasons) as "invalid" (they used to be considered as "undefined" instead). This is in response to fc670f637d4271246691904fd649358ce2e7be59 "svtools: HTML import: don't put lone surrogates in OUString" (which can now be reverted again in a follow-up commit). My fear would have been that some places in the code rely on the original, relaxed handling, but at least 'make check' still succeeded for me. Change-Id: I017e6c04ed3c577c3694b417167f853987a1d1ce
2017-09-13Change assertion failure to SAL_WARNTor Lillqvist1-1/+1
I hit it multiple times and have no interest in figuring out why. Or time. Change-Id: I3f22c8b62fdcf987b760ac16bfe8a21a8870d33e Reviewed-on: https://gerrit.libreoffice.org/42212 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-09-13tdf#75539 ww8import: fix horizontalLine percentageJustin Luth3-1/+12
The formula previously divided by 1000, which was a common dxaGoal width from MSO2003 (based on round-trip testing). But for the bug document, that formuala didn't work. An "assert (false)" with "make check" indicates that only unit test n757118.doc contains a percentage-derived width, and that test also has dxaGoal == 1000. So, my pool of test documents is pretty small, but it seems logical that this is a better formula since it fixes an obviously bad example, and explains why it "worked before". Change-Id: I7bf666e88e7e59e06bbfa3c0961fa8eabbc80310 Reviewed-on: https://gerrit.libreoffice.org/41957 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2017-09-13Updated coreOlivier Hallot1-0/+0
Project: help 42fbc7890755b7f6322be2fc2c7bc934d3c07b1e TDF#97745 Add support custom search in helponline Added some language support for the helponline global search Each custom search engine of google has a unique token, which configuration is handled by CSE owner. The CSE attempt to seach in helponline in the page language. If a page is already indexed, it shows what it has. If not, pages indexed from the *.libreoffice.org domain and wiki.tdf.org are shown. The CSE prevents display of indexed pages of other suites. Change-Id: I133e1a7af867c2380ccb1f20c483af63337a58b9 Reviewed-on: https://gerrit.libreoffice.org/42218 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-13Do not include non-standardized xlocale.h, include locale.h insteadEike Rathke2-0/+15
"The file and this data structure is not standardized. Don't rely on it. It can go away without warning." ... And since glibc 2.26 it's gone. https://ssl.icu-project.org/trac/ticket/13329 Change-Id: Iaf595b9c1be4eaab4306acb2c63c5a13dcb7a4e3 Reviewed-on: https://gerrit.libreoffice.org/42219 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-13Use "en-US" as the default for XHP's xml-lang attribute.Jan Holesovsky2-7/+15
Change-Id: I765e1cc25ac79d2cebf54f7a247a200647c984da Reviewed-on: https://gerrit.libreoffice.org/32296 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-13Replace list by vector in TableFillingAndNavigationTools (sc)Julien Nabet1-2/+2
Change-Id: I6d9426c66b0952a3eac7d418a187ec4e3759eea6 Reviewed-on: https://gerrit.libreoffice.org/42221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-21 16:28:15 +0000