summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-12-23Make functions in rtl/character.hxx constexpr for internal useMike Kaganski2-34/+53
Allows to use them in compile-time initializers. Change-Id: Ifa4b8da5db6ad7b1d7c87cb2476f4c59abeb32d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108219 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-23Use char16_t string literalsStephan Bergmann10-29/+29
Change-Id: I0a8b577957ac1d4cad5fc1163f244012a8391a77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108216 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23Related tdf#139073: deal with "none" for border-width in odf2uof_spreadsheetJulien Nabet1-15/+50
Change-Id: I040aab5a1863b359cf343de45930127a80e28506 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108217 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-23Fix dubious OUStringLiteral with automatic storage durationStephan Bergmann2-2/+3
Change-Id: I0c80ce6efbbc950ce975e55663a5643ea8fb37f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108215 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23Use optional rest argument of OUString::startsWithStephan Bergmann1-3/+3
Change-Id: Id8f9e7464c2c35a1a5ffadbc4c9c5d1f0d780923 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108214 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23Use OUStringCharStephan Bergmann1-2/+1
Change-Id: I4780de855682d252bd12bcf8f0c0c7230098f3a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108213 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23elementary: restore deleted Macro Editor & Pivot Table iconsRizal Muttaqin4-0/+2
Change-Id: I2906674004223916152f3d8b893237410969036d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108226 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-23Drop RTLNAME obfuscating macroMike Kaganski2-308/+306
which only purpose is to make "git grep SbRtl_Foo" a kind of IQ test. Change-Id: I47cfc2ecd1cc4a5ecf2e348465554fa2caeaccf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108218 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-23Don't lock galleries build into DESKTOPJan-Marek Glogowski6-35/+45
And add the missing dependency of Executable_gengal on Package_svx_gengal, so the actual executable script is created in instdir_for_build for the cross-toolset. Change-Id: I98ea1d58273c871f0a3b804a93970eedfb7f8908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108108 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-12-23tdf#138160 Set minimal width of sidebar tabpage after UNO callIlhan Yesil1-3/+6
Call OpenThenToggleDeck in SidebarController instead SwitchToDeck to ensure the minimal width of the tabpage is considered and the width of the sidebar is set correctly. Change-Id: I27c21572b5c648b3ddbb4d908d40af686ac87a9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105758 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-12-22elementary: various icon updatesRizal Muttaqin168-78/+94
Change-Id: Ic8f2e9f87ae5bab7fbfca623f960604bb93fdc12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108208 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-22drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara3-1031/+935
for svtools Change-Id: Iea5d5996cfcd6fe2e356e6565b8366e0db7a0424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108199 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara2-1936/+1825
for vcl Change-Id: I8ed97064bb65b00fac3b024a88677b5abe71d4f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108201 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara1-236/+218
for xmlsecurity, this uses the standard margin-top of 6, removing the additional 6 used in this one dialog Change-Id: Iac729122cc6e28fb17db3866bc7d8759861d3344 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22state GtkAlignment is deprecated in lint-uiCaolán McNamara1-6/+2
Change-Id: I138d21ed6fdf4c07e77c3f096cdd7ac94c61c292 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108198 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22fix lint-ui syntax errorCaolán McNamara1-1/+1
Change-Id: I8c94c28363a358e4e1dfe34b827a084c4c0e7a90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22elementary: tdf#139048 update pencil element to be yellow (3rd patch)Rizal Muttaqin2-1/+1
Change-Id: If80b9d252933d0e52f296f132775a89f2ea73b56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108139 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-22loplugin:loopvartoosmallStephan Bergmann1-1/+1
Change-Id: Ia9ae40b6286801c7cbdab6856d57e0ddd37aba87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108161 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-22tdf#136578 sw BreakDashedLine: edit/delete PageAfterJustin Luth1-1/+48
When you click on the blue dashed line indicating a page break, that delete should remove both that page's break-before, and the previous paragraph's break-after. Also, edit should detect if a break comes from a PageAfter. Prior to this commit, multiple things were wrong: -the previous paragraph wasn't checked, so PageAfter breaks were not deleted. -edit looked at the wrong para if break was PageAfter. -the current paragraph's PageAfter was deleted - deleting the NEXT page break, and not THIS one. I hope only tables are the exception to the rule. It doesn't seem to matter which table pNd is set with the NONE'd break. In theory, I could edit the real GetBreakItem functions to add in that code, but that seems very dangerous at this low of a level. Prior commit d7dfae214384f37901b532618e4d3ef117bd0285 flattened this function and did other minor cleanup. Change-Id: I9944c25853ec206f9febb6ea9f4e34c13c770ebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108072 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-22left/top variable names don't match propertyCaolán McNamara1-2/+2
Change-Id: I3bca14652fba5a3aad9816417ac7f94b8651f3a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108160 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-12-22tdf#139120 tdf#139127 sw: fix empty redline related crashLászló Németh3-0/+156
and bad "$2" redline text in ChangesInMargin mode. Also in the default "changes-in-text" mode, Undo didn't remove this empty redline added for tdf#119571 in the case of associated redline ExtraData (i.e. joining paragraphs with different styles), see also commit 66b39ca79b36da8d5e151deab17a0fb7690eebe6 (tdf#131147 don't store redline ExtraData during Undo). Change-Id: I7faa7c3acd8f8a0312339087072453a15751dd81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108126 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-22oss-fuzz: tgafuzzer doesn't pass sanity checkCaolán McNamara1-2/+13
Step #5: #6 0x63cce7f in __cxa_throw (/tmp/not-out/tgafuzzer+0x63cce7f) Step #5: #7 0x4f13aa in SvStream::ReadUInt16(unsigned short&) (/tmp/not-out/tgafuzzer+0x4f13aa) Step #5: #8 0x1d8d9c5 in (anonymous namespace)::TGAReader::ImplReadHeader() (/tmp/not-out/tgafuzzer+0x1d8d9c5) Step #5: #9 0x1d8c9ca in (anonymous namespace)::TGAReader::ReadTGA(Graphic&) (/tmp/not-out/tgafuzzer+0x1d8c9ca) Step #5: #10 0x1d8c598 in itgGraphicImport (/tmp/not-out/tgafuzzer+0x1d8c598) Change-Id: I1b01435d07d5e553e2941b402d4820836a9dce15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22oss-fuzz: psdfuzzer doesn't pass sanity checkCaolán McNamara2-3/+13
Step #5: #6 0x63cce7f in __cxa_throw (/tmp/not-out/psdfuzzer+0x63cce7f) Step #5: #7 0x4f1af9 in SvStream::ReadUInt32(unsigned int&) (/tmp/not-out/psdfuzzer+0x4f1af9) Step #5: #8 0x1d9dfd6 in (anonymous namespace)::PSDReader::ImplReadHeader() (/tmp/not-out/psdfuzzer+0x1d9dfd6) Step #5: #9 0x1d9d1a6 in (anonymous namespace)::PSDReader::ReadPSD(Graphic&) (/tmp/not-out/psdfuzzer+0x1d9d1a6) Step #5: #10 0x1d9cd38 in ipdGraphicImport (/tmp/not-out/psdfuzzer+0x1d9cd38) Change-Id: I407e7a32dd8e2fffb508edf896b9ca4783b94c97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108157 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22sw: check for remaining stream size in the WW8Fib ctorMiklos Vajna1-1/+1
Commit 8c9a4ff511a3b1d84a7a6d08a1b153c07f164abb (throw exception in SvStream when reading past end of file, 2020-11-16) changed the "read past the end of the stream" behavior to throw, and this broke online.git's unit-password-protected test. Fix the problem by not attempting to read if we know the remaining size is too small, even if the stream is good. Change-Id: I62f1532fc87a14c9f1f5e681e3ad67e4d575e8a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108152 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-22oss-fuzz: epsfuzzer doesn't pass sanity checkCaolán McNamara1-172/+183
Step #5: #6 0x640b42f in __cxa_throw (/tmp/not-out/epsfuzzer+0x640b42f) Step #5: #7 0x5413d9 in SvStream::ReadUInt32(unsigned int&) (/tmp/not-out/epsfuzzer+0x5413d9) Step #5: #8 0x1dd29b1 in ipsGraphicImport (/tmp/not-out/epsfuzzer+0x1dd29b1) Change-Id: Ieab45edabd5f13d07359be558618ff65badfde2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22oss-fuzz: xlsfuzzer doesn't pass sanity checkCaolán McNamara1-26/+34
Step #5: #6 0xc1f57ef in __cxa_throw (/tmp/not-out/xlsfuzzer+0xc1f57ef) Step #5: #7 0x520a3ea in SvStream::ReadUInt16(unsigned short&) (/tmp/not-out/xlsfuzzer+0x520a3ea) Step #5: #8 0x7bae80 in XclImpStream::DetectBiffVersion(SvStream&) (/tmp/not-out/xlsfuzzer+0x7bae80) Step #5: #9 0x53bde9 in ScFormatFilterPluginImpl::ScImportExcel(SfxMedium&, ScDocument*, EXCIMPFORMAT) (/tmp/not-out/xlsfuzzer+0x53bde9) Change-Id: I5c6aee844c62967fb06142992fa67fbc0f3b3725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108155 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22oss-fuzz: pngfuzzer doesn't pass sanity checkCaolán McNamara1-5/+10
Step #5: #6 0x63cceaf in __cxa_throw (/tmp/not-out/pngfuzzer+0x63cceaf) Step #5: #7 0x4f1999 in SvStream::ReadUInt32(unsigned int&) (/tmp/not-out/pngfuzzer+0x4f1999) Step #5: #8 0x6a8cd7 in vcl::PNGReaderImpl::PNGReaderImpl(SvStream&) (/tmp/not-out/pngfuzzer+0x6a8cd7) Step #5: #9 0x6b545f in vcl::PNGReader::PNGReader(SvStream&) (/tmp/not-out/pngfuzzer+0x6b545f) Change-Id: Ibf062f8d7dfbbab7bf57be7d4e837c3a8934a40e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108154 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22oss-fuzz: mtpfuzzer doesn't pass sanity checkCaolán McNamara1-21/+29
Step #5: #6 0x6b5998f in __cxa_throw (/tmp/not-out/mtpfuzzer+0x6b5998f) Step #5: #7 0x21a5bfa in SvStream::ReadUInt16(unsigned short&) (/tmp/not-out/mtpfuzzer+0x21a5bfa) Step #5: #8 0x51f2ef in EQNOLEFILEHDR::Read(SvStream*) (/tmp/not-out/mtpfuzzer+0x51f2ef) Step #5: #9 0x51ef53 in MathType::Parse(SvStream*) (/tmp/not-out/mtpfuzzer+0x51ef53) Change-Id: I6ae5905930376f9424f5d2eb3660ae177c7dc6f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108153 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22oss-fuzz: xlsxfuzzer doesn't pass sanity checkCaolán McNamara2-3/+13
Step #5: #6 0xc1f47cf in __cxa_throw (/tmp/not-out/xlsxfuzzer+0xc1f47cf) Step #5: #7 0x4602309 in SvStream::ReadUInt32(unsigned int&) (/tmp/not-out/xlsxfuzzer+0x4602309) Step #5: #8 0x33d288f in ReadClsId(SvStream&, SvGUID&) (/tmp/not-out/xlsxfuzzer+0x33d288f) Step #5: #9 0x33d328d in StgHeader::Load(SvStream&) (/tmp/not-out/xlsxfuzzer+0x33d328d) Step #5: #10 0x33d3204 in StgHeader::Load(StgIo&) (/tmp/not-out/xlsxfuzzer+0x33d3204) Step #5: #11 0x33d5d8d in StgIo::Load() (/tmp/not-out/xlsxfuzzer+0x33d5d8d) Step #5: #12 0x33b2e01 in Storage::Init(bool) (/tmp/not-out/xlsxfuzzer+0x33b2e01) Step #5: #13 0x33b33c8 in Storage::Storage(SvStream&, bool) (/tmp/not-out/xlsxfuzzer+0x33b33c8) Step #5: #14 0x9b3d5b1 in OLESimpleStorage::OLESimpleStorage(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, Change-Id: Ibc03107373f5558f47894fffc34169218e4aff12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108151 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22oss-fuzz: bmpfuzzer doesn't pass sanity checkCaolán McNamara1-6/+13
Step #5: #6 0x63cceff in __cxa_throw (/tmp/not-out/bmpfuzzer+0x63cceff) Step #5: #7 0x4f121a in SvStream::ReadUInt16(unsigned short&) (/tmp/not-out/bmpfuzzer+0x4f121a) Step #5: #8 0x53919f in (anonymous namespace)::ImplReadDIBFileHeader(SvStream&, unsigned long&) (/tmp/not-out/bmpfuzzer+0x53919f) Step #5: #9 0x5375c7 in (anonymous namespace)::ImplReadDIB(Bitmap&, AlphaMask*, SvStream&, bool, bool, bool) (/tmp/not-out/bmpfuzzer+0x5375c7) Step #5: #10 0x537483 in ReadDIB(Bitmap&, SvStream&, bool, bool) (/tmp/not-out/bmpfuzzer+0x537483) Change-Id: I220f05ff92399dda6811df45bb9c2111e525d916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108150 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22oss-fuzz: qpwfuzzer doesn't pass sanity checkCaolán McNamara1-1/+10
Step #5: #6 0x9d06d2f in __cxa_throw (/tmp/not-out/qpwfuzzer+0x9d06d2f) Step #5: #7 0x476ab6a in SvStream::ReadUInt16(unsigned short&) (/tmp/not-out/qpwfuzzer+0x476ab6a) Step #5: #8 0x512b10 in ScQProReader::nextRecord() (/tmp/not-out/qpwfuzzer+0x512b10) Step #5: #9 0x513a7e in ScQProReader::parse(ScDocument&) (/tmp/not-out/qpwfuzzer+0x513a7e) Step #5: #10 0x514bdc in TestImportQPW (/tmp/not-out/qpwfuzzer+0x514bdc) Change-Id: I42ea56988bcb54a57979535108e5ed90225d1f68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108149 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22oss-fuzz: pcxfuzzer doesn't pass sanity checkCaolán McNamara2-1/+12
Step #5: #6 0x63cce7f in __cxa_throw (/tmp/not-out/pcxfuzzer+0x63cce7f) Step #5: #7 0x4f13aa in SvStream::ReadUInt16(unsigned short&) (/tmp/not-out/pcxfuzzer+0x4f13aa) Step #5: #8 0x1d86707 in (anonymous namespace)::PCXReader::ImplReadHeader() (/tmp/not-out/pcxfuzzer+0x1d86707) Step #5: #9 0x1d858b1 in (anonymous namespace)::PCXReader::ReadPCX(Graphic&) (/tmp/not-out/pcxfuzzer+0x1d858b1) Step #5: #10 0x1d85496 in ipxGraphicImport (/tmp/not-out/pcxfuzzer+0x1d85496) Step #5: #11 0x4e3ab5 in LLVMFuzzerTestOneInput (/tmp/not-out/pcxfuzzer+0x4e3ab5) Step #5: #12 0x30a5a86 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (/tmp/not-out/pcxfuzzer+0x30a5a86) Step #5: #13 0x30a3a31 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) (/tmp/not-out/pcxfuzzer+0x30a3a31) Step #5: #14 0x30a8666 in fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__1::vector<fuzzer::SizedFile, fuzzer::fuzzer_allocator<fuzzer::SizedFile> >&) (/tmp/not-out/pcxfuzzer+0x30a8666) Step #5: #15 0x30a92b5 in fuzzer::Fuzzer::Loop(std::__1::vector<fuzzer::SizedFile, fuzzer::fuzzer_allocator<fuzzer::SizedFile> >&) (/tmp/not-out/pcxfuzzer+0x30a92b5) Step #5: #16 0x306d4c7 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (/tmp/not-out/pcxfuzzer+0x306d4c7) Step #5: #17 0x305ea37 in main (/tmp/not-out/pcxfuzzer+0x305ea37) Change-Id: I4c70f8879c7fb1f9bcd1c857c5fcad9bcaf8d142 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108148 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22jsdialog: add the "expand" actionHenry Castro3-7/+22
to the tree list view control Change-Id: I69f1b06748053fdfe9164c52e889629e51f91409 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107914 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-22jsdialog: disable idle notifyHenry Castro5-1/+25
After testing on client side, when showing the Macro Selector Dialog its receive 5 times the same data. So add an option to not use the idle notifier instead it will use the event 'WindowShow'. Change-Id: Ib5657f3c823fc6e998581b99052aaf578d0913e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107893 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-22elementary: tdf#139048 update pencil element to be yellow (2nd patch)Rizal Muttaqin60-30/+31
Change-Id: Ida3e127b210fef39e0ef98f3d7e7dc4fa77a2c74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108138 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-22pdfium: replace 3 patches with backportsMiklos Vajna5-182/+375
So that vcl/ already uses the upstreamed API and the patches can be just dropped on the next pdfium upgrade. Change-Id: I58f6a4cca37677788d9a2e4e31c2e89d074ad5ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108140 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-22use precalculated members of GeoState..Noel11-14/+14
.. in a couple of places that seem to have been missed. Change-Id: I5e40b46614fe07cd8b47f7148e3e5ec130dd05b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108146 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-22That wasn't a reliable way to detect Apple JDKStephan Bergmann1-7/+0
The check had been introduced with 16c0807d75cfd9ecbca9c703ed0eadda80529aab "configure: reject Apple JDK", but with 7db048f62929a9d267b63db3a6ea2b58b47ec757 "Manually select JDK outside /Library/Java/JavaVirtualMachines on macOS" it works fine to configure --with-jdk-home= a (non-Apple) JDK installed outside /Library/Java/JavaVirtualMachines. If anybody thinks a check to reject Apple JDK would still be useful, and knows a reliable way to detect it, feel free to add back a fixed check. Change-Id: I18910d992e3d1fc6fd8fc4b9d522aec0cce3e652 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108144 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-22rename members of GeoStat classNoel18-96/+97
to make it obvious what they are used for. Change-Id: I8ed825ea0131faa969fa3fd69cd64d195ef61b6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108145 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-22more jumbo sheet workNoel Grandin12-30/+34
Change-Id: I67884a0c0b897d8d60f2cfaba644e01f90f7d164 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108123 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-22Fix typoAndrea Gelmini1-2/+2
Change-Id: Ia0240b8c601e75564109744bb068b7e156384429 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108121 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-22Use gtk_box_pack_start/gtk_grid_attach (vcl/gtk3gtkinst)Julien Nabet1-19/+13
Change-Id: I2b6552e9fcd896a2d9552f81e3b730c82ff3878f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108078 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22use small-button style to remove GtkLinkButton left marginCaolán McNamara1-0/+3
Change-Id: I21a2c97a2d60390f97f84b15a42e2f14edd6d59e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22drop deprecated 'rules-hint'Caolán McNamara8-12/+0
Change-Id: I8b41ca34d6b751a8086a4a1879a42520dcd9b6fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108116 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22replace deprecated xpad/ypadCaolán McNamara20-38/+7
drop entirely suspicious xpad/ypad which are probably accidental Change-Id: Ie80d93502359373e38cc61f63cd5bec962f5d193 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108115 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22remove deprecated (and unwanted) GtkEntry shadow-typeCaolán McNamara3-6/+0
Change-Id: I5f6efbb4c4e2f9e928a6359d32da4a62cd3556bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22replace margin-left with margin-start and margin-right with margin-endCaolán McNamara161-561/+575
Change-Id: Iee3cc8c22b393ca420d0ed68673c61fe7ef240ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108113 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22SotStorageStream does not need to extend SotObjectNoel1-1/+1
Change-Id: I7651d2f806334297fc3f1874fd2f4ba9cd224046 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-22elementary: tdf#139056 Update color to follow upstream's branding (2)Rizal Muttaqin158-77/+79
Change-Id: I5b54280005971ce0d590bfe66b399441db2d5292 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108110 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-22Update git submodulesOlivier R1-0/+0
* Update dictionaries from branch 'master' to c86e9c20e0bed193853cd4df7a9ec921acd9f07e - French dictionary update (v7.0) Change-Id: I1461d5bba34612eab2e9110cc8908950417df0aa Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/107652 Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>