summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-02-15tdf#122218: Hack to avoid blurry text with macOS SDK 10.15Stephan Bergmann3-0/+26
...by setting the LC_VERSION_MIN_MACOSX load command's sdk value to n/a in the soffice executable. See <https://bugs.documentfoundation.org/show_bug.cgi?id=122218#c167> for how this helps, even though I have no idea why it helps. (Adding that -platform_version linker option appears to generate warnings like > ld: warning: passed two min versions (10.13.0, 10.13) for platform macOS. Using 10.13. but which are probably harmless.) (cherry picked from commit 645fe53be0dc36535dba0ed684e21ca4cda80d70) Plus cherry-pick of follow-up b7fd89100d8653dc73955780358fe31d38b68ebf "tdf#122218: Baseline Xcode 9.3 ld presumably doesn't support -platform_version" (and resolving the merge conflict in desktop/Executable_soffice_bin.mk). cherry picked from libreoffice-6-4 <https://gerrit.libreoffice.org/c/core/+/88753> Conflicts: configure.ac Change-Id: I043498c7ff2d148d4a7e1e0e9d46241b638f2eba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88667 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88755 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14tdf#126700 allow replacing the default documentsJan-Marek Glogowski8-10/+44
Per default, a document opened by a user action will always open in a new frame. For tdf#83722, this behaviour was extended to documents created from templates. But this currently also affects the default factory templates, if these are replaced by a config setting with a real template, which was not intentional. So this patch introduces a new MediaDescriptor property, which allows to mark a document as replaceable and automatically sets it for factory default documents. If this property is set to true, a document just acts as a placeholder while it's unmodified. I.e. the next opened document from its frame will close and replace it. For this backport the documentation in MediaDescriptor.idl is dropped, so people won't rely on this as a feature before 7.0. Change-Id: I45ffa8709f7cdda949fac78f3b363f120f0c4a03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88257 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 61e1e0413296928d929f99c0f006c6cbbcf4ac40) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88537 (cherry picked from commit d6188f8c3803490f75fbd1931a0bd6f821c4d700) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88594
2020-02-14tdf#130325 Fix listbox used as dropdownSamuel Mehrbrodt4-4/+7
In this case, the listbox is not used as a static widget, also not as a combobox with dropdown. Instead the listbox is placed in a popup to choose values from. Need to handle this case similiar to the combobox dropdown (Cursor movement only travels through items, Return selects one item). Regression from 7de9417d5f65d35227c7f80f6d587c2a56bde4e0 Change-Id: Idadc3da5847e12e1408203b13ab59eb53fe14eea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88581 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit d92463c88a557eea7a439def39659b1409772583) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88504 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-12tdf#130440 only select first page if no other page is selectedXisco Fauli1-1/+1
Found while implementing the UItest. See https://gerrit.libreoffice.org/c/core/+/88437 it asserts on line 34 AssertionError: 2 != 1 as the first and second slides are selected Change-Id: I249dc0ac6faa55f0f15deedb848beabbc64aeed4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88439 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 7ed602a3b8c0ffe922b4f082cd4cdaa5a8f0d64c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88405 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-12tdf#130555: Prevent negative aSelection.Min()Stephan Bergmann1-2/+7
...which would violate the the preconditions of the later call to maText.remove. When BreakIteratorImpl::previousWord (i18npool/source/breakiterator/breakiteratorImpl.cxx) is called to e.g. move back over a single space at the start of the text, at least for an en-US locale it will fall through to the call to BreakIterator_Unicode::previousWord (i18npool/source/breakiterator/breakiterator_unicode.cxx) at the bottom of the function. That in turn calls icu::BreakIterator::preceding, which is documented (workdir/UnpackedTarball/icu/source/common/unicode/brkiter.h) to return icu::BreakIterator::DONE (i.e., -1, see workdir/UnpackedTarball/icu/source/common/unicode/brkiter.h) in that case, which causes BreakIterator_Unicode::previousWord to return a Boundary with startPos == endPos == -1. The documentation of UNO method css.i18n.XBreakIterator::previousWord (offapi/com/sun/star/i18n/XBreakIterator.idl) is silent about the expected return value in such a case. But lets assume that returning such a [-1..-1] Boundary is as intended, and locally address this case in Edit::ImplDelete, making aSelection start at the start of the text. Change-Id: I40e17ba602088e72aa6962cb41dd8e1cdf6e2561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88431 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit e8f26dc13b65b1a05d948d9c95110c86315e8f20) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88403 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-12tdf#130501: Fix off-by-one error in URIHelper::resolveIdnaHostStephan Bergmann2-4/+19
Change-Id: Ibc231308d0fc93085933ae7d80dc8c4b2699fe02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88204 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 4c0394461af4d6bcba059161113abffbb484efe8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88295 Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 289d2e5c86ffa99bc6a8c6c51f630d629afcd954) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88401 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-12related: tdf#106742 sw: DOCX import/export: fix default of table indentMichael Stahl4-4/+91
There's a compatibilityMode in word/settings.xml in DOCX files: https://docs.microsoft.com/en-us/openspecs/office_standards/ms-docx/90138c4d-eb18-4edc-aa6c-dfb799cb1d0d If a document doesn't contain compatibilityMode, then the default is 12, but the code for table indent import/export assumed that the default is 15, so loading an ODF document and exporting as DOCX results in wrong table indent when loaded in Word. (regression from 9a31d1c83e08600507689dc18f6f0973bc7e4389) Change-Id: I3ce32286473640e5b7e12b487aef5f123bfb8d12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88408 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit d978f5d40102a098f1faf1e98aa39ad122284299) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88393 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-11tdf#130262 ignore negative wrap distance values in doc prop importPatrick Jaap3-0/+16
Change-Id: I2c06b12c958dfde09adcc2ae4c59532ffde6b6fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88127 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 8cbd7f59bb99282c4bcb60639da1263c8eb3a5e3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88399 Reviewed-by: Patrick Jaap <patrick.jaap@tu-dresden.de>
2020-02-11Related: tdf#130161 invalid iterator used in BrowseMode::Subs caseCaolán McNamara1-1/+1
xTreeIter is invalid here before AddEntry, afterwards it will remain invalid unless it was passed in to AddEntry to be updated to the newly inserted location, and we need it to be valid in the BrowseMode::Subs case Change-Id: I4831b7713bdb67889604fd4f8a7cd1644fd81a10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88395 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-11Resolves: tdf#130548 click is sent to the other member of the groupCaolán McNamara1-0/+8
when toggling one the other gets a click signal, but its too early and the page size isn't set yet, making the dialog thing the margins won't fit in the page Change-Id: I5b51f2d91c69558d47f43b3f05eca3fd87a24125 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88387 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-11update creditsChristian Lohmaier1-1890/+2199
Change-Id: I21a49cb649ebdc6b8af50f0b92decb77887e721c (cherry picked from commit 52ee72a0e5ea6e590a98d3388e1cf12fa75583b6)
2020-02-11Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-6-3' to 190fb74b8e223d13f7e61c534689681227f133e2 - update translations for 6.3.5 rc2 and force-fix errors using pocheck Change-Id: I66432dde4e9887dd89c86ef5d2fdfbeab428614d
2020-02-11tdf#130440 only select first page fallback if seting to current page failedCaolán McNamara3-13/+12
Change-Id: Iee4f9cef9659837e9ce131e3bfc8da3e8d87bf84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88389 Tested-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-10tdf#130148 Gallery drop-down list in Impress B&N dialog shows only start...Onur Yilmaz1-6/+3
Change-Id: Ieb8d79d7b3d291ffb36a7daaee0716d4ed8c9a85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87972 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 5088e6d34b0ffba423f8633ee83673a9c1d40036) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88300 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10tdf#93389: keep encryption information for autorecovered MS formatsMike Kaganski5-6/+64
The autorecovery data is stored in ODF, regardless of the original document format. When restoring, type detection generates ODF data, which is stored in the media descriptor attached to document, even after real filter was restored (see AutoRecovery::implts_openDocs). If real filter is not ODF, then at the save time, it doesn't find necessary information in encryption data, and makes not encrypted package. This patch adds both MS binary data, and OOXML data, to existing ODF data for recovered password-protected documents (regardless of their real filter). TODO: only add required information to encryption data: pass real filter name to DocPasswordHelper::requestAndVerifyDocPassword from AutoRecovery::implts_openDocs. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86201 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit dd198398b6e5c84ab1255a90ef96e6445b66a64f) Conflicts: comphelper/source/misc/docpasswordhelper.cxx Change-Id: I4717f067ad3c40167312b99eefef5584a467bfed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88330 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-10tdf#129809 qt5: take a reference in case m_aContents is replacedMichael Weghorn1-1/+4
This takes over Caolán's solution for gtk3 from dbcdc5cd98df5756a96559e467cad95c629343ca ("tdf#129809 take a reference in case m_aContents is replaced") for the qt5 case as well, to prevent that the XTransferable is destroyed along with the Qt5MimeData object as new QMimeData are set in the clipboard, as follows: 1 Qt5Clipboard::setContents Qt5Clipboard.cxx 2 TransferableHelper::CopyToSelection transfer.cxx 3 TransferableHelper::CopyToSelection transfer.cxx 4 SwTransferable::CreateSelection swdtflvr.cxx 5 SwWrtShell::SttSelect select.cxx 6 SwWrtShell::SelectTextAttr move.cxx 7 SwTransferable::GetData swdtflvr.cxx 8 TransferableHelper::getTransferData2 transfer.cxx 9 TransferableHelper::getTransferData transfer.cxx 10 Qt5MimeData::retrieveData Qt5Transferable.cxx 11 QMimeDataPrivate::retrieveTypedData qvariant.h 12 QMimeData::data qmimedata.cpp 13 QInternalMimeData::renderDataHelper(QString const&, QMimeData const *) 14 ?? 15 ?? 16 ?? 17 QXcbConnection::handleXcbEvent(xcb_generic_event_t *) 18 QXcbConnection::processXcbEvents(QFlags<QEventLoop::ProcessEventsFlag>) 19 ?? 20 g_main_context_dispatch Change-Id: Ic712c901a31131efc596cac7f00f14bb6a7ce068 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88192 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 1d7b1a15059a77fde9afa14d0b9a508142bfc247) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88259 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-08crash in manage languages in basic ideCaolán McNamara1-0/+6
when there is more than one language, there needs to be two separate columns with a renderer each, not one column with two renderers Change-Id: Id4f2c9938fd3bd0aa3e006166df6081d57ef57df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88224 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-08tdf#129809 take a reference in case m_aContents is replacedCaolán McNamara1-1/+4
Change-Id: I36ae74b6b3424bd2f0b71bc54838ec39e504b6d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88180 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2020-02-07Resolves: tdf#130340 null deref when nothing selectedCaolán McNamara1-1/+1
Change-Id: Ie406006cbcca566ddd32fd86a7e88f0c754dd02e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88049 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-07fix "Use data for document properties" checkbuttonCaolán McNamara1-1/+1
regression since... commit 3a15c034be9f557f350d0ba1f3a842151066eaae Date: Tue Mar 12 09:59:35 2019 +0000 weld SvxGeneralTabPage Change-Id: I7c4624255f70c3f0c4ccd4b79ebae7750ed2bbe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88110 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-06tdf#130080 soffice.sh: Avoid exporting empty LC_ALLMichael Weghorn1-2/+6
The previous way of doing LO_SAVE_LC_ALL="$LC_ALL" LC_ALL=C export LC_ALL # ... (call some tools,...) LC_ALL="$LO_SAVE_LC_ALL" resulted in the LC_ALL environment variable explicity being set to an empty string in case it was not set at all previously. For some reason, an LC_ALL explicitly set to an empty string (other than an unset LC_ALL) makes the system ICU on various Linux distributions assume an "US-ASCII" encoding, even if the locale is otherwise configured to be a UTF-8 one. Since the corresponding detection from ICU is used in the KF5/Qt stack, that resulted in the Plasma-native file picker assuming an ASCII-encoding, and thus having problems with files containing non-ASCII characters. To avoid this, don't export LC_ALL if unset or set to an empty string. A big thanks to frinring on IRC #kde-devel for the analysis of why the Plasma-native file picker is affected by LC_ALL being set to an empty string! I could also reproduce that the following sample program run with 'LC_ALL=' on KDE Neon Developer edition printed "US-ASCII" when using the system ICU, while it printed "UTF-8" when using a self-built ICU as of current master (commit d6b88d49e3be7096baf3828776c2b482a8ed1780) instead, but did not further investigate why: #include <unicode/ucnv.h> #include <iostream> int main() { std::cout << ucnv_getDefaultName(); } Change-Id: Idee88f200b6edecdb2633ed6e6fa70b370ffcf0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88003 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins (cherry picked from commit 25649502e08a52087dea5e482d34a1d4150f0930) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88036 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-06tdf#129789 bitmap in comment lost on loadNoel Grandin1-1/+1
regression from commit b4a1b89cc84086dfd6f471d7f23fecf0ec8f3331 tdf#119650 slow saving spreadsheet with comments, part 2 Change-Id: I8f6aa6b784b50b80311a420bdff9195ba88f5cff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87968 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 174ba963e05c9dedd57c2027f8656fe1f17030c2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88043
2020-02-04tdf#129582 sw: fix copying of flys in header/footer in DOCX/RTF importMichael Stahl6-14/+26
The problem is that the exception for writerfilter in IsDestroyFrameAnchoredAtChar() and IsSelectFrameAnchoredAtPara() is wrong in the case when the header/footer content is copied via SwXText::copyText(); that is, previously the situation was that writerfilter relied on Delete not deleting such flys (for RemoveLastParagraph) but Copy copying them. (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5 and e75dd1fc992f168f24d66595265a978071cdd277) So restrict the writerfilter hack to delete; this causes a problem with ooxmlexport9 test testTdf100075: it has 2 flys anchored at the same paragraph; writerfilter will insert the content into the body and then convert to fly; when the 2nd one is converted it will copy the 1st fly and anchor it inside the 2nd fly but then unotext.cxx:1719 will reset its anchor to inside the body... Prevent this unwanted copy by relying on the new parameter bCopyText that was introduced in 04b2310aaa094794ceedaa1bb6ff1823a2d29d3e, but change things a bit so that the case that pass in the extra flag isn't the copyText() one that wants the *normal* selection semantics in writerfilter import, but the 2 known places that want the *exceptional* selection semantics in writerfilter import (hopefully there aren't more). This is not ideal and the various bool parameters to CopyRange() plus mbCopyIsMove plus mbIsRedlineMove should probably be consolidated into some flags enum passed to CopyRange(). Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87072 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 81ec0039b2085faab49380c7a56af0c562d4c9e4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87095 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 34bdbb98846115671dcc71e34f6f2900fb638154) The backport is limited to at-character flys because the at-para commit e75dd1fc992f168f24d66595265a978071cdd277 will not be backported to 6.3; lots of related conflicts were resolved. Change-Id: I638c7fa7ad0b4ec149aa6a1485e32f2c8e29ff5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87857 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-04DOCX import: fix lost objects anchored to an empty linked headerMiklos Vajna3-2/+18
This is really similar to commit 04b2310aaa094794ceedaa1bb6ff1823a2d29d3e (DOCX import: fix lost objects anchored to the single para of a linked header, 2020-01-10), except here the header is not just a single-paragraph one, but has no text portions. Update text-copy.docx to have a header which is not only a single paragraph, but also has no character content. This keeps testing the original case, but now also tests the more strict case (single paragraph -> single empty paragraph). Change-Id: I11bb062e77af1a83f717225ea5b4daef39e5a672 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86552 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit c12358166a9bd88fe10feabca45a6ad3f65dff8e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87123 Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 8d58d0ef72162bbfb92cd3a894387f57c62ee8ae) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87856 Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-02-04DOCX import: fix lost objects anchored to the single para of a linked headerMiklos Vajna24-40/+75
Regression from commit 08f13ab85b5c65b5dc8adfa15918fb3e426fcc3c (tdf#112202 writerfilter,sw: fix loss of headers, 2019-12-16), the problem is that on one hand, copyText() is meant to copy a complete XText (header, table cell, footnote, etc), OTOH the internal API use used only copies at-para anchored objects for complete text nodes, so a one-paragraph header will loose its anchored objects when a linked header is copied. Introduce a new "CopyText" flag that provides the expected copyText() behavior and use that when the copyText() UNO API is invoked, but leave the selection behavior unchanged. Perform the inclusive check in IsSelectFrameAnchoredAtPara(), opt in for that from SwXText::copyText(), the rest is just passing the flag around. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86529 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 04b2310aaa094794ceedaa1bb6ff1823a2d29d3e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87122 Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 8f84922be15d37cb54fa592e1445fa5ab2c37f15) Note: this backport doesn't fix anything and has lots of conflicts but is required for backporting a subsequent regression fix... Change-Id: Id727f7ca4f6121a7050340359716a52ecb4886f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87855 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-02-04Related: tdf#129933 assert on pasting over selection in editCaolán McNamara1-1/+5
when its selected right to left with cursor flashing at the start format->paragraph->area->color->pick, cursor into hex# edit, end to cursor at the end, shift + home to select all, right to left, ctrl+c, ctrl+v, assert Change-Id: I8e29108ddff94487c298bd5e6607b98f5f841afd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87886 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-03opengl slide transitions not working with glm >= GLM 0.9.9.0Caolán McNamara1-0/+1
tracked it down to... Removed default initialization, use GLM_FORCE_CTOR_INIT to restore the old behavior so adding in GLM_FORCE_CTOR_INIT to get them working again Change-Id: I1c6e7d8eb748fce40f0c518ff708708e5fb1e3d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87791 Tested-by: Jenkins Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-30tdf#129993 broken tables opening LWP fileNoel Grandin6-80/+80
regression from commit e2080e70fe8b085f18e868e46340454720fa94ca new compilerplugin returnbyref The parts that fix this specific bug are in lwprowlayout.cxx and lwprowlayout.cxx, but fix the other parts I messed up but not understanding the semantics of assigning to reference variables. Change-Id: I064cdd108c5b05da6092da0297dc7bcf487c7702 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87686 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 0b113d6ebbaf923e11ba576bed2691bb68e95ae6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87717 (cherry picked from commit 678e00d2251060b562f295a5fb3c0215b12c8042) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87728
2020-01-29sw_redlinehide: fix SwScriptInfo hidden textMichael Stahl1-0/+1
A missing update of nOffset in SwScriptInfo::InitScriptInfo(); it must be updated for every extent but it's not for the last one in a node. test case: ab cd Delete "bc", hide "d", but "a" disappears. (regression from 0e26d48ad7f18deac8447a306215f79d5c62be27) Change-Id: I99fb88409e184a61866f908722b4430a53914153 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87201 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 53cd5d1f50d3da4efe0938aa340f6a57a0b8501d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87247 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-29Resolves: tdf#130239 set an explicit parent for the message dialogCaolán McNamara1-1/+3
Change-Id: If6e4bdf674f1aaaaaa5ceaa7cda5715af1aa7ce6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87612 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-28tdf#130214: workaround invalid state resulting from error on importMike Kaganski3-0/+11
Obviously the real error is somewhere else, which results in tdf#126435, and produces unexpected state with missing text append context on stack. This is just a hack to avoid crash. Change-Id: I420ac3b74f5efb9688dc764ac2ad0dcc974ba0e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87595 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit eca00082c78fddf79f247057227404738be8806c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87635 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-01-28tdf#127112 repair "sticky" levels in Customize numbering style dialogSeth Chaiklin2-5/+27
Change-Id: Ifa841e7b63b28d6e0f84f5cd6b1800481b36425b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87646 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28bump product version to 6.3.6.0.0+Christian Lohmaier1-1/+1
Change-Id: I48cc8bd5c171e989fa952008aec3f21b7c9bd455
2020-01-28Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-6-3' to 1a20bc7121f96500463e181bbcead205b6e84254 - update translations for 6.3.5 rc1 and force-fix errors using pocheck Change-Id: I6e50ec78c3642b59d397c2b243639e8d159b22e5
2020-01-27Revert "tdf#118526 Reload Notebookbar if read mode has switched"Xisco Faulí1-1/+1
This reverts commit 69310348a6d65a49b406ec5ac2062ad5659bfcf4. Reason for revert: tdf#130187. tdf#130187 may give more problems than tdf#118526. Reverting it in libreoffice-6-3 before 6.3.5 is released Change-Id: I2b5ce4c54a92153454a1fe394e1757598616950e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87521 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-01-24Resolves: tdf#129158 freeze/thaw around bulk insertsCaolán McNamara1-3/+10
Change-Id: I0ba22cd262512b467abd383d2f932d2adf6ca1a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87259 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-24tdf#128782: Add UItestXisco Fauli2-0/+45
Change-Id: I389d05fa9b1e79af2c01abd920fb4454b96543fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87282 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit e13f74ba563e1c82a1de587818f6090077c6f30f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87332
2020-01-24tdf#129382: sw: assign names to shape object stylesVasily Melenchuk2-2/+2
Empty style names for drawing object will cause problems with udo/redo which right now refers style names instead of style pointers. Change-Id: If2266f1db04c624dbfdd716b5599d5f6cbb5371e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86520 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit db8fdf20fbbb22e0510f0500140bbf7a3b2642f7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87214 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87305 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-24tdf#128782: sw: assign name to draw objectVasily Melenchuk1-0/+4
SwXDrawPage is inserting frame styles without name. This is confusing undo/redo code which is operating styles by names. Change-Id: Ibcda01fbd3ec88e9cdbde446c3f18c7ad6b0cbc8 Reviewed-on: https://gerrit.libreoffice.org/83415 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit c2d689790c332ffd2f0d73de6aae53f26f0fbe53) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87206 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87304 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-23Fix build with poppler-0.83Martin Milata3-0/+15
Change-Id: I7a3684932b8f9c403a3368b42fa4d8039c67f1a9 Reviewed-on: https://gerrit.libreoffice.org/84384 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86905 Reviewed-by: Tomáš Chvátal <tchvatal@suse.com> Tested-by: Tomáš Chvátal <tchvatal@suse.com> (cherry picked from commit 035830400393e075fca364a444e04c40516730b2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87204 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-22tdf#129798: store SwWrtShell when it's availableMike Kaganski2-24/+35
GetActiveWrtShell may return nullptr when attaching a new component to current frame, e.g. destroying on print preview. OTOH SwWrtShell is passed to SwFieldDBPage::SetWrtShell on creation, so store it to own base class then. Possibly that would be enough, and we could remove all the checks in other methods - but I don't know the code well enough to be sure that SwFieldDlg::PageCreated and SwFieldEditDlg::CreatePage will always set SwWrtShell; to be on the safe side, I kept the checks where SwWrtShell is used, and stored it in those places if not yet stored. Regression after commit 39ba5e3bde93358af1b363da8f850bdc96806cfa. Change-Id: I21f3c8ef24764e98b1bc287db3c6485ce0b3ab48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86253 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 016c69c99e1ab26e6582ca8dea6fa1b4b9e5d109) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86406 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21Resolves: tdf#129396 Refresh shared formula group area listeners upon shiftingEike Rathke1-1/+11
Regression from commit 47230a036fe35b9a7a7c0609232849fcbb51efcc CommitDate: Thu Feb 5 11:52:51 2015 +0100 Resolves: tdf#88792 do not hold a ScFormulaCell** in group area listener where previously the listener position's column was taken from the group's remembered top formula cell (then updated) position, which holding the cell was wrong in other cases. Change-Id: Ida1503daa7cbda2b41459ff5d63652a6febd91e0 Reviewed-on: https://gerrit.libreoffice.org/85347 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 491e8f60bf7f216a3bb3092b22334924b6c9aee1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85353 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-01-21tdf#129412: Crash when registered data source is not availableJulien Nabet1-0/+2
See bt here: https://bugs.documentfoundation.org/show_bug.cgi?id=129412#c4 Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=9009663deb8f0862f419fd99bf0b761c7f923eff author Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> 2017-02-26 22:48:06 +0100 committer Tomaž Vajngerl <quikee@gmail.com> 2017-04-04 13:39:29 +0000 commit 9009663deb8f0862f419fd99bf0b761c7f923eff (patch) tree ea25976de0919f9d2161037d83be0eace4c1070b parent 1931b5b01c6fdaa204d26ec4b9675dad16373cf2 (diff) tdf#83257 [API-CHANGE] Pivot chart implementation Change-Id: Ib4de665f6e5380baf51589c92473ad88e8c9b84e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87096 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Signed-off-by: xisco <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87125
2020-01-21Resolves: tdf#130093 some lwp file not loadingCaolán McNamara5-7/+1
Change-Id: I2be53792f0fadcf1ca0e99c8f9fab7305d0fcddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87102 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-20tdf#129839: pass initialized shared_ptr to SwDoc::GetBoxAttrMike Kaganski2-1/+26
Regression after commit 1e2682235cded9a7cd90e55f0bfc60a1285e9a46 Change-Id: I40acc9e0ffdd292283381366a31eb6647b80324f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86291 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 4056b70e6339102374898fff26f099da455475b1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86329 Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit ed7dc32834e11c93eaf21de8424d9d46c7fa0d53) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86964
2020-01-20tdf#129173 tdf#129175 Fix number format of data labelsBalazs Varga9-48/+33
Show the real value (cell value) of datapoints instead of the recalculated value in case of Percent Stacked Area chart. Also fix: tdf#95425 Do not reset number format of data labels when open dialog of 'Format data series' and close dialog. Note: Inherits the data series/point label format from the cell format and not the axis format, if we set the 'link to source data' option to true. Change-Id: I04e9968034a67c6bc6b92941df61d945b4292d79 Reviewed-on: https://gerrit.libreoffice.org/84819 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit e57d90cd4e51a1353eafc87bb29cfe6076704a7c) Reviewed-on: https://gerrit.libreoffice.org/85198 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 9c1063ba13028244346528e307d5563d6faf949d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85276 Reviewed-by: Balazs Varga <balazs.varga991@gmail.com>
2020-01-19tdf#128996 Chart: Fix disappeared vertical X axis labelsBalazs Varga5-11/+26
Regression from commit: 75ef0e41ea8a9096ac619356d2b837c5333b47e6 (tdf#125334 Chart: allow text break in bar chart axis labels) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86010 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit d53de6b0bfff08dfbde4fe305e2a9b7a60255458) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86259 Reviewed-by: Balazs Varga <balazs.varga991@gmail.com> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Change-Id: Ib935de74314b7dec489d94a4aa3c65072e18d9e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86355 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga991@gmail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-18gallery theme dialog should be modalCaolán McNamara1-0/+1
Change-Id: I3c32851cda40254c73b0040f92466eedb7427d6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87029 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2020-01-18tdf#127619: external/nss: Load smime3 lib with a path on macOSStephan Bergmann2-0/+26
A plain dlopen("libsmime3.dylib",...) would search (among other places) DYLD_FALLBACK_LIBRARY_PATH, which when unset defaults to a set of paths including /usr/local/lib (so would erroneously find Homebrew's /usr/local/lib/libsmime3.dylib instead of LO's LibreOffice.app/Contents/Frameworks/libsmime3.dylib next to the calling LibreOffice.app/Contents/Frameworks/libnspr4.dylib). At least macOS 10.15.2 supports a "@loader_path/" prefix in dlopen, to find the requested library next to the calling code, so use that as a quick fix. (Should that turn out to be problematic, there is PORT_LoadLibraryFromOrigin in workdir/UnpackedTarball/nss/nss/lib/util/secload.c that might be useful in a more elaborate fix.) Change-Id: I8688606017a4b32a2dd55740f67b8fdb36fc5435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86966 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit a3ca9b88b4b38c008efa868844ba7a3105b4bcca) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86971 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-17tdf#129680 Make text edit outliner view show cursorJim Raykowski1-6/+6
Better placement of tdf#50530 fix 80f18e7e028e9ca431aef281ab98bea99ad19fa3 Change-Id: If6a83d94ebd52ada34d800f8270fa82b4260fdbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86099 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 1840ed1ede481d28c1a75e2767357866f6f1c55a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86957 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-07 09:52:48 +0000