summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2015-09-21cppcheck: noExplicitConstructorCaolán McNamara17-43/+46
Change-Id: I53f9965609c04fd2f0b955fd04de8fc953917344
2015-09-21cppcheck: redundantPointerOpCaolán McNamara1-1/+1
Change-Id: I19f02169a113b8c9bae634691e28cf9f9d6977b5
2015-09-21tdf#94275: core dump when XKeysymToString returns NULLJulien Nabet1-4/+9
0 strlen () at ../sysdeps/x86_64/strlen.S:106 1 0x00007fffdfd69083 in SalDisplay::GetKeyNameFromKeySym (this=this@entry=0x1121b30, nKeySym=<optimised out>) at /build/libreoffice-Ke3JzN/libreoffice-5.0.1~rc2/vcl/unx/generic/app/saldisp.cxx:744 2 0x00007fffdfd696f5 in SalDisplay::GetKeyName (this=0x1121b30, nKeyCode=nKeyCode@entry=9476) at /build/libreoffice-Ke3JzN/libreoffice-5.0.1~rc2/vcl/unx/generic/app/saldisp.cxx:798 3 0x00007fffe17892a2 in GtkSalFrame::GetKeyName (this=<optimised out>, nKeyCode=<optimised out>) at /build/libreoffice-Ke3JzN/libreoffice-5.0.1~rc2/vcl/unx/gtk/window/gtksalframe.cxx:3005 4 0x00007ffff6125bbc in vcl::KeyCode::GetName (this=this@entry=0x7fffffffbfb0, pWindow=<optimised out>, pWindow@entry=0x0) at /build/libreoffice-Ke3JzN/libreoffice-5.0.1~rc2/vcl/source/window/keycod.cxx:108 Thank you Alex Bennée for having noticed this. Change-Id: I4fa89241c72144d5c76cd6175368c6878fc57a46 Reviewed-on: https://gerrit.libreoffice.org/18708 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-21tdf#94351: Web Wizard multiselection doesn't workJulien Nabet3-24/+8
Call getSelectedFiles instead of getFiles+adapt behavior so it deals with an array of files with their full path Change-Id: I21b6c32dea85460461925a9b44dac195d79b7eac Reviewed-on: https://gerrit.libreoffice.org/18714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-21Fix tdf#87500 - Freeze with English/Japanese mixture undo.Mark Hung1-18/+25
Language poolitem will be inserted after user completes editing with IME, making it refer to valid range when undo. Change-Id: Id2876aa74dba6f7d134b8e2df4d9b36a8f429bb1 Reviewed-on: https://gerrit.libreoffice.org/18392 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-21Properly #if these debug hooksfeature/chained-text-boxesStephan Bergmann1-0/+4
...moved here with 6fbab2ce87372bd98275d8239cd782d0ca6375e8 "loplugin:unreffun"; this file still indirectly includes boost/scoped_ptr.hpp via. boost/spirit Change-Id: Ib2f251420950395f58415c1f7c944b7e8fd61476
2015-09-21valgrind: use of uninit data in sw_globalfilter testCaolán McNamara1-2/+2
Change-Id: I4d327d1e65c8ef5b9dede18ac55f1658d8e3569a
2015-09-21loplugin:unreffunStephan Bergmann2-8/+15
Change-Id: I526b9e1cff25a30c3f6b935c1a11ef571f7a12ea
2015-09-21Cleanup: Remove superfluous commentSamuel Mehrbrodt2-8/+2
No need to mention that there has been a check for some state sometime. Change-Id: I844478350ae1209ae64766d28d8e254b7a4d9e10 Reviewed-on: https://gerrit.libreoffice.org/18739 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-21convert SC_LINKREFTYPE to scoped enumNoel Grandin3-14/+12
Change-Id: Ia894548d87390e5170d2b704eac26e34729ebe8e Reviewed-on: https://gerrit.libreoffice.org/18736 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-21convert SC_ENTER constants to scoped enumNoel Grandin6-39/+39
Change-Id: Idd77e2dbbcb1d1c7238ed9b5998730f0e0a9bf50 Reviewed-on: https://gerrit.libreoffice.org/18732 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-21convert SC_LINK constants to scoped enumNoel Grandin13-50/+49
Change-Id: I20470070740fcc39bce85f90ff4e8c14cdd86862 Reviewed-on: https://gerrit.libreoffice.org/18731 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-21boost->stdCaolán McNamara7-11/+7
Change-Id: I787ff19fd41d5ecee56efa1aa7ee539f46650703 Reviewed-on: https://gerrit.libreoffice.org/18703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-21fix OSX buildNoel Grandin1-1/+1
after my Link<> changes Change-Id: I418101e2bf2a29b13b7e9eadaedfe57776cf45ee
2015-09-21convert Link<> to typedNoel Grandin48-326/+254
Change-Id: If3e2b00092440ebd42ae5b73ae2b0e44c3702683
2015-09-21tdf#92521 DOCX export: handle section break right after a tableMiklos Vajna9-34/+62
DocxAttributeOutput::SectionBreaks() previously only handled the text-text and text-table node transitions; implement support for table-text to avoid loosing a page break on export for the bugdoc. (View this commit with whitespace ignored to filter out the noise about SectionBreaks() now accepting non-text nodes, too.) Change-Id: Ie8a1575374a207399351635bda8c0c076ce7268d
2015-09-21sw: implement per-view LOK_CALLBACK_CURSOR_VISIBLEMiklos Vajna1-4/+16
Change-Id: I4e00679547997cfb3dafe603b908f055011a3b30
2015-09-21sw: implement per-view LOK_CALLBACK_TEXT_SELECTIONMiklos Vajna3-8/+24
Also: - let the unit test set the global LOK flag, as sw code now depends on that - in framework, don't return early after emitting the LOK status indicator callback, otherwise CppunitTest_sw_tiledrendering shows how sw LOK callbacks are missing Change-Id: I0c4ac12f2ef5118d29afd131676bcb27d5db7746
2015-09-21gtktiledviewer: fix leftover import progressbar in createView()Miklos Vajna1-3/+6
Change-Id: Ia71e80c521cdc6a8e4df52e51e063a44a0dd53df
2015-09-21gtktiledviewer: don't crash on opening non-existing filesMiklos Vajna2-4/+14
Change-Id: Ic48adaf038e8fbcc86a94b5e351d2f963fcfcd16
2015-09-21desktop: document a number of environment variablesMiklos Vajna1-0/+16
Change-Id: Ie33f8b2f8d2a65fbdb7f4f3caaeee8f0f046cba5
2015-09-21sw: implement per-view LOK_CALLBACK_INVALIDATE_VISIBLE_CURSORMiklos Vajna2-3/+7
Change-Id: Ib4c1caede94d3eac372a3605c430bbbd353755f3
2015-09-21sfx2: adapt comment to realityMiklos Vajna1-1/+1
Change-Id: I9dd2934eaa7b479460c3a2dc7d2d51ce5c767a9f
2015-09-21lok::Document: register callback in the view, if requestedMiklos Vajna1-5/+15
With this, a postKeyEvent() in one view properly results in one LOK_CALLBACK_INVALIDATE_TILES per view, at least in Writer. Change-Id: Ia0a9a00ea5a98c38f3d399208b9ef028f3036f79
2015-09-21sw: implement per-view LOK_CALLBACK_INVALIDATE_TILESMiklos Vajna1-2/+8
Change-Id: Id839dc076824e69fe07386c83bf21fc4c7ce2b8e
2015-09-21comphelper: add LibreOfficeKit::set/isViewCallback()Miklos Vajna3-0/+21
Change-Id: Iad0b2ee419327daf478f3ddda2378effe0184067
2015-09-21sfx2: add SfxViewShell::libreOfficeKitViewCallback()Miklos Vajna3-0/+24
This is similar to the existing LOK callback, the difference is that the existing one assumes there is only one SfxViewShell instance at the same time. This newer callback is precisely per-view, so model notifications can invoke all view callbacks, while view notifications can invoke only the callback of the relevant view. This is just the framework, all actual client code has to be still ported over (and then the existing callback can be removed). Change-Id: I3d8f27740c69fcf6ffbbdce12db2ea088321493d
2015-09-21SfxLokHelper::setView: check if view is already currentMiklos Vajna1-0/+3
Change-Id: I9cf3a4887774657e0e205114688b088fc11c6822
2015-09-21lokdocview: set view before calling lok::Document member functionsMiklos Vajna2-1/+12
getTextSelection() is still to be done, but has to be moved to the widget first. Change-Id: I780a31f1dbce38b2b7398bfdacbbc1c40881229d
2015-09-21Add missing lok::Document::setPartMode() wrapperMiklos Vajna2-4/+7
Change-Id: I5dd5f0cfb8b34621b18a35be682249e042d9b173
2015-09-21LOK: allow postMouseEvent() in multiple viewsMiklos Vajna1-0/+1
Change-Id: Iafb08cb44a96dbc03d12367d21b4120063bd0222
2015-09-21LOK: make getViews() be a member function of DocumentMiklos Vajna6-29/+35
Just to be consistent, as all other view-related member functions are there, too. No real impact, as only the unit test uses this so far, and it always works with a single document. Change-Id: I46f1ed8265ab95017986ab45c1b510e961192241
2015-09-21gtktiledviewer: use setView() before postKeyEvent()Miklos Vajna2-9/+14
Also in SfxLokHelper::setView() set the current view shell directly, GetFocus() in VCL may be a NOP for hidden windows. With this, the Writer layout dump shows that two Gtk windows can have different cursor positions correctly. Change-Id: I81890c1d8ad7972f1194db3d5f2e9d8a39fc2f87
2015-09-21Use SfxViewFrame::Current()Miklos Vajna6-29/+6
Allows getting rid of vcl::ITiledRenderable::getCurrentViewShell(), which would do the same, just not implemented outside Writer. Change-Id: Id26ceca560fb9002dc2d5c740c411b9c4a149523
2015-09-21lok::Document: add get/setView()Miklos Vajna6-1/+75
Change-Id: Ic3bce8f01d7e048e853c063c4bce1255845c60d0
2015-09-21gtktiledviewer: add setupWidgetAndCreateWindow() to avoid copy&pasteMiklos Vajna1-10/+23
Change-Id: Ibbbaaa1c148cfd4578ad37e0f99b62ab885a1a83
2015-09-21lokdocview: set up the widget in all windowsMiklos Vajna1-2/+9
With this finally the number of GTK+ windows always match the number returned by SfxLokHelper::getViews(). Change-Id: Ia45bef7dea86b80cfac00e2ad7c1a16d7f5b507b
2015-09-21lokdocview: avoid GTK+ calls in openDocumentInThread()Miklos Vajna1-23/+34
GTK+ calls should be made from the main thread. Change-Id: Idcfa46d427d6e35fc544246a691bafc72f75a74c
2015-09-21gtktiledviewer: set up a new GtkWindow for a new viewMiklos Vajna1-3/+8
Change-Id: I9dcb5871c231a49bcd65a1187df6c3c81f92bd55
2015-09-21gtktiledviewer: factor out setupDocView() from main()Miklos Vajna1-13/+17
Change-Id: Iac803f03267859c11f0f9090346b09b90c115b76
2015-09-21gtktiledviewer: factor out createWindow() from main()Miklos Vajna1-112/+116
Change-Id: Ib7ccd2192247805205b65e5e8da67bcc826f4d31
2015-09-21lokdocview: allow not calling documentLoad()Miklos Vajna2-0/+50
Change-Id: I2ff57c4be11cd3908bc951ebf572a2c02e2c4585
2015-09-21gtktiledviewer: allow findbar in multiple windowsMiklos Vajna1-31/+36
With this, all previously global data is now stored per-window in the g_aWindows map. Change-Id: I45b4449ee7d516106ea0b039d1af97db49edf759
2015-09-21gtktiledviewer: allow part selector in multiple windowsMiklos Vajna1-29/+36
Change-Id: Ib31fca3d8b4119704fb1a5c3cee885e7c239c247
2015-09-21gtktiledviwer: tool item registration is per-windowMiklos Vajna1-30/+41
Change-Id: I11a6cda7b9b8949c48c201c4bd467b49f2f43ca5
2015-09-21gtktiledviwer: allow GtkToolItems in multiple windowsMiklos Vajna1-40/+48
Change-Id: I6c19a9bdd34163d12047929170e5cfa7bb9a5820
2015-09-21gtktiledviewer: allow multiple status barsMiklos Vajna1-6/+12
Change-Id: I84c4102937deee662814c41607ee8de380a067f2
2015-09-21gtktiledviewer: allow multiple DocView instancesMiklos Vajna1-39/+70
Change-Id: I4e8a08d71a94445e8fd30563867a2741cad862e5
2015-09-21gtktiledviewer: these globals can be staticMiklos Vajna1-6/+6
Change-Id: Ife0a4bb1102f6135e297dc69ba5b52b89a5dd9dd
2015-09-21sfx2: add missing header guardMiklos Vajna1-0/+5
Change-Id: Ide261670be475f5d54d9d12c701ad82470396aeb