summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-11-23Get rid of ValueSet's internal VirtualDevice, draw to RenderContextMike Kaganski2-121/+49
This improves support for Online HiDPI scenarios. Change-Id: I1d4d13d8877b761cabaefa028dcd50d8345d9893 Reviewed-on: https://gerrit.libreoffice.org/63827 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-23Bump compiler plugins Clang baseline to 5.0.2Stephan Bergmann32-182/+31
...as discussed at <https://lists.freedesktop.org/archives/libreoffice/2018-November/081435.html> "minutes of ESC call ..." Change-Id: Ia053da171d59747984546f38e19da808825b4f79 Reviewed-on: https://gerrit.libreoffice.org/63832 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-23tdf#114836, only set changed SfxItemSet propertiesMarkus Mohrhard1-1/+5
By always setting all existing properties again the calls started to differ between XMultiPropertySet::setPropertyValues and XPropertySet::setPropertyValue. This patch reduces the changes in the called methods. We can not avoid slight differences but at least the risk is minimized that something is unexpectedly changed. Change-Id: I5866db7be2829e6aba930f620f45db655df4e3f7 Reviewed-on: https://gerrit.libreoffice.org/63854 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-23Colibre icons: add calc data icons and sync with elementaryandreas kainz90-57/+761
Change-Id: I38dc00c4d4364e50fa3e3aef8e3d613d9d8b4992 Reviewed-on: https://gerrit.libreoffice.org/63848 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-23sw: new unit test for XTextCursorVasily Melenchuk3-0/+108
Change-Id: I5b70f6dc8f7399be78daefa95d6d98687d99ec18 Reviewed-on: https://gerrit.libreoffice.org/61098 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23sw: new testcase for XTextVasily Melenchuk2-0/+90
Change-Id: I8c4b89e1e0851e808daa0902f970f967c6d057a9 Reviewed-on: https://gerrit.libreoffice.org/61348 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23sw: new testcase for XTextRangeVasily Melenchuk3-0/+98
Change-Id: Ia476f4f001851d0f8b51fca62b5c041b1d866cc3 Reviewed-on: https://gerrit.libreoffice.org/61174 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23sw: fixup XAutoTextContainer testThorsten Behrens1-91/+34
This is a follow-up to 4967d498c486800b72ba34192c82c232bc0685bd and avoids to have setup errors making these tests silently pass. Also cleanup code a bit & share common init sequence. Change-Id: I043447a28f5e2c9f416aa906135030c07b2cacc8 Reviewed-on: https://gerrit.libreoffice.org/63800 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23sw: new unit test for XAutoTextGroupSerge Krot2-0/+151
Change-Id: I3928248b73025f304c0e1ef7b5f86349df9a3c8d Reviewed-on: https://gerrit.libreoffice.org/61267 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-22tdf#121326 Don't tab stop at toolboxes with no visible or enabled itemsJim Raykowski1-2/+33
Change-Id: I4d20bafbda9e6b675654d0359421cf9e57712d15 Reviewed-on: https://gerrit.libreoffice.org/63457 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22tdf#118764 Pos&Size and Shadow panels tab stop fixesJim Raykowski2-5/+5
Change-Id: Id6ee2eed8ee96b901be8172cccc9b50e01877e3b Reviewed-on: https://gerrit.libreoffice.org/63361 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22weld SwFramePageCaolán McNamara11-1747/+645
Change-Id: I12f868611860867df26bd29474aa19189c2b9a96 Reviewed-on: https://gerrit.libreoffice.org/63818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22coverity#1441484 Logically dead codeCaolán McNamara1-2/+1
Change-Id: I42a97ccb5cae95f57a03faf210af362a2874fcb1 Reviewed-on: https://gerrit.libreoffice.org/63809 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22coverity#1441483 try and silence bogus Using invalid iteratorCaolán McNamara1-4/+4
Change-Id: I312cef93a0cef48207a3b7f5165dd48d702de3c6 Reviewed-on: https://gerrit.libreoffice.org/63810 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22weld SwFrameURLPageCaolán McNamara3-79/+49
Change-Id: If189c6bbc11f85a47e3908e4ffcef36344ff8f9d Reviewed-on: https://gerrit.libreoffice.org/63819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22tdf#120426 save the style names when set or changedCaolán McNamara2-3/+5
instead of waiting until gaining focus of the listbox, because of the differences in what that focus means in the different backends. It was an odd way to do things anyway. Change-Id: I072e3da04db184b49a86a9888080b60223813729 Reviewed-on: https://gerrit.libreoffice.org/63820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22uitest Calc ScenariosZdeněk Crhonek1-0/+55
Change-Id: Iddb099f4b4773d8b70d24d7df011e103fbf0ac7a Reviewed-on: https://gerrit.libreoffice.org/63806 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-11-22tdf#121052 sc: avoid multiple empty value lookups in rangesSerge Krot3-1/+78
Change-Id: I7759aef51af2f400f3f5ec69854fd9133e845f49 Reviewed-on: https://gerrit.libreoffice.org/62712 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-11-22Don't create temp file in save destination folder when sandboxedTor Lillqvist1-1/+8
In a sandboxed environment we don't want to attempt to create temporary files in the same directory where the user has selected an output file to be stored. The sandboxed process has permission only to create the specifically named output file that the user chose in the system file dialog in that directory. Change-Id: I65274b4c433bd66b436429bea4b287a0505b72c9
2018-11-22--enable-dbgutil --disable-assert-always-abort fixesStephan Bergmann8-11/+11
...which <https://ci.libreoffice.org/job/lo_tb_random_config_linux/> occasionally stumbles across; plus some related loplugin:staticmethods fixes Change-Id: If6998c302cfbabfcad626d9c68d94d3368548a41 Reviewed-on: https://gerrit.libreoffice.org/63808 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-22Avoid busy-loop related to layout when dragging objects.Michael Meeks6-8/+19
Change-Id: I4fb437356bc154cfefc5958592ae5888e24d59c3 Reviewed-on: https://gerrit.libreoffice.org/63804 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-22tdf#121425 Use better Bezier curves to approximate circle arcRegina Henschel1-16/+28
The distance between curve point and control point was calculated as linear scaling with ratio of central angle of the arc to pi/2. The patch replaces this with the mathematical correct formula. Change-Id: I0195e40bb99cd4bbcce95f7ac896158b7e7e3d29 Reviewed-on: https://gerrit.libreoffice.org/63659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22improve function-local statics in toolkitNoel Grandin13-233/+66
Change-Id: I2a134d1cc74eaeaad46f4249fadd215b2391ba19 Reviewed-on: https://gerrit.libreoffice.org/63789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22Update git submodulesAdolfo Jayme Barrientos1-0/+0
* Update helpcontent2 from branch 'master' - tdf#119415 Widen search box and style placeholder Change-Id: I0f60cfea338e695e778d16a208153597ec6d19ca
2018-11-22tdf#121597 DOCX: don't export empty paragraphs at tracked deletionLászló Németh3-28/+18
of non-empty multiple paragraphs. Complete the fix for "tdf#115521 DOCX export: keep empty paragraphs in tracked deletion" in commit 2cdc870a7ee82d0faf35cdb5b2bf4e687cfd2b8d Change-Id: Ic3446e2a2118e604a7a4d269c8fed1f9f157846f Reviewed-on: https://gerrit.libreoffice.org/63731 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-11-22tdf#116931 Fix scale when calc cells move indirectlyArmin Le Grand1-28/+76
For the anchor mode 'To Cell (resize with cell)' there were errors e.g. when the cell the object is in does not scale but move. If that move went further than the object is, wrong offsets emerged. Also added full linear per-cell scale instead of only scale (no translation through scale). Overhauled to use liner transfomations, too. Change-Id: Icff0fad168476c68ea10fd5830bf53bd7294b89f Reviewed-on: https://gerrit.libreoffice.org/63803 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-11-22remove unused enums DocumentTextDirection and RendererPaneStyle::SideNoel Grandin3-16/+0
Change-Id: I5409a1b1ea3e7619bd1dc4a430c65987269f6204 Reviewed-on: https://gerrit.libreoffice.org/63753 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22tdf#120703 PVS: V637 rename inconsistent < and == operatorsCaolán McNamara4-26/+29
i.e. lets not have... if (a == b) { if (a < b) } Change-Id: I8ffb8a1e591cbd5f9bf24fbef497660700ed47b0 Reviewed-on: https://gerrit.libreoffice.org/63802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22SAL_USE_VCLPLUGIN is a UNO bootstrap variableStephan Bergmann1-2/+5
...(which includes environment variables), so read it as one (as is already done in e.g. CreateSalInstance in vcl/source/app/salplug.cxx), esp. so since lo_initialize in desktop/source/lib/init.cxx doesn't set it as an environment variable Change-Id: I557ecf4fcc5daba1e748af789847c8bbb9f563d6 Reviewed-on: https://gerrit.libreoffice.org/63801 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-22Related: tdf#121340: Do wizards steps Title CaseSabri Unal2-20/+20
Change-Id: I4ac17e520a93678a1a0e8dfd5fd849eaf276219d Reviewed-on: https://gerrit.libreoffice.org/63776 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-11-22Update git submodulesIlmari Lauhakangas1-0/+0
* Update helpcontent2 from branch 'master' - Stop index headers from being linkified Change-Id: If445b693feb17fd943eced3a222a20b26039891d Reviewed-on: https://gerrit.libreoffice.org/63759 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-22python tests: fix user config for autotext functionsThorsten Behrens1-1/+1
Seems that the code in SwGlossaries::GetGlosDoc() expects subdirs to exist in user config, and would otherwise fail miserably. Change-Id: I2da6bca46ae5e0d9d90bc23eb710396dbede37f4 Reviewed-on: https://gerrit.libreoffice.org/63798 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-22tdf#121607 defer other requests until password dialog is dismissedCaolán McNamara1-0/+21
Change-Id: I82b308f482cc5eb40a00afd01a6848afc3fb8ab1 Reviewed-on: https://gerrit.libreoffice.org/63793 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22Resolves: tdf#121607 set parent for password dialogsCaolán McNamara5-17/+24
Change-Id: I02210a61d103aed4a181b0e907ea2fd141e5f587 Reviewed-on: https://gerrit.libreoffice.org/63787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22tdf#120703 PVS: V765 simplfy assignmentCaolán McNamara1-1/+1
Change-Id: I4cf55dfd0a4b4684b6e8fed2c36a8e79bbf138c1 Reviewed-on: https://gerrit.libreoffice.org/63799 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22sw: new unit test for XCloseableSerge Krot2-0/+89
Change-Id: I1c89abffcc985d6f5b2e0f570fcb82601d923b5e Reviewed-on: https://gerrit.libreoffice.org/61091 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-22improve function-local statics in vbahelperNoel Grandin33-186/+109
Change-Id: Id54660390baa337d8bd54a19924e138c2ccb0bc7 Reviewed-on: https://gerrit.libreoffice.org/63790 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22Temporarily drop --disable-c++17 from Coverity buildsStephan Bergmann1-1/+0
...to see whether the Coverity issue has solved itself by now (see 0f3b0ec973f06a98c75ef8acfa720a9973e4d2b5 "Avoid C++17 mode for Coverity Scan" for details) Change-Id: I1086d6b79217af51a84e347a0d13f323429b37d0
2018-11-22improve function-local statics in swNoel Grandin82-734/+496
Change-Id: I36b0e9b2819a442f01182f551dbc2bf7d5c878f4 Reviewed-on: https://gerrit.libreoffice.org/63788 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22remove unused enum RedlineFuncNoel Grandin2-5/+0
Change-Id: Ibbe870680e22cf91d6c421df98cf7b8a098d6e3f Reviewed-on: https://gerrit.libreoffice.org/63752 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22Pass some env vars into all kinds of testsStephan Bergmann5-9/+12
...not only CppunitTests, as had been changed with d5ed903618f200456feed9b410b7bd1ed8daeb62 "Set CppunitTest-related env vars only during CppunitTest". Despite those env vars having been deceptively set up in solenv/gbuild/CppunitTest.mk, at least some of them may also be useful during other tests, and may actually have been relied upon by other tests in the past. Change-Id: I854dfb1786bb5e9e2de5fd77cb6323299320b544 Reviewed-on: https://gerrit.libreoffice.org/63784 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-22improve function-local statics in scripting..svtoolsNoel Grandin11-149/+88
Change-Id: Idf3785a1fbc6fc5b8efbdc4cd363047709f3af91 Reviewed-on: https://gerrit.libreoffice.org/63782 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22improve function-local statics in scNoel Grandin61-657/+390
Change-Id: Ibde8aa9393591fe405bfad8ddb23ceda77723a35 Reviewed-on: https://gerrit.libreoffice.org/63781 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22Resolves: tdf#113898 create JumpMatrix for svExternalDoubleRef scalar valuesEike Rathke1-1/+10
Change-Id: I45d2a1e573a7e4923aaaf5b69f3c4b39215aacc2 Reviewed-on: https://gerrit.libreoffice.org/63778 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-11-22improve function-local statics in salNoel Grandin6-45/+21
Change-Id: I0853cf13162bae44cf8a5c44a4546a73f05772d9 Reviewed-on: https://gerrit.libreoffice.org/63780 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22git hooks: Tell what to do in another problematic submodules case.Jan Holesovsky1-0/+6
Change-Id: I6247df16c021c13c97471cae16d3a1c0f3ddc691
2018-11-22git hooks: Check that you are not committing to submodules by accident.Jan Holesovsky1-0/+54
And also for a dangerous setting in the configuration that hides the changes from you. Change-Id: I99bad8024baf7048696d9602e857c253c20cb5c2 Reviewed-on: https://gerrit.libreoffice.org/63389 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-11-22remove printfTomaž Vajngerl1-1/+0
Change-Id: I00394e7c9880bd96a4f68b6695f1b85fa95689b4 Reviewed-on: https://gerrit.libreoffice.org/63442 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-11-22improve function-local statics in svxNoel Grandin12-302/+235
Change-Id: I636fcc8ba1012d774d98f6a880bf29eb4b233128 Reviewed-on: https://gerrit.libreoffice.org/63783 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22Re-factor internal filter logic, and impl. preload properly.Michael Meeks5-84/+93
Change-Id: I4c55ceb19d5db2c1e4756901d0d8b14878641a99 Reviewed-on: https://gerrit.libreoffice.org/63761 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>