summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-03-07log nice exception messages whereever possibleNoel Grandin121-526/+795
Change-Id: Idd125c18bee1a39b9ea8cc4f8c55cddfd37c33e1 Reviewed-on: https://gerrit.libreoffice.org/68579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06sync dbaccess ui files with swriter ui file structureandreas kainz16-479/+547
Change-Id: I5acecb3292c1b4ef6aa2dfdc38775ed5bb81324a Reviewed-on: https://gerrit.libreoffice.org/68806 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-06Sifr icon theme updateandreas kainz12-0/+24
Change-Id: I6aa3d3a4dac4af5b1dbf1d23166cc2a560cd984a Reviewed-on: https://gerrit.libreoffice.org/68808 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-06Increase font size when drawing from widget definitionTomaž Vajngerl1-0/+23
Change-Id: I983dde507758a42c6ce421ea970b6e5d54c5dcae Reviewed-on: https://gerrit.libreoffice.org/68826 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06draw combobox (entire areaonly) from external svg, fix editboxTomaž Vajngerl1-2/+6
Change-Id: Iba7e5b45c4f1ac6f87cbca963bb5284ce810ebcf Reviewed-on: https://gerrit.libreoffice.org/68825 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Add XServiceInfo tests to ScDataPilotFieldObjJens Carl1-1/+9
Change-Id: I7de8902b6857782acb5d2b3566d5768481baab51 Reviewed-on: https://gerrit.libreoffice.org/68824 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-06Move variable nMaxFieldIndex out of namespaceJens Carl5-11/+5
Change-Id: I9396abb722b24d8ee6b2d5f8fccac140a1014436 Reviewed-on: https://gerrit.libreoffice.org/68784 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-06Draw tabs from external svg image, fixes for tabs (colors)Tomaž Vajngerl8-8/+44
Change-Id: I35db7b8e36c474d2196bfae1ec4dd352e17d2a14 Reviewed-on: https://gerrit.libreoffice.org/68822 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Draw pushbutton from external svg imageTomaž Vajngerl4-2/+10
Change-Id: I45d668636d607e09852ee0ff3144500ac03fb8cf Reviewed-on: https://gerrit.libreoffice.org/68819 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Update drawing of spinbox from definitionTomaž Vajngerl6-46/+88
Use SVG to describe the left, right spin button and the entire spinbox widget. Change-Id: I082ee08942fa3fa4145fd7bf53fc2cfc9fc06fd2 Reviewed-on: https://gerrit.libreoffice.org/68818 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Support first, last tab item for the widget definitionTomaž Vajngerl5-12/+45
Add "extra" parameter for the widget definition states with the default set to "any". For tab item, the extra parameter can be "first", "last", "middle" and "first_last" (only one). This is needed to draw first and last tab item differently. Change-Id: I46b6897b485b4df94ab6fe9521925c3715eaa24e Reviewed-on: https://gerrit.libreoffice.org/68817 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Simplify Sequence constructionStephan Bergmann2-9/+5
Change-Id: I52ea31734f7765176e20514c5d02cb3ee5928cdb Reviewed-on: https://gerrit.libreoffice.org/68812 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06Support drawing widgets by interpreting an external SVG definitionTomaž Vajngerl4-3/+172
This uses SvgDrawVisitor and draw commands to draw widgets from an "external" SVG file. The difference to normal SVG drawing is that the shapes are adjusted and not just resized to the widget size. The result of such adjusted drawing is that the margins are preserved exactly just the dimensions of the shapes is adjusted to the desired size (if the shape bounding rectangle starts at {5,5}, so will also when it is adjusted), also the stroke widths are completely preserved. This enables us to use SVG to define also for dynamic widgets, like for example entry fields, listboxes, comboboxes,... which vary in size - depending on the dialog definition. Change-Id: I26fc9a37539d3675a77b48660d235a8a55b81156 Reviewed-on: https://gerrit.libreoffice.org/68816 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Blacklist some dialogs which won't get properly initializedStephan Bergmann2-3/+23
...so that at least Clang -fsanitize=implicit-signed-integer-truncation would generate warnings for them Change-Id: I76fd0aaa8e61784053e2b367b302fdd68c3859b4 Reviewed-on: https://gerrit.libreoffice.org/68815 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06Pass ENABLE_DEBUG into external/zlibStephan Bergmann2-0/+8
Change-Id: I3aea7c64acfc933e4df901d4de349708a3331bcd Reviewed-on: https://gerrit.libreoffice.org/68811 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06tdf#121176 DOCX track changes: same size w:del in w:insLászló Németh3-3/+11
Instead of showing the tracked deletion as untracked normal text, losing the original and actual text contents, now w:del within a same size w:ins is imported as tracked deletion correctly. Change-Id: I7390df34f557664860a63779c5f972d5013ecc99 Reviewed-on: https://gerrit.libreoffice.org/68779 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-03-06parse more attributes in SvgDrawVisitorTomaž Vajngerl2-6/+45
- add additional parameters for DrawRectangle, DrawPath - parse stroke width, stroke and fill color for path and rect - parse rx, ry for rect - use getCurrentViewPort for top-level SVG rectangle Change-Id: Ife498bdaa721852ef2542ac5df2be0e86dfb4e62 Reviewed-on: https://gerrit.libreoffice.org/68785 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06use gfx namespace for DrawCommandsTomaž Vajngerl5-12/+24
Change-Id: Ib2d97c4fee4e1bb433beeba4fb507fdc7d542af9 Reviewed-on: https://gerrit.libreoffice.org/68775 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Draw basic list{node,net,header} from the theme definitionTomaž Vajngerl3-2/+18
Change-Id: I05b2cced0f99d6628a12465748820e3a87c5f3e7 Reviewed-on: https://gerrit.libreoffice.org/68774 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Draw basic toolbar from the theme definitionTomaž Vajngerl3-2/+52
Change-Id: I4d9935973bb6e46a7c5f17f914944f91a3e10a63 Reviewed-on: https://gerrit.libreoffice.org/68773 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Draw basic frame and window background from the theme definitionTomaž Vajngerl3-8/+48
Change-Id: I2422650a155a874855ad4d72fa3bfd27b7d0da8a Reviewed-on: https://gerrit.libreoffice.org/68772 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06Draw basic listbox from the theme definitionTomaž Vajngerl3-7/+43
Change-Id: Id3dd5aaa8b5537e5f740752cec292d6f4a44044e Reviewed-on: https://gerrit.libreoffice.org/68771 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06svgio visitor, add draw commands and create the from svgTomaž Vajngerl11-36/+501
Adds a visitor for svgio for visiting svg nodes and create something useful from them. Basic draw commands - a tree of draw commands (with sub-pixel precision support) just to store a simple definition for drawing. Adds a svg draw visitor and create draw commands from the svg structure and expose the commands through UNO API. Change-Id: I073e891a2cffdd76d4e3b838590e3a19c998e9bf Reviewed-on: https://gerrit.libreoffice.org/68770 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-06support large toolbar sizeCaolán McNamara1-0/+5
Change-Id: If24baee9a682006ff92e543eeb28490573b6cdec Reviewed-on: https://gerrit.libreoffice.org/68805 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-06hookup MenuButton::SetDropDown to GtkMenuButton draw-indicatorCaolán McNamara25-4/+64
Change-Id: I556d61256bed8f607eed5a9c6e0ed3fcfd63af2c Reviewed-on: https://gerrit.libreoffice.org/68802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-06Fix libtool RPATH outsmarting hack for external/librevengeStephan Bergmann1-1/+2
After the blind fix attempt of 490f07cf7235ab3c5dc4be13c53832e3266bd8e6 "Extend libtool RPATH outsmarting hack to external/librevenge", appears that <https://ci.libreoffice.org/job/lo_daily_update_gandalf/596/> also needs runpath_var=LD_RUN_PATH to be reset. (See also how <https://src.fedoraproject.org/cgit/rpms/librevenge.git/tree/librevenge.spec ?id=4960d4c6c190885b20f56ce9ee1ad2ad92b87021#n46> addresses the same problem for Fedora builds of librevenge.) Change-Id: I5cff145605cd05a8b87360c1edc3574e3364139b Reviewed-on: https://gerrit.libreoffice.org/68800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06sync chart2 ui files with swriter ui filesandreas kainz10-197/+215
Change-Id: I5c31fd0aef8d3a3e2ce4bcc6942f9cc06edff858 Reviewed-on: https://gerrit.libreoffice.org/68791 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-06loplugin:staticconstfield improve warning messageNoel Grandin2-7/+10
Change-Id: I000dff6b1b6e33e1b2c5aa337c027c1edd7b1003 Reviewed-on: https://gerrit.libreoffice.org/68795 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06writerfilter: remove empty RTFPicture constructorMiklos Vajna3-12/+9
This is really just a reference-counted struct, not a real class. Change-Id: Ifccd513e56632fd4df7711f7070188671b45e82d Reviewed-on: https://gerrit.libreoffice.org/68777 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-06Introduce Int32ToSVBT32 for cases that apparently want to write a signed valueStephan Bergmann4-53/+58
...and clean up some other (legitimate) uses of UInt32ToSVBT32 to not use a (somewhat misleading) static_cast<long>(...) Change-Id: Ifd0c3f771c3f6e20eef3413b9c27fd2514dc0c13 Reviewed-on: https://gerrit.libreoffice.org/68767 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06Record external/harfbuzz/msvc.patch as sent upstreamStephan Bergmann1-0/+2
Change-Id: I47277272170508e9af7617e9b774bbdca05e9ec3 Reviewed-on: https://gerrit.libreoffice.org/68766 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-06sync sdraw and simpress ui files with swriter ui filesandreas kainz42-818/+896
Change-Id: I321233437b573d254ca63aaf7274b54334ec066a Reviewed-on: https://gerrit.libreoffice.org/68786 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-06tdf#123829 Respect CollapseEmptyCellPara setting when reading odf docsSamuel Mehrbrodt3-0/+17
Commit 56b2cf0c10d9caa01ebae1d80465e342d046a85c introduced a "feature" which would hide an empty line after a table and only make it visible when the cursor is in it. So when loading an ODF doc, only enable this feature for which have the CollapseEmptyCellPara setting set. Change-Id: Ib4dfbbe8d45eb57547c51c7eee2f81331fc5300e Reviewed-on: https://gerrit.libreoffice.org/68742 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-06Fix typoAndrea Gelmini1-1/+1
Change-Id: I0b1c04b846ff5e6197fce59bd3c4325528169a7c Reviewed-on: https://gerrit.libreoffice.org/68787 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-06Typo: unexpectend->unexpectedJulien Nabet3-6/+6
Change-Id: Id7aface81f907afdb046a22f1a64641718391000 Reviewed-on: https://gerrit.libreoffice.org/68776 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-06Remove debugging dump()sStephan Bergmann1-8/+0
Change-Id: I1f5479adefbf7c77a5584d698c6a6c35ff4716d0 Reviewed-on: https://gerrit.libreoffice.org/68778 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06remove some unnecessary typedef struct... sugarNoel Grandin22-115/+103
Change-Id: I1576282b0a0a3af8ae14c04725d9c4900073f2c4 Reviewed-on: https://gerrit.libreoffice.org/68758 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06loplugin:unnecessaryparen improve member expressionNoel Grandin62-123/+133
Change-Id: I304621018cb1e2a47e478e86df4229bcf2176741 Reviewed-on: https://gerrit.libreoffice.org/68757 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06remove sal_IntPtr in OfaMSFilterTabPage2Noel Grandin2-42/+45
and just use a scoped enum Change-Id: Ie229d61866be4a03ccd93b73787b8813b9bd932d Reviewed-on: https://gerrit.libreoffice.org/68744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06tdf#45904 Move XPropertySet Java tests to C++Jens Carl6-325/+12
Move XPropertySet Java tests to C++ for ScDataPilotFieldObj. Change-Id: I9fa5d153cced1aae8892d2422025dfcdcda73c69 Reviewed-on: https://gerrit.libreoffice.org/68782 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-06tdf#45904 Move XNamed Java tests to C++Jens Carl2-3/+8
Move XNamed Java tests to C++ for ScDataPilotFieldObj. Change-Id: Ieecd8799f56dcfa9279d4d523d470a62d9aed203 Reviewed-on: https://gerrit.libreoffice.org/68781 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-06Remove unnecessary calls to Reference::is() after an UNO_QUERY_THROWJens Carl1-27/+27
Change-Id: Icb5ab21168e91951a81c09752e7b53e11813aa1b Reviewed-on: https://gerrit.libreoffice.org/68780 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-06do not access uninitialized values when printing (tdf#121439)Luboš Luňák2-7/+21
The assert in the bugreport is triggered by ScPrintFunc::CalcPages() passing uninitialized values of nEndRow (and others). These variables apparently get initialized only by constructors that take ScPrintState. These ctors also set (the somewhat poorly named) bState and the call to CalcPages() is guarded by this. However, GetPrintState() will simply create ScPrintState filled with these uninitialized values and later on this will be used with these ctors, so bState will be set, but nEndRow will be bogus. Although 5217a2a0bf27e496cc429ee45dff7c239b466ae6 introduced tdf#121439, this strange bState logic and unitialized variables has been these since the initial commit, and the code doesn't take any precautions to check whether the values are valid or not, so I assume this always was just lucky enough to work and 5217a2a0bf finally triggered a problem. Given that it's rather unclear to me how this is supposed to work properly, just add an extra flag to both ScPrintFunc and ScPrintState marking whether the values are set or not and make CalcPages() depends on this flag instead. Change-Id: I0620de6562865c24f5a0edca2566b01546bf2e2b Reviewed-on: https://gerrit.libreoffice.org/68739 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2019-03-05Make mysqlc conditional on MARIADBC, tooTor Lillqvist1-1/+1
Change-Id: I7e8541b8918ea5011fe9669d11b51c941544f794 Reviewed-on: https://gerrit.libreoffice.org/68764 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-03-05Group some more common codeMatteo Casalin1-23/+12
Change-Id: I2bf3e8afd9f330e8d7377300163a3224ed4db05c Reviewed-on: https://gerrit.libreoffice.org/68179 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-05Use optimized OString concatenationMatteo Casalin1-17/+11
Change-Id: Iaefacf4a57398d0e88b4de7552af11832db3e881 Reviewed-on: https://gerrit.libreoffice.org/68178 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-05Use index only where getToken() needs itMatteo Casalin1-12/+6
Change-Id: I28da64c9ef9b36288f380300f6622d48483e6c0d Reviewed-on: https://gerrit.libreoffice.org/68125 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-05Use already available index in following getToken callMatteo Casalin1-2/+1
Change-Id: I1617af942d59c59039e97400a8c39bbc36c3bceb Reviewed-on: https://gerrit.libreoffice.org/68124 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-05Use indexed getToken()Matteo Casalin1-2/+3
Change-Id: I3f34ccb4253c587088f621f914b315e56f96008f Reviewed-on: https://gerrit.libreoffice.org/68123 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-03-05Simplify ShapeAnchor::importVmlAnchorMatteo Casalin1-14/+18
Change-Id: Ibee7914a0c5027b4679163e6a5108f646ad66546 Reviewed-on: https://gerrit.libreoffice.org/68122 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-01 15:21:23 +0000