summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-01-22tdf#96683 Move tabs in Basic IDE to an own rowSamuel Mehrbrodt3-46/+7
So that the tab height does not depend on the scrollbar height (which is subject to the desktop theme) Change-Id: Ie2d787528152aed92c9943fe76955bf499d7d2a9 Reviewed-on: https://gerrit.libreoffice.org/21707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-01-22ImplSVEvent::maDelData is unused nowStephan Bergmann3-9/+3
...since 47bac0de19fc4ca2c9d469b64fcbffe15bc4a0a3 "tdf#96888 Kill internal vcl dog-tags ..." removed its last use Change-Id: I4a6c6f87f99dfa5ff2f6f5abdb028a99b1996345
2016-01-22vcl: oops, these shouldn't be set to false but should be copiedChris Sherlock1-2/+2
Change-Id: Ibb940d91b15d20f31fe60075c5eae05031949d17 Reviewed-on: https://gerrit.libreoffice.org/21697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-22vcl: add orientation flag property to Font classChris Sherlock4-3/+25
Add getter and setter for orientation flag to the Font class. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit test added to vcl/qa/cppunit/font.cxx to test this flag. Change-Id: I62d5a47f870702eeac4625830dd279dd53fbcc3d Reviewed-on: https://gerrit.libreoffice.org/21696 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-22tdf#89708 Adjust print page range for unprinted blank pagesEilidh McAdam2-1/+61
Depending on whether automatically inserted blank pages are to be printed or not, the range of pages to print is expressed differently to the pages displayed in the preview in the Print dialog - i.e. the page range includes blank pages, whereas the preview doesn't (if blank pages are not to be printed). This patch adapts the range so that if blank pages are ignored upon printing, the range can be expressed across printable pages only, same as the Print dialog preview. An example is a merged document of several records into a single page letter or document - blanks are automatically put in between documents but usually aren't displayed/printed. Previously, printing page 2 would print the blank page between the 1st and 2nd merged document. After this change, printing page 2 will print the 2nd merged document instead. The "Pages" (print range) text box in the Print dialog defaults to the current page - this patch adjusts this when blanks are not to be printed so that it is expressed as the current page minus any blanks since the start of the document. Change-Id: Ic1d4d374a82c6f921bb41a97130838757c6b74b1 Reviewed-on: https://gerrit.libreoffice.org/18420 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2016-01-22Use C++ osl::Mutex, osl::MutexGuardStephan Bergmann2-23/+15
...and get rid of that curious "defensive programming" mis-handling of a failing osl_acquireMutex Change-Id: I1730c2d8334f0137ee8646ab990d0914426246bb
2016-01-22vcl: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl1-17/+18
Change-Id: Ia5e5349e879d46d6a57b7b83b31346766c11c58b Reviewed-on: https://gerrit.libreoffice.org/21662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-22Resolves: rhbz#1257635 after httpConnectEncrypt use cupsGetDests2Caolán McNamara1-4/+3
sometimes after calling httpConnectEncrypt + httpClose and then calling cupsGetDests we get no printers found. Using cupsGetDests2 with the return of httpConnectEncrypt consistently provides results. Change-Id: I7ea5b11fbaabbd7ca73e5c94d0757ebdea8445ad
2016-01-22new loplugin sfxpoolitemNoel Grandin3-0/+156
generates a warning about subclasses that add members but do not override operator==() Change-Id: If6df1a2cbd115f17bcca22f9b7995181dcf55c03 Reviewed-on: https://gerrit.libreoffice.org/20468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-22cid#1326191 is a false positiveStephan Bergmann1-3/+1
and trying to appease Coverity with throwing a (checked---semantics attached!) java.io.IOException is plain wrong. Change-Id: Icece5ac74d482791d089f40ec201bc39d61db177
2016-01-22tdf#97275 SVGIO: Change default PPI to 96 in svg import...Xisco Fauli2-3/+4
... thus default font size is 16px from now on. More information: https://gerrit.libreoffice.org/#/c/21542/ Change-Id: If19b5be08d57a9d630647b9ad51a4bb6956c70ed Reviewed-on: https://gerrit.libreoffice.org/21617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-01-22Further uninitialized SvxNumberFormat::mbNumAdjustChanged fixingStephan Bergmann1-1/+1
The uninitialized read during CppunitTest_sd_html_export_tests mentioned in d90a20833a815362c344b82fc16b4bbcff0ebf07 "Missing initialization of SvxNumberFormat::mbNumAdjustChanged" is rather caused by the SvxNumberFormat copy ctor callling the SvxNumberFormat copy assignment op, which calls SvxNumberFormat::SetNumberingType before assigning mbNumAdjustChanged. What is probably wanted here is to simply copy the nNumType member without doing the eNumAdjust adjustments anyway. But a rather brittle design, that. Change-Id: Ic587687038f1ea71173461412350e6b2dee13aa4
2016-01-22TypoKhaled Hosny1-1/+2
Change-Id: Ib4c474cab050cdef003dc5e611e8a9bc1fb46e86
2016-01-22starmath: Catch exception by const refTakeshi Abe2-2/+2
Change-Id: I8a4ef4041e02b5ce76f695be170f2b8e5d29a28f Reviewed-on: https://gerrit.libreoffice.org/21700 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-01-22GCC PCH says -Werror=unused-macros BOOST_SPIRIT_DEBUGMichael Stahl4-3/+1
... so try to blacklist that boost::spirit header, it is fortunately included only in one cxx file per library anyway. Change-Id: I95752540d33b2b20d7a185c05c4d4d15e660d956
2016-01-22Fix wrong use of OUString::copyMaxim Monastirsky1-5/+3
Code like: if( aCommandURL.copy(5) != ".uno:" ) is obviously wrong, as OUString::copy(sal_Int32) takes the _beginning_ index, so for this condition to be false the command URL must have ".uno:" in the _middle_ of the string. This created some weird things like an empty label attribute added to any submenu item. Moreover, the command URL can be easily shorter than 5 (like when a custom submenu added by the user). Using copy(5) in such case officially considered as "undefined behavior" and will trigger an assert in debug build (that's how I discovered this code actually). Most likely the original intent was to check whether the command URL doesn't start with ".uno:", and so should be changed to use OUString::startsWith. But doing that will create a regression, as it won't be possible anymore to change labels of commands that start with ".uno:". Simply dropping this check seems to be better solution here. Change-Id: I2f88807eceae1006066a14750f2003e235f49ad4
2016-01-22cid#1326191, 1326202jan iversen2-1/+10
Null references elements, introduced throw Change-Id: I22bf7de5f20c3ca455df31de2a5d7301b436ed82 Reviewed-on: https://gerrit.libreoffice.org/21691 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-22Missing initialization of SvxNumberFormat::mbNumAdjustChangedStephan Bergmann1-1/+2
introduced in 6517141b6233c5f9667031bc92f66109fddf5b76 "tdf#42788: FORMATTING - Numbering/ordered list," causing a read of the uninitialized value in CppunitTest_sd_html_export_tests. Change-Id: I7955593999e3a2bedca815ee447d96c1b997a358
2016-01-22editeng: ImpEditView::mbTiledRendering is never readMiklos Vajna11-34/+0
Change-Id: Ie8e33d075f0cedbb9f7148717c4318f4494ed419
2016-01-22loplugin:overrideStephan Bergmann1-1/+1
after 6517141b6233c5f9667031bc92f66109fddf5b76 "tdf#42788: FORMATTING - Numbering/ordered list" made SvxNumberType::SetNumberingType virtual. Change-Id: I856a521b88940b6c2a8f3ebbae9ec4066e14ea78
2016-01-22Move sc/source/ui/dbgui/validate.cxx from scui to scStephan Bergmann6-41/+4
8d1a24dae03690b576310e3539369916f31ac475 "Make virtual ~ScValidationDlg non-inline" caused the RTTI for ScValidationDlg to only be emitted in library scui instead of (weakly) wherever needed. That causes UBSan to fail when it uses the RTTI in ScValidityRefChildWin::ScValidityRefChildWin (sc/source/ui/view/reffact.cxx, in library sc, to check that operations on VclPtr<ScValidationDlg> pDlg indeed operate on an ScValidationDlg object). The cleanest fix appears to be to move ScValidationDlg from scui to sc. As Moggi put it on IRC, "that dialog should be in sc as it is a modeless dialog; no idea why it works for that dialog but all other modeless calc dialogs have to be in sc to avoid linker problems." One remaining question is whether it is save nowadays in ScCellShell::ExecuteDB (sc/source/ui/view/cellsh2.cxx) to clean up the ScValidationDlg pointed to by pDlg when that VclPtr<ScValidationDlg> variable goes out of scope, instead of doing the PostUserEvent(... DelayDeleteAbstractDialog) dance that was there before because "after end execute from !IsModalInputMode, it is safer to delay deleting." Lets see. Change-Id: I3ecfd4fafc7b37b2f30e75974ece9b0a23311ef4
2016-01-22tdf#96407 Provide OS X version info for About boxDouglas Mencken2-0/+20
since commits 56a9594649872f4076b6891f & 52856b6ea7b6b01e8a8455ed the about box now includes information about a version of operating system Change-Id: Iaf28b555ec1eb3dfe8c6e9b9567fa0dda18741db Reviewed-on: https://gerrit.libreoffice.org/21564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-22Yes, output the name earlyStephan Bergmann1-1/+1
Change-Id: Ib2975598b2b1e4ddd875ab873de9716418949868
2016-01-22vcl: add font map names to Font classChris Sherlock4-10/+20
Added getter and setter for font map names to the Font class. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Change-Id: I3e12c900da6f3abe60ea9c8dc39178fdd3f98bb7 Reviewed-on: https://gerrit.libreoffice.org/21695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-22Revert "More LTO fixes for android"Tor Lillqvist4-31/+1
Seems to cause tinderbox build breakage, sigh. This reverts commit 1c1b788f38da07aed268be3c515a096594a107dc. Change-Id: I5a69e186e0f8f71c2fcc81d27bebe2253fd240bb Reviewed-on: https://gerrit.libreoffice.org/21699 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-01-22Don't pollute cross-compilation environment with host pkg-configPeter Foley1-1/+3
Revised to prevent undefined macro errors with older pkg-config. Change-Id: Ia588525e5537d7cf758b5351c0a4c5f48b28a200 Reviewed-on: https://gerrit.libreoffice.org/21595 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-01-22More LTO fixes for androidPeter Foley4-1/+31
Change-Id: Id9b4873b8213d9913d54b3821ba0be6ffa7ac188 Reviewed-on: https://gerrit.libreoffice.org/21612 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-01-22lotuswordpro: Clean after we use constructor featureMatúš Kukan3-46/+16
18f1eb7b0c3536817572eeb481591418a7eab3da was pushed sooner, so just few more additions. Change-Id: If8e8082959fc049947986ca6faf329ea9436062a
2016-01-21detailed warnings for invalid pch filesPeter Foley1-2/+2
Change-Id: I28e55bbcae6d16af4ef230d1ec263ab356e1049f Reviewed-on: https://gerrit.libreoffice.org/21586 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-01-21Make ccache work properly with GCC PCHPeter Foley1-0/+7
Change-Id: I2cbf3fc3ba2df7131ce9328de8bada701ecb3b65 Reviewed-on: https://gerrit.libreoffice.org/21524 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-01-21Fix module-deps with clewPeter Foley1-0/+3
Change-Id: Idb266e906915182d12f56a11feb21e11bdc95f76 Reviewed-on: https://gerrit.libreoffice.org/21607 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-21new[] failed but memset of requested len called anywayCaolán McNamara1-6/+5
recent regression from commit a73e606b8cd714520285b4e40890db9fd27d7ba5 Date: Thu Jan 21 16:04:28 2016 +0100 Quickfix for deterministic SvpSalBitmap checksums move the memset (and similar memcpy) inside try block Change-Id: I51d76777f91664459deb777a5dfafae80203af57
2016-01-21gtk3: use gdk_window_create_similar_image_surfaceCaolán McNamara1-2/+12
maybe there is some small benefit to doing so, at least open us up to that possibility Change-Id: Ib1fcdf4a613c729b559bdbe653ed80e68bcb1ff3
2016-01-21tdf#34873 : Show autofilter row count in status barDennis Francis9-1/+157
Change-Id: I91aa637d654c1f4d828832f2e43ad21f03036ad0 Reviewed-on: https://gerrit.libreoffice.org/20134 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-21tdf#87178 Resetting menu shouldn't reset other resourcesMaxim Monastirsky1-1/+8
Change-Id: I6d6334cac9fdb5dfa3e35fe0cba70e5d9adf6fc2
2016-01-21Check for valid SidebarWinMaxim Monastirsky1-2/+2
Change-Id: Ia483408b5fef0880d44f37b6372054956f0ab069
2016-01-21tdf#42788: FORMATTING - Numbering/ordered listNusaiba Al-Kindi2-3/+26
I changed the default numbering alignment of the Roman(upper/ lower) numbers list to the right instead of left with out any changes in the default alignment of other numbring type lists. In addition, numbering alignment can be changed by the user and any new list created will not be affected by the user choice (using the default settings for the new list). Change-Id: I7a6b7fb31bf40e26910e90538cd336e767f4c056 Reviewed-on: https://gerrit.libreoffice.org/21439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-21Clean upStephan Bergmann3-38/+7
after ea6fdbaeeb51ad695f1c3754b796b7273eb4baad "tdf#74608 lotuswordpro: Constructor feature for LotusWordProImportFilter" Change-Id: I24179fd670bbaa92713cb69bd306930e90a8e698
2016-01-21Move XMLMetaExportComponent_get_implementation to a more reasonable placeStephan Bergmann1-8/+8
Change-Id: Iaf3dc5351453b4aee8ffc1e7fb1bc670c45c507f
2016-01-21i18npool: why not document the state transitionsMichael Stahl1-10/+10
Change-Id: Ica5789dab22a49efb9e2da3a795e13aa7e2c4339
2016-01-21starmath: fix OOXML export of non-BMP UnicodeMichael Stahl3-3/+32
Change-Id: Iafaeb9ea2e96ee6d8cc96174731ba3845c230b5e
2016-01-21i18npool: handle non-BMP Unicode in cclass_Unicode::parseText()Michael Stahl3-70/+99
The UTF-16 code unit limitation was mangling starmath import. Change-Id: I087e5c5b7954799fdb73e7ee1a8d3d02669f8831
2016-01-21oox: import Math objects from PPTX filesMichael Stahl9-5/+207
This is quite hacky and limited: in OOXML these are not OLE objects but occur inside text boxes, and PPT 2010 allows inserting multiple Math objects into one text box but Impress does not have as-character anchored objects, so we can't import that properly; for now only import Math if there is nothing else in the text box. Also for now only import them as children of TextParagraphContext (a:p); it's not clear what the possible parent elements could be since the OOXML standard only lists WordProcessingML parent elements :( Change-Id: I847f810084c9ddae4b60f93896fb73a742683cc2
2016-01-21Quickfix for deterministic SvpSalBitmap checksumsStephan Bergmann2-2/+8
...that include the junk parts of the mpDIB->mpBits array in the calculation. MALLOC_PERTURB_=153 in gb_CppunitTest_malloc_check (solenv/gbuild/platform/unxgcc.mk) causes those junk bytes to normally contain 0x66 on Linux, but ASan makes them contain 0xBE instead. Change-Id: I74429c5e539e667cb936b3a486de31867eef3e50
2016-01-21coverity#1326438 Dereference null return valueCaolán McNamara1-0/+12
and coverity#1326439 Dereference null return value Change-Id: Idf7e6f34accfb5d5b98a62f6ad221c325e24586a
2016-01-21coverity#1326447 Dereference null return valueCaolán McNamara1-7/+2
Change-Id: I76f81e86cdeb33ec99f4aade314bbb719a0b1ef4
2016-01-21coverity#1326449 Dereference null return valueCaolán McNamara1-12/+8
and coverity#1326448 Dereference null return value Change-Id: I8e26c9c57264b654a5a7c3dc56c658f23291e357
2016-01-21coverity#1326456 Dereference null return valueCaolán McNamara1-19/+13
and coverity#1326455 Dereference null return value Change-Id: I48f18483c82dafed6352434e98d5b49120fdcfc5
2016-01-21coverity#1326551 Dereference before null checkCaolán McNamara1-2/+2
Change-Id: I11a65723909b7ed78a487ece7456c0e5a4d1aa8b
2016-01-21coverity#1349758 rework to avoid bugus Dereference null warningCaolán McNamara1-4/+8
Change-Id: Ia91b312449b5593a78b11337bd17f5d87903ff8d
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-17 16:48:45 +0000