summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-08-18tdf#99692 sw: fix the fix: don't set bNullContent if node was splitMichael Stahl1-1/+2
When showing the redlines in rhbz908615-13.odt, the following assertion happens: Assertion `IDocumentMarkAccess::IsLegalPaMForCrossRefHeadingBookmark(rPaM) && "<CrossRefBookmark::CrossRefBookmark(..)>" "- creation of cross-reference bookmark with an illegal PaM that does not expand over exactly one whole paragraph."' failed. This is because in DocumentContentOperationsManager::MoveRange() the flag bNullContent is set after the node has been split; in this case the nContent is of course always 0. Later the function then restores aSavePam to the index 0 of the next node, when it actually shouldn't do anything because the JoinNext() already positioned it correctly at the merge-index of the re-joined node. (regression from 850795942b3e168cab8ce88b4f2b421945ff29ca) Change-Id: I64d50e70b19e2fd81537a9771fa8706898b17642
2017-08-18fix typosdennisroczek2-2/+2
Change-Id: Ie0228b07bf801faab5241d835bca36676a07682e Reviewed-on: https://gerrit.libreoffice.org/39736 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-08-18WB_RANGESELECT,WB_MULTISELECT in Calendar is deadNoel Grandin2-241/+19
since commit 6c759da0442f5123a4a4355e8dc9c926a49d25d7 delete workben Change-Id: Ib9db62ea3fb064b70912318eda2528590c307295 Reviewed-on: https://gerrit.libreoffice.org/41287 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18WB_BOLDTEXT,WB_FRAMEINFO,WB_WEEKNUMBER are deadNoel Grandin2-97/+1
since commit 6c759da0442f5123a4a4355e8dc9c926a49d25d7 "delete workben" Change-Id: Ie1f399a7a8179c7727491f4ab7b4b2772fd130b8 Reviewed-on: https://gerrit.libreoffice.org/41286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18Fix typosAndrea Gelmini2-2/+2
Change-Id: Ic9cbc4a05fa28c63ab2f5a773aa2f9e87757609a Reviewed-on: https://gerrit.libreoffice.org/41285 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-18don't use boost in compilerpluginsNoel Grandin1-7/+6
Change-Id: Ic1610e99cd2d11d1a536a6f3e66b44417ee59793
2017-08-18loplugin:redundantparenNoel Grandin1-1/+1
Change-Id: Ie1bae8acdd70ba7943d8ae245d95dee16ce2e5d5
2017-08-18new loplugin:expressionalwayszeroNoel Grandin4-3/+156
The code in SvXMLExportItemMapper::exportXML was broken as far back as its introduction in commit 0c28e3c480a95c03b513c55f029b979bcd9c0401 "Move SvXMLAttrContainerItem to SVX, moved writer only code to sw" Change-Id: I90043ce8b7263aa56fd0883d350e29b97eeaf99b Reviewed-on: https://gerrit.libreoffice.org/41282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18No libepubgen in org.gnome.Sdk//3.24Stephan Bergmann1-0/+1
Change-Id: I71a9e382b2a36cfba38dbd14e1af303153356d47
2017-08-18WB_QUICKHELPSHOWSDATEINFO is deadNoel Grandin1-2/+0
since commit e8559f07b52f434e081b1ef58a8db097cdd826ee Remove unused code Change-Id: I0dcfe7aea4e0326595d99a781a1029a0c25ed15f Reviewed-on: https://gerrit.libreoffice.org/41281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18WB_FORCE_SELECTION is deadNoel Grandin1-2/+0
at least as far back as: commit ac7acb0ab1329913b0cec79790adcde0263960be "Merged SvTreeListBox and SvLBox." Change-Id: I13d8ab413365928749b1c59a0cca0db115b80ffa Reviewed-on: https://gerrit.libreoffice.org/41280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18convert ExtendedWinBits to a single bool flagNoel Grandin6-16/+11
Change-Id: I2ff15a7f485ffdfb78eaabd529d19065faeb4c53 Reviewed-on: https://gerrit.libreoffice.org/41277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18tdf#105538 Download update to Downloads folder on WindowsTakeshi Abe2-6/+8
instead of Desktop. Change-Id: Ib88b23afdd0b836184b7f0a3f501983137a1405d Reviewed-on: https://gerrit.libreoffice.org/40692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-18tdf#109104: respect RFC3986 for newlines in ScEncodeURLJulien Nabet1-1/+8
Quotation of RFC3986: A percent-encoded octet is encoded as a character triplet, consisting of the percent character "%" followed by the two hexadecimal digits representing that octet's numeric value So test the length of the return of OString::number and add "0" if needed ScEncodeURL was added with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=25434372bf56e0ebdb7e7d47ab3c14c68211509f Thank you to Bele (the bugtracker reporter) for code pointer! Change-Id: I8df102eb38b31933c6ebb15bb25c125b423f722b Reviewed-on: https://gerrit.libreoffice.org/41086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-08-18drop unused CntContentTypeItemJochen Nitschke5-259/+0
unused since commit cdae06a664bfc3279bd9f177473357cce316b9b1 Date: Fri Apr 6 11:17:10 2001 +0000 #78400# Template scanning reimplemented using UCB Change-Id: I3e742be5a7c5467628dbe5a19171c4dfcef07c58 Reviewed-on: https://gerrit.libreoffice.org/41274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18Remove dead function declarationStephan Bergmann1-7/+0
Change-Id: I6d54179a9faeda77a3c3672978cfade8408cb835 Reviewed-on: https://gerrit.libreoffice.org/41275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-08-18Rename flag to less generic name to prepare adding more flagsUlrich Gemkow5-11/+15
Change-Id: I27663a42890bbae3279847a7da971cd367335cb3 Reviewed-on: https://gerrit.libreoffice.org/40736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-08-18vcl: DockingManager owns ImplDockingWindowWrappersTakeshi Abe2-27/+12
so simplify code with std::unique_ptr. Change-Id: Ieec470e0a5f52c0d652d169c1ced6ca7307f062f Reviewed-on: https://gerrit.libreoffice.org/41217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18Report full type info (plus the desugared type as "aka")Stephan Bergmann1-1/+1
Change-Id: I647b1c3e479e0be01ed7ea16e1ad3dd9bed9ba6a
2017-08-18loplugin:implicitboolconversion (clang-cl)Stephan Bergmann2-55/+55
...after 2bb282656a19a399a101dbeadf157d10d4d5e4f4 "SalFrame Handle* methods can return bool" Change-Id: I15659eafc27e8402aeb407418e656d546c554f06
2017-08-18loplugin:oncevar (clang-cl)Stephan Bergmann2-3/+2
Change-Id: I118da42ad7a42e4d081fd9901e230a0318a77f73
2017-08-18loplugin:nullptr (clang-cl)Stephan Bergmann1-24/+24
Change-Id: I2d4aea9829cc8057849ba4fb0b8a60b4f4d2054d
2017-08-18loplugin:nullptr (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I8eddd2cb43631d15a04f3edd3cf218232bda45af
2017-08-18loplugin:oncevar (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I36c97d99d268b0ebedfd0eebc4722cabc6e51220
2017-08-18loplugin:oncevar (clang-cl)Stephan Bergmann1-6/+6
Change-Id: I0cbd9a87880070e2c1381ecd385c1fe4c3ad7505
2017-08-18missing include (--disable-pch)Stephan Bergmann1-0/+1
Change-Id: I4e8ae42e2e0c285d34098bebd637ad6d4abaf6a0
2017-08-18loplugin:unreffun (clang-cl)Stephan Bergmann2-11/+7
Change-Id: I6e5789982789adc68a2e003aa6acff57639d5b5d
2017-08-18loplugin:cstylecast (clang-cl)Stephan Bergmann1-2/+2
Change-Id: Id3f66842829a4b86f7980f0c1cbfe6e56e958e9c
2017-08-18-Werror,-Wmissing-field-initializers (clang-cl)Stephan Bergmann1-2/+5
Change-Id: I77b6fb2b9fe8e93f279f29a19f67079f5f81d1b7
2017-08-18-Werror,-Wwritable-strings (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Ic3a23c8290021b4bffe770651269ccf792b7c632
2017-08-18Revert "Related tdf#105500: leaks in PaletteManager and SvxColorToolBoxControl"Noel Grandin2-2/+0
This reverts commit 8c0cc5cd7befffc6e8e6361ba67807a799cc997f. These changes are unnecessary, the compiler already automatically generates the necessary code.
2017-08-18loplugin:unnecessaryparenNoel Grandin36-56/+88
look for statements like return (function()); Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3 Reviewed-on: https://gerrit.libreoffice.org/41260 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18Fix typosAndrea Gelmini12-15/+15
Change-Id: I795059109e23800987cda6f04c58ab18c488ad07 Reviewed-on: https://gerrit.libreoffice.org/41242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-18Fix typosAndrea Gelmini6-6/+6
Change-Id: If13c1408a3e597c6f9b21d209722ef6bc87c0c94 Reviewed-on: https://gerrit.libreoffice.org/41270 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-18NdTopLeft is unused now.Tamás Zolnai6-29/+23
Change-Id: I39184b8fdf666676c21560d39911f6204b0afd52 Reviewed-on: https://gerrit.libreoffice.org/41257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-17Related tdf#111634: Multiple memory leaks in libmacabdrv1 (part3)Julien Nabet2-0/+3
Hope it'll fix leak from https://bugs.documentfoundation.org/show_bug.cgi?id=111634#c13 Change-Id: I61a51faf291145c8cafd03339b7bcc7b23072fba Reviewed-on: https://gerrit.libreoffice.org/41268 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-17tdf#50097: DOCX: export form controls as MSO ActiveX controlsTamás Zolnai29-345/+377
* Use the same structure for export what MSO uses ** Position and size information are exported as VML shape properties ** Different handling of inline and floating controls (pict or object) ** Do some changes on VML shape export to match how MSO exports these controls ** Write out activeX.xml and activeX.bin to store control properties ** Use persistStorage storage type defined in activeX.xml * Drop grabbaging of activex.XML and activeX.bin * Cleanup control related test code Change-Id: I38bb2b2ffd2676c5459b61ec2549c31348bab41c Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/41256 Tested-by: Jenkins <ci@libreoffice.org>
2017-08-17Related tdf#105500: leaks in PaletteManager and SvxColorToolBoxControlJulien Nabet2-0/+2
See comments of the bugtracker for more details Again thank you Alex for very useful information about leaks! Change-Id: I96743e8b167224f1bec73db5f2ba82536c7f23fa Reviewed-on: https://gerrit.libreoffice.org/41265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-17Fix typosAndrea Gelmini87-131/+131
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3 Reviewed-on: https://gerrit.libreoffice.org/41194 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-17drop unused SdrCustomShapeReplacementURLItemJochen Nitschke6-25/+1
no user found at least since 2004 last traceable commit 50a73f5963c4d0ca34629f36cc04e8b45f61bd62 Date: Fri Apr 2 13:07:39 2004 +0000 INTEGRATION: CWS sj05 (1.1.2); FILE ADDED Change-Id: Iaaf80e93ed60611f5e03688f4d95ab0a7d024e79 Reviewed-on: https://gerrit.libreoffice.org/41262 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17EPUB export: handle inline imagesMiklos Vajna7-4/+258
Just the bare minimum, so that the binary file-related member functions of the package interface are triggered, so I can implement them. Change-Id: I996659126667423fded1f89f8097ac726418fa00 Reviewed-on: https://gerrit.libreoffice.org/41261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-17clean xml code in the breeze_svg iconsandreas kainz2752-375701/+20619
Change-Id: I1a7fc0f4978d3a61b4717fcbbc2bd752a401c86e Reviewed-on: https://gerrit.libreoffice.org/41253 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-17these comments no longer validNoel Grandin5-10/+0
Change-Id: I263116383a9342f9600d6cd1622a941afe83634e
2017-08-17Remove excess SAL_WARNsStephan Bergmann1-4/+0
Each such precondition violation for that URE API function would already result in osl_File_E_INVAL anyway. Change-Id: I279949ae8f341e6272bb4574da712fd693461acd
2017-08-17drop unused SdrCustomShapeAdjustmentItemJochen Nitschke18-203/+4
unused since commit 935baf97a926baa50d985808736e0adb8837c716 Date: Tue May 19 09:32:45 2009 +0000 CWS-TOOLING: integrate CWS impress169 Change-Id: I1e8b0285ae1f6e8d92efd3f5a2463ff3126f1a0d Reviewed-on: https://gerrit.libreoffice.org/41248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Drop deprecated SplitWindow configuration settingsGabor Kelemen1-76/+0
These were first marked as deprecated in 2002: https://cgit.freedesktop.org/libreoffice/core/commit/officecfg/registry/schema/org/openoffice/Office/Common.xcs?id=4c25e5b66af5afa507c63947356c4720910a2ad6 Change-Id: I6fb8b48b44d71b85d2cd3406a730f650981b8147 Reviewed-on: https://gerrit.libreoffice.org/40905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-17fix compiler error in passparamsbyrefNoel Grandin1-1/+6
Under clang-3.8 we get: compilerplugins/clang/passparamsbyref.cxx:158:31: error: no member named 'isAssignmentOp' in 'clang::CXXOperatorCallExpr' Change-Id: Icfba2b624f53f07418674237adc5a47819f73c43
2017-08-17odk: oops, typo "have have"Michael Stahl1-1/+1
Change-Id: I3ab67d22985c8023da9db78ee085db07835aa2bf
2017-08-17tdf#107785 odk: document where to download the SDKMichael Stahl1-2/+22
Change-Id: I56368bc7e75671f170cce2360ac093e43b629e66
2017-08-17SmartArt: simplify conditions, miscellaneous changesGrzegorz Araminowicz6-50/+27
Change-Id: I70cc3548a68367b0a5f4cc5f55e55dc2db1e8b27 Reviewed-on: https://gerrit.libreoffice.org/41239 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>