summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-05-11tdf#76258 Various fixes for color filterSamuel Mehrbrodt5-26/+43
Change-Id: Ifb4114597efcb7a957d2e42867d1bdc8abfe7730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115340 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-05-11tdf#84502 CuiConfigGroupListBox Macros,Styles like category for SidebarJim Raykowski19-53/+214
Decks Change-Id: I4d41952547c98ba66c40c1aa1e9776cdf31304c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100455 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-05-11vcl: Don't just return OK when executing a dialog in AndroidTomaž Vajngerl1-8/+0
This was probably "ifdef-ed" out for Android because of some old assumptions and isn't true anymore today. This has prevented that the dialog for macro execution shows up on Android when the document is loading. Change-Id: I662d2deb1520f9a3b421dac05f858488aef825fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115307 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-11lok: move handleMacroConfirmationRequest to its own methodTomaž Vajngerl2-11/+19
Just refactor to make it similar to other requests. Change-Id: I1a76d3d4ecc02b0a223ab8e44b11047455280142 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115306 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-11lok: enable macros by default for AndroidTomaž Vajngerl1-0/+4
This enables macros execution for Android, so the user will be asked to execute macros (assuming the security level is set to 1, which is the default) if the document contains any macros to execute. Change-Id: I34dbd123c5b4ea7386096fd3a21766da3479be6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115305 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-11drawinglayer: move converter.hxx to public includeTomaž Vajngerl4-9/+7
Change-Id: I71a15c532ba161d69585bd47631b3a8e2f6ddd66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115304 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-11tdf#134490: sc_ucalc: Add unittestXisco Fauli2-0/+22
Change-Id: Iac75d72506eceb6d1104f607d32cdf82c68fb566 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115365 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-10speed up SfxExtItemPropertySetInfoNoel Grandin2-15/+44
Change-Id: I7fdf0395c40f1932cfa1fc6ada91accc1912851a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115352 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-10tdf#105650 different strikethrough offset for vertical writing.Mark Hung1-1/+1
Change-Id: I7f1a8753bb00972865625628baeff76ff5dc4699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115015 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-05-10vcl: use DWriteTextRenderer for vertical writing.Mark Hung4-80/+10
It's really not possible to support vertical writing with old ExTextOutW API, use DWriteTextRenderer in this case. This also get rid of the hacks to prepend '@' in front of the font name when it's for vertical writing. Change-Id: Icf594dd248be35fb101d6c1e296971f1acf56e39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115017 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-05-10tdf#138209 ODF export: work around forms problem in LO < 7.0Michael Stahl24-103/+199
LO without commit 519d96fd8b83ef4c61576d87b58f97b7e6e6e3c6 makes a mess when storing form documents it has loaded from ODF 1.3 documents: the XML parts are stored as ODF 1.2, but the storage (and therefore manifest entry) keeps version 1.3. To avoid this, store form documents as ODF 1.2 extended by default. Unfortunately a bunch of ODF export code accesses the global SvtSaveOptions variable; with this version override, only SvXMLExport::getSaneDefaultVersion() must be used. Change-Id: I5fa8e286f5103c578ed0d93da07a8a6cbe2f0ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115357 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-05-10gtk4: GtkPopoverMenu doesn't have "deactivate", try "closed"Caolán McNamara1-0/+5
Change-Id: Ia14944468ebe743999d8c283b96f60352589f82e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115351 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: use gdk_wayland_toplevel_set_application_id for dynamic icon changingCaolán McNamara1-6/+8
Change-Id: Ie1f903a9fa8bfdb94ec3fc0409b350a3e73c444d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115350 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: gtk_im_context_set_client_window->gtk_im_context_set_client_widgetCaolán McNamara1-3/+7
Change-Id: I21d3cd5daf77264f08c6864425c6d9ff37404325 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115349 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: use gtk_window_minimize to replace gtk_window_iconifyCaolán McNamara1-5/+10
Change-Id: I6c50e6f60e24dd5bd93e1ef5f62f3cd3845f9194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: GDK_WINDOW_STATE_WITHDRAWN is goneCaolán McNamara1-1/+5
Change-Id: Ibeca97ca0ac849d69b3b32db6d6f27da7cf551b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115347 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: add some degree of support for minimized/maximized/default sizeCaolán McNamara2-29/+25
so we start up maximized instead of just a titlebar that needs to be expanded Change-Id: I60c8cdd22c5b2bb659ae10806ccde27e964d6733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115342 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10reduce frequency of dynamic_castNoel Grandin1-1/+3
by checking cheaper things first Change-Id: I0c93021966ee09967f0ce2e265adafb279b669bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115356 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-10reduce cost of locking in SvtModuleOptionsNoel Grandin1-17/+19
Change-Id: If9e0c275822b733d339845d16edfbc5942b4aa6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-10upload libmwaw 0.3.19David Tardon6-35/+8
Change-Id: Ibb26390e6cc13c925f499bf95cfc6177d8c9b735 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115355 Tested-by: Jenkins Reviewed-by: David Tardon <dtardon@redhat.com>
2021-05-10Test Kahan Sum. Will check Kahan sum stills work properly.dante1-0/+7506
This test file contains summations wich won't work with a raw sum. However Kahan Summation can give a correct output. Change-Id: I6fb3ded287414e8a99964b838c63f52f9262576e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115256 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-10Resolves: tdf#142186 Accept 123.45 fractional input on weird formats like 0"."Eike Rathke1-5/+23
... or 0"."0 where the literal "." is also the decimal separator but can only occur in the integer part. Change-Id: I95093fdddf7759346f2869ee322222de3d130e55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115338 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-05-10update leak-suppressNoel Grandin1-0/+3
with some CPPUNIT stuff that is being deliberately leaked Change-Id: I7e3e3090877394f05e5bc9f270c456de7e7c57f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115333 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-10gtk4: add focus-in/outCaolán McNamara2-1/+56
Change-Id: Ia954b2b1cc0ea368a318549f39e2efab42a0ebb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115339 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: get the event state into the button press/releaseCaolán McNamara2-47/+44
Change-Id: I85b7e64cf8216a7abf18432bbf7bf659876ee07a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115337 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: add crossing eventsCaolán McNamara2-12/+41
Change-Id: I80adcb946a3f76b7a20fad381667a445e5927566 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: get motion eventsCaolán McNamara2-18/+40
Change-Id: I44f28891015cadf3714dbecd48bad73296d78b53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115335 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: add gesturePressed/gestureReleased support for basic clicksCaolán McNamara2-1/+53
some unknowns here still, but gets some clicks working Change-Id: Ib97a3b70baba5bcce70b71b6d030a1ad2a591724 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115331 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: enable the existing longpress and swipe gesturesCaolán McNamara2-12/+19
for what limited amount of use they have Change-Id: I86f35fde191c0864cdfe9b56176bd71bd488bc1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115330 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: new close-request looks equivalent to old delete-eventCaolán McNamara2-5/+24
Change-Id: I4176de9e8eb2029979f478e4a32e25e0314c7d99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115329 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: use GDK_ALT_MASKCaolán McNamara2-12/+5
define GDK_ALT_MASK as GDK_MOD1_MASK for gtk3 Change-Id: Iff6340956b83403af37b0416a234b6937f1bea18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115328 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10tdf#141613 sw: avoid possible crash when undoing header creationDaniel Arato (NISZ)2-3/+6
Move the ClearRedo() call to the very end of the undo process in order to avoid heap use after free. We still need to call ClearRedo() because there's no mechanism in place to Redo a header/footer change. Regression from commit 65e52cb61d74b0c71b45b63b2da131bc6b621104 "tdf#141613 sw: fix crash at header/footer undo". Change-Id: Ibd4604379c9791e85aef3d4dc6c29c9e3ecd5a28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115275 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-10gtk4: enable signalTooltipQueryCaolán McNamara2-4/+4
Change-Id: Ida3593b1e6ecc98425342f9059f0dcd65901823c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: enable signalMap and signalUnmapCaolán McNamara2-14/+56
Change-Id: I614296cfc2ccf78e45a9b9df04977c938e47dff4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115326 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: enable partial signalRealizeCaolán McNamara2-2/+6
Change-Id: I17bc5d5c0250aea6852e9e82e3742fece4966b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115325 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10svx: fix crash with active text edit vs slide deleteMiklos Vajna3-0/+56
The problem is that SdrObjEditView::HideSdrPage() may delete SdrPaintView::mpPageView when it calls SdrGlueEditView::HideSdrPage(). But SdrObjEditView::pTextEditPV is a non-owning reference to that. GetTextEditBackgroundColor() in svx/ calls SdrObjEditView::GetTextEditPageView(), so in case SdrObjEditView::pTextEditPV is not cleared, we would access a deleted SdrPageView. Change-Id: I948bae8e0e8d557e38aa8f243e9eea522b21a043 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115324 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-10fix some leaks in basicNoel Grandin21-114/+111
Change-Id: I52c10cdbe9661974c908ee052336c779a40de402 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115323 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-10I suspect that we unlikely to use JRE older than 1.3.1_07Mike Kaganski2-48/+5
... and so possibly can rely on -Dfile.encoding=UTF8 now. This reverts 79ac0685de0b19d856db70a208a8372cb589646c and 3428bace79d64a10cfcabb79e4caa608ee5db233. Change-Id: Ia9e09025691b200c0f79427e0f4efe500f9c81f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115272 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-10tdf#142130 sw track changes: fix crossing out of neighboring imagesLászló Németh5-7/+82
Normal images got crossing out from the next deleted images. Fix it by using only the start position of the image in CheckLine() instead of the 1-character length range of the anchor point. Note: add unit test also for tdf#78864. Follow-up to commit d845b91bcc6eb885c55494d4d4fab4ec09577e1d (tdf#78864 sw track changes: cross out deleted images). Change-Id: I8894e625d479adea4b1003f55f24f292064ed7ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115255 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-10gtk4: enable signalDestroyCaolán McNamara2-4/+5
Change-Id: Idd15db9c8666887818a6a119ee796db86fd1482f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115320 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: implement drawing and resizingCaolán McNamara2-17/+65
now we can see something Change-Id: I428354ce382bb4dbf163309b80316488436b027c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115319 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: fill in getXScreenFromDisplayScreenCaolán McNamara1-8/+8
for whatever that's still worth Change-Id: I0be6ccfe6260b9b9f07922293a6654a12a181cdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115318 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: implement GetDisplayScreenCountCaolán McNamara2-6/+8
Change-Id: I23cb4607da4ec4bbe1a8dac0484b269a919011a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115317 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: get monitor sizeCaolán McNamara1-7/+10
Change-Id: I833fbb041c97b10cdca57b21aa7c467a7add646a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115316 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10change <No selection possible> to avoid getting identified as an xml tagCaolán McNamara1-1/+1
Failed to set text '<No selection possible>' from markup due to error parsing markup: Error on line 1 char 23: Odd character “p”, expected a “=” after attribute name “selection” of element “No” Change-Id: I8567862cb0f746529bcaa370e61a423dc9f646b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115313 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: get toplevel menubar and menus workingCaolán McNamara3-21/+21
with gtk_popover_menu_bar_new_from_model doesn't look great, long menus don't seem to scroll or anything like that, but the entries do work Change-Id: I69d6c324b9fe556067ded9acdf1af574ed784a09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115312 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10tdf#127301 XLSX import: hide hidden named range of autofilterBalazs Varga5-18/+45
Create but not insert/add hidden FILTER_CRITERIA (_xlnm._FilterDatabase) to ScRangeName, because no need for them, so avoid of creating extra named ranges by autofilter re-range (shown in Sheet -> Named Ranges and Expressions -> Manage...). See also commit 3a2263a20629b0a3e9b4935dd43dc59817d0241c "mib17: #163146# XLS import: do not skip hidden names[...]". Change-Id: Ibfd86942a99b251a59394955bc890e6dbe0390f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115189 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-10tdf#137679 Use KahanSum for SSE2dante1-6/+46
Change-Id: I97970cbb7a9562081f9a84b1d81423c80ed7f7f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115113 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-10sc_mathematical_functions: Add test for 9a71644aa475a6090f6Xisco Fauli1-0/+24
Change-Id: Ibf4b5b163b9b9ec123597cf99395a02e25a56be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115315 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-10tdf#124457 PPTX animation: export repeatCountTibor Nagy3-1/+43
Aanimation timing property "repeatCount" wasn't exported. Note: PPTX uses a 1000 multiplication in repeatCount to support fractional movement of animated objects, e.g. 1500 means one and a half steps. Change-Id: Iac0dd10007c3e48f06c131d61671e1f78cad45a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115138 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>