summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-06-23tdf#141709: Use poppler_dataMichael Warner12-3/+413
Bundle the files from poppler_data and provide the path to them to poppler when the bundled poppler library is used. Change-Id: I13a2ef861303a0be17aa0a861ef8ac96ed8a93be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117523 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-06-23disable ligatures for monospace fontsCaolán McNamara1-0/+6
we don't want e.g. a ffi ligature for Courier/Nimbus Mono PS Change-Id: I292c6e2ea217b511b4affcd8dab4a4bda85ab5da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117669 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-23optimised FindFormatByName for SwFrameFormatsNoel Grandin10-28/+46
by re-arranging the boost::multi_index key, we can re-use that index to find all formats matching a name Change-Id: I3b3b6ceb7137926be3981578a64052f47f279af0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117676 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-23Add LayoutMode cppunit test to vcl.panoskorovesis3-3/+50
The test sets two LayoutModes (using ComplexTextLayoutFlags) and checks their attributes. Change-Id: Id765c150485c6f06c1326498a7f1b40b8f9c12fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117575 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-23Add TextLanguage cppunit test to vcl.panoskorovesis3-3/+43
The test sets two languages for the metafile and checks their attributes. Change-Id: Ibb23c03af48af5c40ea65593917a40a928fd1280 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117368 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-23Add Font cppunit test to vcl.panoskorovesis3-2/+40
The test creates a Font, sets custom attributes for it and then tests them. Change-Id: Ib1427392674c7728180e1ad00621e56950d495ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117155 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-23Add Comment cppunit test to vcl.panoskorovesis4-3/+59
The test creates two MetaCommentActions from the GDIMetafile and checks their attributes and contents. Change-Id: I748a6fa5dcf0dc09359fb48ea0bf3d7ceef3dbcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117245 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-23Remove unused DOCTYPE from odk/examples xcu fileStephan Bergmann1-4/+0
The declared entities have apparently never been referenced ever since the file's introduction in 9fa09d43d0dc0ec0ac71bad31b85ce7fc302ee90 "INTEGRATION: CWS sdkinspector2". (And at least xmlreader skips and ignores the content of such document type declarations anyway.) Change-Id: I8263200f52bb5f1692090995574619f9c0ec478f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117658 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-23move BufferedDecompositionPrimitive2D impl. into its own fileTomaž Vajngerl3-24/+57
Change-Id: I180ed5378765237f69ccf721448dd799df2b457b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117666 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-22uitest: guard create_doc_in_start_centerXisco Fauli281-15090/+14366
Mostly done by a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I75ef7712af3676363a9a464acf83f6f68ffc4f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117617 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-22Move SwDoc::FindFormatByName to SwFormatsBaseNoel Grandin7-33/+48
in preparation for adding optimised implementations of it for subclasses Change-Id: I6d8ff54864d2d3c605a1cd0b4da2c6136e2a21cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117672 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-22SwFrameFormats::rangeFind does not, in fact return a rangeNoel Grandin3-34/+27
because the index it relies on, is a unique index. So make this explicit in the method call by returning a normal iterator. Change-Id: I428d1b14d1274079955eb4f893ca91d1745264e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117673 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-22Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to a8dd66b4bf752c09980dbffcbbc8a055432d28ed - Mute l10n and small cosmetic changes Change-Id: Id20d7dbba5a835f713945a1d994739dc116cdcef Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117642 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-22uitest: fix buildXisco Fauli1-20/+19
regression from 1e7bf688967dc39540d24070c70c73b06bd1347f < tdf#142851 Chart UI: fix empty Chart Type dialog > self.ui_test.load_file was changed in be0a41679fea524e0935dc6617b5e65349812dd1 < uitest: guard load_file > Change-Id: I00cb5dc6e1213403f2eba5bc4b9dc0e876118536 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117670 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-22ScriptForge - (SF_UI) CreateBaseDocument() new CalcFileName argumentJean-Pierre Ledure2-9/+32
Syntax of CreateBaseDocument() becomes FileName, [EmbeddedDatabase=HSQLDB|FIREBIRD|CALC], [RegistrationName=""], [CalcFileName] Only when EmbedddedDatabase = "CALC", the new argument CalcFileName represents the file containing the tables as Calc sheets. The file must exist or an error is raised. Example: Dim myBase As Object, myCalcBase As Object Set myBase = ui.CreateBaseDocument("C:\Databases\MyBaseFile.odb", "FIREBIRD") Set myCalcBase = ui.CreateBaseDocument("C:\Databases\MyCalcBaseFile.odb", _ "CALC", , "C:\Databases\MyCalcFile.ods") Both Basic and Python are supported. Change-Id: I9912b110dcec12fe451a47abb61ab143fb543b94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117665 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-06-22tdf#106541 doc import: prevent inheriting when LFO == 0Justin Luth2-2/+8
When LFO == 0, that is a special case that means that numbering should be disabled. (This can similarly be accomplished by setting Lvl to 9 - Body text, except doing so here could mess up Lvl inheritance). If the LFO is a negative number, that indicates something different with formatting that we don't currently handle, but it still means cancel numbering. So at this point just treat them all the same as if they were LFO 0. Change-Id: I1bab06c6b766175a3982bf3a7b19f7b321df807e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117480 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-06-22Avoid crash getting default item for OWN_ATTR_TEXTCOLUMNSMike Kaganski1-0/+21
... as seen in https://dev-builds.libreoffice.org/crashtest/89459662bf2684a07596d4132c84e5da7e0af8d4/backtraces/task908-core.backtrace.txt ... #8 0x00007fb81c9674f2 in Application::Abort(rtl::OUString const&) (rErrorText="") at /home/buildslave/source/libo-core/vcl/source/app/svapp.cxx:274 #9 0x00007fb8226aa127 in desktop::Desktop::Exception(ExceptionCategory) (this=0x7ffdf0d856d0, nCategory=<optimized out>) at /home/buildslave/source/libo-core/include/rtl/ustring.hxx:181 bInException = true nOldMode = <optimized out> rArgs = <optimized out> bRestart = <optimized out> bAllowRecoveryAndSessionManagement = <optimized out> #10 0x00007fb81c97ca5a in VCLExceptionSignal_impl(void*, oslSignalInfo*) (pInfo=<optimized out>) at /home/buildslave/source/libo-core/vcl/source/app/svmain.cxx:169 nOldMode = SystemWindowFlags::DIALOG pSVData = 0x7fb81d423300 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance> aLock = {m_isAcquired = true, m_isChecked = true, m_rSolarMutex = @0x5612f7423da0} bIn = true nVCLException = <optimized out> #11 0x00007fb82282d1a7 in callSignalHandler(oslSignalInfo*) (pInfo=pInfo@entry=0x7fb80a196af0) at /home/buildslave/source/libo-core/sal/osl/all/signalshared.cxx:59 pHandler = 0x5612f826c2d0 Action = <optimized out> #12 0x00007fb82289e5a8 in (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) (signal=6, info=0x7fb80a196cf0, context=0x7fb80a196bc0) at /home/buildslave/source/libo-core/sal/osl/unx/signal.cxx:451 Info = {Signal = osl_Signal_AccessViolation, UserSignal = 6, UserData = 0x0} #13 0x00007fb8224d6840 in <signal handler called> () at /lib/x86_64-linux-gnu/libc.so.6 #14 0x00007fb8224d67bb in raise () at /lib/x86_64-linux-gnu/libc.so.6 #15 0x00007fb8224c1535 in abort () at /lib/x86_64-linux-gnu/libc.so.6 #16 0x00007fb8224c140f in () at /lib/x86_64-linux-gnu/libc.so.6 #17 0x00007fb8224cf102 in () at /lib/x86_64-linux-gnu/libc.so.6 #18 0x00007fb81f72434c in SfxItemPool::GetDefaultItem(unsigned short) const (this=0x5612f8e2ec00, nWhich=<optimized out>) at /home/buildslave/source/libo-core/svl/source/items/itempool.cxx:728 __PRETTY_FUNCTION__ = "const SfxPoolItem& SfxItemPool::GetDefaultItem(sal_uInt16) const" nPos = <optimized out> pDefault = <optimized out> #19 0x00007fb81f724326 in SfxItemPool::GetDefaultItem(unsigned short) const (this=0x5612f8869790, nWhich=4006) at /home/buildslave/source/libo-core/svl/source/items/itempool.cxx:727 __PRETTY_FUNCTION__ = "const SfxPoolItem& SfxItemPool::GetDefaultItem(sal_uInt16) const" nPos = <optimized out> pDefault = <optimized out> #20 0x00007fb80de6cc2e in SdStyleSheet::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) (this=0x5612f89d3940, aPropertyName=..., aValue=uno::Any("com.sun.star.text.XTextColumns": {<com::sun::star::uno::XInterface> = {_vptr.XInterface = 0x5612f89006c0}, <No data fields>})) at /home/buildslave/source/libo-core/include/svl/style.hxx:257 aGuard = {<osl::Guard<comphelper::SolarMutex>> = {pT = 0x5612f7423da0}, <No data fields>} pEntry = 0x7fb80e7252e8 <GetStylePropertySet()::aFullPropertyMap_Impl+1992> rStyleSet = SfxItemSet of pool 0x5612f8869790 with parent 0x0 and Which ranges: [(1000, 1012), (1014, 1033), (1047, 1056), (1068, 1091), (1093, 1124), (1174, 1229), (4007, 4058)] = {1000 = 0x0, 1001 = 0x0, 1002 = 0x0, 1003 = 0x0, 1004 = 0x0, 1005 = 0x0, 1006 = 0x0, 1007 = 0x0, 1008 = 0x0, 1009 = 0x0, 1010 = 0x0, 1011 = 0x0, 1012 = 0x0, 1014 = 0x0, 1015 = 0x0, 1016 = 0x0, 1017 = 0x0, 1018 = 0x0, 1019 = 0x0, 1020 = 0x0, 1021 = 0x0, 1022 = 0x0, 1023 = 0x0, 1024 = 0x0, 1025 = 0x0, 1026 = 0x0, 1027 = 0x0, 1028 = 0x0, 1029 = 0x0, 1030 = 0x0, 1031 = 0x0, 1032 = 0x0, 1033 = 0x0, 1047 = 0x0, 1048 = 0x0, 1049 = 0x0, 1050 = 0x0, 1051 = 0x0, 1052 = 0x0, 1053 = 0x0, 1054 = 0x0, 1055 = 0x0, 1056 = 0x0, 1068 = 0x0, 1069 = 0x0, 1070 = 0x0, 1071 = 0x0, 1072 = 0x0, 1073 = 0x0, 1074 = 0x0, 1075 = 0x0, 1076 = 0x0, 1077 = 0x0, 1078 = 0x0, 1079 = 0x0, 1080 = 0x0, 1081 = 0x0, 1082 = 0x0, 1083 = 0x0, 1084 = 0x0, 1085 = 0x0, 1086 = 0x0, 1087 = 0x0, 1088 = 0x0, 1089 = 0x0, 1090 = 0x0, 1091 = 0x0, 1093 = 0x0, 1094 = 0x0, 1095 = 0x0, 1096 = 0x0, 1097 = 0x0, 1098 = 0x0, 1099 = 0x0, 1100 = 0x0, 1101 = 0x0, 1102 = 0x0, 1103 = 0x0, 1104 = 0x0, 1105 = 0x0, 1106 = 0x0, 1107 = 0x0, 1108 = 0x0, 1109 = 0x0, 1110 = 0x0, 1111 = 0x0, 1112 = 0x0, 1113 = 0x0, 1114 = 0x0, 1115 = 0x0, 1116 = 0x0, 1117 = 0x0, 1118 = 0x0, 1119 = 0x0, 1120 = 0x0, 1121 = 0x0, 1122 = 0x0, 1123 = 0x0, 1124 = 0x0, 1174 = 0x0, 1175 = 0x0, 1176 = 0x0, 1177 = 0x0, 1178 = 0x0, 1179 = 0x0, 1180 = 0x0, 1181 = 0x0, 1182 = 0x0, 1183 = 0x0, 1184 = 0x0, 1185 = 0x0, 1186 = 0x0, 1187 = 0x0, 1188 = 0x0, 1189 = 0x0, 1190 = 0x0, 1191 = 0x0, 1192 = 0x0, 1193 = 0x0, 1194 = 0x0, 1195 = 0x0, 1196 = 0x0, 1197 = 0x0, 1198 = 0x0, 1199 = 0x0, 1200 = 0x0, 1201 = 0x0, 1202 = 0x0, 1203 = 0x0, 1204 = 0x0, 1205 = 0x0, 1206 = 0x0, 1207 = 0x0, 1208 = 0x0, 1209 = 0x0, 1210 = 0x0, 1211 = 0x0, 1212 = 0x0, 1213 = 0x0, 1214 = 0x0, 1215 = 0x0, 1216 = 0x0, 1217 = 0x0, 1218 = 0x0, 1219 = 0x0, 1220 = 0x0, 1221 = 0x0, 1222 = 0x0, 1223 = 0x0, 1224 = 0x0, 1225 = 0x0, 1226 = 0x0, 1227 = 0x0, 1228 = 0x0, 1229 = 0x0, 4007 = 0x0, 4008 = 0x0, 4009 = 0x0, 4010 = 0x0, 4011 = 0x0, 4012 = 0x0, 4013 = 0x0, 4014 = 0x0, 4015 = 0x0, 4016 = 0x0, 4017 = 0x0, 4018 = 0x0, 4019 = 0x0, 4020 = 0x0, 4021 = 0x0, 4022 = 0x0, 4023 = 0x0, 4024 = 0x0, 4025 = 0x0, 4026 = 0x0, 4027 = 0x0, 4028 = 0x0, 4029 = 0x0, 4030 = 0x0, 4031 = 0x0, 4032 = 0x0, 4033 = 0x0, 4034 = 0x0, 4035 = 0x0, 4036 = 0x0, 4037 = 0x0, 4038 = 0x0, 4039 = 0x0, 4040 = 0x0, 4041 = 0x0, 4042 = 0x0, 4043 = 0x0, 4044 = 0x0, 4045 = 0x0, 4046 = 0x0, 4047 = 0x0, 4048 = 0x0, 4049 = 0x0, 4050 = 0x0, 4051 = 0x0...} aSet = SfxItemSet of pool 0x5612f8869790 with parent 0x0 and Which ranges: [(4006, 4006)] = {4006 = 0x0} #21 0x00007fb81945d8eb in SvXMLImportPropertyMapper::FillPropertySet_(std::__debug::vector<XMLPropertyState, std::allocator<XMLPropertyState> > const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySetInfo> const&, rtl::Reference<XMLPropertySetMapper> const&, SvXMLImport&, ContextID_Index_Pair*) (rProperties=std::__debug::vector of length 3, capacity 4 = {...}, rPropSet=uno::Reference to (class SdStyleSheet *) 0x5612f89d3ad0, rPropSetInfo=uno::Reference to (class SfxItemPropertySetInfo *) 0x5612f8938ed8, rPropMapper=rtl::Reference to 0x5612f89a1900, rImport=..., pSpecialContextIds=pSpecialContextIds@entry=0x7fb80a1978b0) at /home/buildslave/source/libo-core/include/com/sun/star/uno/Reference.h:384 rProp = @0x5612f8497590: {mnIndex = 54, maValue = uno::Any("com.sun.star.text.XTextColumns": {<com::sun::star::uno::XInterface> = {_vptr.XInterface = 0x5612f89006c0}, <No data fields>})} nIdx = 54 rPropName = "TextColumns" nPropFlags = 201342976 i = 1 bSet = false nCount = <optimized out> #22 0x00007fb8194650c6 in SvXMLImportPropertyMapper::FillPropertySet(std::__debug::vector<XMLPropertyState, std::allocator<XMLPropertyState> > const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, ContextID_Index_Pair*) const (this=0x5612f8fa4960, aProperties=std::__debug::vector of length 3, capacity 4 = {...}, rPropSet=uno::Reference to (class SdStyleSheet *) 0x5612f89d3ad0, pSpecialContextIds=pSpecialContextIds@entry=0x7fb80a1978b0) at /home/buildslave/source/libo-core/xmloff/source/style/xmlimppr.cxx:466 xInfo = uno::Reference to (class SfxItemPropertySetInfo *) 0x5612f8938ed8 xMultiPropSet = empty uno::Reference bSet = <optimized out> xTolPropSet = empty uno::Reference ... Change-Id: Icdb32ff5383a8073f525aad1a39ff1dcc70559f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117661 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-22tdf#142851 Chart UI: fix empty Chart Type dialogTünde Tóth3-1/+40
Chart Type dialog was empty, when the chart type of the chart was unsupported. Regression from commit: 4ff983b930dc15658aa531759d3f1e5b9586aeab (Related: tdf#142049 restore some elements default visibility in the ui) Change-Id: I057e6b9218edee398af8311c46b922ca76a9bcb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117173 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-22Clarify no loplugin:overridevirtual with templated base classStephan Bergmann2-0/+45
Change-Id: I4128b43f2a928fa5465991cc92b2d62e54e2cfec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117662 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-22Resolves: tdf#140361 use the DisableEditHyperlink state as of menu launch timeCaolán McNamara8-4/+85
at context menu popup time set if the EditHyperlink entry should be disabled and use that state if queried about it if EditHyperlink is dispatched from the menu. So ignoring where the mouse currently happens to be when the menu was dismissed. The dispatch is done async, if at all, so also trigger an async Query with Invalidate so at least one Query is ensured to reset the stored state similar to tdf#137445 which was for impress/draw Change-Id: I43a144f1ac0a4db89cc5ab0ebeeae744719f5958 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117653 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-22reduce allocation in ZipContentInfo mapNoel Grandin10-87/+67
This is a small struct, no sense in allocating it separately Change-Id: I709daebbde648a79f175f74c207bdf4871ae6ff1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117604 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-22uitest: guard load_fileXisco Fauli189-10293/+9865
Mostly done by a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: Ia924293dc2a12230fd13f69fd734875ced86be8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117593 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-22configure: Improve help-options handlingJan-Marek Glogowski24-112/+223
This patch includes: * A README.help.md as a general documentation for the different help types, the LO code and help-related build options. * Adds --disable-xmlhelp for removing the xmlhelp support from the build. Disable for iOS, Android and Emscripten. This was partly included in HAVE_FEATURE_DESKTOP before. * Rename WITH_HELP define to WITH_HELPPACKS, which reflects the actual usage AFAIK. * Depend --with-omindex on --with-help=online and don't override the --with-help setting. Error out on conflicting options. * Depend --with-helppack-integration on build help variants, which actually result in help packs. Kind of reverts commit 2c38ea6d16b910294220cefaf8ae6a0683e6405a ("Building without --with-help is not supposed to disable help functionality"). Change-Id: Ie4cb73905b3ed94e991d9f1bd75cfbd6de9da385 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116222 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-22fix indentCaolán McNamara1-8/+7
Change-Id: I0a7e43906522462c6bbf9aaec89d296e5017a3a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-22Update git submodulesRafael Lima1-0/+0
* Update helpcontent2 from branch 'master' to 3c0fb9a710915c30adf5287a734a185696fa0b76 - Add note about Python support availability on some SF services Change-Id: I226b0b92fcc2b380fa6687cba87276b485009151 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117567 Tested-by: Jenkins Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-22configure: make OpenLDAP test independent from X11Jan-Marek Glogowski1-3/+5
I missed that PostgreSQL can be build on MacOSX with OpenLDAP support. Stephan had an incremental build failure because of it. But instead of opting-in using test_openldap=yes on MacOSX, like on Haiku, this drops the using_x11 dependency and defaults to "yes", like it was before. This was more of a convenience then reality anyway, and it makes really not much sense to disable OpenLDAP in case of --without-x. Change-Id: I959a3b30f1c369264174302f18267a4eb40a3a52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117046 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-22Update git submodulesSteve Fanning1-0/+0
* Update helpcontent2 from branch 'master' to 26fad1c72fdc6a72b455c44e57b5738ee6d1a61d - Provide a correct example within the help for Calc's FINDB function. Change-Id: Ibff7dd5bf47f26c431b1ce49e6ac5250f6192176 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117569 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-22crashtesting: assert on export of tdf105134-1.docx to odtCaolán McNamara1-14/+17
when interactively saving on creating preview for recently used Change-Id: I9d859cf404c34659653a14f8c2a94f867c704b7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117616 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-22svp: always release SolarMutex on yieldJan-Marek Glogowski1-6/+6
Always give other threads a chance to acquire the SolarMutex, if we yield. Change-Id: I77d93374ea606acd1f7820755197a27655418639 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117454 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-22cid#1486261 Dereference before null checkCaolán McNamara1-1/+1
since... commit 2e6e87decdb87221a7b832958e03195b1d8fc133 Date: Mon Jun 21 13:18:00 2021 +0200 replace dynamic_cast<SwLayoutFrame> with cheaper check Change-Id: I4623e3eca5a82fa37f52697c189310a835fc76e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-22cid#1486260 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I12613ed381e961fd36348eabd543b11a1960337d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117613 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-22cid#1486241 'Constant' variable guards dead codeCaolán McNamara2-39/+0
Change-Id: Ia90e8ad537fccdf38ed0bf0e9f963033c69ec202 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117612 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-22tdf#142932: fix crash when pasting cells with comments+"skip empty cells"Julien Nabet1-1/+2
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=173011 4 0x00007fc4b0cdbb3d in ScColContainer::operator[](unsigned long) (this=0x872e1e0, nIndex=64) at sc/inc/colcontainer.hxx:43 5 0x00007fc4b120d82b in ScTable::DeleteBeforeCopyFromClip(sc::CopyFromClipContext&, ScTable const&, sc::ColumnSpanSet&) (this=0x872e1e0, rCxt=..., rClipTab=..., rBroadcastSpans=...) at sc/source/core/data/table7.cxx:118 6 0x00007fc4b0e42939 in ScDocument::DeleteBeforeCopyFromClip(sc::CopyFromClipContext&, ScMarkData const&, sc::ColumnSpanSet&) (this=0x3bffa60, rCxt=..., rMark=..., rBroadcastSpans=...) at sc/source/core/data/document10.cxx:75 7 0x00007fc4b0e0b67b in ScDocument::CopyFromClip(ScRange const&, ScMarkData const&, InsertDeleteFlags, ScDocument*, ScDocument*, bool, bool, bool, bool, ScRangeList const*) (this=0x3bffa60, rDestRange=..., rMark=..., nInsFlag=7, pRefUndoDoc=0x0, pClipDoc=0x7d3bb40, bResetCut=true, bAsLink=false, bIncludeFiltered=false, bSkipAttrForEmpty=true, pDestRanges=0x7fff4a3da4b0) at sc/source/core/data/document.cxx:2916 8 0x00007fc4b2412dc3 in ScViewFunc::PasteFromClip(InsertDeleteFlags, ScDocument*, ScPasteFunc, bool, bool, bool, InsCellCmd, InsertDeleteFlags, bool) (this= 0x41a29e0, nFlags=7, pClipDoc=0x7d3bb40, nFunction=ScPasteFunc::NONE, bSkipEmpty=true, bTranspose=false, bAsLink=false, eMoveMode=INS_NONE, nUndoExtraFlags=InsertDeleteFlags::NONE, bAllowDialogs=true) at sc/source/ui/view/viewfun3.cxx:1312 Change-Id: Ic119cb5d414a35a9ba18b0564d7adf83154eb9d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-22no need to make copies of these map entriesNoel Grandin1-7/+17
Change-Id: Ie65cbacd2806a2c030b682f8cfd473676c4f95c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117605 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-22Adapt compilerplugins to llvm::sys::fs::OF_None renameStephan Bergmann2-1/+8
...from F_None, which happened with <https://github.com/llvm/llvm-project/commit/1f67a3cba9b09636c56e2109d8a35ae96dc15782> "[FileSystem] Split up the OpenFlags enumeration" towards LLVM 7, originally leaving the alternative F_None spelling in for compatibility, but which was finally removed now with <https://github.com/llvm/llvm-project/commit/3302af9d4c39642bebe64dd60a3aa162fefc44b2> "Support: Remove F_{None,Text,Append} compatibility synonyms, NFC". Change-Id: Iea1192b5ee351c13ea5d6701887f3aba62133c20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117609 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-22simplify and improve WildcardNoel Grandin2-10/+9
it is faster to just process OUString data, rather than perform expensive conversion to OString and back again. Change-Id: Ie007b872ee507ac5c6e8b55cc0a49ef3ac1f0139 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117608 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21gtk4: some initial dnd effortCaolán McNamara1-7/+53
Change-Id: I964afbf30c75b6d8e0c31ce7fcb536814acf05b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21gtk4: reenable some more working dialogsCaolán McNamara1-0/+4
Change-Id: I373b9260287b229f4f3092b4c27199c2a55ea23d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21gtk4: GtkPicture triggers some sort of unexplained vertical expandCaolán McNamara1-72/+138
an intermediate horizontal GtkBox works to stop the propogation Change-Id: I9fd51c3968c463c7b872b7a12bc3960602d0b025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117596 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-21loplugin:finalclasses in sc/.../filter/incNoel Grandin18-76/+63
Change-Id: Ibaaff4cf3c7a60714f73c7f1b40a5e857060f26c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21loplugin:finalclasses in sc/incNoel Grandin14-31/+29
Change-Id: I818a5dda788fd15a718914fb05f23e5225dce1c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117588 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21create SfxHintId::SwLegacyModify idNoel Grandin51-105/+147
to avoid expensive dynamic_casts in writer Change-Id: Ic73ae7d4af985043f8533913b33939e3445ec7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117586 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 23b0b440515592c9b9ed2fe8e64783ea55375375 - tdf#140446 VBA constants for variable type see /core/oovbaapi/ooo/vba/VbVarType.idl and comment#3 in tdf#140446 Change-Id: Ib2a9743cfb1b636d1c016c8707872c291ef685f6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117598 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-21Update git submodulesAlain Romedenne1-0/+0
* Update helpcontent2 from branch 'master' to ff452e27c1c7f420d8a0cf8a9d82d1d318225d46 - ScriptForge method signatures Change-Id: I5c29d5c08a8c5bd46ca45dc1d17449a0ae4789b8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116910 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-06-21related tdf#81705 doc export: eliminate duplicating OutlineNumberingJustin Luth1-11/+2
It just looks redundant. And all three formats handle it very different. RTF - never writes RES_PARATR_OUTLINELEVEL or RES_PARATR_NUMRULE in styles, only via this OutlineNumbering. DOCX does nothing. That's because there always seems to be a RES_PARATR_OUTLINELEVEL and RES_PARATR_NUMRULE. DOC does BOTH. It writes RES_PARATR_NUMRULE (and now also writes RES_PARATR_OUTLINELEVEL) and also writes them via OutlineNumbering. So OutlineNumbering seems to always have been partially redundant and now is fully redundant. Thus it can be treated like DOCX. Change-Id: Ib9fd32c440e0151b462d6499a60952f120887082 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113452 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-06-21replace dynamic_cast<SwCellFrame> with cheaper checkNoel Grandin3-34/+42
Change-Id: I672be703fb097c71303434127d832681843607e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117580 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21tdf#135316 remove OTempFileService pessimisationNoel Grandin6-261/+116
Closing the temp file when we read to the end, and then opening it again later actually is quite expensive, just leave it open. This takes my load time from 22s to 19s Also clean up the unit-test that failed, so that I can get a useful stack trace out of it when something fails, specifically (*) throw an exception when something goes wrong, instead of just writing a message to stdout (*) don't catch exceptions and write useless messages - just let the exception flow up to the JUnit handler, which will log a nice stacktrace with line numbers. Change-Id: If55c997f91eea4e703e92c632961d68b3453076d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21Delete copy ctors/assignments for DLLEXPORT classMike Kaganski1-1/+8
Their default definitions may create/destroy temporary OutputDevice objects, which requires that the class is defined at the site of instantiation of the implicit definition. The solution is to delete these unused methods. If they would happen to be needed, then move the default definitions to the correct place. This reverts commit 30a17b05fb8a860c1e53cb7cfc405b1cea0a9d15. Change-Id: I43f4e76763ff4409e9527f44cd2d8e227982257c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117574 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-21sw: add BIRT layout test documentMichael Stahl2-0/+6
This nested table is an example that was broken by commit 91b2239783dc716bd71ce7962bfd7e341dfe4175 - if loaded with a wide window, it goes into layout loop; if loaded with a tall window size where page 2 is visible, strangely it doesn't loop. Change-Id: I5e73cfcd928ff1a321667c1a75b0ba7f348d4b77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117587 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-06-21use FileDialogHelper to set file picker parentCaolán McNamara1-2/+2
Change-Id: I970b34fd3da12a1051343bdc26afad411121e672 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117584 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-07-25 00:57:20 +0000