summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-10-11sfx2: fix typoHenry Castro1-1/+1
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I73e4890c024a2ab74ea3d4141c63304c167ba4c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157337 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157751 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11sw floattable, crashtesting: fix PDF export of ooo91654-1.docMiklos Vajna3-4/+48
Regression from 89a75cd194371002247d0138e759835bc673f7b0 (tdf#126449 sw floattable: DOC import: handle inner floating table, 2023-10-04), the document crashed Writer layout when exporting to PDF, which triggers a layout calculation. The trouble seems to be that in case the split fly is anchored in a table which is in a section, then we assume that we can create a section on the next page and move the follow fly frame there, which will mean the follow anchor won't be in a table anymore. Fix this by not moving the follow anchor explicitly, similar to what the nested floating table (inline or floating outer table) code does. The layout will later figure out that the available space is not enough, split the outer table for us, which will lead to a correct result. Note that the original bugdoc is DOC, but just saving it as-is in Word hides the problem, so it's not easy to minimize the reproducer. Instead create a similar DOCX reproducer from scratch. Change-Id: I769615af467ccaa88057ab322da2865f11d3d2ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157803 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-11tdf#132293 remove unused imports from uitestAnkit_Jaipuriar4-5/+2
Change-Id: I3c76c6f1e3561aaf0b4bb719a89feebecc65027a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157482 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-10-11fixup for: fe79008f70e7 sd: send correct slide visibility statusMarco Cecchetti1-1/+2
Check pointer to be vaild Change-Id: Id7be4756496f034c4a6a4407cb625e68a66573c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153051 Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 93a28b3bc8a50226a111464b08ac51d1feb05988) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157761 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11tdf#51510 Blurry QR code after save/reload (docx)Darshan-upadhyay11101-0/+4
- without GfxLinkType::NativeSvg CASE in writeToStorage method by default QR svg changes to low resolution image type and that is the why QR got blurry in doc or docx format - added svg option when we change from odt to doc or docx format Change-Id: I74aec0619992c1f455cc9cbf3c19e352c3037e04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157264 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 1d7dc53f19d188ae12603ca3cd526eb0a5016cf4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157729 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11don't use %PRODUCTNAME in accessible-descriptionCaolán McNamara1-1/+1
similar reason as commit 3cca2c605313576187878a195fb612eb25bd6150 Author: Caolán McNamara <caolanm@redhat.com> Date: Sat Jun 4 21:10:16 2022 +0100 restore %PRODUCTNAME to accessible descriptions that need them reading all a11y desc at load time in order to possibly substitute %PRODUCTNAME and re-write a11y desc at runtime explodes gtk's a11y, so we limit it to where we have to do it. Change-Id: I283934bc81c41ebba2f6f189c1209209f8331c03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157795 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11drop can-focus of False in GtkToolButtonsCaolán McNamara4-18/+0
Change-Id: I12add968fdb5cb4d29087c24aa885cde23488fb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157794 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11add truncate-multiline for consistency with everything elseCaolán McNamara1-0/+1
Change-Id: I4b1e61aeb17f2b3bd8e298bb1613623d4ba1a0f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157793 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11upgrade to libcmis 0.6.0Caolán McNamara10-1462/+3
Change-Id: Ia22d2efca14b1f55f45a4ecb9c487591c3117e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157704 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-11lok: sc: fire "hyperlink clicked" eventHenry Castro2-1/+23
The client side has changed the behaviour when the HYPERLINK formula is clicked, usually in desktop is fired with Ctrl + Mouse Click, now it is fired with Mouse Click. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I08d41170714588d9ee84475991757d8be9b01f07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155270 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155352 (cherry picked from commit 5279aff5588941e1e131a703059e8148713d24ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157726 Tested-by: Jenkins
2023-10-11Delete OUString UTF-16 string literal ctor/assignment opStephan Bergmann18-369/+223
...that have been made unused by 7ef3d937415185ef66e32dd3043783eddcd03db5 "loplugin:ostr: Rewrite some uses of O[U]String to use ""_ostr/u""_ustr literals". (And which means we can remove the relevant code from that plugin again.) (This also found a handful of remaining uses that had been hard for the plugin to discover, along the lines of > std::map<OUString, int> m = {{u"foo", 0}}; being represented by a > DeclStmt 0xdaca578 <line:103:5, col:50> > `-VarDecl 0xdac9150 <col:5, col:49> col:29 s11 'std::map<OUString, int>':'std::map<rtl::OUString, int>' cinit destroyed > `-ExprWithCleanups 0xdaca548 <col:35, col:49> 'std::map<OUString, int>':'std::map<rtl::OUString, int>' > `-CXXConstructExpr 0xdaca508 <col:35, col:49> 'std::map<OUString, int>':'std::map<rtl::OUString, int>' 'void (initializer_list<value_type>, const std::less<rtl::OUString> &, const allocator_type &)' list std::initializer_list > |-CXXStdInitializerListExpr 0xdaca480 <col:35, col:49> 'initializer_list<value_type>':'std::initializer_list<std::pair<const rtl::OUString, int>>' > | `-MaterializeTemporaryExpr 0xdaca468 <col:35, col:49> 'const std::pair<const rtl::OUString, int>[1]' xvalue > | `-CXXBindTemporaryExpr 0xdaca448 <col:35, col:49> 'const std::pair<const rtl::OUString, int>[1]' (CXXTemporary 0xdaca448) > | `-InitListExpr 0xdac9df0 <col:35, col:49> 'const std::pair<const rtl::OUString, int>[1]' > | `-CXXConstructExpr 0xdaca408 <col:36, col:48> 'const std::pair<const rtl::OUString, int>' 'void (const char16_t (&)[4], int &&) noexcept(_S_nothrow_constructible<const char16_t (&)[4], int>())' list > | |-StringLiteral 0xdac91b8 <col:38> 'const char16_t[4]' lvalue u"foo" > | `-MaterializeTemporaryExpr 0xdaca3f0 <col:46> 'int' xvalue > | `-IntegerLiteral 0xdac91d8 <col:46> 'int' 0 > |-CXXDefaultArgExpr 0xdaca498 <<invalid sloc>> 'const std::less<rtl::OUString>':'const std::less<rtl::OUString>' lvalue > `-CXXDefaultArgExpr 0xdaca4b8 <<invalid sloc>> 'const allocator_type':'const std::allocator<std::pair<const rtl::OUString, int>>' lvalue Clang AST.) Change-Id: I496fe9d4d5e1a033cb7b27b4e04b303f8ddbed4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157756 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-11tdf#157442 sw: fix spell checking of words next to digitsLászló Németh1-4/+9
If the preceding or subsequent word was a number or a word with numbers, misspelled words were accepted as correct. Note: it occurred with disabled "Check words with numbers" (default setting in Options – Language Settings – Writing Aids). Regression from commit 5619fc438273cd15e78539e78b8af751bca24b1a "tdf#154499 sw spell checking: add 2-word phrase checking". Change-Id: I4478c89d04ebf971925d4bdd56aaebc7ce8fb77e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157799 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-10-11Use std::spanMike Kaganski3-115/+37
Change-Id: Id40dd540d715ed79f7fe09e686fd0a9909d82d74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157792 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-11Simplify a bitMike Kaganski1-17/+7
Change-Id: If87cf8d71ce49af191cf991e2dc5479b275cd918 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157745 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-11Update git submodulesJulien Nabet1-0/+0
* Update helpcontent2 from branch 'master' to 69bd1d2c11c91b8968b5811855a3fd3acad6f979 - Following fix grammar Change-Id: I838288c594ce5aed9c573f8e7f05074a6672232e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157725 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-10-11cool#7330 calc perf: PaintTile's FillInfoNoel Grandin2-4/+7
try to spend a little less time here, when searching twice, we can use the index result of the first search as a hint Change-Id: I7fc0c2fb4e5e338d2c3f8a3d642043a1b301e7b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157749 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-11wina11y: Drop CAccTextBase::GetXInterfaceMichael Weghorn2-29/+27
Just use the private `pRXText` member directly. The separate getter doesn't really help regarding readability, in particular since the typical usage pattern involved first checking the member directly, then using the getter, making it less obvious that this was about the same object/reference e.g. if(!pRXText.is()) { return E_FAIL; } if( offset < 0 || offset > GetXInterface()->getCharacterCount() ) return E_FAIL; Change-Id: Iaf786220b94a37e79a46985f58e0586252846f56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157766 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-11wina11y: Drop unnecessary check for empty ReferenceMichael Weghorn1-4/+1
Using operator= with either an empty Reference or nullptr has the same effect. Change-Id: Ifa33127f3718ba4bbf3d364484b412b4108719a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157765 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-11tdf#133870: read OBJECTDESCRIPTOR from clipboardMike Kaganski1-0/+41
This extends commit 8ad0c29f56e5069a3679560d404b603332dcf38a (sw: prefer ODF over RTF when pasting from Writer, 2020-04-22). To see that the clipboard contains a matching EMBED_SOURCE from another instance of the program, the content of OBJECTDESCRIPTOR needs to be read into mxObjDesc of TransferableDataHelper. Change-Id: Ic4bf4ba8b077550336be231451cf2e86c42f112b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157791 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-11tdf#156815 Reset solver settings when a sheet is renamedRafael Lima5-1/+43
When a sheet is renamed, the SolverSettings object needs to be reset so that the updated references of the named ranges are reloaded the next time the Solver dialog is opened. Change-Id: I8d501bb5b52f6a69bc899a62863893744d80dc69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156872 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-10-10tdf#154142 null-deref in SfxUndoManager::SetMaxUndoActionCountCaolán McNamara1-1/+1
Change-Id: I09cfbccb5f2ffa009a3e40157c9373b7e10864dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157764 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-10tdf#157502, tdf#157652: sd_png_export: Add unittestXisco Fauli2-0/+48
Change-Id: I19bf2738496e0289e9fe07ac5241781b4c0bc416 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157758 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-10vcl: swap out the BinaryDataContainer tooAshod Nakashian1-0/+2
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: I2e6ac88ff95903acf2df2070a7c23f4fc135c253 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154606 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 896fc921cd72b5f0198772f2d4c569b59f51222c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-10fix internal python build on aarch64-unknown-linux-gnuAndras Timar1-0/+6
Change-Id: I74189af9edd8384cbb1d65a805a29cea91646eeb (cherry picked from commit 77ebb08e5f93ea9b9e82ddc3de0698babe0630a8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157752 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-10Enable QR and barcode dialog for onlineDarshan-upadhyay11106-6/+39
- enable QR and barcode genration dialog for online - Change Qr code genration dialog to async Change-Id: Ia46b8e27a3002adcc893e5ef4c2545d7edcc3e41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156642 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 6ed38adb5578d0b52d11d8f2077e345f9a8c7ade) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157728 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-10lok: set help root URLAndras Timar1-0/+21
Change-Id: Id4089027f095daebb69942eb3315d516cfb14779 (cherry picked from commit 2239e4c1b2dcf06650316a106e5bd883ceefb6c1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157750 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-10jsdialog: hide help and close buttons for searchreplace dialogPedro Pinto Silva2-0/+8
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com> Change-Id: I0f3bc2cd6839c74dff40431f8659d7f90b285d12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149293 (cherry picked from commit c65142fd9fd9a43e1f27cb11f5b4048600b5a4c4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157720 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-10gtk3 a11y: Drop unnecessary check before loopingMichael Weghorn1-51/+48
If `nTextMarkupCount` is <= 0 here, the loop condition isn't met, so the body is never entered anyway, so no need to check this explicitly. Drop the extra nesting level. (Use `git show -w` to ignore whitespace change.) Change-Id: Ib472da039d7b0a02ae3206b350c3feb6d42b914b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157759 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-10tdf#157182 vcl,filter: PDF/A export: fix crash due to SE ID mismatchMichael Stahl5-4/+471
The SE IDs in PDFExtOutDevData and PDFWriterImpl are supposed to match. If PDF/A-1 is exported then RemoveTransparenciesFromMetaFile() is called and that does unspeakable things to the Metafile and then we just throw away the PDF related data for the page in PDFExtOutDevData::ResetSyncData(). This means that then EnsureStructureElement are called on PDFExtOutDevData but not on PDFWriterImpl, so on the next page the IDs will no longer match, which is noticed if there is no transparency to be removed on that page. pdfextoutdevdata.cxx:347: bool vcl::PageSyncData::PlaySyncPageAct(): Assertion `id == -1 || id == mParaInts.front()' failed. Guess the easiest way to deal with this is to have the premature ResetSyncData() replay only the EnsureStructureElement actions, which is only possible because they don't really require any extra data stored in the ridiculous vectors in PageSyncData; PDFWriterImpl will eventually remove the elements as they are never initialised. (regression from commit 07d790ca473cd6e71f0343419b819fa6b485dc01) Change-Id: I8eb295504067edff00608e28fd86b0c86d547083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157748 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-10Remove exec bits on .doc fileAndrea Gelmini1-0/+0
Change-Id: Ia5cf772cab86869a46c5a8f610fe43d170545516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157760 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-10-10Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 415f52ad94adf6df48604304e4e038c1e58bcb79 - Fix grammar Change-Id: I07a30b1b3df454fce1144587176b3612d9bde474 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157724 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-10tdf#107786: sw_ww8: Add test for null pointer dereferenceOmkarAcharekar2-0/+9
Change-Id: I54bd01ce3b0007abe9adb58c0b17195e38e8ceaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157742 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-10-10Make some methods const, and avoid some const_castsMike Kaganski5-8/+8
Change-Id: I4964abd34836438e3d24ee7c3c3b324f356477b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157746 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-10Drop repeated codeMike Kaganski1-6/+0
Change-Id: I0bbbaaf7c24851beca78d4ed024ffc44609e0093 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157719 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-10sw: SwTbxAutoTextCtrl should sort groups by titleMichael Stahl1-1/+4
Change-Id: I2134492fd681393da6f4fc29aec95117145e8e97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157735 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-10lok: fix getting SID_DOC_READONLY slot propertyHenry Castro1-10/+1
Unfortunately, the property is not always set when import XLSX documents. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: If501734704174b92b3589b61a019ba973592c331 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157259 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157736 Tested-by: Jenkins
2023-10-10tdf#157571 sw floattable: fix incorrect blank space after table-in-shapeMiklos Vajna4-4/+53
Regression from a4af5432753408c4eea8a8d56c2f48202160c5fe (tdf#120262 sw floattable, legacy: fix text wrap around fly when no content fits, 2023-07-17), the bugdoc has a shape which contains a table, and lots of empty paragraphs next to it wrap around the shape. Writer didn't wrap these empty paragraphs, so some of the page 1 content was shifted to page 2. What happened here is that in case there is a really small space for the wrapping text around a floating object, then Word has some minimal limit. If the available horizontal space is smaller than the limit, we don't even try to wrap, even if the content (an empty paragraph) would fit. It was assumed that this limit is the shape for normal anchored objects and floating tables, but the two bugdocs show that there are two different limits here. Fix the problem by going back to MINLAY as the default limit where we start wrapping, and only increase that to TEXT_MIN_SMALL when wrapping around floating tables. That fixes the bugdoc and keeps the older floating table use-case working as well. This also allows reverting changes to testParaUpperMarginFlyIntersect, to assert the non-floating-table case again. Change-Id: I8f8a776c6ad5bdfa0ee4f197b600463fef6431f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157743 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-10Silence a new -Werror,-Wdeprecated-declarations for nowStephan Bergmann1-0/+4
Change-Id: I5b457a4e1b9804b53a72d53a49ca9695424fc0c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157708 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-10CppunitTest_sw_ooxmlexport4: rework to avoid preTest()Miklos Vajna1-16/+10
ImportComboBoxAsDropDown is on by default, so all we need is to turn it off at a single place + restore it at the test case end. Change-Id: I399aa60e5bf89817baa226de090625fd89fbbac9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157734 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-10tdf#156980 SwNavigator: Make headings delete even if they haveJim Raykowski2-1/+30
folded outline content Change-Id: If952d8d845c2eeec86231014b924f1632d2f5efe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157667 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-10-10Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 97c4b5ce17d662c498faa38c23074a645e21649b - tdf#155875 UI cmds Writer/Help in Help(52) + refactoring + Grid menu - final Change-Id: I0a237e1e8a6019a9b1cc65db2eebcb8f33ff1072 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157739 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-10Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 3644717d42d7fa24a61af95a6b51643665d879d1 - tdf#155875 UI cmds Writer/Help in Help(51) + refactoring + Edit menu - final Change-Id: Ibf65e70f1edfa2733800eaa9e69ca9789abb0b2c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157738 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-09Add -rpath when building analyzer executable on macOSStephan Bergmann1-1/+3
...as at least with LLVM 18 trunk, the generated executable references @rpath/libclang-cpp.dylib but didn't actually contain an LC_RPATH Change-Id: Ida643903aa4566853ea9541553f0dfc9c3243d4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157706 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-09Avoid a false loplugin:casttovoid on macOSStephan Bergmann1-0/+5
...involving conditional preprocessed code at > vcl/skia/SkiaHelper.cxx:265:13: error: unnecessary cast to void [loplugin:casttovoid] > 265 | (void)blockDisable; > | ^~~~~~~~~~~~~~~~~~ > vcl/skia/SkiaHelper.cxx:286:22: note: first consumption is here [loplugin:casttovoid] > 286 | if (!blockDisable && !DefaultMTLDeviceIsSupported()) > | ^~~~~~~~~~~~ Change-Id: I222d72d240852be2d64fe08d345f00d137cd5a63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157707 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-09loplugin:casttovoidStephan Bergmann1-2/+1
Change-Id: Ifa6c18651b2e3faa4500f19217bf11dba10f02fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157709 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-09bump odt2pdffuzzer max_len againCaolán McNamara1-1/+1
Change-Id: I2fcd448d4efef924d088bfc9470ae800dbd78504 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157737 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-09tdf#157650 Unhelpful error when XML in content.xml is malformedNoel Grandin6-12/+67
regression from commit d9e322d60f65ff20631dab87baa5a2c7c71daaa2 replace ErrorInfo with simpler mechanism we need to tunnel the necessary information through the uui stuff, so add a new Exception class to do that. Change-Id: Ie1fde486e8637b802340795348a5e5aad6a54e96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157732 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-09lok: add getter function to read "ReadOnly" flagHenry Castro1-1/+43
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Id9d2bc638d0f48cb33764b07fb8976b97117a621 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156621 Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157733 Tested-by: Jenkins
2023-10-09tdf#157502 and tdf#157652 invert alpha maskPatrick Luby1-3/+9
Due to the switch from transparency to alpha in commit 81994cb2b8b32453a92bcb011830fcb884f22ff3, invert the alpha mask. Change-Id: Ib6df3523be36ba5d5aaf3887557d4a6a8fa6098c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157731 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-09sfx2: invoke handler "LoadReadOnlyRequest"Henry Castro1-0/+49
It will ask the user if open the Excel documents "read only" Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I909fb39709198e02496f8c522f477c077fb875e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156624 Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157730 Tested-by: Jenkins