summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-04-07lok: async exception dialog messages for VBA macrosHenry Castro1-3/+11
Change-Id: Ia713343541f8102de85f7ac57202780afba3da00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111855 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113686 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-07lok: show error message dialog for VBA macrosHenry Castro1-0/+21
It creates and exclusive message dialog to show the VBA errors to client side. Otherwise the IDE window to show the source code and the error message is not supported yet. Change-Id: Ie74f911b109cb13aebd39de2cb8e899d779c1cf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111854 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113689 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-07tdf#138089: sc: Add UItestXisco Fauli2-0/+48
Change-Id: Ib9baa24c899e40062da0347986cf8e5755cf2f0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113751 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07can short-circuit this conversionNoel1-0/+2
Change-Id: I042bcd0ea9d64ab5d9cca301a04235a89b1e4fbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113662 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-07only call mpCurrentDeck->GetLOKNotifier if we need toCaolán McNamara1-2/+1
Change-Id: I7a4205a51a40d4404c304a4db992baf198eb015e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113742 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-07uitest: factor out common codeXisco Fauli9-40/+20
Change-Id: I4ca17db1ff7221290fedb94700bfb2257e9c647e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113749 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
...apparently since 615ceb107e9faf01b568b0a2440a3f09c8f88ca6 "vcl: remove 4-bit bitmap support from qt5 backend" Change-Id: I8e130b6e1a2439476e6bdf934a3c380d4599c23e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113743 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-07rtl::Static -> function local staticNoel Grandin2-9/+6
Change-Id: If8d2ef2066f52bc287457e03f0e57df11d5cfc85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113714 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-07rtl::Static -> function local staticNoel Grandin3-22/+15
Change-Id: Iee030633d2e2b020f38797d0d323680fa552b81a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113713 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-07lok: add "MacroSecurityLevel" optionHenry Castro1-0/+14
Change-Id: I1cf4e6d4495c552b94c6fe80333291fc4ab20936 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112043 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113691 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-07cache also GetFontData() failuresLuboš Luňák1-4/+12
When drawing some documents such as tdf#141278 GetFontData() is 30+% of CPU time. While at it, also fix the broken refcounting because of missing operator=. Change-Id: Ie62328b8e1c4ff700558796609f4bc6ad7e03a85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113745 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-07xmlsec: fix signing documents on WNTMichael Stahl2-0/+69
Duplicate ds:X509Certificate elements cause: warn:xmlsecurity.comp:9604:3820:xmlsecurity/source/helper/xmlsignaturehelper.cxx:658: X509Data do not form a chain: certificate in cycle: (regression from 5af5ea893bcb8a8eb472ac11133da10e5a604e66) Change-Id: I3d319a2f74dbec17b73f1c7bb8f4efe4e335f0ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113746 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-07lok: fix sidebar controller disposed objectsHenry Castro1-15/+17
The property listener still holds a reference count of the sidebar controller so it is disposed after removing the listener when the windows objects had already disposed. kit-3428938-3428936 2021-01-25 15:39:15.502557 [ kitbroker_001 ] SIG Fatal signal received: SIGSEGV Backtrace 3428938: loolforkit(_ZN7SigUtil13dumpBacktraceEv+0x4e)[0x56273955b7ac] loolforkit(+0x1d9723)[0x56273955b723] /lib/x86_64-linux-gnu/libpthread.so.0(+0x14140)[0x7f689e8f3140] instdir/program/libsfxlo.so(+0x4785f6)[0x7f689b5a45f6] instdir/program/libsfxlo.so(_ZN4sfx27sidebar17SidebarController19UpdateDeckOpenStateEv+0x74)[0x7f689b7a553c] instdir/program/libsfxlo.so(_ZN4sfx27sidebar17SidebarController15RequestOpenDeckEv+0xa0)[0x7f689b7a5316] instdir/program/libsfxlo.so(_ZN4sfx27sidebar20SidebarDockingWindow8GetFocusEv+0x3c)[0x7f689b79aa6e] instdir/program/libvcllo.so(_ZN3vcl6Window14CompatGetFocusEv+0x7f)[0x7f68966da653] instdir/program/libvcllo.so(+0x63427c)[0x7f689661b27c] instdir/program/libvcllo.so(_ZN3vcl6Window9GrabFocusEv+0x1d)[0x7f68966d693d] instdir/program/libvcllo.so(_ZN3vcl6Window7disposeEv+0x1dd5)[0x7f68966c94e5] instdir/program/libsfxlo.so(+0x6993a3)[0x7f689b7c53a3] instdir/program/libvcllo.so(_ZN16VclReferenceBase11disposeOnceEv+0x40)[0x7f68968f7188] instdir/program/libsfxlo.so(+0x6802e1)[0x7f689b7ac2e1] instdir/program/libsfxlo.so(_ZN4sfx27sidebar17SidebarController9disposingEv+0x218)[0x7f689b79ff40] instdir/program/libuno_cppuhelpergcc3.so.3(_ZN4cppu27WeakComponentImplHelperBase7disposeEv+0xef)[0x7f689d2d846b] instdir/program/libsfxlo.so(+0x68036a)[0x7f689b7ac36a] instdir/programlibsfxlo.so(_ZN4sfx27sidebar17SidebarController9disposingERKN3com3sun4star4lang11EventObjectE+0x43)[0x7f689b7a05e5] instdir/program/libsfxlo.so(_ZN4sfx27sidebar5Theme9disposingEv+0x1ae)[0x7f689b804450] instdir/program/libuno_cppuhelpergcc3.so.3(_ZN4cppu27WeakComponentImplHelperBase7disposeEv+0xef)[0x7f689d2d846b] instdir/program/libsfxlo.so(+0x6f5eec)[0x7f689b821eec] instdir/program/libuno_cppuhelpergcc3.so.3(_ZN4cppu27WeakComponentImplHelperBase7releaseEv+0x94)[0x7f689d2d81f0] instdir/program/libsfxlo.so(+0x16c58e)[0x7f689b29858e] instdir/program/libsfxlo.so(+0x17c6e7)[0x7f689b2a86e7] instdir/program/libsfxlo.so(+0x17af6c)[0x7f689b2a6f6c] instdir/program/libsfxlo.so(+0x16c21c)[0x7f689b29821c] instdir/program/libsfxlo.so(+0x16b4d4)[0x7f689b2974d4] instdir/program/libsfxlo.so(_ZN14SfxApplicationD1Ev+0x248)[0x7f689b293cf8] instdir/program/libsfxlo.so(_ZN14SfxApplicationD0Ev+0x18)[0x7f689b293d38] instdir/program/libsfxlo.so(+0x1863e0)[0x7f689b2b23e0] instdir/program/libfwklo.so(_ZN9framework7Desktop8shutdownEv+0x206)[0x7f689c67b47c] instdir/program/libsofficeapp.so(+0x2f14b)[0x7f689ddb814b] instdir/program/libvcllo.so(_ZN11Application7ExecuteEv+0x191)[0x7f6896db9f45] instdir/program/libsofficeapp.so(+0x325c5)[0x7f689ddbb5c5] instdir/program/libvcllo.so(_Z10ImplSVMainv+0x1f4)[0x7f6896dd68a6] Change-Id: I03eb5fa76b7712c8e12cefa2fbf07eb3e169eeb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113068 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-07pViewShell and pMobileNotifier both set to the same thingCaolán McNamara1-3/+2
they are both set to SfxViewShell::Current(), just fetch that onece Change-Id: I06cd483d8cb179ae43b1becd14da75d1f2271681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113741 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-07lok: fix the empty script node type container without "+" symbol expanderHenry Castro2-13/+6
According to description in https://bz.apache.org/ooo/show_bug.cgi?id=30923 "In this case I think it's an acceptable solution to display a '+' symbol for all library nodes, and if a library has no children and the user clicks on the '+' symbol, the '+' will disappear". Unfortunately this behaviour is not well driven for final users' client side, so they misinterpret as a bug. After tracing the method hasChildNodes(), the log result indicates that this method does not load the libraries, but it is necessary to iterate applying the method getChildNodes(), which will cause to load all libraries and determine if the child has a script CONTAINER node type to assign the '+' symbol. Also, I have traced the loading libraries when the Macro Selector dialog pops up and the result it load once, so I do not think it is a problem loading a small finite number of libraries today. Change-Id: I4ae5395b6afa7b7d6ff2b2ec692771e93c46c529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112636 Reviewed-by: Pedro Silva <pedro.silva@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113693 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-07uitest: remove duplicated codeXisco Fauli6-38/+7
Change-Id: I86a4cd75e103445a288ad52a8c2167fa5b20c794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113720 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07jsdialog: JSMessageDialog tweaks when builder is nullptrHenry Castro2-0/+62
"CreateMessageDialog" creates the message dialog without builder, so some buttons need a click handler to close the message dialog. Change-Id: I73ac99020abfb23a1b1313468b6b0f5a8a17f039 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111852 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113692 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-07lok: add "EnableMacrosExecution" optionHenry Castro1-1/+3
Change-Id: I2ad31e2e7f66fdfca1eee07622a4a9fec8b62861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112030 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113690 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-07Updated README.md files to represent current code / use Markdown formatHossein141-1507/+1749
Previously, all of the README files have been renamed to README.md and now, the contents of these files were changed to use Markdown format. Other than format inconsistency, some README.md files lacked information about modules, or were out of date. By using LibreOffice / OpenOffice wiki and other documentation websites, these files were updated. Now every README.md file has a title, and some description. The top-level README.md file is changed to add links to the modules. The result of processing the Markdown format README.md files can be seen at: https://docs.libreoffice.org/ Change-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113424 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-07vcl: move graphic handling into Qt5GraphicsBackendTomaž Vajngerl10-195/+302
This is an effort to make SalGraphicsImpl mandatory for all backends. This introduces Qt5GraphicsBackend: a subclass of SalGraphicsImpl, which now handles graphic rendering. Change-Id: I42aece59d0c692ca1dd33e30f31c5bcceab02008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113734 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-04-07vcl: class to automatically delegate calls to SalGraphicImplTomaž Vajngerl3-340/+248
A class for SalGraphic backends that delegates all the graphic drawing calls to SalGraphicImpl. Use this for GenPspGraphics. Change-Id: I0461259802732e9107d9011608530f1ffe2891ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113733 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-04-07cache Skia fontLuboš Luňák3-14/+69
The conversion costs a little bit and it was done for each drawing. Change-Id: Ifaad42308213f15839d9277beb837d21535bfc25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113735 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-07implement operators +,-,*,/ for tools::SizeLuboš Luňák1-0/+60
If they exist for tools::Point, I don't see why they couldn't do the same also for Size. Change-Id: I02ca1bb413b0bd2694a904372e9a18a7a50be17b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113725 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-07make tools::Point/Size/Rectangle/etc. constructors constexprLuboš Luňák1-56/+54
Change-Id: I4aebf90bba7944f2f8e33312120f8714a8a1c2e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113724 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-07avoid pointless O(N^2) dynamic_castLuboš Luňák1-42/+38
I already tried to reduce the cost of this in ef4964a4e598c3c97, but back then I missed the fact that in fact all the casts guaranteed. So partially revert the first commit and simply use static_cast. Change-Id: I4231f698119d56e9f2536f2f0c9d824442d76b09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113736 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-07lok: show only the filename of the Macro Security dialogHenry Castro1-13/+5
Apply the patch for desktop case too. Change-Id: Ia4cf6d2cefd0e02e11e48ca017f8af9f81600b16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112003 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113688 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-07rtl::Static -> function local static also for UNO3_GETIMPLEMENTATION*_IMPLMike Kaganski1-5/+2
Follow-up to 07fd90cc7d85a89b9f74efba7ddc9ac457110ce3 Change-Id: I788607fe14fe12db015bf023dfac5bdc196b52ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113730 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-07lok: remove popup auto correct itemHenry Castro1-1/+3
The auto correct options and auto correct menu item are no longer need it. Change-Id: I0a5e624c3393151cf80a06961f96d6a5fb8891ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113680 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-07skip check-if-root test if LIB_FUZZING_ENGINE is setCaolán McNamara1-1/+1
https://github.com/google/oss-fuzz/pull/5588/checks?check_run_id=2285987092 Where presubmit checks for oss-fuzz fail with Makefile:62: recipe for target 'check-if-root' failed despite the efforts made to detect running inside a container LIB_FUZZING_ENGINE is set by oss-fuzz which builds LibreOffice by calling bin/oss-fuzz-build.sh which uses distro-configs/LibreOfficeOssFuzz.conf that enables --enable-fuzzers and --enable-fuzzers ensures LIB_FUZZING_ENGINE is set, so checking for LIB_FUZZING_ENGINE seems a reasonable test here to skip the root check Change-Id: I930c87c13bd365b0adbefd3625598a89e48468ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113731 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-07tdf#141528 ensure that reset of linked state is executedArmin Le Grand (Allotropia)1-2/+13
Take m_xDocHolder->GetComponent() and xModif->setModified inside the local try..catch expression to ensure that the reset of the linked state below (m_bIsLink and .clear()) is executed Change-Id: I52d49569a43fd2c23dd997c7217f7552cbdcfb82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113722 Tested-by: Armin Le Grand <Armin.Le.Grand@me.com> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-04-07Resolves: tdf#141515 expander column space isn't wantedCaolán McNamara1-1/+1
in the relationships view Change-Id: I1d4a34dbf86a797573705c202719f5159b5a8bcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113729 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-07jsdialog: simplify unselect for treeviewSzymon Kłos1-4/+2
Change-Id: Iaadd8122d735103d89e4acb65bef1ca8c1ad2e1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112532 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113679 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-07tdf#126735 sw Next Change: cycle through tracked changesLászló Németh2-0/+69
Next/Previous Change commands don't stop at the start or end of the document, but continue on the end or start of the document to cycle through all tracked changes, like Find Next/Previous and other office suites do. Change-Id: I5578d6b98b81ca1f8f222ba78e7d3c08339eca89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113716 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-04-07tdf#141531 liblo-native-code: Add ODatabaseContext_get_implementationMichael Weghorn1-0/+1
Add 'com_sun_star_comp_dba_ODatabaseContext_get_implementation' to liblo-native-code, needed to open mail merge files with data source since commit e64dc07ca8300a997d6d3eebfc3e198ae55d290d Date: Mon Mar 29 11:52:05 2021 +0300 tdf#139906 Show warning message when data source is not avaible. Change-Id: I6fdd500f9c3b9cc54310e78df694eba7103ff0b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113717 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-04-07tdf#141341 docxexport: consolidate conversion of NumTypesJustin Luth3-78/+28
so that one comprehensive function is used for Page and Footnote numbering types (which was already being used by list numbering). I also added support for CHARS_ARABIC_ABJAD <=> arabicAbjad, which was my trigger for consolidating all this. OOXML has one definition (ST_NumberFormat) that specifies the valid values for pgNumType, numFmt (list numbering), numFmt (Endnote and Footnote numbering), so use the same conversion function for all of these. [Also used for caption, but I haven't noticed that yet in export.) In the previous code, there was no possibility for fmt.isEmpty() [despite repeated checks for that situation]. However, I thought it made sense to not specify anything if the conversion didn't match something known (because perhaps the locale could take over then?). In any case, that is a slight change, but for pgNumType we were specifying "none" instead of decimal, which didn't make much sense either. So I don't expect anyone crying 'regression' over that. Change-Id: I90037eb25a0f71d22d6ad1848f43761eb6b9fe00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113351 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-07ScDocShell::GetActiveDialogParent instead of Application::GetDefDialogParentCaolán McNamara1-2/+1
which is more likely to be the relevant calc window Change-Id: I7c939c42752e103494a1df7154b3318643d5206c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-07ofz#32965 move fpe fix of ofz#17212 into toRationalCaolán McNamara1-4/+3
Change-Id: Ica301357f45fd289c41234b8a7059ab0ff264321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-07tdf#141467 xmloff,sc,sw: ODF export: reorder flys' ZOrder/z-index harderMichael Stahl11-22/+351
Also keep the control layer distinct from the foreground, as a follow-up to tdf#133487. Try to improve the detection of already sorted indexes a bit to avoid unnecessary sorting. Hilariously the test docs require adding 3 additional items to the extension schema. Change-Id: I629d5b09294f679717677b9d89537d905ac4c404 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113696 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-07tdf#141297: sd: Add UItestXisco Fauli2-0/+97
Change-Id: I0e0a7869b77719d5080e6f4df83159251bed2f42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113708 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07tdf#141267 PPTX export: fix handling of audio nodes with non-media sourceMiklos Vajna3-2/+18
Regression from commit cf5fa358a6bf6e7c0aae2dca1e8fa3334d95ebdb (PPTX export: fix missing audio anim node for slide narrations, 2021-01-25), the problem was that the audio source can be any kind of shape, not only a media shape. Fix the problem by explicitly checking of the shape has a media URL. Change-Id: I2bdde0f9ed3576f307aabff5e39d441f295c203f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113715 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-07jsdialog: unselect treeview entry by iteratorSzymon Kłos1-1/+4
avoid crash when using relative position from deeper levels returned by get_selected_index to unselect entry using unselect function on root level Change-Id: Iaaddb131031eb5273cb06412c976f310f7323f52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112374 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113678 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-04-07tdf#119661: sw: Add UItestXisco Fauli1-0/+93
Change-Id: I7e24060b9b8e3b2b673a854256c8d8afaf399eb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113707 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07tdf#141338 android: Make "Select file to open" view smallerMichael Weghorn2-4/+4
Use the same height as is used for the "Recent files" entries. Change-Id: Ia6c1e02507ac12b554eb042d6dd32c0fc78cb578 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113675 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-04-07android: Move "Recent files" below system file picker viewMichael Weghorn1-19/+19
Move the view that opens the system file picker when tapped above the "Recent files" view in the Android Viewer start activity. Change-Id: I63ee0ea7fb784a3405877fcf5ed587ce06e8e093 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113674 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-04-07android: Drop custom file abstraction + UIMichael Weghorn36-3272/+51
Android Viewer had its own file abstraction layer. From the (now deleted) IFile.java: > An abstraction of the File class, intended to be implemented by different > Document Providers. > > It represents a file or a directory in the context of a certain Document > Provider. It wraps the file-related operations and provides access to the > final document as a local File, downloading it if necessary. However, Android already provides such an abstraction by what is called "documents provider" there as well, s. [1]. Android Viewer has previously been adapted to support and make use of that. Therefore, drop the custom implementation to avoid duplication and having to reimplement functionality already provided otherwise. Also, drop the custom UI elements to display and select files implemented on top of the custom file abstraction. Support for using the system file picker (via the corresponding Intents) has been added earlier and is now the only available option to open files from within the app. [1] https://developer.android.com/training/data-storage/shared/documents-files Change-Id: Ide529e836a32fd7e880e5a72d971af9f9c7e74bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113667 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-04-07rtl::Static -> function local staticNoel Grandin74-473/+172
Change-Id: I2071c27bdf074403ec24e67f9278ac27f9491303 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113698 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-07loplugin:casttovoid: Fix VisitReturnStmt in lambda bodiesStephan Bergmann2-0/+38
...as caused the assert(!returnTypes_.empty()); in VisitReturnStmt to hit for the return statement in the permutation2D lambda body (which does not happen to be nested within any other function declaration) in patch sets 1 and 2 of <https://gerrit.libreoffice.org/c/core/+/113522> "Compute permutation2D at compile time". Change-Id: Ic4aa55bef4361e40c2cd6247b5646f7b1ba82e6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113699 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-07lok: draw bgcolor lines for covering client grid...Dennis Francis3-14/+47
... that are over merged cells area. This is needed as client has no information about merged cells. Change-Id: I625d64cc3abd0ee1e60a8af9469a152286f25fd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113145 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit e3fa896aa14c03165190f0fef304ff0e8074d619) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113632 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-04-07Related: tdf#128334 Make VBA Range getFormula(R1C1) work not only by accidentEike Rathke1-16/+21
i.e. if document native grammar was very similar to the API grammar (English UI function names, English locale and separators, address convention). Also alloc and init second string and conversion only if necessary. These Formula and FormulaR1C1 properties still behave like FormulaLocal and FormulaR1C1Local, which is wrong, see https://bugs.documentfoundation.org/show_bug.cgi?id=128334#c12 Change-Id: I589b36c2cd51d5bbba767a309ccf61bd051928a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113711 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-04-07tdf#136918 restrict symbol size to button widthJan-Marek Glogowski2-2/+4
... and scale the button based on the DPI scaling factor. The symbol size is based on pDev->GetTextHeight(), but the button itself is fixed to 20px, which would break at some point. So this at least scales the button witdh based on DPI, just like commit 1eba1c4597f8c2698aa91e2218d8452ad0fbc39c ("tdf#130991 Scale the drop-down arrow size-request") did for the toolbar buttons. OTOH this should probably just use the full button width ignoring the GetTextHeight()... Change-Id: I43010443265c10ad92f46cdecd1d7155a7a07a3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113710 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-14 04:43:33 +0000