summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-06-08loplugin:unusedmethodsNoel Grandin38-647/+0
Change-Id: I52efd8d843d0e4cc7a6adefb0eb95aa50469af38 Reviewed-on: https://gerrit.libreoffice.org/73693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08gbuild: treat $({QT,KF}5_CFLAGS) as cxxflags, not definesMichael Weghorn5-11/+9
Treat all of QT5_CFLAGS, QT5_GLIB_CFLAGS and KF5_CFLAGS as C++ flags, since those contain C++ flags in the first place. Therefore, set them using 'gb_Library_add_cxxflags', not 'gb_Library_add_defs'. (Strictly speaking, those variables contain includes as well, but handling that properly would require splitting this up further, either in 'configure.ac' or see e.g. how it's done in 'RepositoryExternal.mk'.) This also prevents the values of those variables from ending up in the wrong section in IDE integration generated by gbuild-to-ide. Handling them as includes previously resulted e.g. in 'vcl/vcl.pro' (generated by 'make qtcreator-ide-integration') containing DEFINES += BOOST_ALL_NO_LIB \ ... \ VCLPLUG_GTK3_KDE5_IMPLEMENTATION -isystem /usr/include//KF5 -isystem /usr/include//KF5/KCoreAddons [...] and Qt Creator would show a (rather unhelpful) warning like the following when opening a header file inside 'vcl/inc/': > Warning: The code model could not parse an included file, > which might lead to incorrect code completion and highlighting, > for, example. > > 4:9: error: macro name must be an identifier Change-Id: I2bb0c37fdf1112650e8adc712f60737888a8169b Reviewed-on: https://gerrit.libreoffice.org/73699 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-06-08Fix typosAndrea Gelmini1-3/+3
Change-Id: Id0f5a19d5ee4941383bcfaf54e951a40b0d85cdf Reviewed-on: https://gerrit.libreoffice.org/73701 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08Fix typosAndrea Gelmini1-2/+2
Change-Id: If9ac60fd2e6b0bccd2f7f68b2acd573fac0371de Reviewed-on: https://gerrit.libreoffice.org/73702 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08Fix typoAndrea Gelmini1-1/+1
Change-Id: I4bb4fed0575e677898d351781b2ed5f44e4ad3d9 Reviewed-on: https://gerrit.libreoffice.org/73703 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08Fix typoAndrea Gelmini1-2/+2
Change-Id: I69019846ebf5e5a953713468b02d66d98ffd75d4 Reviewed-on: https://gerrit.libreoffice.org/73704 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08tdf#125381: Manage URLs beginning with an "~" in cutPrefix (dbaccess/dsntypes)Julien Nabet1-3/+6
On Windows or with other renderings than gtk3, the urls may begin with an ~ In this case, cutPrefix returns only empty string When trying to access Index management for odb files related to dBase indexes don't display because cutPrefix returns empty url in dbaccess/source/ui/dlg/detailpages.cxx line 200 198 ::dbaccess::ODsnTypeCollection* pTypeCollection = pTypesItem ? pTypesItem->getCollection() : nullptr; 199 if (pTypeCollection && pUrlItem && pUrlItem->GetValue().getLength()) 200 m_sDsn = pTypeCollection->cutPrefix(pUrlItem->GetValue()); Change-Id: I47360e205ddea7b060a31da697bbe9857ad3f4c0 Reviewed-on: https://gerrit.libreoffice.org/72568 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08explictly exclude LibreLogo from XScript usageCaolán McNamara1-0/+13
Change-Id: I567647f0e2f8b82e4ef2995c673abe82f4564228 Reviewed-on: https://gerrit.libreoffice.org/73659 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-08weld View3DDialogCaolán McNamara23-547/+1829
Change-Id: Ifd689c54574c08f026f6760efb39b5f927cb2625 Reviewed-on: https://gerrit.libreoffice.org/73604 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-08Add QtCreator-specific file to .gitignoreMuhammet Kara1-0/+1
Change-Id: If00a4eed997acf2eb7783915e41c61c7651232d6 Reviewed-on: https://gerrit.libreoffice.org/73698 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-08loplugin:singlevalfieldsNoel Grandin12-67/+15
Change-Id: I7c00b7d932bf96a0725eac5482580461baea6977 Reviewed-on: https://gerrit.libreoffice.org/73697 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08Auto redaction dialog second iterationMuhammet Kara6-33/+459
* Add the Add handler * Add SfxAddTargetDialog dialog * Add the Delete handler Change-Id: I9c466754f6b593ffe3c8a1cc8034bbe47674f591 Reviewed-on: https://gerrit.libreoffice.org/73285 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-08Auto redaction dialog first iterationMuhammet Kara12-3/+688
* Add the uno command .uno:AutoRedact with the name 'Auto-Redact' * Add the dialog SfxAutoRedactDialog * Implement the basic functionality to show up when clicked on the menu/toolbar item. * Add the class TargetsTable to control the weld::TreeView which is used to list the targets * Add the struct RedactionTarget to keep info for individual targets Change-Id: Ic02dfb009590c0928a2ea7b0f8b19b4febca221a Reviewed-on: https://gerrit.libreoffice.org/72254 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-08TyposJulien Nabet3-5/+5
Change-Id: If8a5aaba35afb270ce30d49b55a0106e020dfbe0 Reviewed-on: https://gerrit.libreoffice.org/73695 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08loplugin:unusedfieldsNoel Grandin18-340/+332
Change-Id: I9758fd606c7d4c251a3ac06661d642a47260b5fc Reviewed-on: https://gerrit.libreoffice.org/73674 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08Fix typoAndrea Gelmini1-2/+2
Change-Id: I57ad3ce3595f8225ae6f52afd63dfc2477b7e5d8 Reviewed-on: https://gerrit.libreoffice.org/73689 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08Fix typoAndrea Gelmini1-1/+1
Change-Id: I8f6725b66ea076804e5a1966e3acb88999d2204d Reviewed-on: https://gerrit.libreoffice.org/73685 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08 Fix typoAndrea Gelmini1-1/+1
Change-Id: Idd668a1d16ae17d4821804859d0d5eb6b92ae345 Reviewed-on: https://gerrit.libreoffice.org/73683 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08Fix typoAndrea Gelmini1-1/+1
Change-Id: I1728ab5cb25cb96e764f21e7c750ca6b91a92b15 Reviewed-on: https://gerrit.libreoffice.org/73682 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08Fix typoAndrea Gelmini1-1/+1
Change-Id: I3c1e4697282f4ccc4ef0b0cea28b55ea20e9189b Reviewed-on: https://gerrit.libreoffice.org/73691 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08Fix typoAndrea Gelmini1-1/+1
Change-Id: I8327e8ba6be8122636d1203cefa8d33ac498c112 Reviewed-on: https://gerrit.libreoffice.org/73687 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08Fix typoAndrea Gelmini1-1/+1
Change-Id: Ifc02d4d56b5068af0c6c73a9138e4ada1a8bbd5f Reviewed-on: https://gerrit.libreoffice.org/73690 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08Fix typoAndrea Gelmini1-1/+1
Change-Id: I1d1b0a678e4d21367349178467d18eef00a98621 Reviewed-on: https://gerrit.libreoffice.org/73688 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08Fix typoAndrea Gelmini1-1/+1
Change-Id: If45e9c127027adc20edbddf31907db257c0ef8f0 Reviewed-on: https://gerrit.libreoffice.org/73686 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-08KDE5 merge KDE5SalGraphics into Qt5SvpGraphicsJan-Marek Glogowski13-214/+117
Nothing KDE specific left in there, so just merge it. Change-Id: I11712961f2abc5e11256a158300ec6b388f9ee44 Reviewed-on: https://gerrit.libreoffice.org/73680 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-08qtcreator: Take over '-std=...' from CXXFLAGSMichael Weghorn1-1/+14
If the '-std=' compiler flag is set in CXXFLAGS, take that over into the .pro files used by Qt Creator. This makes ClangCodeModel use the correct std version, and e.g. know about 'std::string_view' if '-std=gnu++2a' (or anything else indicating C++17 or higher is supported) is used and thus avoids unnecessary errors/warnings from being displayed. Use a list, so other flags can easily be added later. (It currently doesn't seem reasonable to me to just pass all cxxflags though, since .pro files are currently only generated per top-level module, while C++ flags can differ between different targets in the same module). Change-Id: Id3f3e2b9ba77e5220a17fd4796937c816979959a Reviewed-on: https://gerrit.libreoffice.org/73677 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-06-08Drop SwAttrHandler::SwAttrStack; use std::vector insteadMike Kaganski2-141/+35
Change-Id: I3e6257cc34782ca32fb2a7c87c9976494b36907b Reviewed-on: https://gerrit.libreoffice.org/73660 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-08tdf#125673 KDE5 implement a KDE5SalVirtualDeviceJan-Marek Glogowski7-6/+72
We just need AcquireGraphics() to return a KDE5Graphics. Otherwise the BufferDevice's SVP will use a SvpSalGraphics instead of the KDE5Graphics, which knows about Qt's theming. Change-Id: I0ea646df260f2067d61c753f03dee01a003f382a Reviewed-on: https://gerrit.libreoffice.org/73673 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-07Related: tdf#111522 svx: fix crash with view1 doing textedit and resize/rotateMiklos Vajna3-13/+20
The two actually affected functions are SdrEditView::RotateMarkedObj() and SdrDragObjOwn::EndSdrDrag(), but it looks like the other functions in SdrEditView are safe to be changed the same way. I expect IsUndoEnabled() can't be changed, though: that would mean there would be no undo for the text edit itself, either. If other actions still crash, the pattern is the same: put a breakpoint on the SdrUndoAction constructor and see the backtrace to find the function that calls IsUndoEnabled() without calling CanDoSdrUndo() at the same time. Change-Id: If9324e311ec6e9f68a951559e903e14bb72ea31c Reviewed-on: https://gerrit.libreoffice.org/73669 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-07tdf#125551 PPTX export: correct position and size of diagramsGrzegorz Araminowicz3-4/+31
Save position and size of diagram background instead of whole group shape. Some diagrams contain shapes that are outside these boundaries. That caused diagram to grow and move. Change-Id: I909c13a5dc268f77832234b3884b91292922823c Reviewed-on: https://gerrit.libreoffice.org/73663 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-06-07notebookbar_compact updateandreas kainz5-1207/+4388
Change-Id: I256c2ec3934d728b5b68fbca8b7ba99a50a840ff Reviewed-on: https://gerrit.libreoffice.org/73661 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-07tdf#125563 Adapt adjustment values to binary shape geometryRegina Henschel2-19/+58
All presetTextWarp shapes are mapped to MS binary WordArt geometry in current implementation. But they use different reference systems for coordinates and different unit for angles. So _all_ adjustment values have to be adapted. Error was, that only angles were treated. Correct test file to actually contain the claimed 213.25 degree. Other bugs than adjustment values will be addressed in separate issues. Change-Id: I719b364af23887e50f003cf9878665755b8989ae Reviewed-on: https://gerrit.libreoffice.org/73624 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-06-07Don't reset PYTHON_VERSION if it was explicitly passed inStephan Bergmann1-5/+9
...along with PYTHON, PYTHON_CFLAGS, and PYTHON_LIBS. (PYTHON_VERSION is apparently set by AM_PATH_PYTHON. When explicitly passing in PYTHON_CFLAGS and PYTHON_LIBS under --enable-python=system, AM_PATH_PYTHON does not get called, but PYTHON_VERSION needs to be set, so needs to be passed in explicitly.) Change-Id: Ia8c3877fffd8dcc179a56be04627c61a667d8cb0 Reviewed-on: https://gerrit.libreoffice.org/73662 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-07Resolves: tdf#125761 there is no page called 'labelTP_BACKGROUND'Caolán McNamara1-1/+0
Change-Id: Ia6558039da010b0f6d8385e9791c0abc2ef75eba Reviewed-on: https://gerrit.libreoffice.org/73665 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-07tdf#125624: this bugdoc overflows sal_uInt16Mike Kaganski2-12/+12
Change-Id: I8ecc08d3ef42b9f7cc501017e0e169bde2196317 Reviewed-on: https://gerrit.libreoffice.org/73654 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-07fix assert in make screenshotNoel Grandin1-1/+1
after commit a46a257794f1f53b294735fc876c394be23a3811 Date: Wed Jun 5 15:24:04 2019 +0200 improve empty tools::Rectangle (width) Change-Id: I496d92712aa7627f7d6932d7d01f70a68a1ee781 Reviewed-on: https://gerrit.libreoffice.org/73657 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-07lok: re-factor getTextSelection.Michael Meeks16-197/+248
Change-Id: I2c27c213ee980e19d6020e9599b2b72115e7f28e Reviewed-on: https://gerrit.libreoffice.org/73626 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-07tdf#117347 sw form controls: fix disappearing FixedText when editing TextFieldMiklos Vajna1-2/+2
This is nominally a regression from commit af11abf3626e12d2b4b7dd9d255c6c71bf84cd4b (SwViewShell::ImplEndAction: still paint directly when non-double-buffering, 2015-09-01), but that just uncovered an already existing problem introduced earlier in commit 2b26c1796d0a05f47cfb01d79ee4f69344efbbb2 (tdf#92577 sw rendercontext: paint transparent from controls conditionally, 2015-07-06). Given that the first commit (as a side-effect) solved the problem the second commit tried to solve, it's safe to just revert this. (Sadly we have no way to test incremental paints with a reasonable amount of effort, so no testcase.) Change-Id: Ia59efbf45a0cd5af3580914e1dcee74d89068f03 Reviewed-on: https://gerrit.libreoffice.org/73647 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-07android: Fix build after welding AboutDialog.Jan Holesovsky4-4/+8
Without this, the vcl's AboutDialog conflicts with the AboutDialog from cui during linking of liblo-native-code.so. Change-Id: Ie6e5ddd52bb7bdee1c7d53c37ea566d7ce6c9385 Reviewed-on: https://gerrit.libreoffice.org/73613 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-07drop some unneeded includesCaolán McNamara2-2/+0
Change-Id: Ifdafc97c8616da5d844a1ade7694265a833e8f53 Reviewed-on: https://gerrit.libreoffice.org/73598 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-07Drop support for gstreamer-0.10Michael Weghorn19-291/+10
Drop all GStreamer 0.10 support according to ESC decision of 2019-06-06. GStreamer 0.10 is obsolete and no longer needed, superseded by GStreamer 1.0 which is available in baseline (RHEL 7 or CentOS 7) and all relevant distros. Change-Id: Ic317eba04d2c17e141acc983f37fbfa4301c9f3f Reviewed-on: https://gerrit.libreoffice.org/73619 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-06-07improve empty tools::Rectangle (width)Noel Grandin15-71/+137
This is the width part, the height part will come next. Instead of storing "empty" as a special value (which is easy to get wrong, eg. some image filters pass in that special value, expecting it to be a valid width), just use separate boolean values for width and height empty. Also lots of code was calling GetBottom() or GetRight() on an empty rectangle, getting back that magic value and doing calculations on it, resulting in completely bogus data. So (1) make the various Rectangle methods do something reasonable when the empty flags are set (2) fix various other code to handle empty better (3) assert when code accesses Bottom or Right and the empty flag is set. Change-Id: I1163378cd2773dd8b386210f83400bb6b4701069 Reviewed-on: https://gerrit.libreoffice.org/73564 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-07tdf#42949 Fix IWYU warnings in svl/Gabor Kelemen107-160/+62
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Except source/svdde/* which is WIN-specific Also recheck include/svl Change-Id: I32d3bcb6b14665c56c07a2f10526329b08c64cbe Reviewed-on: https://gerrit.libreoffice.org/73630 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-07sw btlr writing mode: DOCX drawingML import for fly framesMiklos Vajna4-23/+22
By using the now working btlr direction of the underlying fly frame, instead of the character-level workaround. Change-Id: I3024e3348a30c72f461032b03b88c210f25eb75a Reviewed-on: https://gerrit.libreoffice.org/73628 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-07Bin the much too verbose SAL_INFO() calls for the "vcl.cg" tagTor Lillqvist8-212/+5
Quikee agreed that they aren't really useful. Doing even the simplest things causes such a huge amount of logging that it is questionable whether anybody could have any use of it. Parts of it might be useful to restore later, if need arises. Like the mnContextStackDepth logging in vcl/inc/quartz/CGHelpers.hxx. Change-Id: If635e6492a50e5955c56c54fa310e7c0ab2986ae Reviewed-on: https://gerrit.libreoffice.org/73639 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-06-07Fix typoAndrea Gelmini1-1/+1
Change-Id: I0037cf0a59189862ad502bfbdb00580ed7378fe4 Reviewed-on: https://gerrit.libreoffice.org/70393 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typoAndrea Gelmini1-1/+1
Change-Id: I4b4f0d6c96d85d050110ff39db2cc06bb1d666c2 Reviewed-on: https://gerrit.libreoffice.org/70690 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typosAndrea Gelmini2-2/+2
Change-Id: Iec0824418063fa4d146d9d48f3c74561fc0c5a67 Reviewed-on: https://gerrit.libreoffice.org/73631 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typosAndrea Gelmini1-3/+3
Change-Id: If9d52bd769d96865a3fbfdda1f339bbd0f8c3ca3 Reviewed-on: https://gerrit.libreoffice.org/73633 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-07Fix typoAndrea Gelmini1-1/+1
Change-Id: Ie9174d46b3936ee19a7d1e70f85af6fed2c0c6d4 Reviewed-on: https://gerrit.libreoffice.org/73637 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-16 03:58:06 +0000