summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-11-22[API Change] revert incompatible change of enum css::sheet::GeneralFunctionEike Rathke8-8/+32
Quick solution before 5-3 branch off without reverting everything related. This will need a new constant value type for API instead of the enum and an internal mapping from/to the enum. Kept the GeneralFunction_MEDIAN at all places in uing code so it can be easily grep'ed for. Change-Id: I95256649f16ded08e467003d2924be0ff5efb87f
2016-11-22Probably a more robust way to fix the testKhaled Hosny1-2/+1
Change-Id: Ib62df74ee8a53dac13c0ca8a839096932cf84c20
2016-11-22OPreparedStatement::m_aTypeInfo is unusedStephan Bergmann5-9/+7
Change-Id: I89a43b06a9983e2fac374298db2fef17f3671ab5
2016-11-22Revert "Timer::Start must be called with SolarMutex locked"Stephan Bergmann1-5/+4
This reverts commit 1c3e88a4ffd927d4dda8bb9e0d05cddc6cd685c0; the static AutoRecovery instance is only destroyed during exit, but wants to use SolarMutex; that causes crashes at least in CppunitTest_services. Apparently needs more thought.
2016-11-22tdf#55469 Consistent line spacing across platformsKhaled Hosny8-93/+160
We current use platform APIs to calculate line spacing, however different platforms behave differently: * FreeType and Core Text will prefer hhea table over OS/2, and OS/2 Typo metrics over Win ones. * GDI’s TEXTMETRIC only uses OS/2 Win metrics, while NEWTEXTMETRIC seems to use Typo one, but we use only the old TEXTMETRIC. So we get inconsistent line spacing and we have no control which of three competing sets of line spacing metrics we end up using. The current conventional wisdom is that: * hhea metrics should be used, since hhea is a mandatory font table and should always be present. * But if OS/2 is present, it should be used since it is mandatory in Windows. OS/2 has Typo and Win metrics, but the later was meant to control text clipping not line spacing and can be ridiculously large. Unfortunately many Windows application incorrectly use the Win metrics (thanks to GDI’s TEXTMETRIC) and old fonts might be designed with this in mind, so OpenType introduced a flag for fonts to indicate that they really want to use Typo metrics. So for best backward compatibility: * Use Win metrics if available. * Unless USE_TYPO_METRICS flag is set, in which case use Typo metrics. This patch does this by reading the hhea and OS/2 tables directly and implementing the algorithm above. Quick comparison with Microsoft Office 2016 shows similar line spacing as the new line spacing here, so I guess we are improving compatibility as well. Change-Id: I4541e67e3e14508e3529e73083056a09de02e637 Reviewed-on: https://gerrit.libreoffice.org/31053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-11-22xmlsecurity: no need to inherit from XSecurityController in XSecControllerMiklos Vajna3-15/+0
Change-Id: If26be2b51a1fd8a6ad3e96928e2d142d1ced2845 Reviewed-on: https://gerrit.libreoffice.org/31074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-22loplugin:datamembershadowStephan Bergmann2-4/+4
Change-Id: If9e9371569750dd2c970450b808c6c5567faae55
2016-11-22Timer::Start must be called with SolarMutex lockedStephan Bergmann1-4/+5
cf. DBG_TESTSOLARMUTEX added to Scheduler::Start in c00d8271ba443c4f0acf657c226eea4824597f95 "vcl: assert solar mutex is held for various timer / scheduler ops." So cover operations on AutoRecovery::m_aTimer with SolarMutexGuard instead of AutoRecovery's own mutex. Is it safe to split guarding like that here? Hopefully. Would it be better to exclusively use SolarMutexGuard? Maybe. The DBG_TESTSOLARMUTEX assert fired at least on macOS when opening some .odb file: > frame #19: 0x00007fffc80e5893 libsystem_c.dylib`__assert_rtn + 320 > frame #20: 0x000000010f5e4dae libvcllo.dylib`ImplDbgTestSolarMutex() + 110 at vcl/source/app/dbggui.cxx:47 > frame #21: 0x000000010e6a5d62 libtllo.dylib`DbgTestSolarMutex() + 130 at tools/source/debug/debug.cxx:74 > frame #22: 0x000000010f5eeb3a libvcllo.dylib`Scheduler::Start(this=0x00000001489233a8) + 58 at vcl/source/app/scheduler.cxx:287 > frame #23: 0x000000010f62f03f libvcllo.dylib`Timer::Start(this=0x00000001489233a8) + 31 at vcl/source/app/timer.cxx:93 > frame #24: 0x00000001481b7483 libfwklo.dylib`(anonymous namespace)::AutoRecovery::implts_updateTimer(this=0x00000001489232a0) + 259 at framework/source/services/autorecovery.cxx:2274 > frame #25: 0x00000001481b3009 libfwklo.dylib`(anonymous namespace)::AutoRecovery::changesOccurred(this=0x00000001489232a0, aEvent=0x00007f92d87d0ec8) + 649 at framework/source/services/autorecovery.cxx:1678 > frame #26: 0x000000014807e04b libfwklo.dylib`framework::WeakChangesListener::changesOccurred(this=0x0000000148c42488, rEvent=0x00007f92d87d0ec8) + 155 at framework/inc/helper/mischelper.hxx:222 > frame #27: 0x000000011c13f29e libconfigmgrlo.dylib`configmgr::Broadcaster::send(this=0x00007000082f9e70) + 5694 at configmgr/source/broadcaster.cxx:187 > frame #28: 0x000000011c0fd9bc libconfigmgrlo.dylib`configmgr::Access::insertByName(this=0x0000000148c118e0, aName=0x00007000082fa258, aElement=0x00007000082fa118) + 3196 at configmgr/source/access.cxx:1232 > frame #29: 0x00000001481bdd23 libfwklo.dylib`(anonymous namespace)::AutoRecovery::implts_flushConfigItem(this=0x00000001489232a0, rInfo=0x00007000082fa600, bRemoveIt=false)::AutoRecovery::TDocumentInfo const&, bool) + 2483 at framework/source/services/autorecovery.cxx:2092 > frame #30: 0x00000001481bb09d libfwklo.dylib`(anonymous namespace)::AutoRecovery::implts_registerDocument(this=0x00000001489232a0, xDocument=0x00007000082fa790) + 3597 at framework/source/services/autorecovery.cxx:2519 > frame #31: 0x00000001481b2a35 libfwklo.dylib`(anonymous namespace)::AutoRecovery::documentEventOccured(this=0x00000001489232a0, aEvent=0x00007f92db3d8620) + 165 at framework/source/services/autorecovery.cxx:1571 > frame #32: 0x00000001481d025b libfwklo.dylib`framework::WeakDocumentEventListener::documentEventOccured(this=0x0000000148c42548, rEvent=0x00007f92db3d8620) + 155 at framework/inc/helper/mischelper.hxx:258 > frame #33: 0x0000000109fca69e libsfxlo.dylib`comphelper::OInterfaceContainerHelper2::NotifySingleListener<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>::operator(this=0x00007000082fa910, listener=0x00007000082fa880)(com::sun::star::uno::Reference<com::sun::star::document::XDocumentEventListener> const&) const + 126 at include/comphelper/interfacecontainer2.hxx:272 > frame #34: 0x0000000109fca4a3 libsfxlo.dylib`void comphelper::OInterfaceContainerHelper2::forEach<com::sun::star::document::XDocumentEventListener, comphelper::OInterfaceContainerHelper2::NotifySingleListener<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent> >(this=0x00000001489186b8, func=0x00007000082fa910) + 163 at include/comphelper/interfacecontainer2.hxx:285 > frame #35: 0x0000000109fca0de libsfxlo.dylib`void comphelper::OInterfaceContainerHelper2::notifyEach<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>(this=0x00000001489186b8, NotificationMethod=21 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00, Event=0x00007f92db3d8620)(com::sun::star::document::DocumentEvent const&), com::sun::star::document::DocumentEvent const&) + 126 at include/comphelper/interfacecontainer2.hxx:298 > frame #36: 0x0000000109fc9f08 libsfxlo.dylib`(anonymous namespace)::SfxGlobalEvents_Impl::implts_notifyListener(this=0x0000000148918628, aEvent=0x00007f92db3d8620) + 168 at sfx2/source/notify/globalevents.cxx:438 > frame #37: 0x0000000109fc6874 libsfxlo.dylib`(anonymous namespace)::SfxGlobalEvents_Impl::documentEventOccured(this=0x0000000148918628, Event=0x00007f92db3d8620) + 132 at sfx2/source/notify/globalevents.cxx:243 > frame #38: 0x000000014957597e libdbalo.dylib`comphelper::OInterfaceContainerHelper2::NotifySingleListener<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>::operator(this=0x00007000082fab30, listener=0x00007000082faaa0)(com::sun::star::uno::Reference<com::sun::star::document::XDocumentEventListener> const&) const + 126 at include/comphelper/interfacecontainer2.hxx:272 > frame #39: 0x0000000149575753 libdbalo.dylib`void comphelper::OInterfaceContainerHelper2::forEach<com::sun::star::document::XDocumentEventListener, comphelper::OInterfaceContainerHelper2::NotifySingleListener<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent> >(this=0x00007f92db0965f0, func=0x00007000082fab30) + 163 at include/comphelper/interfacecontainer2.hxx:285 > frame #40: 0x000000014957407e libdbalo.dylib`void comphelper::OInterfaceContainerHelper2::notifyEach<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>(this=0x00007f92db0965f0, NotificationMethod=21 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00, Event=0x00007f92db3d8620)(com::sun::star::document::DocumentEvent const&), com::sun::star::document::DocumentEvent const&) + 126 at include/comphelper/interfacecontainer2.hxx:298 > frame #41: 0x0000000149573dfb libdbalo.dylib`dbaccess::DocumentEventNotifier_Impl::impl_notifyEvent_nothrow(this=0x00007f92db0965a0, _rEvent=0x00007f92db3d8620) + 379 at dbaccess/source/core/dataaccess/documenteventnotifier.cxx:196 > frame #42: 0x0000000149574580 libdbalo.dylib`dbaccess::DocumentEventNotifier_Impl::processEvent(this=0x00007f92db0965a0, _rEvent=0x00007f92db3d8610) + 224 at dbaccess/source/core/dataaccess/documenteventnotifier.cxx:229 > frame #43: 0x000000010832ba30 libcomphelper.dylib`comphelper::AsyncEventNotifierBase::execute(this=0x000000014df32dd0) + 1184 at comphelper/source/misc/asyncnotification.cxx:163 > frame #44: 0x000000010832e28a libcomphelper.dylib`comphelper::AsyncEventNotifierAutoJoin::run(this=0x000000014df32dd0) + 90 at comphelper/source/misc/asyncnotification.cxx:263 > frame #45: 0x000000010832f23e libcomphelper.dylib`::threadFunc(param=0x000000014df32dd0) + 30 at include/osl/thread.hxx:185 > frame #46: 0x0000000107e9bc27 libuno_sal.dylib.3`osl_thread_start_Impl(pData=0x00007f92db351d30) + 295 at sal/osl/unx/thread.cxx:240 > frame #47: 0x00007fffc82a1aab libsystem_pthread.dylib`_pthread_body + 180 > frame #48: 0x00007fffc82a19f7 libsystem_pthread.dylib`_pthread_start + 286 > frame #49: 0x00007fffc82a1221 libsystem_pthread.dylib`thread_start + 13 Change-Id: I58fe8d61bfc491fa635b75d471a221bbb55c0f6e
2016-11-22improvements to gbuildtoideBjoern Michaelsen2-5/+74
- move supported module selection from the test directly into gbuild, it should not be possible now to have 'make gbuildtoide' failing, it should skip problematic parts - move from whitelisting to blacklisting bad modules - toplevel 'make gbuildtoide' should work now, so add test (limit to non-Windows for now, as Windows is stupid and slow) - remove spurious debug output in test Change-Id: I9838dd2fa091e5fb3e56f414f60164086e8f2076 Reviewed-on: https://gerrit.libreoffice.org/31072 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-11-22Destroy item sets in SdDialogsTest::tearDownStephan Bergmann1-0/+3
...as they apparently hold raw pointers to objects destroyed early, so only destroying the item sets in the SdDialogsTest dtor caused use-after-free crashes during shutdown. Change-Id: Ibe3848c81a56fb0db4bf1fca0eab35836aab6a66
2016-11-22external/icu: Silence -fsanitize=nullStephan Bergmann1-0/+10
...as seen during CppunitTest_sd_dialogs_test: > collationdatareader.cpp:422:13: runtime error: null pointer passed as argument 1, which is declared to never be null > /usr/include/string.h:66:33: note: nonnull attribute specified here > #0 0x7fc3fc837f72 in icu_58::CollationDataReader::read(icu_58::CollationTailoring const*, unsigned char const*, int, icu_58::CollationTailoring&, UErrorCode&) workdir/UnpackedTarball/icu/source/i18n/collationdatareader.cpp:422:13 > #1 0x7fc3fc7fc0bb in icu_58::CollationLoader::loadFromData(UErrorCode&) workdir/UnpackedTarball/icu/source/i18n/ucol_res.cpp:395:5 > #2 0x7fc3fc7fad16 in icu_58::CollationLoader::loadFromCollations(UErrorCode&) workdir/UnpackedTarball/icu/source/i18n/ucol_res.cpp:376:16 > #3 0x7fc3fc7f0c74 in icu_58::CollationLoader::createCacheEntry(UErrorCode&) workdir/UnpackedTarball/icu/source/i18n/ucol_res.cpp:221:16 > #4 0x7fc3fc7f079e in icu_58::LocaleCacheKey<icu_58::CollationCacheEntry>::createObject(void const*, UErrorCode&) const workdir/UnpackedTarball/icu/source/i18n/ucol_res.cpp:144:20 > #5 0x7fc4262d558f in icu_58::UnifiedCache::_get(icu_58::CacheKeyBase const&, icu_58::SharedObject const*&, void const*, UErrorCode&) const workdir/UnpackedTarball/icu/source/common/unifiedcache.cpp:409:17 > #6 0x7fc3fc806774 in void icu_58::UnifiedCache::get<icu_58::CollationCacheEntry>(icu_58::CacheKey<icu_58::CollationCacheEntry> const&, void const*, icu_58::CollationCacheEntry const*&, UErrorCode&) const workdir/UnpackedTarball/icu/source/i18n/../common/unifiedcache.h:234:8 > #7 0x7fc3fc7f1c93 in icu_58::CollationLoader::getCacheEntry(UErrorCode&) workdir/UnpackedTarball/icu/source/i18n/ucol_res.cpp:466:12 > #8 0x7fc3fc7f76d4 in icu_58::CollationLoader::loadFromBundle(UErrorCode&) workdir/UnpackedTarball/icu/source/i18n/ucol_res.cpp:299:16 > #9 0x7fc3fc7f0ae5 in icu_58::CollationLoader::createCacheEntry(UErrorCode&) workdir/UnpackedTarball/icu/source/i18n/ucol_res.cpp:219:16 > #10 0x7fc3fc7f079e in icu_58::LocaleCacheKey<icu_58::CollationCacheEntry>::createObject(void const*, UErrorCode&) const workdir/UnpackedTarball/icu/source/i18n/ucol_res.cpp:144:20 > #11 0x7fc4262d558f in icu_58::UnifiedCache::_get(icu_58::CacheKeyBase const&, icu_58::SharedObject const*&, void const*, UErrorCode&) const workdir/UnpackedTarball/icu/source/common/unifiedcache.cpp:409:17 > #12 0x7fc3fc806774 in void icu_58::UnifiedCache::get<icu_58::CollationCacheEntry>(icu_58::CacheKey<icu_58::CollationCacheEntry> const&, void const*, icu_58::CollationCacheEntry const*&, UErrorCode&) const workdir/UnpackedTarball/icu/source/i18n/../common/unifiedcache.h:234:8 > #13 0x7fc3fc7f1c93 in icu_58::CollationLoader::getCacheEntry(UErrorCode&) workdir/UnpackedTarball/icu/source/i18n/ucol_res.cpp:466:12 > #14 0x7fc3fc7f5a19 in icu_58::CollationLoader::loadFromLocale(UErrorCode&) workdir/UnpackedTarball/icu/source/i18n/ucol_res.cpp:247:16 > #15 0x7fc3fc7f0956 in icu_58::CollationLoader::createCacheEntry(UErrorCode&) workdir/UnpackedTarball/icu/source/i18n/ucol_res.cpp:217:16 > #16 0x7fc3fc7f079e in icu_58::LocaleCacheKey<icu_58::CollationCacheEntry>::createObject(void const*, UErrorCode&) const workdir/UnpackedTarball/icu/source/i18n/ucol_res.cpp:144:20 > #17 0x7fc4262d558f in icu_58::UnifiedCache::_get(icu_58::CacheKeyBase const&, icu_58::SharedObject const*&, void const*, UErrorCode&) const workdir/UnpackedTarball/icu/source/common/unifiedcache.cpp:409:17 > #18 0x7fc3fc806774 in void icu_58::UnifiedCache::get<icu_58::CollationCacheEntry>(icu_58::CacheKey<icu_58::CollationCacheEntry> const&, void const*, icu_58::CollationCacheEntry const*&, UErrorCode&) const workdir/UnpackedTarball/icu/source/i18n/../common/unifiedcache.h:234:8 > #19 0x7fc3fc7f1c93 in icu_58::CollationLoader::getCacheEntry(UErrorCode&) workdir/UnpackedTarball/icu/source/i18n/ucol_res.cpp:466:12 > #20 0x7fc3fc7f1525 in icu_58::CollationLoader::loadTailoring(icu_58::Locale const&, UErrorCode&) workdir/UnpackedTarball/icu/source/i18n/ucol_res.cpp:164:19 > #21 0x7fc3fc7ba783 in icu_58::Collator::makeInstance(icu_58::Locale const&, UErrorCode&) workdir/UnpackedTarball/icu/source/i18n/coll.cpp:460:40 > #22 0x7fc3fc7bb891 in icu_58::Collator::createInstance(icu_58::Locale const&, UErrorCode&) workdir/UnpackedTarball/icu/source/i18n/coll.cpp:448:16 > #23 0x7fc3f196cf17 in com::sun::star::i18n::Collator_Unicode::loadCollatorAlgorithm(rtl::OUString const&, com::sun::star::lang::Locale const&, int) i18npool/source/collator/collator_unicode.cxx:375:57 > #24 0x7fc3f1945c22 in com::sun::star::i18n::CollatorImpl::loadCollatorAlgorithm(rtl::OUString const&, com::sun::star::lang::Locale const&, int) i18npool/source/collator/collatorImpl.cxx:93:25 > #25 0x7fc3f1944a53 in com::sun::star::i18n::CollatorImpl::loadDefaultCollator(com::sun::star::lang::Locale const&, int) i18npool/source/collator/collatorImpl.cxx:79:20 > #26 0x7fc41d2c12e6 in CollatorWrapper::loadDefaultCollator(com::sun::star::lang::Locale const&, int) unotools/source/i18n/collatorwrapper.cxx:75:45 Change-Id: I21868c0a80e06587f9ed802ec3f8d5a89f3cb9aa
2016-11-22Exit gb_CppunitTest_localized loop on first failureStephan Bergmann2-2/+3
...instead of ignoring failures in every but the last iteration Change-Id: Ie80e78f75aaec5e9b1625c2e1ef740adf31fab1b
2016-11-22Resolves: rhbz#1397181 toolbar layout manager not respecting drag cancelCaolán McNamara3-0/+8
plus restore original mbDockCanceled state after wayland-enforced cancel otherwise next drag won't work Change-Id: Idefed25b925b36d0bf72b77609c4fc2eb47f71b9
2016-11-22Executable_pdfverify: move pdfverify.cxx to workben/Miklos Vajna2-1/+1
That's where the implementation of such internal test binaries usually are. Change-Id: Ib7d2eb95de96d0d82e90e51f58da3a0c15a2ec71 Reviewed-on: https://gerrit.libreoffice.org/31073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-22vcl NSS PDF sign: write IssuerSerial sequenceMiklos Vajna1-0/+78
Nominally this is optional, but RFC 5035 says: "The encoding of the ESSCertIDv2 for this certificate SHOULD include the issuerSerial field." So do write it, it fixes a warning issued by the PAdES validator from <https://github.com/esig/dss>. Change-Id: I344f79e17febe82a697a0936a837c17aefa242df
2016-11-22Retain sheet protect options throughout unprotect/protect sessionMike Kaganski1-5/+8
Currently, unprotecting a sheet clears the protection options it had (i.e. if to allow users to select protected/unprotected cells). So, protecting next time requires setting these options again. Unprotecting a sheet usually happens when author edits e.g. a form and intents to re-protect it when the edit is done, so it would be handy to restore previous flags as they were before. This patch allows saving the protection settings by using current ScTableProtection copy with its protection set to appropriate value, instead of new clean ScTableProtection or nullptr. This does not allow to save the flags between edit sessions if the protection is unset. Change-Id: Ieaba4eee746efcf05308dbc88e402c200a59b0d2 Reviewed-on: https://gerrit.libreoffice.org/31044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-11-22tdf#71409: Stop listening to objects going out-of-focus.Kohei Yoshida2-0/+22
This helps eliminate the number of AtkListener objects growing over time. Change-Id: I5cfeac8beae8e950382116544da99ad9c1c1a254 Reviewed-on: https://gerrit.libreoffice.org/31062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-22tdf#71409: Use weak reference to avoid potential circular references.Kohei Yoshida13-253/+201
AtkListener shouldn't be holding a reference back to the context / broadcaster it listens to, as the latter also holds a reference to the former. Change-Id: Ie75cc4667f614752db710c20acbb83b93783654f Reviewed-on: https://gerrit.libreoffice.org/31063 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-22remove some more global OUStringsNoel Grandin12-108/+56
Change-Id: Ic02754f98bfda3b7cd8c06857123d363a96e8d0e Reviewed-on: https://gerrit.libreoffice.org/31071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-22trivial makefile cleanupsMichael Stahl12-37/+14
Change-Id: Ida5bdfa06ecd7907305f4f171ca5ab64260d0259
2016-11-22loplugin:countusersofdefaultparams in include/sfx2Noel Grandin30-50/+49
Change-Id: I8b5e3ebbfb715d0b6aec2c4137f0ff524b63227e Reviewed-on: https://gerrit.libreoffice.org/31065 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-22New loplugin:oslendianStephan Bergmann5-0/+214
...to catch new places where defined'ness of OSL_BIG/LITENDIAN would be checked without osl/endian.h being included; cf. e2f08f9def0869460ad38a1c2adb450778290f6e "connectivity, sc: add missing #include <osl/endian.h>" and 2b14fb3a4f92b928f0a5fc536c6a5f4a6e51a9b8 "cppcanvas, oox: add missing #include <osl/endian.h>". Change-Id: I167c8916a01391b7dacad7325153ccf35d3ba9dc
2016-11-22Add the missing Adobe Symbol Encoding glyphsKhaled Hosny2-4/+616
Copied from SymbolNeu font which is metric compatible with Microsoft’s Symbol font, from: http://commondatastorage.googleapis.com/chromeos-localmirror/distfiles/croscorefonts-1.23.0.tar.gz With the following license: Licensed under the Apache License, Version 2.0 This fixes the original issue that was fixed in: commit 8556cd881270823865662e9a7700da58d11c2785 Author: Miklos Vajna <vmiklos@collabora.co.uk> Date: Thu Mar 6 09:48:54 2014 +0100 cp#1000039 DOC import: ignore symbol charset of the symbol font Which was reverted in: commit d8c386593e42e1f0cce52d052b1009c59e75afa2 Author: Khaled Hosny <khaledhosny@eglug.org> Date: Thu Nov 17 15:03:39 2016 +0200 tdf#103944: Fix symbol font remapping No test this time, as I don’t think we can currently test which glyph ended up being used (or the visual rendering of the document). Change-Id: I82aef00862502fbe69d94a228307b8cff97ab336 Reviewed-on: https://gerrit.libreoffice.org/30961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-22Updated coreAndras Timar1-0/+0
Project: translations f88396624a2f348f845818564210947f3e738e55 Updated Slovenian translation Change-Id: I5766d65b3a525745e7d02c316ab2b27ac79a448f
2016-11-22Sort lines lexicographicallyStephan Bergmann1-2/+2
Change-Id: I4dc6bebb41b0e1beee58631fdf92dea82ae38db7
2016-11-22tdf#102872 Add qa unit test for BASIC methodsLaurent Balland-Poirier7-0/+439
Add test if several methods still works Change-Id: I8d26e5e3555dbbc0f07152138e1bc0cd65d90998 Reviewed-on: https://gerrit.libreoffice.org/30166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
2016-11-22tdf#103982 DOCX export: make sure SdrObject margin is non-negativeMiklos Vajna3-4/+19
Regression from commit a5a836d8c43dc9cebbbf8af39bf0142de603a7c6 (DOCX filter: effect extent should be part of the margin, 2014-12-04), the effect extent is added to the nominal margin in DOCX, so we exclude that from the margin in our document model. But it shouldn't be ever negative, ST_WrapDistance is a restriction of the W3C XML Schema unsignedInt datatype. Change-Id: I82b3c1ba0e3a14f7c585b0d389264a2c12e454e7 Reviewed-on: https://gerrit.libreoffice.org/31064 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-22tdf#80196 - Standardized color palette normalized by graytonevsfoote2-0/+124
mathematically generated colors, attachment 101316 attachment 104623 authored by Wade D. Peterson contributed CC0 in the public domain Change-Id: I06b1b58b1c9e8cf2ef15e581fcf148b74ed36301 Reviewed-on: https://gerrit.libreoffice.org/31061 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-11-22Revert "tdf#80196 - Standardize color palette using mathematically generated ↵V Stuart Foote1-161/+0
colors" This reverts commit 6f3bf1cdc48b62caec1e54a6aa6db41b4a56d1c4. Change-Id: Id077d1603ff2a5c82ba56b700b5e1fdfa637c877 Reviewed-on: https://gerrit.libreoffice.org/31054 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-11-22Make sure there's a single global RTTI for SfxLinkItemStephan Bergmann1-1/+1
...as otherwise dynamic_cast<SfxLinkItem*>(...) could fail at least on macOS (as observed with CppunitTest_sc_screenshots) Change-Id: I4a41a8b085b839598119791637f79cd467ad4130
2016-11-22tdf#101789 work around DYLD_LIBRARY_PATH limitations on newer MacOS XLionel Elie Mamane2-2/+7
Change-Id: I6e3cbff1ec7a75e896ba5bafb9d1fbccc3bc8909
2016-11-22remove redundant space in stringStanislav Horacek1-1/+1
Change-Id: I7fbfe0ac11ef5dbe23b0fa3864c647682d1a73a7 Reviewed-on: https://gerrit.libreoffice.org/30938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-22re-organise SdrObject class definitionNoel Grandin2-183/+150
it had public/private/protected sections all over the place. Also use loplugin can-be-private analysis to make some fields and methods private. Change-Id: Ibb3c8d1f58753ff5599d94106f0991af152217d2 Reviewed-on: https://gerrit.libreoffice.org/31055 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-22can-be-private analysis needs to ignore virtual methodsNoel Grandin2-9/+32
Change-Id: I1e2f28ed550ff9751912f70e3eec511ddc5b75cf
2016-11-21Remove excessive parenthesis.Kohei Yoshida1-1/+1
Ugly. Change-Id: Ifdb9638e998b83c7aeaf9908f9584ff69d56d7b2
2016-11-22lok: add command values .uno:FontSubsetHenry Castro4-0/+95
Conflicts: desktop/Library_sofficeapp.mk Change-Id: Id36a98c32f0eb5e88e4e9a714e260a71d7465c05 Reviewed-on: https://gerrit.libreoffice.org/31033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-11-22unit test for tdf#104096, ScRange::Parse() with trailing charactersEike Rathke1-0/+4
Change-Id: I5df087b0ad25b78c6badf72afba6c189e48ec7ca
2016-11-21tdf#42949 Remove not needed uno headers from sc/source/coreBartosz Kosiorek17-27/+0
Change-Id: I1fd2b647caaa947390443ec41591a7ea050c4819 Reviewed-on: https://gerrit.libreoffice.org/31046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-21FieldDecl::getParent fires assert for Objective C @interface membersStephan Bergmann1-1/+1
(like in vcl/inc/osx/a11ywrapper.h's AquaA11yWrapper), at least on recent Clang trunk, from within the call to cast() in cast<RecordDecl>(getDeclContext()) as the decl context apparently is something other than a RecordDecl. Change-Id: I238bae44d6db0f04bf8f90b0032489e3b4822eee
2016-11-21Resolves: tdf#104096 reset also rRawRes if trailing characters are presentEike Rathke1-1/+1
... in lcl_ScAddress_Parse_OOo() so that ScRange::Parse() doesn't receive a "partially valid" result and does not attempt to follow the entire column/row path. Change-Id: Ie37c9d22280e30f770422fb621e3b9d972ec1546
2016-11-21loplugin:datamembershadowStephan Bergmann2-12/+11
Change-Id: I773bb19ae33709421fde01426716dcf52065402f
2016-11-21loplugin:datamembershadowStephan Bergmann2-3/+1
shadowed OCatalog::m_xMetaData can be used here directly Change-Id: I1041272b98139fda2413442e4621507655ab67ca
2016-11-21Revert "Revert "std::list<sal_uLong> to deque""Julien Nabet1-2/+3
+ use returned iterator by insert method call This reverts commit 1a583283d6b58c8951cb52faac82ecb24fdbf1b3. Change-Id: I02547663230fb7b5959df349c4d395bbadd74c3b Reviewed-on: https://gerrit.libreoffice.org/30439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-21Fix various "unmapped accelerator key" on MacOsJulien Nabet1-0/+27
Add mapping for: KEY_SEMICOLON KEY_BACKSPACE KEY_PAGEUP KEY_PAGEDOWN KEY_UP KEY_DOWN KEY_RETURN KEY_BRACKETLEFT KEY_BRACKETRIGHT Retrieved from AquaSalFrame::GetKeyName I would have preferred to use this function and remove custom mapping to avoid dup but mapping is a bit different eg: in AquaSalFrame::GetKeyName KEY_A to KEY_Z uses sal_Unicode( 'A' + (i - KEY_A) ) In SetAccelerator, we use sal_Unicode( 'a' + (i - KEY_A) ) and when using GetKeyName, LO segfaults. Change-Id: I3808cdcd1c0566e768a98a211bc1f41ff012a32f Reviewed-on: https://gerrit.libreoffice.org/30909 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-21Delete the "Any-to-Any" template specializations for LIBO_INTERNAL_ONLYStephan Bergmann15-93/+166
i.e., css::uno::Any function template specializations Any::has<Any>() const Any::get(Any const &) const operator >>=(Any const &, Any &) operator <<=(Any &, Any const &) that don't make much sense (the first is always true, the rest can be replaced with operator =, which additionally supports move semantics). For 3rd-party compatibility, do this only for LIBO_INTERNAL_ONLY, however. However, some generic template code did benefit from operator >>= working also for Any, so make up for that with a new (LIBO_INTERNAL_ONLY, given that operator >>= still covers if fine for !LIBO_INTERNAL_ONLY) fromAny, complementing the existing toAny. Change-Id: I8b1b5f803f0b909808159916366d53c948206a88 Reviewed-on: https://gerrit.libreoffice.org/30022 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-21MinorKhaled Hosny1-6/+6
Change-Id: Icb074b628ae479dfe05cc1fe10121f96c492806e
2016-11-21Update the reference rdbs to libreoffice-5-2Stephan Bergmann1-0/+4
(This deliberately leaves out the published css.mozilla.XRemoteServiceManagerProvider originally manually removed from offapi/type_reference/offapi.idl with 4c18af27bf95b332ee2006cfc0bbf469fb1a84d4 "tdf#96398 kill remaining NPAPI support for plugins _inside_ LO" and now fully removed with b5589970125ae4b8c0a091cfc12d058ca42ce2ab "[API CHANGE] Remove tdf#96398 leftover XRemoteServiceManagerProvider".) Change-Id: I75d4cd82ba306099e2563a44739bfb3867a265e9
2016-11-21get table name from resultset simplyWastack9-259/+12
There is a much simpler way to access table name in ResultSetMetadata in Firebird sdbc which I didn't notice before. Change-Id: Ib306c04acf38ec86475d8d1a22a67012fe48539e Reviewed-on: https://gerrit.libreoffice.org/30931 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-11-21[API CHANGE] Remove tdf#96398 leftover XRemoteServiceManagerProviderStephan Bergmann2-50/+0
4c18af27bf95b332ee2006cfc0bbf469fb1a84d4 "tdf#96398 kill remaining NPAPI support for plugins _inside_ LO" had removed various other (also published) offapi/com/sun/star/mozilla/*.idl files, and had included removal of css.mozilla.XRemoteServiceManagerProvider from offapi/type_reference/offapi.idl, but had forgotten to actually remove this .idl file---apparently an oversight. Change-Id: I1a8f0c594829a5dd6025ff6c2b6a6fa9a109ca36
2016-11-21tdf#48140 Replace uno call from worksheethelper.cxxBartosz Kosiorek5-58/+59
Change-Id: Ibf738d67af6536e9300e11f8d4fa3fe79ab7099b Reviewed-on: https://gerrit.libreoffice.org/31006 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-21 16:25:51 +0000