summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-08-20Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' - Cleanups in /shared/00/ Change-Id: I54fc724adac9d08ac6f705933c4b3fc0cf9ffa0b Reviewed-on: https://gerrit.libreoffice.org/57134 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-20TODO: refcount ImplFontListCaolán McNamara10-54/+39
Change-Id: Ie125f1ac9c14a41e25c3e54beafca2f9e34e4c6f Reviewed-on: https://gerrit.libreoffice.org/59310 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-20FindMetricCompatibleFont can take FontSelectPatternAttributesCaolán McNamara1-1/+1
Change-Id: I2a42c469d2ab009c5823fc654912fd20c649d2df Reviewed-on: https://gerrit.libreoffice.org/59323 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-20these just use the base FontSelectPatternAttributesCaolán McNamara2-5/+5
Change-Id: I0c5ffe571c2cf37ec7d20d4d3ae965227cd72b7e Reviewed-on: https://gerrit.libreoffice.org/59314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-20TODO: refcount ImplFontCacheCaolán McNamara9-42/+27
Change-Id: Ia4499c2a1515aebaff9edf0e843fc66c7fb1414e Reviewed-on: https://gerrit.libreoffice.org/59309 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-20tdf#116370 cleanup Writer idle job handingJan-Marek Glogowski5-35/+37
This prevents the start of the idle job, while processing itself, so the fixed WinSalInstance::AnyInput of commit 3bf6c97029d2 ("tdf#112975 WIN correctly handle VclInputFlags::OTHER") won't report the timer events of the re-started idle job to process. Fixes the early abort of the background job, which resulted in the busy loop of the reported bug and this strange printing behaviour. P.S. I'm not sure, why this was just broken on Windows. Change-Id: I6503dcd925c9a0ed843e794a31eea32a4a4b2889 Reviewed-on: https://gerrit.libreoffice.org/59279 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-20tdf#118786 WIN allow nested SendMessage callsJan-Marek Glogowski2-16/+34
This bug trips "assert( !pInst->mbNoYieldLock )". There is already a special case, introduced in commit 4baec725e0dc ("WIN run main thread redirects ignoring SolarMutex"), to prevent tripping the assert for a nested SendMessage call. So this implements a general solution for nested SendMessage calls. We just have to prevent yielding in a call from an other thread, as the sending thread still owns the SolarMutex. This way we can also drop the special handling in WinSalFrame::ReleaseFrameGraphicsDC. Change-Id: I7024b081b26f3545af12a3a3a038fe5e5671af3c Reviewed-on: https://gerrit.libreoffice.org/59275 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-20coverity#1438402 Improper use of negative valueCaolán McNamara1-0/+1
Change-Id: I00aa17ae4fd543faabc4cb7a052e3561da29c1e6 Reviewed-on: https://gerrit.libreoffice.org/59311 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-20loplugin:useuniqueptr in svt::DialogNoel Grandin5-8/+8
Change-Id: Ib13cd74f186de0db1be4414e893b2d4f66048b44 Reviewed-on: https://gerrit.libreoffice.org/59304 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-20return weld widgets by std::unique_ptr from builderNoel Grandin46-273/+298
Change-Id: I20c007b13dae2d1155034711ad1ad48bfdfd0ba8 Reviewed-on: https://gerrit.libreoffice.org/59288 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-20Update git submodulesStanislav Horacek1-0/+0
* Update helpcontent2 from branch 'master' - table is not in Insert menu anymore, use another example Change-Id: Iab50a4452f5b50eade881119f316410a03611265 Reviewed-on: https://gerrit.libreoffice.org/59305 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-19Fix typosAndrea Gelmini1-2/+2
Change-Id: Ib717870185bdf4ac43af8fcd3a7233b051e23d30 Reviewed-on: https://gerrit.libreoffice.org/58888 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-08-19Remove comment leftoversJohnny_M2-4/+0
This is a follow-up to commit 45ec1d9b56cec41596f806ebf845ebfcd30c9f46 , where the respective defines were removed, but their comments stayed behind. Change-Id: I205c5a36e0cd13e67293215c0be730ac7b17f111 Reviewed-on: https://gerrit.libreoffice.org/59284 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-19Translate German commentsJohnny_M4-6/+6
Change-Id: I1a4e41ccd3e3eb829419c45edd0417776a73c3ae Reviewed-on: https://gerrit.libreoffice.org/59285 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-19Translate German variable namesJohnny_M3-4/+4
Change-Id: I6b5fb91cbf32ce082fb77989e1b9ac5e8ecfe438 Reviewed-on: https://gerrit.libreoffice.org/59283 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-19toolkit: a micro-optimization taking min and max simulnateouslyTakeshi Abe1-2/+3
Change-Id: I161dd318b1e5729ef0b8c55a41c0eddc681b153f Reviewed-on: https://gerrit.libreoffice.org/57612 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-19Menubar Calc: update sheet menuentry according to table in writerandreas kainz3-119/+107
Calc sheet menubar entry First section was use the same items than writer so the WriterCategories were moved to GenericCategorie Main benefit is that app specific items are centralized in sheets - Format -> Row, Columns and Merge items are in Sheet on the same subsection than writer - Format -> Print Range was moved from Format to Sheet where SplitTable is in writer - Format -> Conditional and Style stuff was moved to Sheet where the Style stuff is located in writer. In writer there are NO Style items in Format - Tools -> Protect and View -> Protect is centralized in Sheet like in Writer -> Table - Sheet -> Comments are now in Edit -> Comments like i writer open point: Sheet -> Size -> The entries has to be renamed to be more clear (like already in writer) Change-Id: Ic014ccc260dd3264ef6e79a2b71d268e40f22088 Reviewed-on: https://gerrit.libreoffice.org/56912 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-08-19Related: tdf#122166 require opengl >= 3.0 for slide transitionsCaolán McNamara2-3/+1
glGenVertexArrays requires opengl >= 3.0 and since... commit c831e4851f35ddef5ef45062ba291d07dda4b1b4 Date: Wed Dec 9 21:39:27 2015 +0000 slideshow: Fix what was remaining to be able to use a core context we always use that in all slide transitions, so slideshow opengl transitions presumably thus all have a min opengl version of 3.0 Change-Id: Ifb21201fc94c4a911c8d4127d1df1efb3e34a2d8 Reviewed-on: https://gerrit.libreoffice.org/59298 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-19tdf#112166 need to check if glXCreateContextAttribsARB really existsCaolán McNamara1-1/+3
checking the glXCreateContextAttribsARB function pointer will just return the epoxy_glXCreateContextAttribsARB stub which always exists. Change-Id: I740cc680082102c1f9712cf5cc083e92b26f8865 Reviewed-on: https://gerrit.libreoffice.org/59300 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-19tdf#119030: Disable entries if open file read-only is uncheckedXisco Fauli2-0/+16
Change-Id: I9e00094f92210a025537f2115e2529acb82d960f Reviewed-on: https://gerrit.libreoffice.org/58400 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-08-19Writer templates: built from XML codeLaurent BP64-5/+5102
Maintaining XML code is easier if we need to change a font (name or size). See tdf#114749 Change-Id: I1c1e5951c24863be717aef3dd22d533f5fd23a4f Reviewed-on: https://gerrit.libreoffice.org/58787 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-08-19tdf#119321: fix appendCopy in searchAndReplace (printing)Julien Nabet1-1/+1
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=cd66852f6dd08631a25d15a1527a647e69ab8ce3 Change-Id: Iea4b21647dd01406271f9b3e13fea3cc73e1c801 Reviewed-on: https://gerrit.libreoffice.org/59303 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-18tdf#119330: fix regression in SfxNotebookBar.cxxJulien Nabet1-0/+2
See https://bugs.documentfoundation.org/attachment.cgi?id=144272 Change-Id: Ibe36c0bbacc5a36db03129ce139b3b4b1adbbf39 Reviewed-on: https://gerrit.libreoffice.org/59296 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-08-18coverity#1438401 assert nPrevIndex >= 0Caolán McNamara1-0/+3
Change-Id: I1b6e4428aa44163bd098517ed654ea115c10daf7 Reviewed-on: https://gerrit.libreoffice.org/59292 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-18coverity#1438403 Unchecked return valueCaolán McNamara1-2/+2
Change-Id: I7debe5eb1c366264cb94a52f63677f392cda647e Reviewed-on: https://gerrit.libreoffice.org/59291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-18coverity#1438404 Identical code for different branchesCaolán McNamara1-21/+6
Change-Id: I19a7bb7a142ddb90d9b42fe589900bd74d09e153 Reviewed-on: https://gerrit.libreoffice.org/59290 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-18tdf#116436 doc export: add missing table background fillJustin Luth3-18/+31
MS formats only have support for Table and Cell fill. Interestingly, MS Word doesn't let the cells inherit from the Table fill setting, so that value also needs to be written out into every cell. Since Word apparently ignores the table color, I didn't bother trying to search out how to export that in DOC format. (I did add it to DOCX since it was so easy to find.) Change-Id: I8946f07b45f72fed5959369182882a7bf013b1d0 Reviewed-on: https://gerrit.libreoffice.org/59281 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-08-18tdf#116436 docx export: add missing table background fillJustin Luth4-1/+42
MS formats only have support for Table and Cell fill. Interestingly, MS Word doesn't let the cells inherit from the Table fill setting (even though LO docx import currently does), so that value also needs to be written out into every cell. Change-Id: Ib49fddf52758ff641428de747ea290d1fcb894f3 Reviewed-on: https://gerrit.libreoffice.org/59260 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-08-18uitest Impress-rename,new slide ; tdf#85360Zdeněk Crhonek2-0/+96
Change-Id: Id080fdeb3d47f27f9a8b83b7720e96eb46eb716b Reviewed-on: https://gerrit.libreoffice.org/59267 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-08-18loplugin:useuniqueptr pass SmNodeList around by std::unique_ptr(2)Noel Grandin2-15/+13
Change-Id: I53b7f39ddc150367bc5f9c4a7ee7049d59e9f485 Reviewed-on: https://gerrit.libreoffice.org/59231 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-18new loplugin intvsfloatNoel Grandin2-0/+178
This was a good idea from mike kaganski as a consequence of https://gerrit.libreoffice.org/55359 Unfortunately, clang/llvm is not yet up to the job of doing floating point evaluation, I get tons of crashes all over the evaluate infrastruction inside clang, so this will need to wait until clang's code matures. So park it in store for now Change-Id: I5ba4de8323e462b4fd4db301e4d116a81fd56ed3 Reviewed-on: https://gerrit.libreoffice.org/59254 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-17Avoid further downstream overflowStephan Bergmann4-11/+11
...after 004304eb2fd1703d22dec0abf0170bb2ce493d0c "try to avoid overflows in some compare functions" had changed the return type of just one function, but not its callers. Found with Clang's new -fsanitize=implicit-conversion during CppunitTest_sd_filters_test: > Testing file:///home/sbergman/lo/core/sd/qa/unit/data/ppt/pass/hang-17.ppt: [...] > sot/source/sdstor/stgdir.cxx:101:19: runtime error: implicit conversion from type 'sal_Int32' (aka 'int') of value -57120 (32-bit, signed) to type 'short' changed the value to 8416 (16-bit, signed) > #0 in StgDirEntry::Compare(StgAvlNode const*) const at sot/source/sdstor/stgdir.cxx:101:19 (instdir/program/libsotlo.so +0x217699) > #1 in StgAvlNode::Find(StgAvlNode const*) at sot/source/sdstor/stgavl.cxx:43:29 (instdir/program/libsotlo.so +0x1db72b) > #2 in StgDirStrm::Find(StgDirEntry&, rtl::OUString const&) at sot/source/sdstor/stgdir.cxx:907:57 (instdir/program/libsotlo.so +0x22f2dc) > #3 in Storage::IsStream(rtl::OUString const&) const at sot/source/sdstor/stg.cxx:773:39 (instdir/program/libsotlo.so +0x1d2cdf) > #4 in SotStorage::IsStream(rtl::OUString const&) const at sot/source/sdstor/storage.cxx:654:27 (instdir/program/libsotlo.so +0x29ebdb) > #5 in PropRead::PropRead(SotStorage&, rtl::OUString const&) at sd/source/filter/ppt/propread.cxx:543:19 (instdir/program/libsdfiltlo.so +0x6b72ee) > #6 in ImplSdPPTImport::Import() at sd/source/filter/ppt/pptin.cxx:262:32 (instdir/program/libsdfiltlo.so +0x5d0dc4) > #7 in SdPPTImport::Import() at sd/source/filter/ppt/pptin.cxx:167:21 (instdir/program/libsdfiltlo.so +0x5cf733) > #8 in ImportPPT at sd/source/filter/ppt/pptin.cxx:2761:26 (instdir/program/libsdfiltlo.so +0x618f64) > #9 in SdPPTFilter::Import() at sd/source/filter/sdpptwrp.cxx:106:32 (instdir/program/libsdlo.so +0x2877ed3) > #10 in sd::DrawDocShell::ConvertFrom(SfxMedium&) at sd/source/ui/docshell/docshel4.cxx:474:46 (instdir/program/libsdlo.so +0x2e1607c) > #11 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:786:23 (instdir/program/libsfxlo.so +0x2c8c762) > #12 in SdFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at sd/qa/unit/filters-test.cxx:75:31 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x19771) > #13 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:130:20 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x5724c) > #14 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:155:5 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x57ec9) > #15 in SdFiltersTest::testCVEs() at sd/qa/unit/filters-test.cxx:83:5 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x19d6d) Change-Id: Iaffd35d33f0e1109195e3bd56538104d395af01b Reviewed-on: https://gerrit.libreoffice.org/59274 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-17sw: Replace std::list with std::vector for simplicityTakeshi Abe2-6/+3
Change-Id: I239df7b0009711eeaf025221bec9c95887681c8d Reviewed-on: https://gerrit.libreoffice.org/58918 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-17Use for-range loopsCaolán McNamara1-109/+126
Change-Id: I7bf26258b8330a5f81657a3684c81ce429b37090 Reviewed-on: https://gerrit.libreoffice.org/59262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-17Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - Fix dup ID Change-Id: I4c21333e6738edc39153ed2f9b276f361190d396 Reviewed-on: https://gerrit.libreoffice.org/59276 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-17Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - tdf#115254 Some branch bookmarks are'nt working 16 Module svx Change-Id: I0ce6c3c004ee8ef68b7114692ffcc6f9e912ccf3 Reviewed-on: https://gerrit.libreoffice.org/59273 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-17tdf#105998: Enhanced fix for MetafileToBitmap at better placeArmin Le Grand2-105/+59
Change-Id: I220bdbe196a68ef2df25885dceee70e15b760410 Reviewed-on: https://gerrit.libreoffice.org/59220 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-08-17ofz: make ValidNewTabName faster wrt collisionsCaolán McNamara2-7/+420
Change-Id: Id2058719c3bc822518faa922a6cd0409b4088ac7 Reviewed-on: https://gerrit.libreoffice.org/59253 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-08-17Remove unused includesStephan Bergmann1-3/+2
Change-Id: If51bdcb4bd426ddbd563861a0cf3eeb5f2756b06 Reviewed-on: https://gerrit.libreoffice.org/59268 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-17Consolidate: basegfx::clamp -> o3tl::clampStephan Bergmann21-82/+97
Change-Id: Iffd8b0a19d4479b6c70dc834c6f64499e87e01b1 Reviewed-on: https://gerrit.libreoffice.org/59265 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-17tdf#119117: get phonebook sort work by tweaking ICU call mechanismJulien Nabet3-8/+17
Using "phonebook" as variant does't work with de_DE since it gives de_DE_PHONEBOOK whereas icu expects de__PHONEBOOK See http://userguide.icu-project.org/locale#TOC-Variant-code, Level 2 canonicalization, 8. So let variant empty and use the fourth arg of icuLocale "keywords" See constructors in http://icu-project.org/apiref/icu4c/classicu_1_1Locale.html Change-Id: I6c216c86cdd32abfa477c14a80d1b8794b536900 Reviewed-on: https://gerrit.libreoffice.org/58870 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-08-17Resolves: tdf#118983 do not expand range if sheet references not affectedEike Rathke1-8/+5
Change-Id: Ib207d3723ce1d370a953e652957aaed399affc9c Reviewed-on: https://gerrit.libreoffice.org/59255 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-08-17Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - Add MACOSX for =INFO("system") Change-Id: I23bd4706bf7f0eba4334e15c21e750b2f2cf2883 Reviewed-on: https://gerrit.libreoffice.org/59266 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-17Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - Mute l10n in numeric table and InfoType strings Numeric cell are not to be translated InfoType either. Change-Id: I320b78c2c84212ece5c080e47c78cef2550ae066 Reviewed-on: https://gerrit.libreoffice.org/59263 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-17make GetCodeName accessor more standardCaolán McNamara2-2/+2
Change-Id: Ieee004ef7f6c7db5503a8a0d1660785105ec0511 Reviewed-on: https://gerrit.libreoffice.org/59251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-17Resolves: tdf#119325 tooltip position should be relative to widgetCaolán McNamara1-1/+1
Change-Id: I244f2d6cd89fd53d7a874cac593f3759d75966da Reviewed-on: https://gerrit.libreoffice.org/59256 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-17loplugin:useuniqueptr pass SmNodeList around by std::unique_ptrNoel Grandin2-55/+63
Change-Id: I263a7afd23a38f68ee54ecb11f00bcfbdda30c64 Reviewed-on: https://gerrit.libreoffice.org/59230 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-17ofz#9934 null derefCaolán McNamara2-2/+3
Change-Id: I6833ad8a556b561a37e468da8845914cabfac4c5 Reviewed-on: https://gerrit.libreoffice.org/59246 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-17a11y: Use ATK "footnote" roleSamuel Thibault1-2/+2
instead of "comment" which is less precise. Change-Id: Icca55a3c440748f311d896aac648a7a6d89f3bc4 Reviewed-on: https://gerrit.libreoffice.org/58763 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-17tdf#116542 a11y: Make R/O accessibleedit use STATIC roleSamuel Thibault1-1/+1
as improvement to tdf#86661 which had made it a LABEL as first improvement over TEXT. Change-Id: I0e5ee7b680ec943f38526b98cb904d0f9f916d85 Reviewed-on: https://gerrit.libreoffice.org/58736 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 14:35:44 +0000