summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-04-28Version 7.1.3.2, tag libreoffice-7.1.3.2libreoffice-7.1.3.2Christian Lohmaier3-0/+0
2021-04-28bump product version to 7.1.3.2Christian Lohmaier1-1/+1
Change-Id: Ib13486de27816fc8e0920cba8557950a998366ca
2021-04-28tdf#86321: Revert "Resolves: #i123539# some optimizations for 3D chart..."Xisco Fauli3-67/+25
This reverts commit db1d2af02861b49e4f53d726d59cd71c20cee9b1 The commit was already partically reverted in bca8d8985666d3fd22b91eb280f9baaeb933c2d0 < Resolves: tdf#90583 3D pie-chart missing guide handles >. This partial revert broke the optimization introduced in db1d2af02861b49e4f53d726d59cd71c20cee9b1 <Resolves: #i123539# some optimizations for 3D chart...> for 3D charts like https://bz.apache.org/ooo/attachment.cgi?id=81810 Later, 3D charts were optimized again in 55a7e836a2db662a53adc4f8b98d08b06790c758 < chart2: When creating objects prevent setting object rects dirty > so the remaining code originally introduced can go. Import time of https://bz.apache.org/ooo/attachment.cgi?id=81810 is the same with and without this patch Change-Id: I25338d0dfb4b41651dfe05e7bfbd74c86091dacb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114313 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit eec03e848cb6874ce6d64dc0b8f45dbaf52e6c2b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114277 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 3fe117cb0f319fbb84073d75ad5e2d676b587866) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114359 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-28update creditsChristian Lohmaier1-2063/+2126
Change-Id: Idd3d14c272c1eebca7207054dccbeae4632c51cc (cherry picked from commit 93a90a5b0558aeac847aefe06f49f68c00a26678) (cherry picked from commit b427f78fdf26ed25a2afe852978c56115e97762f)
2021-04-28tdf#141914: Allow to unset modified anywayMike Kaganski1-5/+9
IsEnableSetModified returning true means kind of "treat this document as read-only". Marking object unmodified does not break this idea. Change-Id: I3efd5b3b25e2d9318702cdbf24ac5eb61aeda3ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114666 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit eeb2854e085fdd9f7a38d6e952a8aedf43e90323) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114605 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit ed12e778bffd38bf9691981436f912ff199e8ec8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114610 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-28tdf#132472: do not set text color when table style is 'Themed-Style-2'Xisco Fauli3-3/+34
and it has no Accent Regression from 2c3f7d4ee0a0b2bf6efc41670645bd361f1b76ef < tdf#107604 Handle predefined table styles. > Change-Id: Id9ab5b20825e2eaf8cc138c108608fe446f33db4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114477 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 54f7c32beca5a9c99d7316dc38818edad55f7415) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114497 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 62cbb4b7694893a39de41cebd5f785122b154961) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114600 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-04-28tdf#137470 use a more proper URL for the extensionsChristian Lohmaier2-4/+4
also hide the download-count, since those numbers are completely made up by the script Change-Id: I15b53a8a023c34ecc6a544b88ad35800891e4327 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114740 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 452fcbe0792aa10042bb8cd2cfd6cd29ca754be5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114774 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit e5b8477a1270a8b572b3815cfb318110eb19d0f2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114720 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-27Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-7-1-3' to e7b111a56788789226f03e2dfda4aed0a40675c3 - update translations for 7.1.3 rc2 and force-fix errors using pocheck Change-Id: I01bef69ec2c4e02df560e3334fac5d1226cb2c56 (cherry picked from commit 0a7477257a9aa9c557c090f29f9d3b52e2cfda77)
2021-04-27tdf#141924: SwFormatAutoFormat::GetStyleHandle may return nullptrMike Kaganski1-3/+5
Change-Id: Id1b6fe687f5b328fa0743036a287bacfefe5e5fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114685 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114687 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit d1ac603b006a14c3cf8c8f852eb481a27e3c46fa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114608 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-27tdf#141887 SW don't crash on missing SwWrtShellJan-Marek Glogowski1-3/+3
The code assumes that SwEditWin::Command can just be called, while there is still an m_rView.GetWrtShell(), which is at least not true, if you have an IM in pre-selection and close the Writer window via Window decoration. Change-Id: I67d5f1f917e9b2180037babb8c70c72d75c4a7ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114624 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 9a1c4a10b08ccb8d874a85a2cd984fd71f08c022) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114604 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 0011c032afb96b2b3cfa63f88565e01c84d03512) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114609 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-27tdf#141902 Fix domain in ui files (found with ui-checkdomain.sh)Julien Nabet3-3/+3
Backport to 7-1 to fix a user visible problem Change-Id: I6ec07748616c6ddbe12a48077a777c91ffb8f96f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108046 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114682 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit e9341b4356c8e5e72aa4dbde9029b0ffca3966e7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114607 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-27tdf#138785 sw: fix mis-positioned as-char flys when deleting empty pageMichael Stahl2-0/+6
When SwFrame::CheckPageDescs() deletes an empty page in the middle of the document, which happens during SetRedlineFlags() here, the SwFlyInContentFrame::maFrameArea is moved in lcl_MoveAllLowers(), but the SwFlyInContentFrame::m_aRefPoint stays unchanged. Because the formatting occurs only after the redline mode is reset, the position of the SwFlyInContentFrame when it is formatted is exactly the same as its (stale) m_aRefPoint, so the setting of (updated) maFrameArea is skipped in SwAsCharAnchoredObjectPosition::CalcPosition(), so the fly ends up a page above where it should be. So keep m_aRefPoint consistent with maFrameArea in lcl_MoveAllLowers(). (regression from b9ef71476fd70bc13f50ebe80390e0730d1b7afb) Change-Id: If1b421daa0d71718d89d9772f5c0d9e367e76845 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114332 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit e656cf2a71e738c282abcd0d610e724b955f274a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114520 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit c79b92edfb5e650fff76688998cf4f0bbd08d2a4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114603 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-26tdf#141419 restore use any explicitly set background color in previewsCaolán McNamara1-0/+10
regression since... commit 6f3899b27156591e65f62649a92c727eb6f5dd03 Date: Thu Oct 29 15:03:44 2020 +0100 Resolves tdf#137059 - Use application colors for font preview but continue to use the doc-color setting when there isn't an explicit bg setting in the input propertyset Change-Id: I531b5ddea7700fcd4a731f32d4830b4d0b767d7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114418 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 40868f520f9da24d3eaa5e0489da8657bc8383b4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114425 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-24tdf#141703 Restore tab function in sd tablesSamuel Mehrbrodt1-2/+5
Regression from 67ad205404211a2ae17c430a17ede6e9d04d0b7e Change-Id: Iadbdaf1b59d2481264e45b85aed248c84404c26b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114383 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit 75f5fdbbe48a847874397d9d126f832dbdfada5a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114368 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 29de1e98d30db95b4045537b6c867c7ea0090c4e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114414 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2021-04-24Better handling of filelocsStephan Bergmann1-0/+1
Change-Id: Ic9c06cb476942ceb7d0166f22103e2e88cc9c21f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114339 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 177dcfec4e833f83f1f11c7bdbfc6f1977ebcee7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114357 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-22fix too wide glyphs with Skia/GDI if horizontal scale is used (tdf#141715)Luboš Luňák1-0/+6
Change-Id: I7b06b64e04313493f48b7224fbc4883356feda95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114327 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 764360df78535befcc4806736fcbaedbe0e34ea1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114285 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: V, Stuart Foote <vstuart.foote@utsa.edu> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-20Resolves: tdf#141770 remove empty tagCaolán McNamara1-5/+0
Change-Id: I0e6c1b36c145c0eb464867e7a30a6d693598409b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114280 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 0fe2fe972a18ce986e38f5e7f8f3de402179b36c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114291 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2021-04-20tdf#132901: do not add updatecheck to libmergedXisco Fauli1-4/+0
LibreOffice crashes if "online update" feature is not installed Regression from c63148ba139bd6b9ae7a0f9e24e51f29e5370963 < Revert "Revert "add some libs to libmerged"" > Change-Id: Ia18f50bc6baf830b2d3e0814645ef04283bfaa04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114247 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 6064446f828f8cd612f7d6660153b2eb1139239b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114191 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 2b258e8c5e0bd12af1ecea76be99bb384327fda9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114274 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-20tdf#141244 Modify DDE Link dialog was emptyAron Budea1-20/+20
Regression from de01c0c1d0f80ffec3882625d77c02ab806f6c7a. Apparently <property> entries must precede <child> ones in .ui files. Change-Id: Ie91897d126527d3b30935a46b31f0a53b2837c53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114312 Reviewed-by: Aron Budea <aron.budea@collabora.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 8e324e8c9e8cfafef2f5fcebc64e7c5efb035ca2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114278 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-15bump product version to 7.1.3.1.0+Christian Lohmaier1-1/+1
Change-Id: I6fda75436d99913a9d1f95149e1a20c1c58d2e3e
2021-04-15Branch libreoffice-7-1-3Christian Lohmaier4-1/+1
This is 'libreoffice-7-1-3' - the stable branch for the 7.1.3 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.1.x release, please use the 'libreoffice-7-1' branch. If you want to build something cool, unstable, and risky, use master.
2021-04-15Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-7-1' to c4fcb9c24c38d1f51482abc9017c082132fca2e4 - update translations for 7.1.3 rc1 and force-fix errors using pocheck Change-Id: I7b650d4872fc30c395ebc518f697c01bc0cda50a
2021-04-15Work around assert() in circular reference within group calc, tdf#141146Eike Rathke1-5/+17
Triggered by crash test loading document of wget 'https://bz.apache.org/ooo/attachment.cgi?id=71756' -O ooo114587-1.ods after commit 042dbf83122b14fd1dd32705c8f8b7d65c22f21b CommitDate: Thu Mar 25 16:31:29 2021 +0100 Resolves: tdf#141146 Fix LOOKUP in array with result scalar / single reference Though could happen any time whenever a shared formula group calc attempts to obtain a result from an already running cell. Change-Id: Id668b31a8d81389c593c6fd2191fd444efcdb70f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113494 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 465b8b0e9ad4b0c9c7701dee2820a99c5d00b5bf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113633 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-15tdf#132393 sw: disable TabOverMargin layout flag inside sectionsMiklos Vajna3-1/+70
Regression from commit bdfc6363d66aa079512cc8008996b633f693fed1 (n#793998 sw: add TabOverMargin compat mode, 2013-01-08), the problem is that currently adding an alphabetical index generates document model where tab positions are explicitly over the margin and users expect that the page numbers are still visible, even for Word documents. Fix the problem by disabling this mode inside sections. Long-term we may want to fix the ToX generator to create a more sane document model and then this flag can be handled even inside sections. (cherry picked from commit e1cc5041cfb7272eb96f174e1c64285420397588) Conflicts: sw/qa/core/text/text.cxx Change-Id: Ic91ac36e703d59e4711a009db1f921e456bf8645 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114039 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-15tdf#140639 cache FcPattern for font optionsCaolán McNamara4-22/+117
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114083 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> also includes... getFontOptions is always called with pitch of PITCH_DONTKNOW getFontOptions is called from only one location and there the pitch value is left at its default PITCH_DONTKNOW which is suspicious but that's the way it currently is Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114076 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> use original FontAttributes instead of an intermediate FastPrintFontInfo Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> hintstyle is unused left behind after... commit 561a02ec72cf963d7cd59cfb9a183c1032f0861b Date: Thu Jun 15 15:28:46 2017 +0200 loplugin:unusedfields in vcl part3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Change-Id: Ibb1b1e06630e505924e05ea4b5b454e58738d743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114140 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-13tdf#131171: make Diagonal Squares animations behave as describedKatarina Behrens1-8/+8
All of these animations map to Waterfall transition left-to-bottom: horizontal left rotated 90° clockwise right-to-top: reverse of left-to-bottom right-to-bottom: horizontal right rotated 90° counterclockwise left-to-top: reverse of right-to-bottom This holds for entrance animations. For exit it is the same but reversed see also: https://www.w3.org/TR/SMIL2/smil-transitions.html#Table%205:%20SMPTE%20Matrix%20Wipes Change-Id: I9d1b05485727bb6f0e93ba78f10094055bfbaa70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113985 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org> (cherry picked from commit 46fe595379a898ee7e537cbffd5d215d4a58aca5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113997 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-13tdf#134736 move nLastBgAction to also include any trailing popsCaolán McNamara1-0/+12
RemoveTransparenciesFromMetaFile is a very fragile thing Change-Id: I8feeb436426d16087ab5fbaddf6b39ac32574e5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113992 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-13tdf#141549 sw: fix ordering of virtual SdrObjects for textboxesMichael Stahl3-11/+37
In header/footer it turns out that not only can the text box be inserted after the shape, it can also be inserted before the shape. This is because SwDrawFrameFormat::MakeFrames() ends up first destroying all the SwDrawVirtObj and then creating them from scratch again, while the SwVirtFlyDrawObj survives. 4 SwDrawContact::DisconnectFromLayout(bool) (this=0x6ed0200, _bMoveMasterToInvisibleLayer=false) at sw/source/core/draw/dcontact.cxx:1664 5 SwDrawContact::ConnectToLayout(SwFormatAnchor const*) (this=0x6ed0200, pAnch=0x0) at sw/source/core/draw/dcontact.cxx:1791 6 SwDrawContact::SwClientNotify(SwModify const&, SfxHint const&) (this=0x6ed0200, rMod=..., rHint=...) at sw/source/core/draw/dcontact.cxx:1521 7 SwModify::CallSwClientNotify(SfxHint const&) const (this=0x6ecfd80, rHint=...) at sw/source/core/attr/calbck.cxx:321 8 sw::BroadcastingModify::CallSwClientNotify(SfxHint const&) const (this=0x6ecfd80, rHint=...) at sw/source/core/attr/calbck.cxx:326 9 SwDrawFrameFormat::MakeFrames() (this=0x6ecfd80) at sw/source/core/layout/atrfrm.cxx:3394 10 AppendAllObjs(SwFrameFormats const*, SwFrame const*) (pTable=0x69c1920, pSib=0x38c6100) at sw/source/core/layout/frmtool.cxx:1349 11 InsertCnt_(SwLayoutFrame*, SwDoc*, unsigned long, bool, unsigned long, SwFrame*, sw::FrameMode) (pLay=0x6be4320, pDoc=0x69af7c0, nIndex=157, bPages=true, nEndIndex=0, pPrv=0x6baedc0, eMode=sw::FrameMode::New) at sw/source/core/layout/frmtool.cxx:1927 Fix this by searching for the existing SwVirtFlyDrawObj in SwDrawVirtObj::AddToDrawingPage(). (regression from 3bc8f90e9693f710f12632f69b9348c1c833c906) Change-Id: Ic00878685ab16018c9331190f1e80f874c1a9a4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113844 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit c2eae4998b3ae79210ef0b5c064e9833218c22de) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113853 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-12tdf#140489 fix chart display in xlsxSzymon Kłos3-2/+41
Commit 1147383: tdf#114181 XLSX combined chart: fix swapped primary and secondary axes etc. introduced regression by applying axis swaping not only for combined charts. Change-Id: I764399579ff922ddd495540fdd2a39675f2a8da5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113836 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit be82f6313f298c13a2f040b218c6f2a33705ff8c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113871 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-12tdf#138646 - consider the document's address conventionAndreas Heinisch3-1/+51
When accessing a named range using getCellRangeByName, consider the document's address convention. Otherwise, an exception is raised, when the formula syntax is EXCEL R1C1 or EXCEL A1. Change-Id: I5df2546f1c3fd00ff30cb057dcf47f6bb01d501d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112602 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113984
2021-04-12tdf#141623 Qt5+cairo init surface with widget sizeJan-Marek Glogowski1-4/+4
The QFont based rendering path directly uses the widgets size to initialize the QImage buffer image, so do the same for the Cairo surface, instead of the arbitrarily size of 640x480. Change-Id: I91326dab67cbbb5e75b78b02c34eaca61ad26482 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113955 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 91c883e75436210ca8af95df1ca597caeeda8703) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113869 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-04-11tdf#140404 Qt ignore "unchanged" clipboard eventsJan-Marek Glogowski1-0/+9
LO gets a Qt signal on all clipboard changes. For X11 you get one signal when you set the clipboard. Anything else normally signals lost of clipboard ownership. But on Wayland LO somehow gets a second notification without any actual change. AFAIK it's not triggered by any LO actions and isOwner still indicates, that LO has the ownership. This breaks the single notification assumption, the code was relying on. Initially I found it quite tricky to find a rule to identify the ignorable change signals. Change-Id: I744cdd3c4254533b01d909309ecc3967d789361e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113617 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins (cherry picked from commit 71471a36b125f6bdc915d5dbcae92ebcaa7ff5a4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113641
2021-04-11Sukapura: tdf#141618 fix blured vertical line of Sukapura's anchor markerRizal Muttaqin2-1/+1
Change-Id: I11b3fca85ec00049dfe84df6cfb548a320e255cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113937 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org> (cherry picked from commit d9f10d8f0f6bae31dd5ebd9fa00f989d17fc21da) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113865 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-11Related tdf#117750: fix "Solarization" and "Aging"Julien Nabet2-2/+2
For solarization, regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=c38485279cd36da96ac81107d567ea4e779b2b96 author Chris Sherlock <chris.sherlock79@gmail.com> 2018-04-20 20:27:41 +1000 committer Tomaž Vajngerl <quikee@gmail.com> 2018-04-22 05:33:11 +0200 commit c38485279cd36da96ac81107d567ea4e779b2b96 (patch) tree ad9843a17f87271f9e0cf89643e2e6c3ee8a8de1 parent bcbf767bcfc024e2be839e0c0886f942dd068e4f (diff) vcl: ImplSolarize() to BitmapSolarizeFilter For aging, regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=1ab12471f3a69c4d502e6271e84ddf8a981f507f author Chris Sherlock <chris.sherlock79@gmail.com> 2018-04-20 20:32:23 +1000 committer Tomaž Vajngerl <quikee@gmail.com> 2018-04-22 05:33:39 +0200 commit 1ab12471f3a69c4d502e6271e84ddf8a981f507f (patch) tree 6652276229ad1c3ffca48f7a31e1b77d2ea04b07 parent c38485279cd36da96ac81107d567ea4e779b2b96 (diff) vcl: ImplSepia -> BitmapSepiaFilter Change-Id: I4f350aa8b494caf55c9c810ac7fa9ed8db349725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113926 (cherry picked from commit f3151e62bcc7cb66313df70a2ec8eed8ca8f2c88) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113858 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-11Related tdf#117750: fix UnsharpenFilterJulien Nabet1-1/+1
Change-Id: I372bb6baae747adb3b2d2a2b8fd39d1631b074ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113927 (cherry picked from commit 3d32e6a6ccfae56f379cb1dec6dcadf9aa8fa85f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113859 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-11tdf#141600 fix blured vertical line of Colibre anchor markerRizal Muttaqin4-2/+2
Change-Id: I5acab0328fd40e7eb4043a77197d78925c38237a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113861 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-11Colibre: Revise some bullet/numbering iconsRizal Muttaqin44-22/+22
Change-Id: I6ff3e82cc02272e10314cc92e6ee584fcc50724c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113863 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-10Resolves: tdf#139075 diagonal focus rects contain focus rects of old sizeCaolán McNamara1-0/+3
since... commit 356f6c5d89dd4dd92b2351898e07f99b96cb34cc Date: Tue Jan 15 08:55:00 2013 +0000 teach FrameSelector to be resizable Change-Id: I5ac4d1d12f60086349e7dbb3b78d29977f22c226 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113856 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-10tdf#141416: partial revert of the fix for tdf#81396Xisco Fauli1-4/+5
d4743045a0b320449d07a957463a76bb8b13f939 < the cells need to be imported before we handle charts, tdf#81396 > Import time of sample file in tdf#141416 goes from more than an hour to 1 minute while keeping tdf#81396 fixed Unittest for tdf#81396 added in 9a59068fc31d7150e255ada91c59b8299636f185 Change-Id: Ic15d57945069397076c483b6ef8f3070057db317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113818 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 30f222c91fa816a7863bf4bfc4a36e503e0bf2d3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113768 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-09fix small cairo leak in gen backendNoel Grandin1-2/+3
Change-Id: I57b8cd00d252cef2699d499b9080f829be9098da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113854 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-09tdf#97569 docxexport: export russianUpper/russianLower numberingJustin Luth2-8/+8
Change-Id: Iad5f5d4687eccc05a63d6a9a4f81cf3f552cb17d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113829 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit 3236020c4b8bed68dcf57210c0437f43f4160130) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113771 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-09tdf#139495 doc import: prevent negative Int forced into uIntJustin Luth4-2/+14
Don't cast a negative number into a sal_uInt16 and expect good results. (ww8import test) But for bug 139495 (and ww8export3), the problem area is also related to pHdFormat->SetFormatAttr(SwFormatFrameSize... which takes an awt::Size which consists of Longs. So they should accept negative numbers. Likely the result is being treated as a uInt somewhere. And a negative height doesn't mean very much anyway. There seems to be a fundamental difference between Word and LO here. Word sets the page margins, but that is irrelevant to the header/footer, which have their own distance from the edge. In LO, the header starts at the page margin, and the body text must follow the header, (In Word, the body text can start above the header, as seen in the ww8export3 unit test.) [FYI: DOC format (since forever) seems to ignore the header size, allowing the content to at least overlap with the body text, but DOCX doesn't have that. Likely this is #112727# using floating frames hack. So I'd better not keep messing around in here.] Change-Id: Ie7bffec8a3de25958cf1f311ff2c8338d4870d99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113681 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit 28a9a92105f3155d82fd9e31095efabd3ec706ea) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113769 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-08tdf#141529 sync linked OLE save(s) with hosting file save(s)Armin Le Grand (Allotropia)5-28/+141
Before deactivating a linked OLE saved it and overwrote the original, even when not saving the hosting document at all. This is not intuitive from user perspective and may lead to unexpected data loss (of the OLE content). Reported case was especially about closing the hosted document without saving in the understandable believe that that way the changed OLE will not be changed on external medium. Added mechanism for linked OLE to hold data in a hidden local temp file, synching/writing back on hosting file save. Most complicated was adapting the 'break link' case and ensuring other cases to work, but looks good now from my POV Change-Id: I7f63d667820b2d9725abc598a9dd7360be1f8d5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113793 Tested-by: Armin Le Grand <Armin.Le.Grand@me.com> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> (cherry picked from commit f4c66a2272d890eaa7a6d7429e5bfa7bdb1f7162) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113762 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-08tdf#141528 ensure that reset of linked state is executedArmin Le Grand (Allotropia)1-2/+13
Take m_xDocHolder->GetComponent() and xModif->setModified inside the local try..catch expression to ensure that the reset of the linked state below (m_bIsLink and .clear()) is executed Change-Id: I52d49569a43fd2c23dd997c7217f7552cbdcfb82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113722 Tested-by: Armin Le Grand <Armin.Le.Grand@me.com> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> (cherry picked from commit 2f665daa29dd5509b4ceb0461e76292e2262fa56) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113761 Tested-by: Jenkins
2021-04-08tdf#141547: maQueryItems can be 0Mike Kaganski3-13/+7
E.g., fillQueryParam (sc/source/ui/unoobj/datauno.cxx) may clear it and leave empty if relevant input item is empty. Note how commit e4b924df8f9ad02c66549751cb8e123e420e8508 had changed the same checks in ScQueryEntry::IsQueryBy[Non]Empty. Change-Id: I552462c72e69ddce43711bcff645dc6c7b133db7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113783 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit a0d2fb3217094aa7158310f0bcf16093bcc4984f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113757 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-07xmlsec: fix signing documents on WNTMichael Stahl2-0/+69
Duplicate ds:X509Certificate elements cause: warn:xmlsecurity.comp:9604:3820:xmlsecurity/source/helper/xmlsignaturehelper.cxx:658: X509Data do not form a chain: certificate in cycle: (regression from 5af5ea893bcb8a8eb472ac11133da10e5a604e66) Change-Id: I3d319a2f74dbec17b73f1c7bb8f4efe4e335f0ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113746 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit ae08aa8a095832ae2a88eac14f9680ac8d3a13b6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113748 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-04-07tdf#136918 restrict symbol size to button widthJan-Marek Glogowski2-2/+4
... and scale the button based on the DPI scaling factor. The symbol size is based on pDev->GetTextHeight(), but the button itself is fixed to 20px, which would break at some point. So this at least scales the button witdh based on DPI, just like commit 1eba1c4597f8c2698aa91e2218d8452ad0fbc39c ("tdf#130991 Scale the drop-down arrow size-request") did for the toolbar buttons. OTOH this should probably just use the full button width ignoring the GetTextHeight()... Change-Id: I43010443265c10ad92f46cdecd1d7155a7a07a3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113710 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit ea4fb1559f7b99a0bfaf18f26cb3b6972c9cde1c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113648 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-07Resolves: tdf#141515 expander column space isn't wantedCaolán McNamara1-1/+1
in the relationships view Change-Id: I1d4a34dbf86a797573705c202719f5159b5a8bcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113651 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-07Resolves: tdf#128334 Reset mnCurrentSheetEndPos, mnCurrentSheetTab in all casesEike Rathke1-0/+6
Encountered for a single decimal separator not being a value either, but could be for any condition within IsReference() returning false up to the IsSingleReference() call. Change-Id: I6222adf2a2d06904001175da8798b2ba9fdef99c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113697 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 4d4fd4cc57a37a5f24178cf8bac63d979f4323da) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113647 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-07use VCL_DLLPUBLIC for UnoWrapperBase to allow use in vclplug-gtk3Caolán McNamara1-1/+1
Change-Id: Icecb736088c5c248c1a6bf87ecb8ab0be8e46e00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113293 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113709