summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-08-01Fix typo in codeAndrea Gelmini1-1/+1
It passed "make check" on my laptop Change-Id: I72c01c63a67e3d664cc28fc93d5681f7b342d39c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137659 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-01no no need to call QuickGetTextSize hereNoel Grandin1-2/+1
when we only need the height Change-Id: I16d74cb6f68e3391b9857cc9702cc6f93b9fb9ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137678 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-01tdf#150034 very slow opening pathological chartNoel Grandin1-1/+7
This chart has a ridiculously long legend, which makes the loop that tries to shorten legends take an extremely long time. Make this loop faster, at the risk of sometimes getting a slightly wrong answer. Ideally we could speed up the layout down in ImpEditEngine, but that is a much bigger task. Change-Id: I7cb337c674515bac13e4b11c3b0fabb94aed6865 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137677 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-01Add infrastructure and basic tests including slight UI interactionColomban Wendling13-13/+907
This introduces a couple helper base classes for implementing accessibility tests more easily, and includes a few tests as examples, including basic document layout check and minimal UI interaction through menus. Change-Id: I8961af8be1e7d52dc55fe27c758806d9b4c3c5d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137337 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-01tdf#150197 sw: convert pre-defined num styles to ListFormatJustin Luth5-8/+90
Early in 7.x, allotropia introduced a generic list format string instead of prefix/suffix. Convert the pre-defined numbering formats to use that syntax as well. The problem was that ms export wasn't able to handle the old way of doing things any more. For example, if a user added numbering via the numbering style "Numbering 123", then on export the numbering string was lost. Change-Id: I11cd00280da2b464a9b00a5f0a8d72080f14e44c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137632 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Justin Luth <jluth@mail.com>
2022-08-01tdf#116411 fix Navigate By Page Next does not move the expected nextJim Raykowski5-10/+90
page into view Uses newly introduced GetFirstLastVisPageNumbers function which does not include pages having only visible bottom or top margins. This solves the issue of pages with bottom margin remnants in the view causing Page Next to not move the expected page into view. Change-Id: Iec05f132b39e1db92be5d13c7d4cc41072dddac0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132373 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-08-01vcl: fix crash in vcl::ImportPDFUnloaded()Miklos Vajna1-0/+5
Crashreport signature: SIG Fatal signal received: SIGSEGV code: 1 for address: 0x0 program/libmergedlo.so vcl::ImportPDFUnloaded(rtl::OUString const&, std::vector<vcl::PDFGraphicResult, std::allocator<vcl::PDFGraphicResult> >&) vcl/source/filter/ipdf/pdfread.cxx:256 program/../program/libsdlo.so SdPdfFilter::Import() sd/source/filter/pdf/sdpdffilter.cxx:55 program/../program/libsdlo.so sd::DrawDocShell::ConvertFrom(SfxMedium&) sd/source/ui/docshell/docshel4.cxx:500 (discriminator 1) program/libmergedlo.so SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:768 Change-Id: I2fc635de696643af6a80a29aa5af4fa128f8776c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137673 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-08-01related tdf#150197 sw: NONE numbering still returns prefix/suffixJustin Luth1-1/+1
Missing this has surfaced repeatedly during the refactoring of numbering. A code read suggests this is necesary here. I'm not sure how to test this, or how to trigger it. A make check never hits this situation. Change-Id: I1adc81968ebddbb36db9b4af551e5d3867016b53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137635 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2022-08-01clang-tidy modernize-pass-by-value in ucbNoel Grandin83-216/+269
Change-Id: I641d05e360c3208845a2fa6721ac8ba1ad0f3309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137667 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-01introduce SwPosition::GetNodesNoel Grandin12-22/+27
as part of the process of hiding the internals of SwPosition largely done by doing: git grep -lF 'nNode.GetNodes' | xargs perl -pi -e 's/nNode\.GetNodes/GetNodes/g' Change-Id: I05ac253803ef3f265edfa9be6f24f8f66b2b02c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137670 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-01remove NOP in editeng: HOLDDEPTHJustin Luth1-1/+0
The clause to get into this function already tells us that HOLDDEPTH is offf. The functions called in here do not turn it on, so there is no need to clear it at the end. This looks unchanged since initial import. I tested with an assert that the flags saved at the beginning of the clause were identical to the flags at the end, and ran a make check. No asserts. Change-Id: I28bc8725062895d94f387fa0780a16e40b4efe5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137541 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-08-01sw: prefix members of SwBreakDlg, SwCondCollPage, SwDropCapsPage and ...Miklos Vajna6-75/+75
... SwDropCapsPict See tdf#94879 for motivation. Change-Id: I2aefa925964745680529815a729d3a60b29fc545 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137666 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-08-01Remove pngread/pngwrite from excludelistofftkp1-2/+0
Change-Id: Ifc9a2c147a9c40db4b6c68c781f40b2790fd3b64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137259 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-01tdf#150064 Keep a11y child order intactMichael Weghorn2-58/+80
commit 8f9fd6806ccfbf381a383efe5d143ead86ee49de Date: Wed Jun 29 19:47:20 2022 +0200 tdf#137544 reduce cost of ChildrenManagerImpl::Update had added sorting based on memory addresses of the corresponding shapes, but the order of the children in `maVisibleChildren` is expected to reflect the order of the accessible children (i.e. based on the child index of the corresponding shapes' a11y objects), since items are accessed by index (s. e.g. `ChildrenManagerImpl::GetChild`). Since the `ChildDescriptor`'s `mxAccessibleShape` reference can be empty, its child index also cannot be used for sorting instead. To prevent the a11y tree from becoming unstable/random, don't reorder/sort `maVisibleChildren`, but allocate a helper vector holding pointers to the items in the real vector, and iterate over that one instead. This also moves identification of the elements that are only in the old, but no longer the new vector to `ChildrenManagerImpl::MergeAccessibilityInformation`, where the sorted vector is availabe, and returns a vector of obsolete children that is then passed to `ChildrenManagerImpl::RemoveNonVisibleChildren`, instead of doing the comparison of the old/new vector there. Change-Id: Ie449f76f1b98ffe8e85ca28e938b11d726086721 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137622 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Colomban Wendling <cwendling@hypra.fr> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-01tdf#150064 a11y: Swap old/new list before merging informationMichael Weghorn2-14/+15
Swap the old and new list before merging information from the old list to the new one, not afterwards. This also moves this into the block guarded by the SolarMutexGuard, which seems to be held primarily due to changes to `maVisibleChildren` going on, which may already be happening in `ChildrenManagerImpl::MergeAccessibilityInformation` since the elements in the vector can be reordered since commit 8f9fd6806ccfbf381a383efe5d143ead86ee49de Date: Wed Jun 29 19:47:20 2022 +0200 tdf#137544 reduce cost of ChildrenManagerImpl::Update This change is primarily in preparation of adapting what list(s) get sorted/reordered in `ChildrenManagerImpl::MergeAccessibilityInformation` in follow-up commit Ie449f76f1b98ffe8e85ca28e938b11d726086721, "tdf#150064 Keep a11y child order intact". Change-Id: I88bd27b6cbca1e7a03702fd7e75f4094bdb5f977 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137621 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-01Fix typo in codeAndrea Gelmini2-10/+10
Change-Id: I215eb41bc2e7f442b0dc37393460bd2e53fed8c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137646 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-08-01Fix typoAndrea Gelmini1-1/+1
Change-Id: Ic60f4ca995b4f6261a45d7d5ca7f6736b9308f37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137656 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-08-01Fix typoAndrea Gelmini1-1/+1
Change-Id: Ic0f544eeb53c60d2d461c219e38b8fef30eac46e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137658 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-08-01Fix typoAndrea Gelmini1-1/+1
Change-Id: Ib8aabe9fc514b8f2b834e2805b2e583fac250efb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137655 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-08-01Fix typoAndrea Gelmini1-1/+1
Change-Id: I511caa41a696b2181b7691e15940ff7fe9b6f1c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137657 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-08-01Fix typoAndrea Gelmini2-2/+2
Change-Id: I2e2f9bf41bbe0427ab39a1f1870bc5104cd88bb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137654 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-08-01tdf#149916 follow up to include expand field textJim Raykowski1-1/+2
in cross-reference entry text Change-Id: Iaff06e02d272bbe41e63da5356e6c9a6f67c26f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137665 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-08-01tdf#138868 SdNavigator: track object selected on canvasJim Raykowski5-5/+60
Change-Id: Ie28d0ee9482d0bcb4a0a8803e499af3bc0e816d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135084 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-08-01Add 'JobName' to PrintOptionsSamuel Mehrbrodt3-4/+25
Allow users to specify a job name which is sent to the printer (by default this is the current document name). Usage: Sub PrintWithCustomJobname Dim mPOpts(1) As New com.sun.star.beans.PropertyValue mPOpts(0).Name = "JobName" mPOpts(0).Value = "My Job Name" ThisComponent.Print(mPOpts()) End Sub Change-Id: Id7c1c0da7f581b1c050bb3e6d61dd01b7e8205f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137562 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-08-01tdf#142628 Update icons for Field and Field by TypeRizal Muttaqin16-3/+30
Change-Id: I0f369c0d7c426b6f8930f4d34d7e2130c71a06c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137647 Tested-by: Jenkins Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-08-01tdf#120972 DOCX: fix import of decimal tabulatorsTünde Tóth3-3/+18
Use locale specific decimal separator for decimal tabulators, because OOXML does not support custom decimal separator. Regression from commit c0b6aadedc9429eee4f4df85957e00e29ccb0c8f "(related: fdo#81033) writerfilter: default tab fill character is space". Change-Id: I9d89e5817707f3b39a1b718b732f6e289f7c6a99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136846 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-07-31vcl: Better kashida insertion position validationKhaled Hosny2-5/+35
Use the new HarfBuzz glyph flag HB_GLYPH_FLAG_SAFE_TO_INSERT_TATWEEL if available to prevent kashida insertion where is would interrupt shaping (between contextual glyphs). Previously we only prevented it when there is a ligature across the insertion position, with this change fonts that use contextual alternate instead of ligatures will be handled better as well. Change-Id: Ibb42a310c1e7dbcb225a1ba3acac82154b4edb3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-31Update HarfBuzz to 5.1.0Khaled Hosny3-20/+2
Dropping negativeadvance.patch that was applied upstream. Change-Id: I8eba49d2d158c0c29911f4079315ed0bf87b7fa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137648 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-31tdf#150166 DOCX export: fix broken file with tracked ToC movingLászló Németh4-4/+27
It seems, bookmark export always resulted unpaired bookmark elements around ToC sections without causing any interoperability problem, but replacing bookmark elements with moveRange (where needed) releaved the problem, resulting a file format issue in MSO. Skip export the unpaired moveRangeEnd elements until there is a better solution, i.e. exporting moveRangeStart elements also in paragraph-end positions before TOC sections. Note: for back-porting this is the best, i.e. simple enough to be stable and to get a quick review. Regression from commit 9e1e88ad5cf2dc0e9b188c60930445652a6c7519 "tdf#145720 DOCX export: fix loss of tracked moving". Change-Id: I93de467b6a43b2dd3fa97defaef47993969bb7ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137623 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-07-31sc, out of order undo: allow multiple actions from other viewNoel Grandin4-8/+88
this is the calc equivalent of commit c88c2d40d1a4aebc46b25368b80c02bc2f136658 Date: Fri Nov 12 08:39:35 2021 +0100 sw, out of order undo: allow multiple actions from other views Change-Id: I5acbd1e1cacef7c2e2a549f4d2270e961f576a65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137652 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-31Related: tdf#150196 can't change away from "indeterminate" stateCaolán McNamara2-9/+43
Change-Id: Iefa29d422eb810b4f1404bb9582fac508e1853f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137637 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-31Fix typo in codeAndrea Gelmini2-2/+2
Change-Id: Ica86f2c5043fd8f78e83d06778e4b0f468032474 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137645 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-31tdf#150201 Fix endianness for placeable WMFofftkp2-1/+25
The constant PLACEABLE_SIGNATURE in graphicfilter2.cxx had wrong endianness, which would cause the WMF file detection to fail for placeable WMFs. Changed endianness since WMF files are in little endian. Also added test using placeable and non-placeable WMFs. To run the test: make CPPUNIT_TEST_NAME="testDetectWMF" -sr CppunitTest_vcl_graphic_test Change-Id: Ia3c61bae5ab27375636f21bc902f773804cf9273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137634 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-07-31Fix typoAndrea Gelmini1-4/+4
Change-Id: I75b3562ac1710c4eed32b916382ec4fff7ce7041 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137644 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-31tdf#145226 sw: ODF export: fix table-row/table-cell stylesMichael Stahl5-78/+103
The SwFrameFormat for table lines and table boxes gets an auto-generated name in SwDoc::MakeTableBoxFormat()/MakeTableLineFormat(). The problem is that xmltble.cxx assumes that these SwFrameFormats never have a name, and sets names on them temporarily during exportTextAutoStyles(), then later reads them when exporting the table-rows and table-cells, then eventually resets them all to an empty name. One issue is that it assumes that a non-empty SwFrameFormat name indicates a style has been exported, but that isn't always the case, and the name may still be an auto-generated one. Another issue is that overwriting the names interferes with the use of the names in Undo operations. So store the name for the ODF styles in members of the filter classes instead of the core model. (regression from commit 083fe09958658de8c3da87a28e0f8ff7b3b8a5e9) Change-Id: I9b17962decbf9f8ecd2a91551230cf0f012e7a9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127548 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-07-31sc, out of order undo: allow a subset of a non-empty redo listNoel Grandin3-10/+116
This is the calc analogue of commit 60665dc4a2af238939b1a5056ae4a4ce2c083159 sw, out of order undo: allow a subset of a non-empty redo list Specifically, we used to not allow out of order undo at all if the redo list was non-empty. This relaxes that condition a bit. Out of order undo is OK with a non-empty redo list, in case all undo actions in the redo list are either 1) owned by the current view or 2) independent from the undo action to be executed I.e. if view1 has lots of type undo actions and an view2 adds a single type undo action on top of it, then allow view 1 to execute multiple of its typing undo actions, not just a single one. Change-Id: Ib7ab88e9ebbefce267d3c7d567debd1cd98d7d6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-31clang-tidy modernize-pass-by-value in writer*Noel Grandin35-115/+137
Change-Id: Ib08c971eb3e859e7b04cdd408af7966d83c2955b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137585 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-31tdf#149944 Do away with some excessive, unwarranted horizontal spacingAdolfo Jayme Barrientos1-3/+1
Change-Id: I01e2e57dd85802eba1ab024ca3730ba30f311e55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137642 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-30Fix typoAndrea Gelmini1-1/+1
Change-Id: I3cfb8f3daf8e670adc5fe29edb2e3b6ce2ace0cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137640 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-30Fix typoAndrea Gelmini1-9/+9
Change-Id: I8ebd08019541a22acfe763330c2579b9b5c4c7bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137638 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-30Fix typoAndrea Gelmini1-1/+1
Change-Id: I55558e5252c238be2417d370040760ed9c450a4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137641 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-30Improve vcl scheduler documentationHossein1-5/+18
* Fixed a heading problem * Marked variables, functions and identifiers as fixed width * Added several related links Change-Id: If5e56c1e2a474fcfa52601ccda7911bf9e80c913 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137636 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2022-07-30gtk4: convert AtkObject::accessible-role to something elseCaolán McNamara1-0/+33
we only use AtkObject::accessible-role for "static", but there doesn't seem to be a good match to anything I can see in gtk4. convert it to accessible-role of "alert" for lack of a better idea. Change-Id: Ic0795fed006b827914f1319150a915187188a4db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-30sc: allow undo of typing in 2 views independent from each otherNoel Grandin18-13/+218
This commit follows the same pattern as commit c72e500ccaf0ce2261c5233b80fba9342778f810 sw: allow undo of typing in 2 views independent from each other with some changes since calc and writer have different undo/redo infrastructure on top of SfxUndoManager. Change-Id: Ib6e7e21caccb94752c01c529b5013553dba8b4f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-30Assert downcastJim Raykowski1-0/+1
In this case it should be guaranteed that pField is a pointer to SwGetRefField by: else if (pField->GetTypeId() == SwFieldTypesEnum::GetRef) To follow best practice to allow some diagnostic in debug mode, assert(dynamic_cast) before using static_cast to downcast. Change-Id: Ib2c6fb4259b66d5059f1886e23d05fc1c2aa3682 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137578 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-30Add help and list executables options for bin/run scriptHossein1-0/+33
bin/run script is described as: "simple wrapper script to run non-installed executables from workdir". When the bin/run script was used without parameters, it was generating error as it could not run the folder workdir/LinkTarget/Executable. Now, we print usage instructions in this case, or when help is requested with -h, -help or --help. Also, now user can get the list of executables with -l, -list or --list. In normal execution, the script's name is also printed. For example: $ ./bin/run minvcl Setting env variables and running workdir/LinkTarget/Executable/minvcl ... Change-Id: I5c62c300d5247f55d1d1cfd095cecffc979d494b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137626 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2022-07-30tdf#117967 Fixes Save confirmation dialog for user cancelMatt K1-1/+18
The "Confirm save" dialog is launched from SfxMedium::CheckFileDate via "xHandler->handle( xInteractionRequestImpl );" and if the user canceled it the error is saved in the SfxMedium via "SetError(ERRCODE_ABORT);". Then, control is returned to the calling function SfxObjectShell::SaveTo_Impl which currently doesn't handle the cancel error condition, so this change just adds a check to detect it and return instead of doing more "save" processing. This return then goes to the calling function SfxObjectShell::DoSave_Impl which also does some save processing after cancel, in particular it updates the timestamps of the current SfxMedium (which are checked in SfxMedium::CheckFileDate from above and determines whether the "Confirm save" dialog will be launched), so this change prevents the updates to the timestamps by exiting early (i.e. before "DoSaveCompleted();" is called) if the abort error condition is seen so as to avoid a timestamp comparison result of equality which would prevent the "Confirm save" dialog from showing on every subsequent save action from the user. Now the behavior is for the timestamp comparison to fail equality (as would be expected if the file changed underneath the user) so as to ensure the "Confirm save" dialog continues to show for every subsequent save action by the user. Change-Id: I9c4aefc163a06029c80a8a28cdf4a09dff0031a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137540 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2022-07-30tdf#149467 fix re-entrance crashJim Raykowski1-12/+3
This crash is caused by an odd re-entrance happening. In this case re-entrance to SwContentTree::UpdateTracking happens when SfxHintId::DocChanged is broadcast from SwDocShell::SetModified when GetContentAtPos is called from SwContentTree::UpdateTracking which eventually causes a stack crash. Getting model position for view point when getting content at position (GetContentAtPos call to GetModelPositionForViewPoint) shouldn't set the document modification state. Which is what happens using the steps to repro this crash. This patch disallows setting document modification state during the DocumentStylePoolManager::GetFormatFromPool call from SwTextINetFormat::GetCharFormat. backtrace of last 100 levels before crash: 1 SwTextFrame::GetModelPositionForViewPoint_ frmcrsr.cxx 551 0x7fffbddbde96 2 SwTextFrame::GetModelPositionForViewPoint frmcrsr.cxx 665 0x7fffbddbe891 3 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 4 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 5 SwPageFrame::GetModelPositionForViewPoint trvlfrm.cxx 211 0x7fffbdcf6f2f 6 SwRootFrame::GetModelPositionForViewPoint trvlfrm.cxx 452 0x7fffbdcf7fa0 7 SwCursorShell::GetContentAtPos crstrvl.cxx 1370 0x7fffbd581050 8 SwContentTree::UpdateTracking content.cxx 3700 0x7fffbe9864a0 9 SwContentTree::TimerUpdate content.cxx 3589 0x7fffbe985474 10 SwContentTree::Notify content.cxx 3047 0x7fffbe9811ad 11 SfxBroadcaster::Broadcast SfxBroadcaster.cxx 40 0x7ffff4180f32 12 SwDocShell::SetModified docsh2.cxx 1446 0x7fffbe53b663 13 SwDocShell::Ole2ModifiedHdl docsh.cxx 1150 0x7fffbe52d660 14 SwDocShell::LinkStubOle2ModifiedHdl docsh.cxx 1131 0x7fffbe52d597 15 Link<bool, void>::Call link.hxx 111 0x7fffbd8889f5 16 sw::DocumentStateManager::SetModified DocumentStateManager.cxx 50 0x7fffbd888729 17 SwDoc::MakeCharFormat docfmt.cxx 861 0x7fffbd6ef2b8 18 SwDoc::MakeCharFormat_ docfmt.cxx 883 0x7fffbd6ef43a 19 sw::DocumentStylePoolManager::GetFormatFromPool DocumentStylePoolManager.cxx 1514 0x7fffbd89132c 20 sw::DocumentStylePoolManager::GetCharFormatFromPool DocumentStylePoolManager.cxx 1718 0x7fffbd892d86 21 SwTextINetFormat::GetCharFormat txtatr2.cxx 144 0x7fffbdfa1a03 22 SwTextINetFormat::GetCharFormat txtinet.hxx 52 0x7fffbddb4f4e 23 CharFormat::GetItemSet atrstck.cxx 145 0x7fffbddb07e5 24 SwAttrHandler::PushAndChg atrstck.cxx 345 0x7fffbddb1047 25 SwAttrIter::Chg itratr.cxx 102 0x7fffbddf02db 26 SwAttrIter::SeekFwd itratr.cxx 296 0x7fffbddf1104 27 SwAttrIter::Seek itratr.cxx 419 0x7fffbddf17b3 28 SwAttrIter::SeekAndChgAttrIter itratr.cxx 158 0x7fffbddf06e2 29 SwTextIter::SeekAndChg itrtxt.hxx 313 0x7fffbde01791 30 SwTextCursor::GetModelPositionForViewPoint itrcrsr.cxx 1658 0x7fffbddff83f 31 SwTextFrame::GetModelPositionForViewPoint_ frmcrsr.cxx 604 0x7fffbddbe337 32 SwTextFrame::GetModelPositionForViewPoint frmcrsr.cxx 665 0x7fffbddbe891 33 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 34 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 35 SwPageFrame::GetModelPositionForViewPoint trvlfrm.cxx 211 0x7fffbdcf6f2f 36 SwRootFrame::GetModelPositionForViewPoint trvlfrm.cxx 452 0x7fffbdcf7fa0 37 SwCursorShell::GetContentAtPos crstrvl.cxx 1370 0x7fffbd581050 38 SwContentTree::UpdateTracking content.cxx 3700 0x7fffbe9864a0 39 SwContentTree::TimerUpdate content.cxx 3589 0x7fffbe985474 40 SwContentTree::Notify content.cxx 3047 0x7fffbe9811ad 41 SfxBroadcaster::Broadcast SfxBroadcaster.cxx 40 0x7ffff4180f32 42 SwDocShell::SetModified docsh2.cxx 1446 0x7fffbe53b663 43 SwDocShell::Ole2ModifiedHdl docsh.cxx 1150 0x7fffbe52d660 44 SwDocShell::LinkStubOle2ModifiedHdl docsh.cxx 1131 0x7fffbe52d597 45 Link<bool, void>::Call link.hxx 111 0x7fffbd8889f5 46 sw::DocumentStateManager::SetModified DocumentStateManager.cxx 50 0x7fffbd888729 47 SwDoc::MakeCharFormat docfmt.cxx 861 0x7fffbd6ef2b8 48 SwDoc::MakeCharFormat_ docfmt.cxx 883 0x7fffbd6ef43a 49 sw::DocumentStylePoolManager::GetFormatFromPool DocumentStylePoolManager.cxx 1514 0x7fffbd89132c 50 sw::DocumentStylePoolManager::GetCharFormatFromPool DocumentStylePoolManager.cxx 1718 0x7fffbd892d86 51 SwTextINetFormat::GetCharFormat txtatr2.cxx 144 0x7fffbdfa1a03 52 SwTextINetFormat::GetCharFormat txtinet.hxx 52 0x7fffbddb4f4e 53 CharFormat::GetItemSet atrstck.cxx 145 0x7fffbddb07e5 54 SwAttrHandler::PushAndChg atrstck.cxx 345 0x7fffbddb1047 55 SwAttrIter::Chg itratr.cxx 102 0x7fffbddf02db 56 SwAttrIter::SeekFwd itratr.cxx 296 0x7fffbddf1104 57 SwAttrIter::Seek itratr.cxx 419 0x7fffbddf17b3 58 SwAttrIter::SeekAndChgAttrIter itratr.cxx 158 0x7fffbddf06e2 59 SwTextIter::SeekAndChg itrtxt.hxx 313 0x7fffbde01791 60 SwTextCursor::GetModelPositionForViewPoint itrcrsr.cxx 1658 0x7fffbddff83f 61 SwTextFrame::GetModelPositionForViewPoint_ frmcrsr.cxx 604 0x7fffbddbe337 62 SwTextFrame::GetModelPositionForViewPoint frmcrsr.cxx 665 0x7fffbddbe891 63 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 64 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 65 SwPageFrame::GetModelPositionForViewPoint trvlfrm.cxx 211 0x7fffbdcf6f2f 66 SwRootFrame::GetModelPositionForViewPoint trvlfrm.cxx 452 0x7fffbdcf7fa0 67 SwCursorShell::GetContentAtPos crstrvl.cxx 1370 0x7fffbd581050 68 SwContentTree::UpdateTracking content.cxx 3700 0x7fffbe9864a0 69 SwContentTree::TimerUpdate content.cxx 3589 0x7fffbe985474 70 SwContentTree::Notify content.cxx 3047 0x7fffbe9811ad 71 SfxBroadcaster::Broadcast SfxBroadcaster.cxx 40 0x7ffff4180f32 72 SwDocShell::SetModified docsh2.cxx 1446 0x7fffbe53b663 73 SwDocShell::Ole2ModifiedHdl docsh.cxx 1150 0x7fffbe52d660 74 SwDocShell::LinkStubOle2ModifiedHdl docsh.cxx 1131 0x7fffbe52d597 75 Link<bool, void>::Call link.hxx 111 0x7fffbd8889f5 76 sw::DocumentStateManager::SetModified DocumentStateManager.cxx 50 0x7fffbd888729 77 SwDoc::MakeCharFormat docfmt.cxx 861 0x7fffbd6ef2b8 78 SwDoc::MakeCharFormat_ docfmt.cxx 883 0x7fffbd6ef43a 79 sw::DocumentStylePoolManager::GetFormatFromPool DocumentStylePoolManager.cxx 1514 0x7fffbd89132c 80 sw::DocumentStylePoolManager::GetCharFormatFromPool DocumentStylePoolManager.cxx 1718 0x7fffbd892d86 81 SwTextINetFormat::GetCharFormat txtatr2.cxx 144 0x7fffbdfa1a03 82 SwTextINetFormat::GetCharFormat txtinet.hxx 52 0x7fffbddb4f4e 83 CharFormat::GetItemSet atrstck.cxx 145 0x7fffbddb07e5 84 SwAttrHandler::PushAndChg atrstck.cxx 345 0x7fffbddb1047 85 SwAttrIter::Chg itratr.cxx 102 0x7fffbddf02db 86 SwAttrIter::SeekFwd itratr.cxx 296 0x7fffbddf1104 87 SwAttrIter::Seek itratr.cxx 419 0x7fffbddf17b3 88 SwAttrIter::SeekAndChgAttrIter itratr.cxx 158 0x7fffbddf06e2 89 SwTextIter::SeekAndChg itrtxt.hxx 313 0x7fffbde01791 90 SwTextCursor::GetModelPositionForViewPoint itrcrsr.cxx 1658 0x7fffbddff83f 91 SwTextFrame::GetModelPositionForViewPoint_ frmcrsr.cxx 604 0x7fffbddbe337 92 SwTextFrame::GetModelPositionForViewPoint frmcrsr.cxx 665 0x7fffbddbe891 93 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 94 SwLayoutFrame::GetModelPositionForViewPoint trvlfrm.cxx 168 0x7fffbdcf6c08 95 SwPageFrame::GetModelPositionForViewPoint trvlfrm.cxx 211 0x7fffbdcf6f2f 96 SwRootFrame::GetModelPositionForViewPoint trvlfrm.cxx 452 0x7fffbdcf7fa0 97 SwCursorShell::GetContentAtPos crstrvl.cxx 1370 0x7fffbd581050 98 SwContentTree::UpdateTracking content.cxx 3700 0x7fffbe9864a0 99 SwContentTree::TimerUpdate content.cxx 3589 0x7fffbe985474 100 SwContentTree::Notify content.cxx 3047 0x7fffbe9811ad Change-Id: I7e0814cf3a42dc876dd60c926d4b2245a036cc3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135802 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-07-30tdf#118696 better fix for sd Navigator object selectionJim Raykowski1-10/+5
resulting in unexpected view movement This fix reverts commit 3c86ffd8ded628e6f2b4187948a1b1056f6a0f56 and reintroduces DrawViewShell::MakeVisible with change made to the passed object rectangle always being the snap rectangle instead of the rectangle returned from a call to object GetLogicRect. Change-Id: I05e777545fb1093838c05618e87ad4d4f5ec003c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137008 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-07-30Fix typoAndrea Gelmini1-1/+1
Change-Id: I1b6c7eccebffc80b057eb2730428b20047ee685b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137625 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-20 01:23:04 +0000