summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-03-24sw: keep the cursor visible after creating SwDrawTextShellAshod Nakashian1-1/+1
For some mysterious reason the cursor was forced to become hidden after creating SwDrawTextShell, which is used to edit the text on shapes. Doing this didn't have a negative effect on desktop, because the cursor was shown anyway at a later point. However, for LOK, the cursor was not restored. This was unexpected as the clients didn't know editing was possible (and on mobile wouldn't even show the keyboard). There doesn't seem to be any ill-effect to leaving the cursor enabled in all cases after creating an SwDrawTextShell instance. Change-Id: Ifae8d533ef48b2146a451d58d729e46f5248be71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90897 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit a50d20b114b4d418cebb968af4b40645dfac087a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90947 Tested-by: Jenkins
2020-03-24sw: check for null SdrObject before accessingAshod Nakashian1-0/+2
Change-Id: I30f1cc658450982232feea10dbe9c5bfefe07d91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90896 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 8ed4ac6152c96280616a784b47c4f75df147501a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90946 Tested-by: Jenkins
2020-03-24Sukapura: Add more 32px and independent iconsRizal Muttaqin248-119/+207
- Update Impress's hover image - Fix for wrong named icon - etc Change-Id: I1ad1f74a1b6ee4658b55fdb25d85d08e42e9a138 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90933 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-03-23external/nss: --no-zdefs for gyp-base sanitizer buildsStephan Bergmann3-20/+1
Change-Id: I0516295c340e4b6df2fae852303e423a08784172 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90943 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-23Fix typosAndrea Gelmini9-11/+11
Change-Id: Iba46fbe8559211403118a23cd198a2217b333a81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90900 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-23tdf#124176 Use pragma once instead of include guardsgokaysatir7-28/+7
Change-Id: I3077e6e3a043401e66cd527c5f69b8571e8b25d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90915 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-23tdf#131434 ensure expander icon column is createdCaolán McNamara1-0/+2
which the normal ::insert case does, but the bulk insert omitted Change-Id: I9b236e5f0e91292539164d39f0f90e109a1b503e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90928 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-23tdf#114441: Convert use of sal_uLong to better integer typesFurkan Ahmet Kara1-5/+5
Change-Id: Iec1e6f0d5d3f79357182c92166ba83c5fad3521f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90894 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-23actually export $NINJA from configureLuboš Luňák2-2/+4
I based the check on the gmake check, but that one doesn't need the export, as gmake is what needs to be called for the build to start. But ninja is currently only used during building NSS. Also do not use Windows path for ninja on Windows, as NSS actually invokes it from a shell script. Change-Id: I0d8a86ee3688f27a376d547cd946bb4c59a547a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90922 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-23Keep Writer Navigator content view vertical scroll positionJim Raykowski1-12/+9
...when an object is renamed Change-Id: Ib8984fd67653e6bec30d9b27c2d2fbe86b7ce0c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90891 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-23Remove nonexisting files from solenv/clang-format/blacklistStephan Bergmann1-12/+0
Found with > while IFS= read -r i; do if test ! -f "$i"; then printf '%s\n' "$i"; fi; done <solenv/clang-format/blacklist Change-Id: If919ef697b6dd8f7fc511835e3fa90caf37ad991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90918 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-23Related tdf#97694 Check Base macro signatures on loadSamuel Mehrbrodt9-47/+128
Change-Id: I45c6eae633c41585c6c7e4c5fff0b187a6dc1f60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90908 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-23python3: upgrade to release 3.7.7Michael Stahl2-3/+3
Fixes CVE-2020-8315; this only affects Windows 7 and is a regression in Python 3.6. Change-Id: Ic1706e064a1b03ca1de6361794ed4586a89821d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90916 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-23tdf#131344 Make SvxFontSizeBox_Impl Enable and Disable workJim Raykowski1-0/+3
...with change to InterimItemWindow way of using FontSizeBox as member variable widget Change-Id: I0ad0c3191800ce80a88e58467950a80b5791a2da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90510 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-23GtkInstanceTreeView: Expand to path before setting cursorJim Raykowski1-0/+8
Expands the parent of a child, if needed, so the child can be selected. Change-Id: If4b7322a7024065e5e96ed2ed43289c5ae7c5f5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-23tdf#130711: [tr] Extend Autocorrect list for Turkish language (Start with D/E)ayhanyalcinsoy1-0/+34
Change-Id: I312fb575e888c8a4c1ef0d2857e9682a7f31e295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90187 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-23Sort solenv/clang-format/blacklistStephan Bergmann1-3/+3
(lexicographically, by Unicode code point values; to make it easier to add further entries) Change-Id: Ie7f5dbfbc7e2c1c8ed331d5328c059866c2e2d10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90914 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-23Add wrongly formatted file to blacklistStephan Bergmann1-0/+1
Change-Id: I1e51edcf80ca7f6c114bf83f55441644f08b8595 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90911 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-23sw: add pad-to-5 numberingMiklos Vajna10-0/+73
This is the last padded numbering type that is supported by Word but was not supported by Writer. Change-Id: Ica1a0843897c61a4b569105fd21e5bfe7b5012cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90912 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-23add a configure check for ninjaLuboš Luňák3-1/+65
Internal NSS now needs it for building on most platforms, so better check early in configure. Change-Id: I45d7038536ea1416443f3b2523f25eee22911485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90859 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-23build also PDBs for nss when using gypLuboš Luňák3-6/+74
This should be the gyp variant of 54acab919e7c7c5d60fc697bda5427. Change-Id: Ic50f5153c4b1f19ae74a52eb9bc0d7c6c23ae131 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90118 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-23build nss using gyp+ninja also on WindowsLuboš Luňák8-31/+238
Change-Id: I3acb0f2a93cee85e382e03c2b2fdd68273e12516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90117 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-23do not reset PATH when invoking internal pythonLuboš Luňák1-1/+1
Change-Id: I7759fefbf5c2dbc39ae9a53f7c044bf63165608c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90116 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-23build nss using their new build system (gyp/ninja-based)Luboš Luňák12-1/+219
This requires installed ninja, gyp is included as source. This allows nss be built as a parallel build, unlike the old Makefile build system. Since gyp internally uses python, even recursively, this requires more complicated setup in case our internal python is used. Moreover gyp itself seems to be kind of deprecated itself and hasn't been ported to python3 yet, so that needs patching too. So far only easy Unix-like systems are converted, Windows I'll do later, the more complicated systems I'll leave to whoever has access to them. Change-Id: I358baad7690d2aa6df44bafa9244dc7cc828fc3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90115 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-23rework the default make targetLuboš Luňák3-18/+14
The current default target ('all') was a confusing mess, it did run some tests, but it did run just some of them and it also depended on some factors (toplevel 'make' vs module 'make'). And running tests on plain 'make' also makes the developer cycle longer, which is annoying, and now there's Jenkins which will do checks. This commit makes the default make target to be 'build'. All the other targets should work the same way, with the exception of 'all', which I've removed (given that it was confusing, it's probably better not to try to keep any kind of backwards compatibility there). The 'build-nocheck' target is now equal to 'build' and thus pointless, but I've kept it for backwards compatibility. Change-Id: I874b7ae8d26e95efa86a00dd32cfa7fd19599b9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89820 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-23writerfilter: GCC 9.2.1 -Og -Werror=maybe-uninitializedMichael Stahl1-1/+1
This one isn't GCC's fault, not obvious that the any must contain a bool. Change-Id: Iad94dc5bd1a010be1c22e527e0d14c027f0dcf60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90910 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-23configure,gbuild: gla11y fails on Fedora 31Michael Stahl3-4/+8
The problem is that the LD_LIBRARY_PATH on the command line causes /usr/bin/python to find LO's libpython*.so*: 18269: find library=libpython3.7m.so.1.0 [0]; searching 18269: search path=.../instdir/program (LD_LIBRARY_PATH) 18269: trying file=.../instdir/program/libpython3.7m.so.1.0 Presumably LD_LIBRARY_PATH is used to find bundled libxml/libxslt. So let's try to disable the broken case where a bundled lxml is used with system python and bundled libxml/libxslt; this cannot work. (regression from 84ef6d82546b044990f4efd57e51e29c6c6565c8) Change-Id: I67aa8250691cae8f899d65f674aa9da23a9d1d7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90906 Reviewed-by: Samuel Thibault <sthibault@hypra.fr> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-03-23tdf#39674 Translate some German variable namesshivammore4-7/+7
Words translated TITEL->TITLE SUBTITEL->SUBTITLE Change-Id: If26f3b53b0ee960522515a640bc0367df257bf57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90679 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-03-23Fix spelling of variableJohnny_M1-6/+6
Formular -> Formula (Found when working on variable translation in c212e295c589695c9da0c21914fb30b6af5909d6.) Change-Id: I9409598670eabdd6ebb1ea1cb0ccc4d9d6292f8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90464 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-23Translate German variable namesJohnny_M1-20/+20
Formular -> Form Change-Id: I2efb4a8df4898d73e4cf0ebaf93df0adccb2a562 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90463 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-23tdf#42949 Fix IWYU warnings in dbaccess/source/core/*/*cxxGabor Kelemen64-319/+59
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I24808de5bfd176e007fdc96f120a3c9a43dc7902 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90480 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-23tdf#125268: Export LO character background as MSO shading by default.Tamás Zolnai1-1/+1
Change-Id: I139f7b0795a12bbf0f54a0031883c2f05bf644cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90909 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-23tdf#124176: Use pragma once instead of include guardsHarshit Jain11-46/+11
Change-Id: Ia4a6b35a9a734e9fa1dc9dea702fc1ec370021f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90901 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-23tdf#125268: Add mso-highlight color palette.Tamás Zolnai2-0/+20
These colors are supported by MSO highlight feature. With using these user can avoid conversion issues, while saving to MSO formats. Change-Id: I9ef4a8470a7115d8dce984b8c30ce6798fe8131a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90905 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-23make more classes private in mergedlibs modeNoel Grandin158-280/+438
Change-Id: I486922d0652f26fa7ee56f5fe308e19fe5ff137e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90856 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-23always set ForceMakeVisibleCaolán McNamara1-0/+1
Change-Id: Icb0b4f34b5f230b6e1cb99debba278e4a9c8dd96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-23cid#1209589 Dereference after null checkCaolán McNamara1-0/+4
Change-Id: I6077e4f6e763c083f2fab29f7ada0e20184097d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90892 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-23sw: prefix members of ArrayComparator, CommonSubseq, CompareSequence and ...Miklos Vajna3-83/+83
.. SwUndoTextToTable See tdf#94879 for motivation. Change-Id: I5d80e8dff390f528359a0b4c43553921f81a8519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90902 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-22FieldDeletionModify: no more ModifyBjoern Michaelsen1-15/+10
Change-Id: Iec2c7d6178358a4145c10f1c22ab526f03670806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90862 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-22tdf#131465 image is stretched to fit allocationCaolán McNamara1-9/+24
center it inside a parent box instead Change-Id: I8ad407119924e0a6d9992e99d2d9e6e88453477b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-22tdf#124176: Use pragma once instead of include guardsFurkan Ahmet Kara16-62/+17
Change-Id: I24df5daa3ded43f1fa031a9e2714453cb03b92f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90769 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-22tdf#131464: fix create an index of Writer in Japanese localeJulien Nabet1-2/+2
in i18npool/source/collator/collator_unicode.cxx, we got: 177 // replace algorithm name to implementation name. 178 if (rAlgorithm == "phonetic (alphanumeric first)") 179 aBuf.append("phonetic_alphanumeric_first"); 180 else if (rAlgorithm == "phonetic (alphanumeric last)") 181 aBuf.append("phonetic_alphanumeric_last"); 182 else 183 aBuf.append(rAlgorithm); So don't add extra ja_ before "phonetic..." Also we already add "ja" in buffer with line: 158 aBuf.append("get_").append(rLocale.Language).append("_"); so right functions from ICU will be retrieved Change-Id: I163c3ca4bb4dcfa1e5d29313190c5ba3e6396c4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90877 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-22Fix typoAndrea Gelmini1-1/+1
Change-Id: I52d6c6108861bf2118854e78b2653f3157595b31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90861 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-22Colibre: fix for tdf#131454, Wrong icons for Valid SignatureRizal Muttaqin13-7/+7
Change-Id: I16790b6f668823be346a6d8b51de4a98ac3eb5d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90874 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-03-22Sukapura: Add Fill Cell iconsRizal Muttaqin78-18/+67
- Update hide related icons, etc Change-Id: I053a628f58f9a3eeb2690b74ea50ce4c5320b64c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90867 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-03-21Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to f3583cef91c71b5cec52ffef7db602580c65ee69 - tdf#91313 Update Paste Special new features - add Paste Nested Table, Columns Before, Rows Above - add Paste Only Text, Number, Formula - Refactor Paste Special <switch> for Calc Change-Id: I56547db917863aca2402191bef934c2bba5ff619 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/90864 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-03-21ddefld.cxx: SwIterator no more ...Bjoern Michaelsen1-20/+17
(also fix regression from 89d39bc100aabf5dccbe77c0b5c0c85736e85b39 mixing up booleans it seems) Change-Id: If5deb615cec8a8d585dff449c7030f8f97a7afa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90854 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-03-21Casual users don’t care about Unicode code pointsAdolfo Jayme Barrientos1-1/+1
It was too geeky to include this detail in the first place, but the bigger problem was that no other options do. Besides, the capitalization used here was wrong (menus are title case). Change-Id: Ia103850709739aedf43fda2b905143b991a9d43c
2020-03-21add get_modifier_state to toolbar for what modifiers are heldCaolán McNamara3-0/+15
Change-Id: I77e7f6238d82249ffede1edee2dc88f1a76b3717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90860 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-21scroll GtkTreeView to a position after clear+fill without flickeringCaolán McNamara1-1/+55
Change-Id: Ibe5519cf19c35da91ce7bef46a0b72292621d3e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90830 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>