Age | Commit message (Collapse) | Author | Files | Lines |
|
Cppcheck noticed a run of 3 if's with the same condition next to each
other; they're fall out of e54d65dea830c which simplified the conditions
to all be the same.
Squash them.
Change-Id: I5f0b928b9a629dc43cc62cc03ab6ced2a4b42b2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109851
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
ba69036c8e889237da4bb312d7c5c94066abbfd3 "Upgrade update check and extension
URLs to https" had changed ExtensionUpdateURL only in the corresponding instdir/
version ini-file generated by instsetoo_native/CustomTarget_setup.mk.
Change-Id: Ia6281fceec649495681051093ce744edbfe1d225
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109823
Tested-by: Guilhem Moulin <guilhem@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Guilhem Moulin <guilhem@libreoffice.org>
|
|
35518c92365cc183ba6cce2a4d284a130c0ca13f "Move all public Java classes to
libreoffice.jar" had changed URE_MORE_JAVA_TYPES only in the corresponding
instdir/ fundamental ini-file generated by
instsetoo_native/CustomTarget_setup.mk.
Change-Id: I76c65b4f2fc5088b1b9bb1c0976d895b963108b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109822
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I887d8bc4554880ca826259c8f9b30aaa3b41ec1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109820
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I773555180758a97aff37f9bc27de83c355d71521
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109761
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Instead of just skipping hidden rows, either skip or interpolate
into visible ones.
This method, and it's single caller look rather unusual to me. It is
unclear why we would want to return the results we do, and why the
one caller subtracts a row.
Some surprising proportion of tile rendering was exercising this code
path extremely slowly.
--5.94%--ScDocument::GetPrintArea
|
|--5.04%--ScDrawLayer::GetPrintArea
| ScTable::GetRowForHeight
| |
| --4.58%--ScFlatBoolRowSegments::getRangeData
| |
| --2.46%--ScFlatSegmentsImpl<bool, bool>::getRangeData
Change-Id: I75418d6af59a33b99e8bb0c374139e1a4ee6ef87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109837
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Ashod Nakashian <ash@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109848
Tested-by: Jenkins
|
|
--doc_setView
SfxLokHelper::setView
SfxViewFrame::MakeActive_Impl
SfxApplication::SetViewFrame_Impl
|
--SfxDispatcher::Update_Impl
|
--SfxWorkWindow::UpdateObjectBars_Impl
SfxWorkWindow::UpdateObjectBars_Impl2
|
--framework::LayoutManager::requestElement
framework::LayoutManager::createElement
|
--11.97%--framework::implts_isPreviewModel
We re-calculate the calc print-area on every setView via this
code-path; pointlessly expensive.
Change-Id: I36dbdc60a789fac4e2a82825b145725a4a4d6439
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109805
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: I89b1b7fef33cfd6960af4da38112199f3874d9fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109828
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 37a79c487851addcdac66d5f229556a53f5d4416
- Create SFDocuments Help page (ScriptForge)
Adds a new Help page for the Document service provided by ScriptForge.
Add a <variable> tag to the sf_ui.xhp for x-ref.
Change-Id: Ic65daf9ebcecddf569bd494c10010f03bb360299
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109687
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 7c1c258ce3396984a5c57874f5ab1e28758c9ed5
- Fixes localization issues in ScriptForge Help pages
Some code blocks with comments need translation and therefore need to have the localize="false" removed.
Also, other parts of the text shouldn't be localized, so localize="false" was added.
Change-Id: Id072eb88f95ee8759f86d2ca3736698855b50b4b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109801
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
not just when changed by the user
Change-Id: If2238341ff8465fee6375dad1ea9b4d7ec0110e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109827
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
The import side went wrong in commit
812ee7a6dc29b55acfbeaa1a43e632adbaf72e6b (Removal rtl and string
cleanup, 2012-12-31), which turned a prefix check into an equality
check.
The export side ignored the command parameters, now we write 'playFrom'
instead of 'play' in case we have a start timestamp.
Change-Id: Ia7e058e17400b1efbf7a6254355a70c4a5e15dbe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109825
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Type of actual parameter is made same as formal parameter.This is done to undo the conversions made in sbxToUnoValueImpl.
Change-Id: I8c7a880503d927eb43ad38eac4bf01451442834b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109773
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
since...
commit ff4896a2af1df6138e9246fe1588dfe8c3748f1a
Date: Fri Jun 29 11:36:03 2018 -0300
Sets paper sizes listbox in print dialog
see as the above commit added some uses of doSloppyFit to vcl I imagine
the calls there want to be able to match rotated paper sizes, but in
the cases of tdf#135590 we don't want that behaviour because it doesn't
match what the user is presented with, the width and height are swapped.
So drop matching against swapped height/width by default, but let calls
added in 'Sets paper sizes listbox in print dialog' continue to match
rotated sizes.
Change-Id: I34aeddf12a7ca22234fbc6394487d3c8da7772ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109784
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ib0e7e1656dfb631e6cc8a897d376c783455483d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109817
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
to look through template instantiations involving std::forward
motivated by
commit b1617acde182d1683bdfb529794d7456f8b4bf6d
drop RadioButton arg defaults
the nBits arg in builder.cxx was in the wrong place
Change-Id: I222ea2aeea6f44ae54839e824a247a8105392c2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109789
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to 859c52b35a1cd6b624554c71f8ef2097ddd58b11
- Fix typo
Change-Id: I8f17236721839f1a0fc909629e80c6e18e98fd18
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109826
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
|
|
Change-Id: I2baa559b368a4c3110a6e726baafc394a16360af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109781
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
...following up on 336a9ec1c4801ab57264b264ead90e5c14451230 "URI-encode spaces
in PRODUCTNAME for UserInstallation"
Change-Id: I73fadea567c8e26f6a337c094623fa83be1e2188
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109815
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: Id8deeee0c1a919f330bc6623f708453279a214c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109785
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
which uses MapUnit::Twip
so directly after insert, envelope, ok the new document sidebar
was using MapUnit::Map100thMM to lookup paper sizes instead of
MapUnit::Twip giving inconsistent results against format, page
Change-Id: I6a92fddedfe9fef8ad7532ad00b2b38b9741bb69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109782
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Fix regression from commit 39090afac268f9ae985832c2f08863b41e6c06f2
(tdf#120336 DOCX import: fix page break after tracked deletion),
limiting the condition only for *empty* section starting
paragraphs with tracked deletion.
Change-Id: I020c8b0edf5d4a37a9150cccec8c25fce50327d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109779
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: I105af83c1f490ab49e0ba061b08069787ebaa49f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109776
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
If the columns are marked as AutoWidth, then there is
no need to go to the remarkably poor layout code
to determine if the columns should be exported as equal.
In this case, it appears as if the layout engine hadn't
really identified the full width, or evaluated the
wish values of each column.
This fixes DOCX, DOC, and RTF.
Change-Id: I1a1193b65d01e654b3bfbfaee7d8c02a683ae2c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109762
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I0eb512980261629827b411ab3009b48c1fe6075c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109629
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iaa5ed1b3f68b257ec94731c2873e6016c7988608
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109780
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
update the script to use python3, and run it
Change-Id: I9c2a86e1f7a2eb889dcf214f2a2f6a31ceb1f59e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109710
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
i.e. input fr/de 12,34 should be stored as 12.34
Change-Id: I20c97d2d604998a40e3a15963aa3d8716101e3c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109772
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1a295ece6e618e3bb81b8842a8b9df5de1cbffac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109366
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
+ DrawingArea
+ Combobox
+ Listbox
+ RadioButton
+ Expander
+ IconView
+ Entry
+ TextView
+ SpinField
Change-Id: Ic1fdc8ae37216089d0ba18191ff12895c1f5e84e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109367
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
Change-Id: I5b4e690c48583dcb609eb139ef2bf8e62d146d30
(cherry picked from commit 89ce9c72e332b141882d92e809fbc10121aee9a5)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109693
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
|
|
This was invisible in PowerPoint without explicit stretching.
Change-Id: I29b9f23eba6d59436cb1b6d15c9840794f932e69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109778
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I5bea6423a3c3bbe933ae5160ac02923ddea5c408
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109777
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: I85906e1c72f4bf2ff3f48a7c2882423c9965621c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109771
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Idbeff3c0bd3bd3134bbefbf6bb55b9a70fe106ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109768
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I01f14cdf0aa3ea16cd311aed9abe14423e2ec846
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109727
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
There is maSequence already, which is totally different to this
variable, so rename it to aPropertySequence, which should hint
at what it is actually used for.
Change-Id: Ia202c5bd69ed17ebe80ffb522538e03de2a83f3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109601
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
While the first fix (Change-Id
I12a780bf52024cef31188651813d3a93cc2b5ddd,
"tdf#139782 sc: Don't try to access unallocated column") makes
opening the simplified bugdoc I had attached to tdf#139782 work,
the original document I was given (which I can't share as is, but
from which the simplified bugdoc was created) had more formulas and
managed to hit another similar issue related to the fact that columns
are now dynamically allocated, and crashed trying to access one that
wasn't yet allocated.
Fix this place as well by making sure the column exists.
Backtrace:
"#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50\n"
"#1 0x00007ffff7aa7537 in __GI_abort () at abort.c:79\n"
"#2 0x00007ffff794beb1 in std::__throw_bad_exception() () at /lib/x86_64-linux-gnu/libstdc++.so.6\n"
"#3 0x00007fffa0b161dc in std::__debug::vector<std::unique_ptr<ScColumn, o3tl::default_delete<ScColumn> >, std::allocator<std::unique_ptr<ScColumn, o3tl::default_delete<ScColumn> > > >::operator[](unsigned long) (this=0x555558827250, __n=84) at /usr/include/c++/10/debug/vector:427\n"
"#4 0x00007fffa0c23935 in ScColContainer::operator[](unsigned long) (this=0x555558827250, nIndex=84) at .../libreoffice/sc/inc/colcontainer.hxx:44\n"
"#5 0x00007fffa0c76275 in ScQueryCellIterator::InitPos() (this=0x7fffffff8040) at .../libreoffice/sc/source/core/data/dociter.cxx:1082\n"
"#6 0x00007fffa0c76c28 in ScQueryCellIterator::GetFirst() (this=0x7fffffff8040) at .../libreoffice/sc/source/core/data/dociter.cxx:1233\n"
"#7 0x00007fffa0c76fb6 in ScQueryCellIterator::FindEqualOrSortedLastInRange(short&, int&) (this=0x7fffffff8040, nFoundCol=@0x7fffffff7f58: 1024, nFoundRow=@0x7fffffff7fb0: 1048576) at .../libreoffice/sc/source/core/data/dociter.cxx:1304\n"
"#8 0x00007fffa11b1529 in ScInterpreter::ScMatch() (this=0x5555619f7fd0) at .../libreoffice/sc/source/core/tool/interpr1.cxx:5050\n"
"#9 0x00007fffa121f653 in ScInterpreter::Interpret() (this=0x5555619f7fd0) at .../libreoffice/sc/source/core/tool/interpr4.cxx:4247\n"
"#10 0x00007fffa0f03bf5 in ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) (this=0x55555e793030, rContext=..., eTailParam=ScFormulaCell::SCITP_NORMAL) at .../libreoffice/sc/source/core/data/formulacell.cxx:1952\n"
"#11 0x00007fffa0f028b2 in ScFormulaCell::Interpret(int, int) (this=0x55555e793030, nStartOffset=-1, nEndOffset=-1) at .../libreoffice/sc/source/core/data/formulacell.cxx:1644\n"
"#12 0x00007fffa0be0274 in ScFormulaCell::MaybeInterpret() (this=0x55555e793030) at .../libreoffice/sc/inc/formulacell.hxx:445\n"
"#13 0x00007fffa0f07b34 in ScFormulaCell::GetErrCode() (this=0x55555e793030) at .../libreoffice/sc/source/core/data/formulacell.cxx:2974\n"
"#14 0x00007fffa10bac28 in ScCellFormat::GetString(ScRefCellValue const&, unsigned int, rtl::OUString&, Color const**, SvNumberFormatter&, ScDocument const&, bool, bool, bool) (rCell=..., nFormat=0, rString=\"\", ppColor=0x7fffffff87e8, rFormatter=..., rDoc=..., bNullVals=true, bFormula=false, bUseStarFormat=false) at .../libreoffice/sc/source/core/tool/cellform.cxx:77\n"
"#15 0x00007fffa0bcb8f8 in ScColumn::UpdateScriptType(sc::CellTextAttr&, int, mdds::detail::mtv::iterator_base<mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::iterator_trait, mdds::detail::mtv::private_data_forward_update<mdds::detail::mtv::iterator_value_node<unsigned long, mdds::mtv::base_element_block> > >&) (this=0x55555e793330, rAttr=..., nRow=1, itr=...) at .../libreoffice/sc/source/core/data/column3.cxx:794\n"
"#16 0x00007fffa0b9e315 in ScColumn::GetRangeScriptType(mdds::detail::mtv::iterator_base<mdds::multi_type_vector<mdds::mtv::custom_block_func1<mdds::mtv::default_element_block<51, sc::CellTextAttr> >, mdds::detail::mtv::event_func>::iterator_trait, mdds::detail::mtv::private_data_forward_update<mdds::detail::mtv::iterator_value_node<unsigned long, mdds::mtv::base_element_block> > >&, int, int, mdds::detail::mtv::iterator_base<mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::iterator_trait, mdds::detail::mtv::private_data_forward_update<mdds::detail::mtv::iterator_value_node<unsigned long, mdds::mtv::base_element_block> > > const&) (this=0x55555e793330, itPos=..., nRow1=1, nRow2=1, itrCells_=...) at .../libreoffice/sc/source/core/data/column2.cxx:2089\n"
"#17 0x00007fffa0b27563 in (anonymous namespace)::FindEditCellsHandler::operator()(size_t, ScFormulaCell const*) (this=0x7fffffff9180, nRow=1, p=0x55555e793030) at .../libreoffice/sc/source/core/data/column.cxx:3091\n"
"#18 0x00007fffa0b31267 in sc::CheckElem<mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>, mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>, (anonymous namespace)::FindEditCellsHandler>(mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent> const&, mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::const_iterator const&, size_t, size_t, (anonymous namespace)::FindEditCellsHandler&) (rStore=..., it=..., nOffset=0, nDataSize=999, rFuncElem=...) at .../libreoffice/sc/inc/mtvfunctions.hxx:149\n"
"#19 0x00007fffa0b2eb58 in sc::FindElement2<mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>, (anonymous namespace)::FindEditCellsHandler, (anonymous namespace)::FindEditCellsHandler>(mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent> const&, mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::size_type, mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::size_type, (anonymous namespace)::FindEditCellsHandler&, (anonymous namespace)::FindEditCellsHandler&) (rStore=..., nStart=0, nEnd=1048575, rFuncElem=..., rFuncElse=...) at .../libreoffice/sc/inc/mtvfunctions.hxx:496\n"
"#20 0x00007fffa0b2b487 in sc::FindFormulaEditText<(anonymous namespace)::FindEditCellsHandler>(sc::CellStoreType const&, SCROW, SCROW, (anonymous namespace)::FindEditCellsHandler&) (rStore=..., nRow1=0, nRow2=1048575, rFunc=...) at .../libreoffice/sc/inc/mtvcellfunc.hxx:141\n"
"#21 0x00007fffa0b293e3 in ScColumn::HasEditCells(int, int, int&) (this=0x55555e793330, nStartRow=0, nEndRow=1048575, rFirst=@0x7fffffff92ec: 0) at .../libreoffice/sc/source/core/data/column.cxx:3434\n"
"#22 0x00007fffa0b981b1 in ScColumn::GetOptimalHeight(sc::RowHeightContext&, int, int, unsigned short, int) (this=0x55555e793330, rCxt=..., nStartRow=0, nEndRow=1048575, nMinHeight=0, nMinStart=0) at .../libreoffice/sc/source/core/data/column2.cxx:863\n"
"#23 0x00007fffa0fcaf7d in (anonymous namespace)::GetOptimalHeightsInColumn(sc::RowHeightContext&, ScColContainer&, SCROW, SCROW, ScProgress*, sal_uLong) (rCxt=..., rCol=..., nStartRow=0, nEndRow=1048575, pProgress=0x7fffffff9740, nProgressStart=406268) at .../libreoffice/sc/source/core/data/table1.cxx:93\n"
"#24 0x00007fffa0fccdae in ScTable::SetOptimalHeight(sc::RowHeightContext&, int, int, ScProgress*, unsigned long) (this=0x55555a39e890, rCxt=..., nStartRow=0, nEndRow=1048575, pOuterProgress=0x7fffffff9740, nProgressStart=406268) at .../libreoffice/sc/source/core/data/table1.cxx:470\n"
"#25 0x00007fffa0c7ced6 in ScDocRowHeightUpdater::update() (this=0x7fffffff9910) at .../libreoffice/sc/source/core/data/dociter.cxx:2732\n"
"#26 0x00007fffa15aae65 in ScXMLImport::endDocument() (this=0x555558902ec0) at .../libreoffice/sc/source/filter/xml/xmlimprt.cxx:1443\n"
"#27 0x00007fff99f9e04b in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) (this=0x555559b8e0f0, rStructSource=...) at .../libreoffice/sax/source/fastparser/fastparser.cxx:911\n"
"#28 0x00007fff99fa2318 in sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) (this=0x55555a718940, aInputSource=...) at .../libreoffice/sax/source/fastparser/fastparser.cxx:1482\n"
"#29 0x00007fffecc8fa95 in SvXMLImport::parseStream(com::sun::star::xml::sax::InputSource const&) (this=0x555558902ec0, aInputSource=...) at .../libreoffice/xmloff/source/core/xmlimp.cxx:504\n"
"#30 0x00007fffa15e0863 in ScXMLImportWrapper::ImportFromComponent(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, com::sun::star::uno::Reference<com::sun::star::frame::XModel> const&, com::sun::star::xml::sax::InputSource&, rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, bool) (this=0x7fffffffa2b0, xContext=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x55555591a590, xModel=uno::Reference to (ScModelObj *) 0x55555a39fe50, aParserInput=..., sComponentName=\"com.sun.star.comp.Calc.XMLOasisContentImporter\", sDocName=\"content.xml\", aArgs=uno::Sequence of length 4 = {...}, bMustBeSuccessfull=true) at .../libreoffice/sc/source/filter/xml/xmlwrap.cxx:182\n"
"#31 0x00007fffa15e3c0b in ScXMLImportWrapper::Import(ImportFlags, ErrCode&) (this=0x7fffffffa2b0, nMode=ImportFlags::All, rError=...) at .../libreoffice/sc/source/filter/xml/xmlwrap.cxx:510\n"
"#32 0x00007fffa182aa1c in ScDocShell::LoadXML(SfxMedium*, com::sun::star::uno::Reference<com::sun::star::embed::XStorage> const&) (this=0x55555a783820, pLoadMedium=0x55555aa07260, xStor=empty uno::Reference) at .../libreoffice/sc/source/ui/docshell/docsh.cxx:482\n"
"#33 0x00007fffa182b423 in ScDocShell::Load(SfxMedium&) (this=0x55555a783820, rMedium=...) at .../libreoffice/sc/source/ui/docshell/docsh.cxx:629\n"
"#34 0x00007ffff5182831 in SfxObjectShell::LoadOwnFormat(SfxMedium&) (this=0x55555a783820, rMedium=...) at .../libreoffice/sfx2/source/doc/objstor.cxx:3128\n"
"#35 0x00007ffff5174ee3 in SfxObjectShell::DoLoad(SfxMedium*) (this=0x55555a783820, pMed=0x55555aa07260) at .../libreoffice/sfx2/source/doc/objstor.cxx:677\n"
"#36 0x00007ffff51c5544 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x55555a39fdc0, seqArguments=uno::Sequence of length 16 = {...}) at .../libreoffice/sfx2/source/doc/sfxbasemodel.cxx:1883\n"
"#37 0x00007ffff52f307f in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (this=0x5555587e4650, rArgs=uno::Sequence of length 13 = {...}, _rTargetFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x5555569f3330) at .../libreoffice/sfx2/source/view/frmload.cxx:681\n"
"#38 0x00007ffff5fd8854 in framework::LoadEnv::impl_loadContent() (this=0x555557039788) at .../libreoffice/framework/source/loadenv/loadenv.cxx:1163\n"
"#39 0x00007ffff5fd45c7 in framework::LoadEnv::start() (this=0x555557039788) at .../libreoffice/framework/source/loadenv/loadenv.cxx:394\n"
[..]
Change-Id: I2d61e4a29543b1d331ae63d7ec023e88395e0b68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109705
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This fixes a regression from
commit 7282014e362a1529a36c88eb308df8ed359c2cfa
Date: Fri Feb 1 15:15:16 2019 +0100
tdf#50916 Makes numbers of columns dynamic.
Change-Id: I12a780bf52024cef31188651813d3a93cc2b5ddd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109704
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This adds support to create a Graphic with only a GfxLink and the
Graphic is in a swapped-out state. This is similar to the prepared
state, but the prepared state is a special state of the Graphic.
In the future, all loading will probably be done in this way and
prepared state will go away, but for now this is only supported
for PDF and is used in PDFium import only.
The main reason is to avoid that a multi-page PDF is immediately
swapped out after loading, which just does unneeded work and
freezes the application for a while.
Change-Id: I409741d27a4ad309264cdf27b2ba03f2cf37ead9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109600
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Calling getSizePixel can force to create a bitmap for vector
graphic, only for the purpuse to get the size of the graphic in
pixels. We use this when swapping out, which is not ideal as
we would force create a replacement bitmap just before we would
get rid of it. This optimization will just copy the size in pixels
to the ImpSwapInfo structure if a bitmap exists and otherwise
leave it empty.
Change-Id: I9ccb1af4ddc63e77e2a6ca536cb4f762d0b5f182
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109599
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
VectorGraphicLoader is a set of functions that "load" a vector
graphic (starting with PDF) from a BinaryDataContainer. Usually
this only needs to create VectorGraphicData and set the correct
type, as loading will be done on-demand.
Use the VectorGraphicLoader function when swapping-in so this is
an alternative to calling LoadNative on GfxLink, which loads
into a new Graphic via. GraphicFilter, which is something we
really want to avoid.
Change-Id: If529c8ddca2b31660da4ea28d8e75bb20bf3c778
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109598
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Using BinaryDataContainer doesn't require to copy the data as it
is compatible with what is used in Graphic, VectorGraphicData and
GfxLink.
Change-Id: I01589158ae6bf6ac407bde60f07952e3968e3970
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109597
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
At least on macOS x86-64 you get a warning
> [build LNK] Library/libwpftdrawlo.dylib
> ld: warning: direct access in function 'std::__1::__shared_ptr_pointer<librevenge::RVNGInputStream*, std::__1::shared_ptr<librevenge::RVNGInputStream>::__shared_ptr_default_delete<librevenge::RVNGInputStream, librevenge::RVNGInputStream>, std::__1::allocator<librevenge::RVNGInputStream> >::__get_deleter(std::type_info const&) const' from file 'workdir/UnpackedTarball/libzmf/src/lib/.libs/libzmf-0.0.a(ZMFDocument.o)' to global weak symbol 'typeinfo for std::__1::shared_ptr<librevenge::RVNGInputStream>::__shared_ptr_default_delete<librevenge::RVNGInputStream, librevenge::RVNGInputStream>' from file 'workdir/UnpackedTarball/libcdr/src/lib/.libs/libcdr-0.1.a(CDRDocument.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
The reason is that libzmf uses -fvisibility=hidden and generates
> $ nm -m workdir/UnpackedTarball/libzmf/src/lib/.libs/libzmf-0.0.a | grep __ZTINSt3__110shared_ptrIN10librevenge15RVNGInputStreamEE27__shared_ptr_default_deleteIS2_S2_EE
> 0000000000006dd8 (__DATA,__const) weak private external __ZTINSt3__110shared_ptrIN10librevenge15RVNGInputStreamEE27__shared_ptr_default_deleteIS2_S2_EE
while libcdr erroneously does not use -fvisibility=hidden and generates
> $ nm -m workdir/UnpackedTarball/libcdr/src/lib/.libs/libcdr-0.1.a | grep __ZTINSt3__110shared_ptrIN10librevenge15RVNGInputStreamEE27__shared_ptr_default_deleteIS2_S2_EE
> 00000000000072b8 (__DATA,__const) weak external __ZTINSt3__110shared_ptrIN10librevenge15RVNGInputStreamEE27__shared_ptr_default_deleteIS2_S2_EE
The reason for that error is as follows:
workdir/UnpackedTarball/libcdr/configure.ac uses, among other things, the result
of
AX_GCC_FUNC_ATTRIBUTE([visibility])
when deciding whether to use -fvisibility=hidden. And the old ("serial 5")
workdir/UnpackedTarball/libcdr/m4/ax_gcc_func_attribute.m4 decides "no" if its
test compilation generates any warning output. But Clang on macOS generates
> conftest.cpp:34:56: warning: target does not support 'protected' visibility; using 'default' [-Wunsupported-visibility]
> int foo_pro( void ) __attribute__((visibility("protected")));
> ^
and lots of
> conftest.cpp:2:9: warning: macro is not used [-Wunused-macros]
> #define PACKAGE_NAME "libcdr"
> ^
(because of -Wunused-macros set for Clang in
solenv/gbuild/platform/com_GCC_defs.mk).
Same issue with external/libqxp, which would cause
> [LNK] Library/libwpftdrawlo.dylib
> ld: warning: direct access in function 'std::__1::__shared_ptr_pointer<librevenge::RVNGInputStream*, std::__1::shared_ptr<librevenge::RVNGInputStream>::__shared_ptr_default_delete<librevenge::RVNGInputStream, librevenge::RVNGInputStream>, std::__1::allocator<librevenge::RVNGInputStream> >::__get_deleter(std::type_info const&) const' from file 'workdir/UnpackedTarball/libcdr/src/lib/.libs/libcdr-0.1.a(CDRDocument.o)' to global weak symbol 'typeinfo for std::__1::shared_ptr<librevenge::RVNGInputStream>::__shared_ptr_default_delete<librevenge::RVNGInputStream, librevenge::RVNGInputStream>' from file 'workdir/UnpackedTarball/libqxp/src/lib/.libs/libqxp-0.0.a(QXPMacFileParser.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
<http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=commitdiff;
h=df0894ad1a8195df67a52108b931e07d708cec9a> "ax_gcc_func_attribute: Revise the
detection of unknown attributes", even though it was apparently meant to fix
something different, nicely fixes this Clang issue, making AX_GCC_FUNC_ATTRIBUTE
correctly detect support for visibility now.
When building with Clang on Linux, there is no -Wunsupported-visibility about
__attribute__((visibility("protected"))), but all the -Wunused-macros are
present as well, which caused all the AX_GCC_FUNC_ATTRIBUTE checks to be mis-
detected as "no" there, too.
There are more uses of AX_GCC_FUNC_ATTRIBUTE in
workdir/UnpackedTarball/libcdr/configure.ac and
workdir/UnpackedTarball/libqxp/configure.ac, and there are many more
workdir/UnpackedTarball/*/m4/ax_gcc_func_attribute.m4 in other external projects,
all of which may cause similar AX_GCC_FUNC_ATTRIBUTE mis-detections. However,
they do not cause any noticeable traces like the "direct access" ld warning here,
so I left those alone for now. (Ultimately, all the upstream external projects
should probably deploy the latest version of ax_gcc_func_attribute.m4 from
<http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;
f=m4/ax_gcc_func_attribute.m4>.)
Change-Id: Ia0560cace770ec7da9ee390566a01a5c592f9209
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109774
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
The presence of border padding was causing the algorithm
to reset the overall width, which in page style triggered
an even redistribution of the columns. That should only
happen when the number of columns changes, or else one of
the 5 predefined column choices is selected.
My first python unit test is included.
make UITest_writer_tests4 \
UITEST_TEST_NAME=tdf138546.tdf138546.test_tdf138546
Change-Id: I650e429568f2ab794649cc557998a809479b6e82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108210
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I4dd0c6862c6473d3cbfcc4535c2d2ebe4a0a238a
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108683
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109215
Tested-by: Jenkins
|
|
Change-Id: I4d23b4eda9ab3333eb0c062259601ba9bfb2179d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109775
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ie8d28702bbae6c76924745a5a773393f1b831012
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109706
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
|
|
Change-Id: Id6594ea397f08e1b460d8ba94cb05e674dfa2ba0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109757
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
|
|
Change-Id: I89aed7ffbe40ddda19baff569b08580f1e4f118d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109770
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|