summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2014-10-29coverity#1028106 Dereference before null checkCaolán McNamara1-16/+0
Change-Id: I77a910542cf1b7889f69a1d3b7989779d9ecc7e8
2014-10-29coverity#1242433 SdrMakeOutliner alway derefs pModCaolán McNamara15-45/+29
so change from a pointer to a reference Change-Id: I81eb2c9e4df8353fbbdad7058c6ca7ea22286e62
2014-10-29coverity#1247624 oslModule -> osl::ModuleCaolán McNamara1-15/+14
should silence warning, still actually avoid dlclose on the non-error path Change-Id: Ibc522bf1067feb04def7d7284eee59878ddc6f47
2014-10-29callcatcher: more ww1 removal falloutCaolán McNamara7-699/+1
quite pleasing Change-Id: I3eaf711e8d5a42358922c16bfc82d0e32d0bc44b
2014-10-29improve coverity#1242796 calculationCaolán McNamara1-1/+1
Change-Id: I0a462d043aaa67863d5f1906451e66d01b634a8f
2014-10-29coverity#735609 Division or modulo by zeroCaolán McNamara1-0/+2
Change-Id: Iaa765c4ed0aa7bb11e74c1c2be48b336158249cc
2014-10-29coverity#1078542 Division or modulo by zeroCaolán McNamara1-3/+8
Change-Id: I3325328c01b23d43c774db4af080df535f47787b
2014-10-29coverity#1078539 Division or modulo by zeroCaolán McNamara1-0/+3
Change-Id: Ifbe3cbd8fa93ee828ed95c19893c52b8134d3fd1
2014-10-29coverity#735611 Division or modulo by float zeroCaolán McNamara1-3/+5
and coverity#735612 Division or modulo by float zero Change-Id: I805d59a88a6a9fea11a4cb9890a50f0b649a7ad3
2014-10-29Don't use output rArea when TableLayouter::getCellArea returns falseStephan Bergmann1-9/+10
...when xCell->isMerged, as happens during CppunitTest_sd_filters_test. aCellArea will be "empty" (i.e., getMinX()==SAL_MAX_INT32 etc.) and the aCellRect.Move calculation will overflow for 32-bit long. Change-Id: I12649234c060edd9f2cab1792cf75335ae22b730
2014-10-29fix spellingNoel Grandin1-1/+1
Change-Id: I08a5fb662a4a5d756b72340cb9328fc1dc1fe9fe
2014-10-29ref-counting vcl::Window subclassesNoel Grandin28-81/+93
Points of discussion -------------------- (*) where in the Window destructor should dispose() be called? It's a seriously large method. (*) we're going to need similar typedefs and declarations for every single sub-class of vcl::Window, I assume that I will need to create a macro to make it less verbose. TODO ---- Update clang plugin to verify that: (a) dispose() methods always call their superclass dispose() (b) dispose() methods don't forget to clear any references owned by that class. Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
2014-10-29sw: convert last usage of switchHeaderFooter() to DocxTableExportContextMiklos Vajna1-2/+3
Change-Id: I47c5c60b0ffef3923c1d2830de992e1a67eb76ff
2014-10-29cid#1242749 Unused valueNoel Grandin1-5/+1
Change-Id: I3227a05a4cafdcca23c32a62fdb72245cdf493d6
2014-10-29OXYGEN: Refreshing icons from main source and added a few new onesYousuf Philips31-0/+0
Change-Id: I7c5ca8cb9533a1df07a86909a6993bc36eda5253 Reviewed-on: https://gerrit.libreoffice.org/12129 Reviewed-by: Matthew Francis <mjay.francis@gmail.com> Tested-by: Matthew Francis <mjay.francis@gmail.com>
2014-10-28colorwindow: try to fix initial layoutMaxim Monastirsky2-12/+13
Change-Id: Ic69bbcd877d248afd0f23a867d4c57d801479b74
2014-10-28colorwindow: Use exactly one row of recent colorsMaxim Monastirsky3-8/+4
Right now one row of SvxColorValueSet is 12 colors. Change-Id: I9be6e8487d5325866e17f578b7abb08f7c338fb1
2014-10-28colorwindow: Update recent colors list immediatelyMaxim Monastirsky1-3/+7
Change-Id: Ieb6277f0962f88dfa55b6af80535ec8af497433e
2014-10-28colorwindow: Unify SelectHdl and SelectRecentHdlMaxim Monastirsky2-24/+7
Change-Id: I680517bc7d91ef15593d235a7ff72588c7513b15
2014-10-28Rename loadColorVector to addEntriesForColorVectorMaxim Monastirsky3-3/+3
So it will be similar to addEntriesForXColorList Change-Id: Ie352e0cf05fa6875ed76e69478131a57293b39a1
2014-10-28Windows build fix.Kohei Yoshida1-1/+0
Change-Id: Ia118c81e39f5f48d4678cc375bad45f31ba8322e
2014-10-28WaE: C4101: 'unused' : unreferenced local variableTor Lillqvist1-1/+1
Change-Id: I511c2df37c7feda8a3ffa311074bcf2fe669a73a
2014-10-28fix build on android-arm tinderboxDavid Tardon1-2/+2
Change-Id: If528f3cbaab66ceec07e35b479b4fe2ed55aa3c7
2014-10-28fdo#81356: use boost::rational internally in FractionJuan Picca3-317/+231
Change-Id: I6f40eafee7652209395bd471e3508fe3a3d19d73 Reviewed-on: https://gerrit.libreoffice.org/12085 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-28Move these headers from include to svx; they are not used outside svx.Kohei Yoshida33-47/+39
Change-Id: I8685b451a39e890250a3309ddb70346bac4084b2
2014-10-28Fix -fsanitize=signed-integer-overflow (when long int is 32-bit)Stephan Bergmann1-2/+2
Change-Id: Ia6f1b60108784660c4a2dfd311592207e6bf5d88
2014-10-28external/icu: workaround -fsanitize=signed-integer-overflow warningsStephan Bergmann1-0/+11
Change-Id: I7d8e3be80f04ec0a9d1dbd394ac0e2ab2f1a4551
2014-10-28cui: clean up gradient parts of the background tab pageMiklos Vajna1-77/+0
I forgot to clean this up when cherry-picking 6e61ecd09679a66060f932835622821d39e92f01 (Merge back branch alg_writerframes to trunk, 2014-03-19). Change-Id: I531dea63d3b62d16f11d414758012432bb4b2503
2014-10-28coverity#1242844 Untrusted loop boundᚉᚐᚑᚂᚐᚅ McNamara1-1/+4
Change-Id: I64a805503d0c044b5c5a80df1513e35df5c39171
2014-10-28lastAnchorPos got renamed to mpLastAnchorPosCaolán McNamara1-1/+1
Change-Id: Icfb055123e049cdc16a5825e4be4f18a42d6cb7f
2014-10-28coverity#1242796 Untrusted loop boundᚉᚐᚑᚂᚐᚅ McNamara1-1/+9
and throw ogham at the bugzilla bot for kicks Change-Id: I50cdf676e59e4e966f999218837dabfdd2008b6e
2014-10-28fdo#84692 SwXAutoStyleFamily::insertStyle: don't throw on unknown propertyMiklos Vajna2-2/+2
Regression from commit 7d9bb549d498d6beed2c4050c402d09643febdfa (Related: #i124638# Second step of DrawingLayer FillAttributes..., 2014-06-02), the problem was that the new branch (used for paragraphs) in the method does not tolerate unknown properties (it throws), while the behavior was just a warning. Adapt the new branch to the old behavior, so that the document can be opened again. Change-Id: I5d849987602fb8aa0cbbda92ce07c050067473b3
2014-10-28fdo#37960 fix shift+click to select multiple drawingsAndras Timar1-2/+0
I simply didn't get the logic behind calling GotoNextFly(). It caused not only this bug. For example Ctrl+click on a background text frame did not select the text frame, but an image on the previous page. Change-Id: I85ccbbda2f324de55417d6199b4abe79e59bf295
2014-10-28fix a big pile of the crash tester .doc import failuresCaolán McNamara1-2/+4
wrt the blasted SwIndexReg dtor assert Change-Id: I4b3eeab76d5d76f7b769b458baeadbc0a9bd4238
2014-10-28SwXTextPortionEnumeration ctor: avoid dynamic_cast in the common caseMiklos Vajna1-2/+2
For a document of 1000 pages and with 1000 bookmarks, this brings a considerable speedup on ODF export: before: real 3m28.187s after: real 2m51.565s Change-Id: Ic3f85c727a8ea4b5012d5c3f0a5887ff47762fb8
2014-10-28Resolves: fdo#85081 terminate if can't load kde addressbookCaolán McNamara1-6/+20
Change-Id: I3b1b78127d7d4080a23c0ac9f7d37706197de62c
2014-10-28coverity#982593 experiment with silencing Infinite loopCaolán McNamara4-0/+9
etc. Change-Id: I1548d60280ab4f74fe023d026435a05f7865b516
2014-10-28coverity#735332 Unchecked return valueCaolán McNamara1-1/+1
the !isAfterLast should be sufficient Change-Id: Iab45b70c24ae1f90c38178d261e467d9b1e3fa6c
2014-10-28coverity#1157745 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: I06e8e946063dc54335f3b672105d5cd0b3ff71a4
2014-10-28coverity#1078486 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: I762796b848aa8d8dd35b401e03bf40af18fb8e72
2014-10-28coverity#1078448 Unchecked return valueCaolán McNamara1-1/+3
Change-Id: Icbdd0b6b19a91a3339c8635c112729b46232069e
2014-10-28coverity#735309 Unchecked return valueCaolán McNamara1-2/+2
Change-Id: I15cbfb15054962998a058da1381a84bb667944ef
2014-10-28coverity#735305 Unchecked return valueCaolán McNamara1-5/+5
Change-Id: I0f03b67a5df3427e78f70f2b86aba26024ea575f
2014-10-28coverity#704090 Unchecked return valueCaolán McNamara1-1/+1
going to assume that this is correct Change-Id: I47072dc668f200eacf0f6a6d7ccdad0c9d6bfa68
2014-10-28coverity#704089 Unchecked return valueCaolán McNamara1-15/+14
rework code a little to help coverity out Change-Id: I4aa253a579153ad389d4667a9676fff04aa00a34
2014-10-28coverity#704086 Unchecked return valueCaolán McNamara1-1/+1
following check is sufficient Change-Id: Ibcf53293c8e862ab823ed422d1a7a59dcc0977cf
2014-10-28coverity#704085 Unchecked return valueCaolán McNamara1-1/+1
other patterns aren't really the same as this one Change-Id: Ie26fd5c01d156004f755017a859679e904a29520
2014-10-28coverity#704072 Unchecked return valueCaolán McNamara1-29/+31
Change-Id: I3bd198fc21bb414a0b80e8234e22782e24e0477e
2014-10-28coverity#704067 Unchecked return valueCaolán McNamara1-4/+8
and coverity#704068 Unchecked return value those are ok I think Change-Id: I7869c3f4200792d4bafafdff49735e8563d2e822
2014-10-28coverity#704066 Unchecked return valueCaolán McNamara1-1/+1
that's ok I think Change-Id: Ie8dd3b938a058d771791471833fde4ef4ceef252