summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-02-13tdf#119138 Show custom chart title if autoTitleDeleted is missingGabor Kelemen3-1/+17
autoTitleDeleted might be omitted by generators other than Excel while providing custom title. mbAutoTitleDel is set only based on the attribute value and the default also varies on whether MSO 2007 or newer is the generator, see tdf#78080 ECMA-376 Part 1 at 21.2.2.7 says: A value of 1 or true specifies that the property is applied. This is the default value for this attribute, and is implied when the parent element is present, but this attribute is omitted. Change-Id: If3457fe850e13ae8af207bb9beceecc9e887b797 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88151 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-13tdf#130623 host gtk FieldControl within the design viewCaolán McNamara2-3/+17
to make this work in master Change-Id: I96a4e7fc0993fbdcf28e2ccad17573b93f4f99dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88570 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#130623 owner of FieldControl needs to set its allocationCaolán McNamara2-1/+30
which works fine automatically when its in a dialog (copy table) but not automatically when hosted inside the design view this will make the gen case work in master, and the gen and gtk case work in 6-4 Change-Id: I530cfa0a7e1f5b62c6812ffde255c1edf478930d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88569 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13Resolves: tdf#130593 set correct range for spinbuttonCaolán McNamara1-2/+2
Change-Id: I6691f2709aa4053798fcc1744f9f41c3c3866a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88554 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13inherit MediaControl from InterimItemWindowCaolán McNamara5-47/+13
to de-dup some code Change-Id: I8bf20d4b57f3ec7bd2902f01e11278da8ded194b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88550 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13remove unneeded includes and update pchCaolán McNamara3-6/+7
Change-Id: I6b38e96e6eb509e9d1ea0acaf30cb2a542bdbc2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#130161 detect if a node already had an expansion attemptCaolán McNamara4-23/+50
and so isn't in child-on-demand mode anymore, in which case in basctl new module/dialog children should be appended to it similarly to how they are added if had been expanded in the earlier attempt Change-Id: I75255fb743852c70e194bbf4828cd90b9112db79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#130161 adding a document dialog or modules doesn't update catalogCaolán McNamara1-4/+7
in basctl UI, seems to be since... commit 44861f2435a0c487d4fb5b196f7e4fe7f9569396 Date: Fri Aug 17 07:29:20 2012 +0200 Object Catalog in Dialog Editor if it even really worked before that changed UpdateObjectCatalog to only get called for non-document changes Change-Id: I77a94bb4859cc399e86d75fdf2c9ca7c50288b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88543 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#95495 DOCX import: fix inherited list level of custom stylesSzabolcs Toth3-10/+44
in DOCX export of MSO 2003, 2007 and 2010, where ilvl and outlinelvl settings are missing, based on the settings of the parent styles. Change-Id: I01d239db505d46a89d7f3b9118ef0b55697bc7fc CO-Author: Balázs Nádasdy (NISZ) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87328 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-13Hack to dynamically adapt to __cxa_exceptiom in LLVM 11 libcxxabiStephan Bergmann2-1/+46
(where the new change to __cxa_exception effectively reverts the change that prompted 7a9dd3d482deeeb3ed1d50074e56adbd3f928296 "Hack to dynamically adapt to __cxa_exceptiom in LLVM 5.0 libcxxabi") Change-Id: Iec4ef1dc188bea2223d99b1b7eb8adec636c98e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88583 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-13find-unneeded-includes: silence broken o3tl::optional -> std::optional proposalMiklos Vajna1-1/+4
This is just a workaround, see the upstream bugreport for the details. Change-Id: I2334fb3ad86db7f43bd49c694eea3c240316bfa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88566 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-13aImmediateMacro is unusedStephan Bergmann1-2/+0
...ever since fdc50b0a1b9741c5610a2b6c793c8fcdf5573c76 "new loplugin:returnconstant" Change-Id: Ib7f8760a95112aa31e1dd2ae15229c42e5fee812 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88547 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-02-13tdf#57307 - Expand word boundaries to include connector punctuationsAndreas Heinisch1-6/+3
Include connector punctuations when adding a variable to the watch window using "Enable Watch (F7)" in order to add the correct variable name. Change-Id: Idaf7699dde3f4147d603c6aea4b2381e2af497a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88575 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-13mobile: Center inserted shapes on visible areaMuhammet Kara1-0/+12
Change-Id: I366ef5d01ee3afb072b1f67d24015c889a41f4b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88488 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12tdf#130614: Revert "tdf#125520 Fix OLE objects drag&drop with 'Insert as Copy'"Xisco Faulí1-11/+2
This reverts commit e4cea049c80f4fd6d2a586e73fe9fa08ebd08371. Change-Id: Ic925cb5660df152208cdc63bfee62d82fe912717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88493 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-12tdf#130610 docx export: handle bold as toggle propertiesSerge Krot4-0/+96
Change-Id: I4c60b7eab6430a64ea1c8bcf40d0036d0b38516f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88460 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-02-12DOCX import: fix ZOrder of inline vs anchored shapesMiklos Vajna8-11/+33
Shapes which are anchored but are not in the background should be always on top of as-char anchored shapes in OOXML terms. Writer supports a custom ZOrder even for as-char shapes, so make sure that they are always behind anchored shapes. To avoid unnecessary work, make sure that when there are multiple inline shapes, we don't pointlessly reorder them (the old vs new style of the sorting controls exactly this, what happens when two shapes have the same ZOrder, and all inline shapes have a 0 ZOrder). Adapt a few tests that used ZOrder indexes to access shapes, but the intention was to just refer to a shape: fix the index and migrate to shape names where possible. Change-Id: I670e4dc2acbd2a0c6d47fe964cb5e3f2300e6848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88540 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-12Classify shape(s) selections as 'complex'...Dennis Francis1-0/+3
in isComplex() of XTransferable2 implementation SwTransferable. This method is used by online via doc_getSelectionType() to determine the type of selection. In writer this method used to classify shape objects as non-complex which translates to 'text' in online, so if a shape is selected in online, the js code there would treat it as text. This is problematic when you want to send the correct align uno commands based on selection type. So returning true in isComplex() for writer would correctly treat the shape selections as 'complex' in online Writer. Change-Id: I09fcd9e4fab48aa0d7e7d04c88bae9e1281a1b0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88158 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit c7178a12e6e57e3d85cecd09e9c0373ececbb33f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88495 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12vcl: avoid accessing null member on unloading viewsAshod Nakashian1-2/+3
Change-Id: If4e416c7257c861b9e13352b3329d9719b159e61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87830 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88538 Tested-by: Jenkins
2020-02-12Fix typoAndrea Gelmini1-1/+1
Change-Id: I2b0fe68cf5346a6788bbd63242eadf872d58a87e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88556 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-12drop newly unused TreeListBoxCaolán McNamara5-1057/+2
Change-Id: Iea157bb472ee409a1a15b9f6c9cfe0adc21d1a03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88449 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12weld ObjectCatalogCaolán McNamara7-79/+122
Change-Id: I1979c6f8f5705360aa0df8cb7aeaeca00cd66ce9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12crashtesting: convert assert to SAL_WARN_IFNoel Grandin1-1/+1
Change-Id: I70a9922960dee978be05218ebf16a8186c3bc0c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88524 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12Add case table for MedefaidrinAlex Henrie1-0/+43
Change-Id: I7325311a4a0957b1a43c36d04cbefde2ea7461eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88420 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-02-12only freeze/thaw if we have toCaolán McNamara3-2/+22
because gtk will relayout and things jump around confusingly and unnecessarily Change-Id: I817e803f8ad7e523e5855326fc097f8798ddb679 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88526 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12add some more libs to libmergedNoel Grandin1-0/+9
Change-Id: I2d3c3d64f1fb1d3635bdde761f6502ba05221f95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88522 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-12we always want to expand/collapse on double clickCaolán McNamara1-5/+5
Change-Id: Idf5496b44f5e2d5782d99317029aa0e9cb99e8d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88527 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12cypress: mobile: Font size combobox is broken on core/master.Caolán McNamara9-22/+45
a) for vcl version, listen to modify and select, instead of just modify so we can get the artificial select via uiobject that the mobile makes use of. (and disregard the modify which we know will lead to select so we get just one event in that case) b) default to assuming something has been picked "directly" unless we know otherwise. ideally the result is that https://cgit.freedesktop.org/libreoffice/online/commit/?id=08d6c3fdf9bac4ad8318151ab1402690eb950f52 isn't needed Change-Id: Ibbf33eab88dabd55d0c329aa00c8adaf001a4f50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88476 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12Blind fix for Linux aarch64 with libcxxabiStephan Bergmann1-2/+2
...after untested a7d1fed24557b203acb5016a98af26f4ef24d27a "Hack to dynamically adapt to __cxa_exceptiom in LLVM 5.0 libcxxabi" had been submitted Change-Id: I68694645825ddebb249a90d9af9b8ba04c0bdbb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88519 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-12crashtesting: remove assert in SvXMLImportContext::SvXMLImportContextNoel Grandin1-1/+0
which came from commit 813118bfbb453f812be9e1a30f84908b4e0bfb51 Date: Fri Dec 20 14:34:56 2019 +0200 add checks to optional fields in SvXMLImportContext but it turns out various places abuse this field and pass stuff that is not a element name, including empty strings Change-Id: I33cfc7e44e0aafe0fdb084482a199d5cffde6a76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88523 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-12lok: add "type" information when a graphic is selectedHenry Castro1-3/+4
Change-Id: I67a36d3aabbc197d9ac8f6ca4509dafd6f2620f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87991 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12android: Don't show the multiline toggle in the formula input bar on phones.Jan Holesovsky1-2/+6
The interaction there currently distorts the view and occupies too much space anyway. Change-Id: I093432dcfc223e4ea8b0f5a3cc45368f90c3cc0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88477 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88481 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12Get the align states of draw-shapes in...Dennis Francis1-9/+44
SwDrawBaseShell::GetState() so that the align buttons are informed (in core desktop and online via statechange messages) Change-Id: Ic69fb03bc98f39b1a6a389d50d3d6404fefd7f29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88159 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88453 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12Allow boolean valued statechange messages for...Dennis Francis4-8/+37
object align commands : ObjectAlignLeft [SID_OBJECT_ALIGN_LEFT] ObjectAlignRight [SID_OBJECT_ALIGN_RIGHT] AlignCenter [SID_OBJECT_ALIGN_CENTER] What is pending is to set correct align state items for Impress in DrawViewShell::GetMenuStateSel(). For doing that we need to store the object align state somewhere when we execute SID_OBJECT_ALIGN_* in DrawViewShell::FuTemporary(). For Writer the align state information was already available in frame-format-manager object. Change-Id: I86fcf59cfc66af98097611277201ecaa3b8c22cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88077 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88452 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12tdf#129575 DOCX import: fix table style preferenceLászló Németh17-45/+203
handling by recognizing docDefault properties instead of default-value based heuristics. Change-Id: I3bab9d85d77d0e5f1c357121b1caf02cbe4899c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88457 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-12move some svx/ headers inside the moduleNoel Grandin170-372/+265
Change-Id: I8d9a50039a8139caebb2cfb83ca476d39432f255 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88238 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-12ofz#20455 sw: add some checks in SwTable::CheckConsistency()Michael Stahl1-1/+8
Check consistency of number of boxes in SwTable and nodes. Change-Id: I617f99282b900b17a65ecd18fdd8e8f8860896db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88471 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-12ofz#20455 sw: HTML import: fix invalid table in footerCaolán McNamara6-8/+21
The obvious problem was that a bookmark failed to be copied to the correct node, it was created on a SwStartNode, which failed in makeMark() and caused a null-pointer. The target position was off by 1 node because there was a spurious StartNode/EndNode pair directly below the table: [ 41] 0x5b13430 TableNode , [ 42] 0x5b1d010 StartNode , [ 43] 0x5b12a50 StartNode , [ 44] 0x5b135f0 TextNode "", This was created by a special case in SwTableNode::MakeCopy() because .GetTabSortBoxes().size() == 1. But the table had actually quite a bunch more cells in the nodes-array, just they were not yet in the SwTable. In an exciting twist of events, it turns out the table was copied while it was not yet finished parsing: the problem was that in the middle of the table, some CSS set some page attributes, and this caused a first-page page style to be created in SwCSS1Parser::ParseStyleSheet(), by copying the master page style. Unfortunately the table was in the <div title="footer">, so it was copied in this incomplete and inconsistent state. It might be possible to get rid of the special case in SwTableNode::MakeCopy() by restricting the special case skipping of StartNodes at the start in SwNodes::CopyNodes() a bit so that StartNodes whose EndNodes are copied aren't skipped; at least that's the most reasonable explanation for the special case. But for now just fix the HTML import. Additionally, only on MacOSX, using libc++, this triggered an assert: Assertion failed: (!pImpl->mpStaticDefaults || typeid(rItem) == typeid(GetDefaultItem(nWhich))), function PutImpl, file /Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/svl/source/items/itempool.cxx, line 611. Probably because SdrTextAniCountItem is not marked DLLPUBLIC. Change-Id: Ia167265e7540eea649801eaac2b89f9e18b685cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87859 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-12Revert "tdf#118947 sw tablestyle: manually scan parents for ::SET"László Németh3-113/+23
Except its unit test. This reverts commit 6bced3c6a1bf8d4652dd6ba75e41b128ce1bfc5c. Change-Id: I525edd59b9d4d522048b272575285f13675413e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88456 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-12Revert "related tdf#118947 sw tablestyle: no need to avoid numbered para"László Németh1-1/+2
This reverts commit 6ed87cc5a4f755f360951550cac836e8967fc6bf. Change-Id: Idd56da3056b60a60228875c644d57099b3d2520f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88455 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-12Revert "revert obsolete writerfilter hacks for tdf#119054 and tdf#128752"László Németh4-0/+58
This reverts commit 749fd6508504cf3b2e3822eca52a67fa36d75fb8. Change-Id: Iad4cd836e2908e2c21e70013f88af213b3a1822d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88142 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-12add some more libs to libmergedNoel Grandin1-0/+5
Change-Id: I14ec1c6015c8a71fabca90ca3dec52965915a63f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88511 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-12move some canvas/ headers inside the moduleNoel Grandin87-226/+208
Change-Id: Iaa00cff88ad756b7e084cc68fe744d387328180b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88360 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-12If asked to do so, enable icecream even in the 'build' part of configure.Jan Holesovsky1-0/+1
Otherwise it is used only in the 'host' part of the cross-compile build. Change-Id: Ifb8d88e18c131e3019a4f3168afc1b743f3cc8e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88486 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12Store and retrieve client visible area on ScViewDataMuhammet Kara2-0/+8
So that core will be aware of the visible area on the client side, and act accordingly when needed. Change-Id: Ieca9b23deb36f3e713704304672dd7037154e904 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88487 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
2020-02-12lok: Add LOK_CALLBACK_STATE_CHANGED for uno:OrientationMuhammet Kara2-1/+16
Change-Id: Iab3aaf742bdb9fc4b9c5875fee7d769fa0581eeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87370 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88451 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12solenv: remove no longer needed OptionalBox widget factoryMiklos Vajna1-1/+0
Not needed since commit 2d0944ab7a94ea0d5cd5f66c4895a0c99d9a3593 (Resolves: tdf#130513 sfxlo-OptionalBox isn't in sfx, 2020-02-08). Fixes this Android build error: /tmp/native-code-7aaa80.o:native-code.cxx:custom_widgets: error: undefined reference to 'makeOptionalBox' Change-Id: Ib03c9516963e6b14c57ecfca9c7f78132dea2059 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88514 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12Drop macOS SDK 10.12 baselineMike Kaganski1-5/+2
...which appears to no longer work due to incompatible changes incorporated in LO code already. sberg says: "The first issue I encountered when building against the 10.12 SDK is 'fpicker/source/aqua/ControlHelper.hxx:119:78: error: use of undeclared identifier 'NSControlStateValueOn''." Change-Id: Ib762dd8eaa355925b9a81fb41b550c49bfcf53da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86216 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins
2020-02-12clang-analyzer-deadcode.DeadStoresNoel Grandin56-205/+86
Change-Id: Ifa384933569b27d0d08eb479bb95b799163ae386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88450 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-12tdf#130440: Add UItestXisco Fauli1-0/+45
Change-Id: I7621e0576dedcc759f44e9662a3926d238d952d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88437 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 00:45:50 +0000