summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-07-17remove the GL based 3D chartsMarkus Mohrhard132-11664/+13
Change-Id: Ia578c71ae70aa0a85b49fa50138edf90f961b1e9 Reviewed-on: https://gerrit.libreoffice.org/57533 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-16Update git submodulesCaolán McNamara1-0/+0
* Update helpcontent2 from branch 'master' - reword Block any links from untrusted documents documentation Change-Id: I7f509ca500d859e4332fdc94f9a265fa34a64fcb Reviewed-on: https://gerrit.libreoffice.org/57509 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16tdf#113646, export font size for dxf recordsMarkus Mohrhard1-0/+7
Change-Id: I6dd6b0ef858fd933603be4435f7810c739b72ef0 Reviewed-on: https://gerrit.libreoffice.org/57471 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-16tdf#69460, tdf#118416: Don't copy whole columns to the clipboardTor Lillqvist1-19/+47
...for the BITMAP or PNG formats either. Change-Id: Ib1739ceb917fe24dac412007fd6522e40f5517c4 Reviewed-on: https://gerrit.libreoffice.org/56577 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-16uitest for bug tdf#102525Zdeněk Crhonek4-0/+64
Change-Id: Idb3810d99ebbd33bf0961f362694d0f4961fb912 Reviewed-on: https://gerrit.libreoffice.org/57463 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-16tdf#118681 make sure we're using the right font char mapCaolán McNamara5-13/+13
Change-Id: I64265dac5d0d18b092d64ef656997d7177a425a4 Reviewed-on: https://gerrit.libreoffice.org/57504 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16Remove obsolete (cargo-cult copied) dependenciesJens Carl1-29/+1
Change-Id: Iab52f84d7a9fbe8ad460ef09190452b053c5c661 Reviewed-on: https://gerrit.libreoffice.org/57476 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-16tdf#118635 relative checkbox disabled on reopenCaolán McNamara1-7/+7
Change-Id: Ic52737e5122b1ae37390061a5f7cf17b69e7e665 Reviewed-on: https://gerrit.libreoffice.org/57498 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16Upgrade to ICU 62.1Eike Rathke8-34/+77
Change-Id: I9426e77aa85cfe068df59db47b8ac50b59cd4eb3 Reviewed-on: https://gerrit.libreoffice.org/57500 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-16tdf#118549 crash on dialog teardownCaolán McNamara1-0/+2
only an issue for the current partially complete interim case Change-Id: Iaf1ef4dabca1cdd5d2d90028edf5793cf45feb20 Reviewed-on: https://gerrit.libreoffice.org/57501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16try to make the windows tinderboxes happierNoel Grandin2-1/+5
at the moment about 1 in 10 builds fail Change-Id: I29ada5555170bf7c3f603b684ab4dc7b1932c44c Reviewed-on: https://gerrit.libreoffice.org/57491 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16convert SW*READER constants to scoped enumNoel Grandin10-23/+30
Change-Id: I7cf635e238a16e7ec96e585e6eb5e2e9c39b545a Reviewed-on: https://gerrit.libreoffice.org/57497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:useuniqueptr in SwXTextSearchNoel Grandin2-4/+5
Change-Id: I30fcea4f03b29dfcd434f4544d5c52dc7ca9d4a9 Reviewed-on: https://gerrit.libreoffice.org/57422 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16tdf#118769 parent of modal dialog not setCaolán McNamara1-1/+1
Change-Id: Ie3b1a626eb0ca4f39e015a18fede935b36ed194e Reviewed-on: https://gerrit.libreoffice.org/57492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16coverity#1401328 Uncaught exceptionCaolán McNamara2-3/+4
Change-Id: I08c91c9c84d53f567332e5780b14173b8c8e5fb1 Reviewed-on: https://gerrit.libreoffice.org/57462 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16loplugin:mergeclasses update results outputNoel Grandin1-18/+26
Change-Id: Id1138cf7358c610aff77b7d7073c61cd3f13129c Reviewed-on: https://gerrit.libreoffice.org/57485 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16move freeze/thaw to WidgetCaolán McNamara3-30/+27
Change-Id: I3944092c26ca81028912f6fb206b148b49e4f172 Reviewed-on: https://gerrit.libreoffice.org/57489 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16loplugin:useuniqueptr in SwUndoDrawDeleteNoel Grandin2-4/+3
Change-Id: I7d7e89a9ffa67141e459772791caae2937458b8f Reviewed-on: https://gerrit.libreoffice.org/57425 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:mergeclasses merge ResourceManager into SlideSorterModuleNoel Grandin6-346/+211
Change-Id: If78dc81e41180e7449b389e36223ee78d6ac91ec Reviewed-on: https://gerrit.libreoffice.org/57486 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:mergeclasses merge BPixelRaster into BZPixelRasterNoel Grandin5-100/+43
Change-Id: Ib6f7bfd2392daa5512d5fa68b69428ae9c8876f9 Reviewed-on: https://gerrit.libreoffice.org/57488 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16forcepoint#50 refetch FirstNonHeadlineRowCaolán McNamara2-13/+7
Invalid read of size 8 at 0x43D42DE6: SwFrame::GetUpper() const (frame.hxx:664) by 0x44427435: SwRowFrame::ShouldRowKeepWithNext() const (tabfrm.cxx:4618) by 0x4441FA5C: SwTabFrame::MakeAll(OutputDevice*) (tabfrm.cxx:2403) by 0x4433492F: SwFrame::PrepareMake(OutputDevice*) (calcmove.cxx:343) by 0x44431B6F: SwFrame::Calc(OutputDevice*) const (trvlfrm.cxx:1799) by 0x44334430: SwFrame::PrepareMake(OutputDevice*) (calcmove.cxx:246) by 0x44431B6F: SwFrame::Calc(OutputDevice*) const (trvlfrm.cxx:1799) by 0x44334430: SwFrame::PrepareMake(OutputDevice*) (calcmove.cxx:246) by 0x44431B6F: SwFrame::Calc(OutputDevice*) const (trvlfrm.cxx:1799) by 0x44334A67: SwFrame::OptPrepareMake() (calcmove.cxx:354) by 0x443982CE: SwFrame::OptCalc() const (frame.hxx:1051) by 0x44395F18: SwLayAction::FormatContent_(SwContentFrame const*, SwPageFrame const*) (layact.cxx:1794) Address 0x352771b0 is 144 bytes inside a block of size 280 free'd at 0x4C2EDAC: free (vg_replace_malloc.c:530) by 0x4E5B9D7: rtl_freeMemory_SYSTEM(void*) (alloc_global.cxx:237) by 0x4E5BC93: rtl_freeMemory (alloc_global.cxx:303) by 0x4E5A7A2: rtl_cache_free (alloc_cache.cxx:1081) by 0xF28B5B9: FixedMemPool::Free(void*) (mempool.cxx:49) by 0x442FF36D: SwRowFrame::operator delete(void*, unsigned long) (rowfrm.hxx:123) by 0x444243E8: SwRowFrame::~SwRowFrame() (tabfrm.cxx:3702) by 0x4441630C: SwFrame::DestroyFrame(SwFrame*) (ssfrm.cxx:384) by 0x4441AC31: SwTabFrame::RemoveFollowFlowLine() (tabfrm.cxx:900) by 0x4441D7EB: SwTabFrame::MakeAll(OutputDevice*) (tabfrm.cxx:1836) by 0x4433492F: SwFrame::PrepareMake(OutputDevice*) (calcmove.cxx:343) by 0x44431B6F: SwFrame::Calc(OutputDevice*) const (trvlfrm.cxx:1799) Change-Id: I36fe0df0ef96b4019e0ca5756b06df72e9f0d8cb Reviewed-on: https://gerrit.libreoffice.org/57480 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16Add missing sal/log.hxx headersGabor Kelemen122-0/+125
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from connectivity to cui Change-Id: I9903c10d0a04bbeb93d0f776d1d252b152459499 Reviewed-on: https://gerrit.libreoffice.org/57408 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-16sw: prefix members of SwDateTimeField and SwFormatDropMiklos Vajna4-73/+73
Change-Id: I8824da58ccbbe3cd377e8f258941676598145062 Reviewed-on: https://gerrit.libreoffice.org/57477 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-16oox: refactor CommonBehaviorContext to inherit from FragmentHandler2.Mark Hung2-3/+5
Although it's convenient to inherit from TimeNodeContext, but only mpNode is used so it's really not necessary. Change-Id: I922774df4c420ee9982f1c31e720f4fd85991e02 Reviewed-on: https://gerrit.libreoffice.org/57395 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-16oox: enum MS_AttributeNames -> enum class AnimationAttributeEnumMark Hung4-53/+53
It's the attribute enum for the target animation. Remove MS_ prefix since it is in oox::ppt namespace and prepend Animation to make the purpose more clear. Change-Id: I0b6bbaf30ae4e2cf1cb0f6d5d24ba9f31e0b0773 Reviewed-on: https://gerrit.libreoffice.org/57353 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-16cppcheck: useInitializationList in vclJochen Nitschke11-82/+69
reorder members of GIFLZWDecompressor to ease initialization. use rtl_allocateZeroMemory in ImplVectMap to avoid memset in ctor. Change-Id: Icfcfe73ec7e52988036995d8dbc604361aee893b Reviewed-on: https://gerrit.libreoffice.org/57481 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-07-16coverity#1437962 and 1437961 and 1437955 and 1437951 resource leakNoel Grandin2-8/+8
regression from commit 0fb5ca6cc9cc55a4436a36c533461769b1fc8526 tdf#79877 perf loading docx file, writerfilter/ improvements Change-Id: I76792bd635eacc60647a097e070ce7b963fd122f Reviewed-on: https://gerrit.libreoffice.org/57478 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16coverity#1437959 Copy into fixed size bufferCaolán McNamara1-6/+5
Change-Id: I5578e195c834b2a3ceacd5c528f58d1d03502c2e Reviewed-on: https://gerrit.libreoffice.org/57461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16loplugin:useuniqueptr in SwUndoSortNoel Grandin2-7/+7
Change-Id: I9e524c9c653fd4b1f61e407eee12ca3a7fdc14df Reviewed-on: https://gerrit.libreoffice.org/57420 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16return BaseProcessor2D by std::unique_ptrNoel Grandin11-35/+29
Change-Id: Ibad6e989d2d7ba779e7557e41552d06c076f657b Reviewed-on: https://gerrit.libreoffice.org/57448 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16SvPersistBase no longer necessaryNoel Grandin13-121/+42
Change-Id: I928c0898d77d30bd6ca755d07acac6f78b20563b Reviewed-on: https://gerrit.libreoffice.org/57436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:useuniqueptr in SwHistoryNoel Grandin2-61/+52
Change-Id: Ie36cdf1e7b3d09ae27cb2a5b51f8a644693fe2b3 Reviewed-on: https://gerrit.libreoffice.org/57424 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:useuniqueptr in SwSdrUndoNoel Grandin2-9/+7
Change-Id: I67276f2cd13cce8a7cb047216ead40c5afc384bd Reviewed-on: https://gerrit.libreoffice.org/57423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:useuniqueptr in UndoTransliterate_DataNoel Grandin2-10/+12
Change-Id: I1c6e865a6f59ce7f31c42d28b2b463a577b3cc28 Reviewed-on: https://gerrit.libreoffice.org/57421 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:useuniqueptr in SwUndoInsertsNoel Grandin2-8/+7
Change-Id: I678798048b5ff5fc917fd2c37180d977a2a1d606 Reviewed-on: https://gerrit.libreoffice.org/57419 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:useuniqueptr in SwUndoCompDocNoel Grandin2-18/+15
Change-Id: I3a74f017b2b82476034f1c92a509c1d5bb20de35 Reviewed-on: https://gerrit.libreoffice.org/57418 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:useuniqueptr in SwUndoRedlineNoel Grandin2-8/+7
Change-Id: I158cfb0774b5991197816725aef7c74b7e1f00da Reviewed-on: https://gerrit.libreoffice.org/57417 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:useuniqueptr in SwUndoInsNumNoel Grandin2-7/+7
Change-Id: I1bdf4b0ac9ccbb6fb618f7c44a15caf01bd321b4 Reviewed-on: https://gerrit.libreoffice.org/57416 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16Remove obsolete (cargo-cult copied) dependenciesJens Carl1-30/+1
Change-Id: I3486391ff2c3826a4c10892e756428cca400f991 Reviewed-on: https://gerrit.libreoffice.org/57446 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-16related tdf#113646, keep cjk, ctl font items in syncMarkus Mohrhard1-11/+22
If the default style and default pool items are no longer in sync, our script detection assumes that any style without an explicitly set font has script type CTL or CJK. Use the same selection idea for both cases and at the same time use the *_SPREADSHEET font items for the default pool items. Change-Id: I6a5bb14a3fabab11627ad52b9e79554fdcedac89 Reviewed-on: https://gerrit.libreoffice.org/57470 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-16pretty-print the calc default stylesMarkus Mohrhard1-8/+8
Change-Id: I8245fc1d1b3d045ec0431ddb04d890cc59c87825 Reviewed-on: https://gerrit.libreoffice.org/57469 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-16Fix Win32 warning C4702: unreachable codeThorsten Behrens1-0/+3
..by disabling the warning for the moment. This happens on x86 builds with VS2017, but only with OSL_DEBUG_LEVEL=0, e.g. at: cppuhelper/source/servicemanager.cxx(1311) : error C2220: warning treated as error - no ´object´ file generated cppuhelper/source/servicemanager.cxx(1311) : warning C4702: unreachable code cppuhelper/source/servicemanager.cxx(1373) : warning C4702: unreachable code Change-Id: I91943350d7f6f5acfedb3b2bb14e5d835e4494ed Reviewed-on: https://gerrit.libreoffice.org/57472 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-16Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - tdf#115254 Some branch bookmarks are not working 4 sfx2 module dialogs Change-Id: Id7f799c0939c63695c29d0b6352e88c005386d3f Reviewed-on: https://gerrit.libreoffice.org/57468 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-15related tdf#117816, the dxf ID is a global and not a sheet propertyMarkus Mohrhard2-2/+2
Change-Id: I4c5ca66ce550de74d8b9396aa0213c558b7f884f Reviewed-on: https://gerrit.libreoffice.org/57445 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-15related tdf#117816, only export cond format formula to xlsx when requiredMarkus Mohrhard1-3/+24
Change-Id: I7523d17e9945dfbdf0c346fff8eddd40593f946a Reviewed-on: https://gerrit.libreoffice.org/57444 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-15related tdf#117816, add more work arounds for MS Excel bugsMarkus Mohrhard1-11/+53
Another set of cases where MS Excel needs the formula. Change-Id: I58344a540ad69ff9b8c56aa817730079bd011acd Reviewed-on: https://gerrit.libreoffice.org/57443 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-15Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - tdf#115254 Some branch bookmarks are not working 3 dialogs from chart2 Change-Id: I97e08c5b8ca2200f143073abadb355da99b38b9a Reviewed-on: https://gerrit.libreoffice.org/57450 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-15coverity#1437956 Dereference after null checkCaolán McNamara1-0/+1
Change-Id: Idcfb63beb094a000c70f594542757ad2e4a577fc Reviewed-on: https://gerrit.libreoffice.org/57459 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-15coverity#1437960 Resource leak in objectCaolán McNamara2-16/+13
Change-Id: Icee05e1ef1fef213de293971beb9e17753c8eb3b Reviewed-on: https://gerrit.libreoffice.org/57458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-15coverity#1437954 Dereference null return valueCaolán McNamara1-1/+1
turn DBG_ASSERT into a real assert since... commit 904c97bbdf4c76709dbcacb11292668b98a9efd8 Date: Mon Jul 2 17:23:59 2018 +0200 move SvTreeList::*Sibling to SvTreeListEntry since they don't depend on SvTreeList at all Change-Id: Ib230ff2fc9ab1f68c6686c125dbf4213e77bea84 Reviewed-on: https://gerrit.libreoffice.org/57457 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>