summaryrefslogtreecommitdiff
path: root/dbaccess/source/ui/querydesign/querydlg.cxx
diff options
context:
space:
mode:
Diffstat (limited to 'dbaccess/source/ui/querydesign/querydlg.cxx')
-rw-r--r--dbaccess/source/ui/querydesign/querydlg.cxx33
1 files changed, 13 insertions, 20 deletions
diff --git a/dbaccess/source/ui/querydesign/querydlg.cxx b/dbaccess/source/ui/querydesign/querydlg.cxx
index 5a21998d9946..5eb7bc96319f 100644
--- a/dbaccess/source/ui/querydesign/querydlg.cxx
+++ b/dbaccess/source/ui/querydesign/querydlg.cxx
@@ -21,7 +21,7 @@
#include <JoinController.hxx>
#include <JoinDesignView.hxx>
#include <strings.hrc>
-#include <tools/diagnose_ex.h>
+#include <comphelper/diagnose_ex.hxx>
#include "QTableConnectionData.hxx"
#include <core_resource.hxx>
#include <QueryTableView.hxx>
@@ -45,14 +45,14 @@ DlgQryJoin::DlgQryJoin(const OQueryTableView* pParent,
const OJoinTableView::OTableWindowMap* _pTableMap,
const Reference< XConnection >& _xConnection,
bool _bAllowTableSelect)
- : GenericDialogController(pParent->GetFrameWeld(), "dbaccess/ui/joindialog.ui", "JoinDialog")
+ : GenericDialogController(pParent->GetFrameWeld(), u"dbaccess/ui/joindialog.ui"_ustr, u"JoinDialog"_ustr)
, eJoinType(static_cast<OQueryTableConnectionData*>(_pData.get())->GetJoinType())
, m_pOrigConnData(_pData)
, m_xConnection(_xConnection)
- , m_xML_HelpText(m_xBuilder->weld_label("helptext"))
- , m_xPB_OK(m_xBuilder->weld_button("ok"))
- , m_xLB_JoinType(m_xBuilder->weld_combo_box("type"))
- , m_xCBNatural(m_xBuilder->weld_check_button("natural"))
+ , m_xML_HelpText(m_xBuilder->weld_label(u"helptext"_ustr))
+ , m_xPB_OK(m_xBuilder->weld_button(u"ok"_ustr))
+ , m_xLB_JoinType(m_xBuilder->weld_combo_box(u"type"_ustr))
+ , m_xCBNatural(m_xBuilder->weld_check_button(u"natural"_ustr))
{
Size aSize(m_xML_HelpText->get_approximate_digit_width() * 44,
m_xML_HelpText->get_text_height() * 6);
@@ -167,13 +167,9 @@ IMPL_LINK_NOARG( DlgQryJoin, LBChangeHdl, weld::ComboBox&, void )
eJoinType = LEFT_JOIN;
break;
case ID_RIGHT_JOIN:
- {
- pResId = STR_QUERY_LEFTRIGHT_JOIN;
- eJoinType = RIGHT_JOIN;
- OUString sTemp = sFirstWinName;
- sFirstWinName = sSecondWinName;
- sSecondWinName = sTemp;
- }
+ pResId = STR_QUERY_LEFTRIGHT_JOIN;
+ eJoinType = RIGHT_JOIN;
+ std::swap( sFirstWinName, sSecondWinName );
break;
case ID_FULL_JOIN:
pResId = STR_QUERY_FULL_JOIN;
@@ -188,7 +184,7 @@ IMPL_LINK_NOARG( DlgQryJoin, LBChangeHdl, weld::ComboBox&, void )
m_xTableControl->lateInit();
m_xCBNatural->set_active(false);
m_xTableControl->enableRelation(false);
- m_pConnData->AppendConnLine("","");
+ m_pConnData->AppendConnLine(u""_ustr,u""_ustr);
m_xPB_OK->set_sensitive(true);
}
break;
@@ -242,13 +238,10 @@ IMPL_LINK_NOARG(DlgQryJoin, NaturalToggleHdl, weld::Toggleable&, void)
try
{
Reference<XNameAccess> xReferencedTableColumns(m_pConnData->getReferencedTable()->getColumns());
- Sequence< OUString> aSeq = m_pConnData->getReferencingTable()->getColumns()->getElementNames();
- const OUString* pIter = aSeq.getConstArray();
- const OUString* pEnd = pIter + aSeq.getLength();
- for(;pIter != pEnd;++pIter)
+ for (auto& column : m_pConnData->getReferencingTable()->getColumns()->getElementNames())
{
- if ( xReferencedTableColumns->hasByName(*pIter) )
- m_pConnData->AppendConnLine(*pIter,*pIter);
+ if (xReferencedTableColumns->hasByName(column))
+ m_pConnData->AppendConnLine(column, column);
}
}
catch( const Exception& )