1 files changed, 24 insertions, 25 deletions
diff --git a/chart2/source/controller/sidebar/ChartTypePanel.cxx b/chart2/source/controller/sidebar/ChartTypePanel.cxx
index f6334864b049..da3166c74cf4 100644
--- a/chart2/source/controller/sidebar/ChartTypePanel.cxx
+++ b/chart2/source/controller/sidebar/ChartTypePanel.cxx
@@ -405,34 +405,33 @@ void ChartTypePanel::selectMainType()
     }
 
     m_pCurrentMainType = getSelectedMainType();
-    if (m_pCurrentMainType)
-    {
-        showAllControls(*m_pCurrentMainType);
+    if (!m_pCurrentMainType)
+        return;
 
-        m_pCurrentMainType->adjustParameterToMainType(aParameter);
-        commitToModel(aParameter);
-        //detect the new ThreeDLookScheme
-        aParameter.eThreeDLookScheme
-            = ThreeDHelper::detectScheme(ChartModelHelper::findDiagram(m_xChartModel));
-        if (!aParameter.b3DLook && aParameter.eThreeDLookScheme != ThreeDLookScheme_Realistic)
-            aParameter.eThreeDLookScheme = ThreeDLookScheme_Realistic;
-
-        uno::Reference<css::chart2::XDiagram> xDiagram
-            = ChartModelHelper::findDiagram(m_xChartModel);
-        try
-        {
-            uno::Reference<beans::XPropertySet> xPropSet(xDiagram, uno::UNO_QUERY_THROW);
-            xPropSet->getPropertyValue(CHART_UNONAME_SORT_BY_XVALUES) >>= aParameter.bSortByXValues;
-        }
-        catch (const uno::Exception&)
-        {
-            DBG_UNHANDLED_EXCEPTION("chart2");
-        }
+    showAllControls(*m_pCurrentMainType);
 
-        fillAllControls(aParameter);
-        uno::Reference<beans::XPropertySet> xTemplateProps(getCurrentTemplate(), uno::UNO_QUERY);
-        m_pCurrentMainType->fillExtraControls(m_xChartModel, xTemplateProps);
+    m_pCurrentMainType->adjustParameterToMainType(aParameter);
+    commitToModel(aParameter);
+    //detect the new ThreeDLookScheme
+    aParameter.eThreeDLookScheme
+        = ThreeDHelper::detectScheme(ChartModelHelper::findDiagram(m_xChartModel));
+    if (!aParameter.b3DLook && aParameter.eThreeDLookScheme != ThreeDLookScheme_Realistic)
+        aParameter.eThreeDLookScheme = ThreeDLookScheme_Realistic;
+
+    uno::Reference<css::chart2::XDiagram> xDiagram = ChartModelHelper::findDiagram(m_xChartModel);
+    try
+    {
+        uno::Reference<beans::XPropertySet> xPropSet(xDiagram, uno::UNO_QUERY_THROW);
+        xPropSet->getPropertyValue(CHART_UNONAME_SORT_BY_XVALUES) >>= aParameter.bSortByXValues;
     }
+    catch (const uno::Exception&)
+    {
+        DBG_UNHANDLED_EXCEPTION("chart2");
+    }
+
+    fillAllControls(aParameter);
+    uno::Reference<beans::XPropertySet> xTemplateProps(getCurrentTemplate(), uno::UNO_QUERY);
+    m_pCurrentMainType->fillExtraControls(m_xChartModel, xTemplateProps);
 }
 } // end of namespace ::chart::sidebar