diff options
49 files changed, 75 insertions, 72 deletions
diff --git a/embeddedobj/source/msole/olewrapclient.hxx b/embeddedobj/source/msole/olewrapclient.hxx index f5cc8dcc34c5..8064f79d8025 100644 --- a/embeddedobj/source/msole/olewrapclient.hxx +++ b/embeddedobj/source/msole/olewrapclient.hxx @@ -32,7 +32,7 @@ class OleWrapperClientSite : public IOleClientSite OleComponent* m_pOleComp; public: - OleWrapperClientSite( OleComponent* pOleComp ); + explicit OleWrapperClientSite(OleComponent* pOleComp); virtual ~OleWrapperClientSite(); void disconnectOleComponent(); diff --git a/embeddedobj/source/msole/xdialogcreator.hxx b/embeddedobj/source/msole/xdialogcreator.hxx index e428aea59620..c047273b3e7b 100644 --- a/embeddedobj/source/msole/xdialogcreator.hxx +++ b/embeddedobj/source/msole/xdialogcreator.hxx @@ -35,7 +35,7 @@ class MSOLEDialogObjectCreator : public ::cppu::WeakImplHelper< css::uno::Reference< css::lang::XMultiServiceFactory > m_xFactory; public: - MSOLEDialogObjectCreator( + explicit MSOLEDialogObjectCreator( const css::uno::Reference< css::lang::XMultiServiceFactory >& xFactory ) : m_xFactory( xFactory ) { diff --git a/embeddedobj/source/msole/xolefactory.hxx b/embeddedobj/source/msole/xolefactory.hxx index 500be34d1db3..cbc22773b32a 100644 --- a/embeddedobj/source/msole/xolefactory.hxx +++ b/embeddedobj/source/msole/xolefactory.hxx @@ -35,7 +35,7 @@ class OleEmbeddedObjectFactory : public ::cppu::WeakImplHelper< css::uno::Reference< css::lang::XMultiServiceFactory > m_xFactory; public: - OleEmbeddedObjectFactory( + explicit OleEmbeddedObjectFactory( const css::uno::Reference< css::lang::XMultiServiceFactory >& xFactory ) : m_xFactory( xFactory ) { diff --git a/embeddedobj/test/MainThreadExecutor/xexecutor.hxx b/embeddedobj/test/MainThreadExecutor/xexecutor.hxx index 13b37e59a290..78862982bac6 100644 --- a/embeddedobj/test/MainThreadExecutor/xexecutor.hxx +++ b/embeddedobj/test/MainThreadExecutor/xexecutor.hxx @@ -34,7 +34,7 @@ class UNOMainThreadExecutor : public ::cppu::WeakImplHelper< css::task::XJob, css::uno::Reference< css::lang::XMultiServiceFactory > m_xFactory; public: - UNOMainThreadExecutor( + explicit UNOMainThreadExecutor( const css::uno::Reference< css::lang::XMultiServiceFactory >& xFactory ) : m_xFactory( xFactory ) { diff --git a/embeddedobj/test/mtexecutor/bitmapcreator.hxx b/embeddedobj/test/mtexecutor/bitmapcreator.hxx index 5218031d77cf..4afaad3a9f4c 100644 --- a/embeddedobj/test/mtexecutor/bitmapcreator.hxx +++ b/embeddedobj/test/mtexecutor/bitmapcreator.hxx @@ -33,7 +33,7 @@ class VCLBitmapCreator : public ::cppu::WeakImplHelper< { public: - VCLBitmapCreator( + explicit VCLBitmapCreator( const css::uno::Reference< css::lang::XMultiServiceFactory >& xFactory ) {} diff --git a/embeddedobj/test/mtexecutor/mainthreadexecutor.hxx b/embeddedobj/test/mtexecutor/mainthreadexecutor.hxx index 095f983e2aaa..918969ed63a1 100644 --- a/embeddedobj/test/mtexecutor/mainthreadexecutor.hxx +++ b/embeddedobj/test/mtexecutor/mainthreadexecutor.hxx @@ -48,7 +48,7 @@ class MainThreadExecutor : public ::cppu::WeakImplHelper< { public: - MainThreadExecutor( + explicit MainThreadExecutor( const css::uno::Reference< css::lang::XMultiServiceFactory >& xFactory ) {} diff --git a/embedserv/source/inprocserv/advisesink.hxx b/embedserv/source/inprocserv/advisesink.hxx index a30653aa0a84..6a496bad912c 100644 --- a/embedserv/source/inprocserv/advisesink.hxx +++ b/embedserv/source/inprocserv/advisesink.hxx @@ -49,7 +49,7 @@ public: OleWrapperAdviseSink(); // an AdviseSink for IOleObject interface - OleWrapperAdviseSink( const ComSmart< IAdviseSink >& pListener ); + explicit OleWrapperAdviseSink( const ComSmart< IAdviseSink >& pListener ); // an AdviseSink for IDataObject interface OleWrapperAdviseSink( const ComSmart< IAdviseSink >& pListener, FORMATETC* pFormatEtc, DWORD nDataRegFlag ); diff --git a/embedserv/source/inprocserv/dllentry.cxx b/embedserv/source/inprocserv/dllentry.cxx index 5f70df9138d1..b7086068a3a0 100644 --- a/embedserv/source/inprocserv/dllentry.cxx +++ b/embedserv/source/inprocserv/dllentry.cxx @@ -140,7 +140,7 @@ class InprocEmbedProvider_Impl : public IClassFactory, public InprocCountedObjec { public: - InprocEmbedProvider_Impl( const GUID& guid ); + explicit InprocEmbedProvider_Impl( const GUID& guid ); virtual ~InprocEmbedProvider_Impl(); /* IUnknown methods */ diff --git a/embedserv/source/inprocserv/inprocembobj.cxx b/embedserv/source/inprocserv/inprocembobj.cxx index 912efc4dc160..70db0c218ee9 100644 --- a/embedserv/source/inprocserv/inprocembobj.cxx +++ b/embedserv/source/inprocserv/inprocembobj.cxx @@ -1018,7 +1018,8 @@ STDMETHODIMP InprocEmbedDocument_Impl::Advise( IAdviseSink *pAdvSink, DWORD *pdw ULONGGuard aGuard( &m_nCallsOnStack ); // avoid reentrance problem if ( SUCCEEDED( hr ) && pOleObject ) { - ComSmart< OleWrapperAdviseSink > pOwnAdvise( new OleWrapperAdviseSink( pAdvSink ) ); + ComSmart<IAdviseSink> aListener(pAdvSink); + ComSmart<OleWrapperAdviseSink> pOwnAdvise(new OleWrapperAdviseSink(aListener)); DWORD nRegID = 0; if ( SUCCEEDED( pOleObject->Advise( pOwnAdvise, &nRegID ) ) && nRegID > 0 ) @@ -1450,7 +1451,8 @@ STDMETHODIMP InprocEmbedDocument_Impl::SetAdvise( DWORD aspects, DWORD advf, IAd ULONGGuard aGuard( &m_nCallsOnStack ); // avoid reentrance problem if ( SUCCEEDED( hr ) && pIViewObject ) { - ComSmart< OleWrapperAdviseSink > pOwnAdvise( new OleWrapperAdviseSink( pAdvSink, aspects, advf ) ); + ComSmart<IAdviseSink> aListener(pAdvSink); + ComSmart<OleWrapperAdviseSink> pOwnAdvise(new OleWrapperAdviseSink(aListener, aspects, advf)); if ( SUCCEEDED( pIViewObject->SetAdvise( aspects, advf, pOwnAdvise ) ) ) { diff --git a/embedserv/source/inprocserv/inprocembobj.h b/embedserv/source/inprocserv/inprocembobj.h index 95a28ed2f94f..83e5c10470d5 100644 --- a/embedserv/source/inprocserv/inprocembobj.h +++ b/embedserv/source/inprocserv/inprocembobj.h @@ -94,7 +94,7 @@ class InprocEmbedDocument_Impl : public InprocCountedObject_Impl InprocEmbedDocument_Impl& m_rOwnDocument; public: - InternalCacheWrapper( InprocEmbedDocument_Impl& rOwnDocument ) + explicit InternalCacheWrapper( InprocEmbedDocument_Impl& rOwnDocument ) : m_rOwnDocument( rOwnDocument ) {} @@ -120,7 +120,7 @@ class InprocEmbedDocument_Impl : public InprocCountedObject_Impl public: - InprocEmbedDocument_Impl( const GUID& guid ) + explicit InprocEmbedDocument_Impl( const GUID& guid ) : m_refCount( 0 ) , m_bDeleted( FALSE ) , m_guid( guid ) diff --git a/embedserv/source/inprocserv/smartpointer.hxx b/embedserv/source/inprocserv/smartpointer.hxx index 62011df14556..dab46ada769a 100644 --- a/embedserv/source/inprocserv/smartpointer.hxx +++ b/embedserv/source/inprocserv/smartpointer.hxx @@ -50,7 +50,7 @@ public: m_pInterface->AddRef(); } - ComSmart( T* pInterface ) + explicit ComSmart( T* pInterface ) : m_pInterface( pInterface ) { if ( m_pInterface != NULL ) @@ -136,7 +136,7 @@ class CSGuard CRITICAL_SECTION* m_pCriticalSection; public: - CSGuard( CRITICAL_SECTION* pCS ) + explicit CSGuard( CRITICAL_SECTION* pCS ) : m_pCriticalSection( pCS ) { if ( m_pCriticalSection ) @@ -155,7 +155,7 @@ class ULONGGuard ULONG* m_pValue; public: - ULONGGuard( ULONG* pValue ) + explicit ULONGGuard( ULONG* pValue ) : m_pValue( pValue ) { if ( m_pValue ) diff --git a/extensions/source/activex/SOActiveX.cxx b/extensions/source/activex/SOActiveX.cxx index 09e3f26aa89a..74d82632f8c4 100644 --- a/extensions/source/activex/SOActiveX.cxx +++ b/extensions/source/activex/SOActiveX.cxx @@ -946,7 +946,7 @@ class LockingGuard { BOOL& mbLocked; public: - LockingGuard( BOOL& bLocked ) + explicit LockingGuard( BOOL& bLocked ) : mbLocked( bLocked ) { mbLocked = TRUE; diff --git a/extensions/source/ole/servprov.hxx b/extensions/source/ole/servprov.hxx index 06ced5eb136a..8cf9e55c77b1 100644 --- a/extensions/source/ole/servprov.hxx +++ b/extensions/source/ole/servprov.hxx @@ -169,7 +169,7 @@ class OleConverter_Impl2 : public WeakImplHelper<XBridgeSupplier2, XInitializati public UnoConversionUtilities<OleConverter_Impl2> { public: - OleConverter_Impl2( const Reference<XMultiServiceFactory>& smgr); + explicit OleConverter_Impl2( const Reference<XMultiServiceFactory>& smgr); OleConverter_Impl2( const Reference<XMultiServiceFactory>& smgr, sal_uInt8 unoWrapperClass, sal_uInt8 comWrapperClass ); virtual ~OleConverter_Impl2(); @@ -214,7 +214,7 @@ class OleClient_Impl : public WeakImplHelper<XMultiServiceFactory, css::lang::XS public UnoConversionUtilities<OleClient_Impl> { public: - OleClient_Impl( const Reference<XMultiServiceFactory>& smgr); + explicit OleClient_Impl( const Reference<XMultiServiceFactory>& smgr); ~OleClient_Impl(); // XMultiServiceFactory @@ -253,7 +253,7 @@ protected: class OleServer_Impl : public cppu::WeakImplHelper<css::lang::XServiceInfo> { public: - OleServer_Impl( const Reference<XMultiServiceFactory> &smgr); + explicit OleServer_Impl( const Reference<XMultiServiceFactory> &smgr); ~OleServer_Impl(); OUString SAL_CALL getImplementationName() diff --git a/extensions/source/ole/unoconversionutilities.hxx b/extensions/source/ole/unoconversionutilities.hxx index 83d3a18078b9..ea857fffafde 100644 --- a/extensions/source/ole/unoconversionutilities.hxx +++ b/extensions/source/ole/unoconversionutilities.hxx @@ -101,7 +101,7 @@ template< class > class UnoConversionUtilities { public: - UnoConversionUtilities( const Reference<XMultiServiceFactory> & smgr): + explicit UnoConversionUtilities( const Reference<XMultiServiceFactory> & smgr): m_nUnoWrapperClass( INTERFACE_OLE_WRAPPER_IMPL), m_nComWrapperClass( IUNKNOWN_WRAPPER_IMPL), m_smgr( smgr) diff --git a/extensions/source/ole/windata.hxx b/extensions/source/ole/windata.hxx index 5e6c30abcefe..b8b43ce2ca7a 100644 --- a/extensions/source/ole/windata.hxx +++ b/extensions/source/ole/windata.hxx @@ -56,7 +56,7 @@ public: CComPtr< ITypeInfo > m_pTypeInfo; VARDESC* m_pVarDesc; - VarDesc(ITypeInfo* pTypeInfo) : + explicit VarDesc(ITypeInfo* pTypeInfo) : m_pTypeInfo(pTypeInfo), m_pVarDesc(NULL) { @@ -96,7 +96,7 @@ class FuncDesc public: - FuncDesc(ITypeInfo * pTypeInfo) : + explicit FuncDesc(ITypeInfo * pTypeInfo) : m_pTypeInfo(pTypeInfo), m_pFuncDesc(NULL) { @@ -174,7 +174,7 @@ public: CComPtr< ITypeInfo > m_pTypeInfo; TYPEATTR* m_pTypeAttr; - TypeAttr(ITypeInfo* pTypeInfo) : + explicit TypeAttr(ITypeInfo* pTypeInfo) : m_pTypeInfo( pTypeInfo ), m_pTypeAttr( NULL ) { diff --git a/extensions/source/propctrlr/pcrunodialogs.hxx b/extensions/source/propctrlr/pcrunodialogs.hxx index bfd05f67525d..15499438f091 100644 --- a/extensions/source/propctrlr/pcrunodialogs.hxx +++ b/extensions/source/propctrlr/pcrunodialogs.hxx @@ -50,7 +50,7 @@ namespace pcr // </properties> public: - OTabOrderDialog( const css::uno::Reference< css::uno::XComponentContext >& _rxContext ); + explicit OTabOrderDialog( const css::uno::Reference< css::uno::XComponentContext >& _rxContext ); virtual ~OTabOrderDialog(); // XTypeProvider diff --git a/extensions/source/scanner/grid.cxx b/extensions/source/scanner/grid.cxx index ccdb44cd8492..4bc1b999046b 100644 --- a/extensions/source/scanner/grid.cxx +++ b/extensions/source/scanner/grid.cxx @@ -118,7 +118,7 @@ class GridWindow : public vcl::Window virtual Size GetOptimalSize() const override; void drawLine(vcl::RenderContext& rRenderContext, double x1, double y1, double x2, double y2); public: - GridWindow(vcl::Window* pParent); + explicit GridWindow(vcl::Window* pParent); void Init(double* pXValues, double* pYValues, int nValues, bool bCutValues, const BitmapEx &rMarkerBitmap); virtual ~GridWindow(); virtual void dispose() override; diff --git a/extensions/source/update/check/download.cxx b/extensions/source/update/check/download.cxx index 45ac34e76410..292df2011e64 100644 --- a/extensions/source/update/check/download.cxx +++ b/extensions/source/update/check/download.cxx @@ -54,7 +54,7 @@ struct OutData osl::Condition& StopCondition; CURL *curl; - OutData(osl::Condition& rCondition) : FileHandle(nullptr), Offset(0), StopCondition(rCondition), curl(nullptr) {}; + explicit OutData(osl::Condition& rCondition) : FileHandle(nullptr), Offset(0), StopCondition(rCondition), curl(nullptr) {}; }; diff --git a/extensions/source/update/check/updatecheck.cxx b/extensions/source/update/check/updatecheck.cxx index 600e408b45ab..4f93a77d3d8d 100644 --- a/extensions/source/update/check/updatecheck.cxx +++ b/extensions/source/update/check/updatecheck.cxx @@ -303,7 +303,7 @@ public: class MenuBarButtonJob : public ::cppu::WeakImplHelper< task::XJob > { public: - MenuBarButtonJob(const rtl::Reference< UpdateCheck >& rUpdateCheck); + explicit MenuBarButtonJob(const rtl::Reference< UpdateCheck >& rUpdateCheck); // XJob virtual uno::Any SAL_CALL execute(const uno::Sequence<beans::NamedValue>&) @@ -341,7 +341,7 @@ private: class ShutdownThread : public osl::Thread { public: - ShutdownThread( const uno::Reference<uno::XComponentContext>& xContext ); + explicit ShutdownThread(const uno::Reference<uno::XComponentContext>& xContext); virtual void SAL_CALL run() override; virtual void SAL_CALL onTerminated() override; diff --git a/extensions/source/update/check/updatecheckconfig.hxx b/extensions/source/update/check/updatecheckconfig.hxx index df8b4fcd386c..d4a9a55094ce 100644 --- a/extensions/source/update/check/updatecheckconfig.hxx +++ b/extensions/source/update/check/updatecheckconfig.hxx @@ -37,7 +37,7 @@ class NamedValueByNameAccess const css::uno::Sequence< css::beans::NamedValue >& m_rValues; public: - NamedValueByNameAccess( + explicit NamedValueByNameAccess( const css::uno::Sequence< css::beans::NamedValue >& rValues) : m_rValues(rValues) {} ; @@ -53,7 +53,7 @@ public: class UpdateCheckROModel { public: - UpdateCheckROModel(NamedValueByNameAccess& aNameAccess) : m_aNameAccess(aNameAccess) {}; + explicit UpdateCheckROModel(NamedValueByNameAccess& aNameAccess) : m_aNameAccess(aNameAccess) {}; bool isAutoCheckEnabled() const; bool isDownloadPaused() const; diff --git a/extensions/source/update/feed/updatefeed.cxx b/extensions/source/update/feed/updatefeed.cxx index 699cf8d2ebe6..1e459c999259 100644 --- a/extensions/source/update/feed/updatefeed.cxx +++ b/extensions/source/update/feed/updatefeed.cxx @@ -80,7 +80,7 @@ class InputStreamWrapper : public ::cppu::WeakImplHelper< io::XInputStream > uno::Reference< io::XInputStream > m_xStream; public: - InputStreamWrapper(const uno::Reference< io::XInputStream >& rxStream) : + explicit InputStreamWrapper(const uno::Reference< io::XInputStream >& rxStream) : m_xStream(rxStream) {}; virtual sal_Int32 SAL_CALL readBytes(uno::Sequence< sal_Int8 >& aData, sal_Int32 nBytesToRead) @@ -296,7 +296,7 @@ private: class SingleUpdateInformationEnumeration : public ::cppu::WeakImplHelper< container::XEnumeration > { public: - SingleUpdateInformationEnumeration(const uno::Reference< xml::dom::XElement >& xElement) + explicit SingleUpdateInformationEnumeration(const uno::Reference< xml::dom::XElement >& xElement) : m_nCount(0) { m_aEntry.UpdateDocument = xElement; }; virtual ~SingleUpdateInformationEnumeration() {}; diff --git a/extensions/source/update/ui/updatecheckui.cxx b/extensions/source/update/ui/updatecheckui.cxx index a168e5e8acec..804819137069 100644 --- a/extensions/source/update/ui/updatecheckui.cxx +++ b/extensions/source/update/ui/updatecheckui.cxx @@ -157,7 +157,7 @@ private: Image GetBubbleImage( OUString &rURL ); public: - UpdateCheckUI(const uno::Reference<uno::XComponentContext>&); + explicit UpdateCheckUI(const uno::Reference<uno::XComponentContext>&); virtual ~UpdateCheckUI(); // XServiceInfo diff --git a/extensions/test/ole/OleClient/axhost.hxx b/extensions/test/ole/OleClient/axhost.hxx index ea62befd2754..759b6eff4bba 100644 --- a/extensions/test/ole/OleClient/axhost.hxx +++ b/extensions/test/ole/OleClient/axhost.hxx @@ -32,7 +32,7 @@ class HostWin: public CWindowImpl<HostWin, CWindow, CComBSTR controlName; CComPtr<IUnknown> spControl; public: - HostWin(LPWSTR progid); + explicit HostWin(LPWSTR progid); ~HostWin(); diff --git a/extensions/workben/pythonautotest.cxx b/extensions/workben/pythonautotest.cxx index a7ee631e8a75..3fe5365210de 100644 --- a/extensions/workben/pythonautotest.cxx +++ b/extensions/workben/pythonautotest.cxx @@ -214,7 +214,7 @@ public: } - TestListener( XDebuggingRef *p ) + explicit TestListener( XDebuggingRef *p ) { attach( p ); } diff --git a/extensions/workben/testpgp.cxx b/extensions/workben/testpgp.cxx index a95cba91c227..743b08f6fb39 100644 --- a/extensions/workben/testpgp.cxx +++ b/extensions/workben/testpgp.cxx @@ -64,7 +64,7 @@ class DataSource_Impl : int m_fd; public: - DataSource_Impl (int fd = 0); + explicit DataSource_Impl(int fd = 0); virtual ~DataSource_Impl(); void setBuffer (const Sequence<sal_Int8> &rBuffer); diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx index 309cee31b1eb..39552a012bb2 100644 --- a/filter/source/msfilter/msdffimp.cxx +++ b/filter/source/msfilter/msdffimp.cxx @@ -154,8 +154,10 @@ static sal_uInt32 nMSOleObjCntr = 0; struct SvxMSDffBLIPInfo { sal_uLong nFilePos; ///< offset of the BLIP in data strem - SvxMSDffBLIPInfo(sal_uLong nFPos): - nFilePos( nFPos ) {} + explicit SvxMSDffBLIPInfo(sal_uLong nFPos) + : nFilePos(nFPos) + { + } }; /// the following will be sorted by the order of their appearance: diff --git a/fpicker/source/office/OfficeControlAccess.cxx b/fpicker/source/office/OfficeControlAccess.cxx index 31adbc8c33a6..a42dc2659030 100644 --- a/fpicker/source/office/OfficeControlAccess.cxx +++ b/fpicker/source/office/OfficeControlAccess.cxx @@ -153,11 +153,14 @@ namespace svt struct ControlPropertyLookup { OUString m_sLookup; - ControlPropertyLookup( const OUString& _rLookup ) : m_sLookup( _rLookup ) { } + explicit ControlPropertyLookup(const OUString& rLookup) + : m_sLookup(rLookup) + { + } - bool operator()( const ControlProperty& _rProp ) + bool operator()(const ControlProperty& rProp) { - return m_sLookup.equalsAscii( _rProp.pPropertyName ); + return m_sLookup.equalsAscii(rProp.pPropertyName); } }; diff --git a/fpicker/source/office/OfficeFilePicker.cxx b/fpicker/source/office/OfficeFilePicker.cxx index 9bd9724cf187..a4d9dd3e4b9f 100644 --- a/fpicker/source/office/OfficeFilePicker.cxx +++ b/fpicker/source/office/OfficeFilePicker.cxx @@ -122,7 +122,7 @@ struct ElementEntry_Impl bool m_bHasLabel : 1; bool m_bHasEnabled : 1; - ElementEntry_Impl( sal_Int16 nId ); + explicit ElementEntry_Impl( sal_Int16 nId ); void setValue( const Any& rVal ) { m_aValue = rVal; m_bHasValue = true; } void setAction( sal_Int16 nAction ) { m_nControlAction = nAction; } @@ -337,7 +337,7 @@ namespace { const OUString& rTitle; public: - FilterTitleMatch( const OUString& _rTitle ) : rTitle( _rTitle ) { } + explicit FilterTitleMatch( const OUString& _rTitle ) : rTitle( _rTitle ) { } bool operator () ( const FilterEntry& _rEntry ) diff --git a/fpicker/source/office/RemoteFilesDialog.cxx b/fpicker/source/office/RemoteFilesDialog.cxx index b5de1d9cde94..e62dd6236775 100644 --- a/fpicker/source/office/RemoteFilesDialog.cxx +++ b/fpicker/source/office/RemoteFilesDialog.cxx @@ -28,7 +28,7 @@ class FileViewContainer : public vcl::Window VclPtr<vcl::Window> m_pFocusWidgets[FocusState::FocusCount]; public: - FileViewContainer( vcl::Window *pParent ) + explicit FileViewContainer( vcl::Window *pParent ) : Window( pParent, WB_TABSTOP ) , m_pFileView( nullptr ) , m_pTreeView( nullptr ) diff --git a/fpicker/source/office/fpinteraction.hxx b/fpicker/source/office/fpinteraction.hxx index bfac7d9bc9e3..28192e0bed9d 100644 --- a/fpicker/source/office/fpinteraction.hxx +++ b/fpicker/source/office/fpinteraction.hxx @@ -57,7 +57,7 @@ namespace svt EInterceptedInteractions m_eInterceptions; // enable/disable interception of some special interactions public: - OFilePickerInteractionHandler( const css::uno::Reference< css::task::XInteractionHandler >& _rxMaster ); + explicit OFilePickerInteractionHandler( const css::uno::Reference< css::task::XInteractionHandler >& _rxMaster ); // some generic functions void enableInterceptions( EInterceptedInteractions eInterceptions ); diff --git a/fpicker/source/office/fpsmartcontent.hxx b/fpicker/source/office/fpsmartcontent.hxx index c37db2f933be..d25cdd8a01c0 100644 --- a/fpicker/source/office/fpsmartcontent.hxx +++ b/fpicker/source/office/fpsmartcontent.hxx @@ -66,7 +66,7 @@ namespace svt public: SmartContent(); - SmartContent( const OUString& _rInitialURL ); + explicit SmartContent( const OUString& _rInitialURL ); ~SmartContent(); public: diff --git a/fpicker/source/office/fpsofficeResMgr.hxx b/fpicker/source/office/fpsofficeResMgr.hxx index 359fc8867f04..8c5137cb18e9 100644 --- a/fpicker/source/office/fpsofficeResMgr.hxx +++ b/fpicker/source/office/fpsofficeResMgr.hxx @@ -33,7 +33,7 @@ namespace fpicker struct SvtResId : public ResId { - SvtResId (sal_uInt16 nId) : ResId (nId, *ResMgrHolder::getOrCreate()) {} + explicit SvtResId (sal_uInt16 nId) : ResId (nId, *ResMgrHolder::getOrCreate()) {} }; } diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx index 5b32695884b2..3365bb28ce51 100644 --- a/fpicker/source/office/iodlg.cxx +++ b/fpicker/source/office/iodlg.cxx @@ -366,7 +366,7 @@ class CustomContainer : public vcl::Window VclPtr<vcl::Window> m_pFocusWidgets[FocusState::FocusCount]; public: - CustomContainer(vcl::Window *pParent) + explicit CustomContainer(vcl::Window *pParent) : Window(pParent) , _pImp(nullptr) , _pFileView(nullptr) @@ -1696,7 +1696,7 @@ private: VclPtr<vcl::Window> _pOld; public: - SvtDefModalDialogParent_Impl( vcl::Window *pNew ) : + explicit SvtDefModalDialogParent_Impl( vcl::Window *pNew ) : _pOld( Application::GetDefDialogParent() ) { Application::SetDefDialogParent( pNew ); } diff --git a/fpicker/source/office/iodlgimp.cxx b/fpicker/source/office/iodlgimp.cxx index c5e0552a7970..ae511ecb53a6 100644 --- a/fpicker/source/office/iodlgimp.cxx +++ b/fpicker/source/office/iodlgimp.cxx @@ -65,7 +65,7 @@ namespace struct SvtSimpleResId : public ResId { - SvtSimpleResId (sal_uInt16 nId) : ResId (nId, *ResMgrHolder::getOrCreate()) {} + explicit SvtSimpleResId (sal_uInt16 nId) : ResId (nId, *ResMgrHolder::getOrCreate()) {} }; } diff --git a/fpicker/source/office/iodlgimp.hxx b/fpicker/source/office/iodlgimp.hxx index 5452c94da62b..38aa8bdb8e11 100644 --- a/fpicker/source/office/iodlgimp.hxx +++ b/fpicker/source/office/iodlgimp.hxx @@ -181,7 +181,7 @@ public: // remember sizes OUString _aIniKey; - SvtExpFileDlg_Impl( WinBits nBits ); + explicit SvtExpFileDlg_Impl( WinBits nBits ); ~SvtExpFileDlg_Impl(); diff --git a/fpicker/source/win32/filepicker/FilePicker.hxx b/fpicker/source/win32/filepicker/FilePicker.hxx index 1c68cf029d4b..63029ef4bbf5 100644 --- a/fpicker/source/win32/filepicker/FilePicker.hxx +++ b/fpicker/source/win32/filepicker/FilePicker.hxx @@ -58,7 +58,7 @@ class CFilePicker : public: // ctor - CFilePicker( const css::uno::Reference< css::lang::XMultiServiceFactory >& xServiceMgr ); + explicit CFilePicker( const css::uno::Reference< css::lang::XMultiServiceFactory >& xServiceMgr ); // XFilePickerNotifier diff --git a/fpicker/source/win32/filepicker/VistaFilePicker.hxx b/fpicker/source/win32/filepicker/VistaFilePicker.hxx index 01b6da335893..b14eb124dc69 100644 --- a/fpicker/source/win32/filepicker/VistaFilePicker.hxx +++ b/fpicker/source/win32/filepicker/VistaFilePicker.hxx @@ -67,7 +67,7 @@ public: // ctor/dtor - VistaFilePicker( const css::uno::Reference< css::lang::XMultiServiceFactory >& xSMGR ); + explicit VistaFilePicker( const css::uno::Reference< css::lang::XMultiServiceFactory >& xSMGR ); virtual ~VistaFilePicker(); diff --git a/fpicker/source/win32/filepicker/VistaFilePickerEventHandler.hxx b/fpicker/source/win32/filepicker/VistaFilePickerEventHandler.hxx index 98a61afc0b24..bb63b55b0050 100644 --- a/fpicker/source/win32/filepicker/VistaFilePickerEventHandler.hxx +++ b/fpicker/source/win32/filepicker/VistaFilePickerEventHandler.hxx @@ -61,7 +61,7 @@ class VistaFilePickerEventHandler : public ::cppu::BaseMutex // ctor/dtor - VistaFilePickerEventHandler(IVistaFilePickerInternalNotify* pInternalNotify); + explicit VistaFilePickerEventHandler(IVistaFilePickerInternalNotify* pInternalNotify); virtual ~VistaFilePickerEventHandler(); diff --git a/fpicker/source/win32/filepicker/asynceventnotifier.hxx b/fpicker/source/win32/filepicker/asynceventnotifier.hxx index b5d4d1735c86..335608d2645d 100644 --- a/fpicker/source/win32/filepicker/asynceventnotifier.hxx +++ b/fpicker/source/win32/filepicker/asynceventnotifier.hxx @@ -43,7 +43,7 @@ class CAsyncEventNotifier { public: - CAsyncEventNotifier(cppu::OBroadcastHelper& rBroadcastHelper); + explicit CAsyncEventNotifier(cppu::OBroadcastHelper& rBroadcastHelper); ~CAsyncEventNotifier(); bool SAL_CALL startup(bool bCreateSuspended = true); diff --git a/fpicker/source/win32/filepicker/controlcommand.hxx b/fpicker/source/win32/filepicker/controlcommand.hxx index c843589c8617..497286344b22 100644 --- a/fpicker/source/win32/filepicker/controlcommand.hxx +++ b/fpicker/source/win32/filepicker/controlcommand.hxx @@ -32,14 +32,10 @@ class CFilePickerState; class CControlCommandRequest; class CControlCommandResult; - - - - class CControlCommand { public: - CControlCommand( sal_Int16 aControlId ); + explicit CControlCommand( sal_Int16 aControlId ); virtual ~CControlCommand( ); virtual void SAL_CALL exec( CFilePickerState* aFilePickerState ) = 0; diff --git a/fpicker/source/win32/filepicker/controlcommandrequest.hxx b/fpicker/source/win32/filepicker/controlcommandrequest.hxx index f62cfd3a35c7..6fc95a3027ee 100644 --- a/fpicker/source/win32/filepicker/controlcommandrequest.hxx +++ b/fpicker/source/win32/filepicker/controlcommandrequest.hxx @@ -29,7 +29,7 @@ class CControlCommandRequest { public: - CControlCommandRequest( sal_Int16 aControlId ) : + explicit CControlCommandRequest( sal_Int16 aControlId ) : m_aControlId( aControlId ) { } diff --git a/fpicker/source/win32/filepicker/controlcommandresult.hxx b/fpicker/source/win32/filepicker/controlcommandresult.hxx index f32fff6ad79a..cdc09ec8c626 100644 --- a/fpicker/source/win32/filepicker/controlcommandresult.hxx +++ b/fpicker/source/win32/filepicker/controlcommandresult.hxx @@ -31,7 +31,7 @@ class CControlCommandResult { public: - CControlCommandResult( sal_Bool bResult = sal_False ) : + explicit CControlCommandResult( sal_Bool bResult = sal_False ) : m_bResult( bResult ) { } diff --git a/fpicker/source/win32/filepicker/filepickereventnotification.hxx b/fpicker/source/win32/filepicker/filepickereventnotification.hxx index bb9a0582055e..132e4e937371 100644 --- a/fpicker/source/win32/filepicker/filepickereventnotification.hxx +++ b/fpicker/source/win32/filepicker/filepickereventnotification.hxx @@ -35,7 +35,7 @@ public: typedef void (SAL_CALL css::ui::dialogs::XFilePickerListener::*EventListenerMethod_t)(); public: - CFilePickerEventNotification(EventListenerMethod_t EventListenerMethod); + explicit CFilePickerEventNotification(EventListenerMethod_t EventListenerMethod); virtual void SAL_CALL notifyEventListener( css::uno::Reference< css::uno::XInterface > xListener ); @@ -52,7 +52,7 @@ class CFilePickerParamEventNotification : public CEventNotification public: typedef void (SAL_CALL css::ui::dialogs::XFilePickerListener::*EventListenerMethod_t)(const css::ui::dialogs::FilePickerEvent&); - CFilePickerParamEventNotification(EventListenerMethod_t EventListenerMethod, const css::ui::dialogs::FilePickerEvent& FilePickerEvent); + explicit CFilePickerParamEventNotification(EventListenerMethod_t EventListenerMethod, const css::ui::dialogs::FilePickerEvent& FilePickerEvent); virtual void SAL_CALL notifyEventListener( css::uno::Reference< css::uno::XInterface > xListener ); diff --git a/fpicker/source/win32/filepicker/filepickerstate.hxx b/fpicker/source/win32/filepicker/filepickerstate.hxx index fbf15f62747c..24e6ba1edf77 100644 --- a/fpicker/source/win32/filepicker/filepickerstate.hxx +++ b/fpicker/source/win32/filepicker/filepickerstate.hxx @@ -108,7 +108,7 @@ private: class CExecuteFilePickerState : public CFilePickerState { public: - CExecuteFilePickerState( HWND hwndDlg = NULL ); + explicit CExecuteFilePickerState( HWND hwndDlg = NULL ); virtual void SAL_CALL setValue( sal_Int16 aControlId, sal_Int16 aControlAction, const css::uno::Any& aValue ); diff --git a/fpicker/source/win32/filepicker/previewadapter.cxx b/fpicker/source/win32/filepicker/previewadapter.cxx index 1180d8856f29..981fde0ff882 100644 --- a/fpicker/source/win32/filepicker/previewadapter.cxx +++ b/fpicker/source/win32/filepicker/previewadapter.cxx @@ -44,7 +44,7 @@ using namespace ::com::sun::star::lang; class CPreviewAdapterImpl { public: - CPreviewAdapterImpl(HINSTANCE instance); + explicit CPreviewAdapterImpl(HINSTANCE instance); virtual ~CPreviewAdapterImpl(); @@ -402,7 +402,7 @@ HWND SAL_CALL CPreviewAdapterImpl::findFileListbox() const class CWin95NTPreviewAdapterImpl : public CPreviewAdapterImpl { public: - CWin95NTPreviewAdapterImpl(HINSTANCE instance); + explicit CWin95NTPreviewAdapterImpl(HINSTANCE instance); virtual void SAL_CALL notifyParentShow(sal_Bool bShow); }; diff --git a/fpicker/source/win32/filepicker/previewadapter.hxx b/fpicker/source/win32/filepicker/previewadapter.hxx index c3cfe171b0f7..634b9b7c0494 100644 --- a/fpicker/source/win32/filepicker/previewadapter.hxx +++ b/fpicker/source/win32/filepicker/previewadapter.hxx @@ -50,7 +50,7 @@ class CPreviewAdapter public: // ctor - CPreviewAdapter(HINSTANCE instance); + explicit CPreviewAdapter(HINSTANCE instance); ~CPreviewAdapter(); diff --git a/fpicker/source/win32/folderpicker/FolderPicker.hxx b/fpicker/source/win32/folderpicker/FolderPicker.hxx index d5612ee1095d..331cfee37e36 100644 --- a/fpicker/source/win32/folderpicker/FolderPicker.hxx +++ b/fpicker/source/win32/folderpicker/FolderPicker.hxx @@ -43,7 +43,7 @@ class CFolderPicker : public: // ctor/dtor - CFolderPicker( const css::uno::Reference< css::lang::XMultiServiceFactory >& xServiceMgr ); + explicit CFolderPicker( const css::uno::Reference< css::lang::XMultiServiceFactory >& xServiceMgr ); // XExecutableDialog diff --git a/fpicker/source/win32/folderpicker/MtaFop.hxx b/fpicker/source/win32/folderpicker/MtaFop.hxx index 62a01df6034b..c85d6b420332 100644 --- a/fpicker/source/win32/folderpicker/MtaFop.hxx +++ b/fpicker/source/win32/folderpicker/MtaFop.hxx @@ -51,7 +51,7 @@ class CAutoPathBuff { public: - CAutoPathBuff( size_t size = 0 ) + explicit CAutoPathBuff( size_t size = 0 ) { if (0 == size) size = 32000; // max path length under Win2000 @@ -96,7 +96,7 @@ private: class CMtaFolderPicker { public: - CMtaFolderPicker( sal_uInt32 Flags ); + explicit CMtaFolderPicker( sal_uInt32 Flags ); virtual ~CMtaFolderPicker( ); // shell functions diff --git a/fpicker/source/win32/folderpicker/WinFOPImpl.hxx b/fpicker/source/win32/folderpicker/WinFOPImpl.hxx index ecfe8ff4b8b8..e5336b3adb85 100644 --- a/fpicker/source/win32/folderpicker/WinFOPImpl.hxx +++ b/fpicker/source/win32/folderpicker/WinFOPImpl.hxx @@ -33,7 +33,7 @@ class CFolderPicker; class CWinFolderPickerImpl : public CMtaFolderPicker { public: - CWinFolderPickerImpl( CFolderPicker* aFolderPicker ); + explicit CWinFolderPickerImpl( CFolderPicker* aFolderPicker ); // XExecutableDialog |