diff options
author | Miklos Vajna <vmiklos@collabora.co.uk> | 2013-11-22 13:01:53 +0100 |
---|---|---|
committer | Miklos Vajna <vmiklos@collabora.co.uk> | 2013-11-22 15:29:56 +0100 |
commit | e04d21afee4a286d63f836e7375d573dd4b7f73a (patch) | |
tree | 5beb1f4fdd35cc690bb53d23561f1f493aaa0000 /writerfilter | |
parent | 37441c602381804ff186088ee94f045a59aae6e3 (diff) |
DOCX drawingML shape filter: import wps:txbx inside the shape
The problem was that previously the shape text was imported normally, and the
shape itself was simply appended after the text.
In case of the VML import, the following mechanism made it possible to have the
shape earlier: OOXMLFastContextHandlerShape::sendShape() is called twice, early
in OOXMLFastContextHandlerWrapper::lcl_createFastChildContext(), in case the
shape had text, and later in
OOXMLFastContextHandlerShape::lcl_endFastElement(), in case the shape didn't
have text. This works because the parent element of v:textbox (v:shape) is
already something that isn't handled in writerfilter, so the parent of the
w:txbxContent's parent was a OOXMLFastContextHandlerWrapper.
In case of WPS, the problem was that the parent of w:txbxContent is wps:txbx,
and the parent of that is wps:wsp, which is something (unlike v:shape) we do
handle in writerfilter. Fix this by adding an early call to sendShape() in
OOXMLFastContextHandlerShape::lcl_createFastChildContext() as well.
Change-Id: Ia24678871d7bbad89d18b1d5f468c17f68feec10
Diffstat (limited to 'writerfilter')
-rw-r--r-- | writerfilter/source/ooxml/OOXMLFastContextHandler.cxx | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx index 2b9be07b420e..35a63269a6f4 100644 --- a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx +++ b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx @@ -2197,6 +2197,12 @@ OOXMLFastContextHandlerShape::lcl_createFastChildContext break; } + // VML import of shape text is already handled by + // OOXMLFastContextHandlerWrapper::lcl_createFastChildContext(), here we + // handle the WPS import of shape text, as there the parent context is a + // Shape one, so a different situation. + if (Element == static_cast<sal_Int32>(NS_wps | OOXML_txbx)) + sendShape(Element); return xContextHandler; } |