diff options
| author | Justin Luth <justin.luth@collabora.com> | 2020-08-11 09:14:39 +0300 |
|---|---|---|
| committer | Justin Luth <justin_luth@sil.org> | 2020-08-11 21:31:47 +0200 |
| commit | 98665425ebb5cdeeda341336871ca4da7f4842b7 (patch) | |
| tree | a90f506362eecc12cf8e00e124955086c036fb82 /writerfilter | |
| parent | f6253490c48b1e16becb5baf428ad3505a8ed2e2 (diff) | |
related tdf#135343 writerfilter: document broken nextColumn
Fortunately, it is rather hard in Word to insert a nextColumn
section-break, so this situation is rarely seen,
and bug 135343's fix made it even more irrelevant.
The fix includes unit tests demonstrating this problem.
The column break should be inserted around m_xStartingRange,
but the section should start from pPrevSection->m_xStartingRange
and be extended include this section. But I have no idea
how to do that.
At least documenting that something is completely broken
should be very useful for anyone drawn to this code.
Change-Id: I878f99601bb2181500d215a0440a34a62f3840f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100461
Tested-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Diffstat (limited to 'writerfilter')
| -rw-r--r-- | writerfilter/source/dmapper/PropertyMap.cxx | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/writerfilter/source/dmapper/PropertyMap.cxx b/writerfilter/source/dmapper/PropertyMap.cxx index 6b5af2fd9404..578738175238 100644 --- a/writerfilter/source/dmapper/PropertyMap.cxx +++ b/writerfilter/source/dmapper/PropertyMap.cxx @@ -1536,6 +1536,10 @@ void SectionPropertyMap::CloseSectionGroup( DomainMapper_Impl& rDM_Impl ) try { InheritOrFinalizePageStyles( rDM_Impl ); + /*TODO tdf#135343: Just inserting a column break sounds like the right idea, but the implementation is wrong. + * Somehow, the previous column section needs to be extended to cover this new text. + * Currently, it is completely broken, producing a no-column section that starts on a new page. + */ uno::Reference< beans::XPropertySet > xRangeProperties; if ( m_xStartingRange.is() ) { |