diff options
| author | Michael Meeks <michael.meeks@collabora.com> | 2015-03-27 14:36:47 +0000 |
|---|---|---|
| committer | Michael Meeks <michael.meeks@collabora.com> | 2015-04-10 13:13:27 +0100 |
| commit | 7df35a2e92fa9fb548bbca0d0935f055e56e6d10 (patch) | |
| tree | 30afd6654892fc8ef21f06f1368786728a9b17c3 /vcl/source/window/syswin.cxx | |
| parent | 23eada8dbbf10de29b85e9d965f5c0ed11942efc (diff) | |
Unwind mpDialogParent oddness.
This pointer is used to pass extra information through dialog
constructors, and (as such) if implemented with a VclPtr it causes
us to take and then release a reference on our in-construction
object, before it can return it's 'this' into the safety of its
calling VclPtr<> constructor; not good. cf.
Dialog::doDeferredInit vs. SystemWindow::loadUI.
Change-Id: Idcab40cedcdebed560077cfaa1a14395e6e01cd6
Diffstat (limited to 'vcl/source/window/syswin.cxx')
| -rw-r--r-- | vcl/source/window/syswin.cxx | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/vcl/source/window/syswin.cxx b/vcl/source/window/syswin.cxx index 9cb57f310b2e..99ac9bcb4fa4 100644 --- a/vcl/source/window/syswin.cxx +++ b/vcl/source/window/syswin.cxx @@ -119,7 +119,6 @@ void SystemWindow::dispose() // as a SystemWindow (which it no longer is by then): mpWindowImpl->mbSysWin = false; disposeBuilder(); - mpDialogParent.clear(); Window::dispose(); } |