diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2018-07-26 14:02:37 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2018-07-27 08:26:45 +0200 |
| commit | d2a28ebd5878305b29d8dbfc3b537ddfaabd3625 (patch) | |
| tree | 31cf4eead2c179466b5ae3e93b217780b70b3bc1 /vcl/source/app/settings.cxx | |
| parent | 739f746254853dbf6552b0fac9192bfd5ddd0118 (diff) | |
vcl: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)
...by explicitly defaulting the copy/move functions (and, where needed in turn,
also a default ctor) for classes that have a user-declared dtor that does
nothing other than an implicitly-defined one would do, but needs to be user-
declared because it is virtual and potentially serves as a key function to
emit the vtable, or is non-public, etc.; and by removing explicitly user-
provided functions that do the same as their implicitly-defined counterparts,
but may prevent implicitly declared copy functions from being defined as non-
deleted in the future. (Even if such a user-provided function was declared
non-inline in an include file, the apparently-used implicitly-defined copy
functions are already include, so why bother with non-inline functions.)
Change-Id: Ife5d8eb699b8b6c84b9229ae275dc386fa189bce
Reviewed-on: https://gerrit.libreoffice.org/58105
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'vcl/source/app/settings.cxx')
| -rw-r--r-- | vcl/source/app/settings.cxx | 25 |
1 files changed, 0 insertions, 25 deletions
diff --git a/vcl/source/app/settings.cxx b/vcl/source/app/settings.cxx index a000b065092d..4354ff573bee 100644 --- a/vcl/source/app/settings.cxx +++ b/vcl/source/app/settings.cxx @@ -433,10 +433,6 @@ MouseSettings::MouseSettings() { } -MouseSettings::~MouseSettings() -{ -} - void MouseSettings::CopyData() { // copy if other references exist @@ -715,10 +711,6 @@ StyleSettings::StyleSettings() { } -StyleSettings::~StyleSettings() -{ -} - void StyleSettings::SetFaceColor( const Color& rColor ) { @@ -2346,10 +2338,6 @@ MiscSettings::MiscSettings() { } -MiscSettings::~MiscSettings() -{ -} - bool MiscSettings::operator ==( const MiscSettings& rSet ) const { if ( mxData == rSet.mxData ) @@ -2529,10 +2517,6 @@ HelpSettings::HelpSettings() { } -HelpSettings::~HelpSettings() -{ -} - bool HelpSettings::operator ==( const HelpSettings& rSet ) const { if ( mxData == rSet.mxData ) @@ -2614,15 +2598,6 @@ AllSettings::AllSettings() { } -AllSettings::AllSettings( const AllSettings& rSet ) -{ - mxData = rSet.mxData; -} - -AllSettings::~AllSettings() -{ -} - void AllSettings::CopyData() { // copy if other references exist |