vcl: Create accessor and mutator for font scaling in FontMetric

This is fragile code! There are actually *two* classes that do almost
precisely the same thing, they are:

- ImplFontMetric, and
- ImplFontMetricData

They both have much in common, including their class name, and even
most of their functionality. In fact, they both have common accessor
functions. When I look at the code, it looks like OutputDevice is
actually given an ImplFontMetricData object, which it then uses to
populate an ImplFontMetric object...

Basically, I'm going to merge these classes. To do so, I'm going to
do the following:

Step 1: Implement accessor functions for ImplFontMetric and FontMetric
        (then remove the friendship of this class to OutputDevice!)
Step 2: Write a unit test for each accessor function in ImplFontMetric
Step 3: Ensure that ImplFontMetric and ImplFontMetricData use some
        sort of smart pointer (probably an intrusive_ptr like I did
        ages ago with FontCharMap)
Step 4: Merge the two classes together once their class interfaces
        are the same and I am satisfied they do the same thing
Step 5: Find all instances of inefficient usage - for instance, I can
        do away with the code that copies the ImplFontMetricData
        attributes into an ImplFontMetric object.

Change-Id: I07c1cb848774b130fa2ca60b51da53e07754dd00
Reviewed-on: https://gerrit.libreoffice.org/21399
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

1 files changed, 61 insertions, 0 deletions

diff --git a/vcl/qa/cppunit/fontmetric.cxx b/vcl/qa/cppunit/fontmetric.cxx
new file mode 100644
index 000000000000..b7db7dfafe11
--- /dev/null
+++ b/vcl/qa/cppunit/fontmetric.cxx
@@ -0,0 +1,61 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include <test/bootstrapfixture.hxx>
+
+#include <osl/file.hxx>
+#include <osl/process.h>
+
+#include <vcl/metric.hxx>
+
+#include "impfont.hxx"
+
+class VclFontMetricTest : public test::BootstrapFixture
+{
+public:
+    VclFontMetricTest() : BootstrapFixture(true, false) {}
+
+    void testScalableFlag();
+    void testEqualityOperator();
+
+    CPPUNIT_TEST_SUITE(VclFontMetricTest);
+    CPPUNIT_TEST(testScalableFlag);
+    CPPUNIT_TEST(testEqualityOperator);
+    CPPUNIT_TEST_SUITE_END();
+};
+
+void VclFontMetricTest::testScalableFlag()
+{
+    // default constructor should set scalable flag to false
+    FontMetric aFontMetric;
+
+    CPPUNIT_ASSERT_MESSAGE( "Scalable flag should be false after default constructor called", !aFontMetric.IsScalable() );
+
+    aFontMetric.SetScalableFlag(true);
+
+    CPPUNIT_ASSERT_MESSAGE( "Scalable flag should be true", aFontMetric.IsScalable() );
+}
+
+void VclFontMetricTest::testEqualityOperator()
+{
+    // default constructor should set scalable flag to false
+    FontMetric aLhs, aRhs;
+
+    aLhs.SetScalableFlag(true);
+    aRhs.SetScalableFlag(true);
+
+    CPPUNIT_ASSERT_MESSAGE( "Scalable flag set same", aLhs == aRhs );
+}
+
+
+CPPUNIT_TEST_SUITE_REGISTRATION(VclFontMetricTest);
+
+CPPUNIT_PLUGIN_IMPLEMENT();
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */