loplugin:constantparam in framework..vbahelper

Change-Id: I592f73012ae8a4df8488ef04dc0956d9400625bc

3 files changed, 5 insertions, 8 deletions

diff --git a/vbahelper/source/vbahelper/vbacommandbar.cxx b/vbahelper/source/vbahelper/vbacommandbar.cxx
index c35f346fd0ae..a39ee2a5aba8 100644
--- a/vbahelper/source/vbahelper/vbacommandbar.cxx
+++ b/vbahelper/source/vbahelper/vbacommandbar.cxx
@@ -197,10 +197,9 @@ ScVbaCommandBar::getServiceNames()
 VbaDummyCommandBar::VbaDummyCommandBar(
         const uno::Reference< ov::XHelperInterface >& xParent,
         const uno::Reference< uno::XComponentContext >& xContext,
-        const OUString& rName, sal_Int32 nType ) throw( uno::RuntimeException ) :
+        const OUString& rName ) throw( uno::RuntimeException ) :
     CommandBar_BASE( xParent, xContext ),
-    maName( rName ),
-    mnType( nType )
+    maName( rName )
 {
 }
 
@@ -253,7 +252,7 @@ uno::Any SAL_CALL VbaDummyCommandBar::Controls( const uno::Any& aIndex ) throw (
 
 sal_Int32 SAL_CALL VbaDummyCommandBar::Type() throw (script::BasicErrorException, uno::RuntimeException, std::exception)
 {
-    return mnType;
+    return office::MsoBarType::msoBarTypePopup;
 }
 
 uno::Any SAL_CALL VbaDummyCommandBar::FindControl( const uno::Any& /*aType*/, const uno::Any& /*aId*/, const uno::Any& /*aTag*/, const uno::Any& /*aVisible*/, const uno::Any& /*aRecursive*/ ) throw (script::BasicErrorException, uno::RuntimeException, std::exception)
diff --git a/vbahelper/source/vbahelper/vbacommandbar.hxx b/vbahelper/source/vbahelper/vbacommandbar.hxx
index e2b7ea84a8da..5c66988fb407 100644
--- a/vbahelper/source/vbahelper/vbacommandbar.hxx
+++ b/vbahelper/source/vbahelper/vbacommandbar.hxx
@@ -67,8 +67,7 @@ public:
     VbaDummyCommandBar(
             const css::uno::Reference< ov::XHelperInterface >& xParent,
             const css::uno::Reference< css::uno::XComponentContext >& xContext,
-            const OUString& rName,
-            sal_Int32 nType ) throw( css::uno::RuntimeException );
+            const OUString& rName ) throw( css::uno::RuntimeException );
 
     // Attributes
     virtual OUString SAL_CALL getName() throw (css::uno::RuntimeException, std::exception) override;
@@ -90,7 +89,6 @@ public:
 
 private:
     OUString maName;
-    sal_Int32 mnType;
 };
 
 #endif // INCLUDED_VBAHELPER_SOURCE_VBAHELPER_VBACOMMANDBAR_HXX
diff --git a/vbahelper/source/vbahelper/vbacommandbars.cxx b/vbahelper/source/vbahelper/vbacommandbars.cxx
index 8c579f96cb51..33ca3d3243f9 100644
--- a/vbahelper/source/vbahelper/vbacommandbars.cxx
+++ b/vbahelper/source/vbahelper/vbacommandbars.cxx
@@ -122,7 +122,7 @@ ScVbaCommandBars::createCollectionObject( const uno::Any& aSource )
             else if( sBarName.equalsIgnoreAsciiCase( "Cell" ) )
             {
                 // EVIL HACK (tm): spreadsheet cell context menu as dummy object without functionality
-                aRet <<= uno::Reference< XCommandBar >( new VbaDummyCommandBar( this, mxContext, sBarName, office::MsoBarType::msoBarTypePopup ) );
+                aRet <<= uno::Reference< XCommandBar >( new VbaDummyCommandBar( this, mxContext, sBarName ) );
             }
         }
         else if( m_pCBarHelper->getModuleId() == "com.sun.star.text.TextDocument" )