diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-30 15:24:30 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-30 21:04:40 +0200 |
| commit | 83d8331581ab43cf35325ca674cf62d4ba5dc5ad (patch) | |
| tree | 052e506efe8c6dbf2eb59935768aca7f781bfa92 /uui | |
| parent | c90da566ed1026a70217ac8a52a90e5df5c3026e (diff) | |
loplugin:stringloop in svgio..xmlsecurity
Change-Id: I1b2fe5674c8350690efc3d3219b9273cc61d5b0c
Reviewed-on: https://gerrit.libreoffice.org/58332
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'uui')
| -rw-r--r-- | uui/source/iahndl.cxx | 9 | ||||
| -rw-r--r-- | uui/source/secmacrowarnings.cxx | 9 |
2 files changed, 8 insertions, 10 deletions
diff --git a/uui/source/iahndl.cxx b/uui/source/iahndl.cxx index 16fd450ce05c..2aec43bf5979 100644 --- a/uui/source/iahndl.cxx +++ b/uui/source/iahndl.cxx @@ -413,15 +413,14 @@ UUIInteractionHelper::handleRequest_impl( = aModSizeException.Names; if ( sModules.getLength() ) { - OUString aName; + OUStringBuffer aName; for ( sal_Int32 index=0; index< sModules.getLength(); ++index ) { if ( index ) - aName += "," + sModules[index]; - else - aName = sModules[index]; // 1st name + aName.append(","); + aName.append(sModules[index]); } - aArguments.push_back( aName ); + aArguments.push_back( aName.makeStringAndClear() ); } handleErrorHandlerRequest( task::InteractionClassification_WARNING, ERRCODE_UUI_IO_MODULESIZEEXCEEDED, diff --git a/uui/source/secmacrowarnings.cxx b/uui/source/secmacrowarnings.cxx index 1233ced8c86c..3030ab92520a 100644 --- a/uui/source/secmacrowarnings.cxx +++ b/uui/source/secmacrowarnings.cxx @@ -160,16 +160,15 @@ void MacroWarning::SetStorage( const css::uno::Reference < css::embed::XStorage { mpInfos = &rInfos; OUString aCN_Id("CN"); - OUString s; - s = GetContentPart( rInfos[ 0 ].Signer->getSubjectName(), aCN_Id ); + OUStringBuffer s = GetContentPart( rInfos[ 0 ].Signer->getSubjectName(), aCN_Id ); for( sal_Int32 i = 1 ; i < nCnt ; ++i ) { - s += "\n"; - s += GetContentPart( rInfos[ i ].Signer->getSubjectName(), aCN_Id ); + s.append("\n"); + s.append(GetContentPart( rInfos[ i ].Signer->getSubjectName(), aCN_Id )); } - mxSignsFI->set_label(s); + mxSignsFI->set_label(s.makeStringAndClear()); mxViewSignsBtn->set_sensitive(true); } } |