clang-tidy performance-unnecessary-value-param

Change-Id: I69247498e13331f6ef84afeb242479f8fb1178a8
Reviewed-on: https://gerrit.libreoffice.org/60068
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2 files changed, 32 insertions, 39 deletions

diff --git a/ucb/source/ucp/file/filtask.cxx b/ucb/source/ucp/file/filtask.cxx
index 474942bb6040..71ca460b160e 100644
--- a/ucb/source/ucp/file/filtask.cxx
+++ b/ucb/source/ucp/file/filtask.cxx
@@ -2619,9 +2619,8 @@ TaskManager::getContentDeletedEventListeners( const OUString& aName )
     return listeners;
 }
 
-
-void
-TaskManager::notifyInsert( std::vector< std::unique_ptr<ContentEventNotifier> > listeners, const OUString& aChildName )
+void TaskManager::notifyInsert(const std::vector<std::unique_ptr<ContentEventNotifier>>& listeners,
+                               const OUString& aChildName)
 {
     for (const auto & l : listeners )
     {
@@ -2629,9 +2628,8 @@ TaskManager::notifyInsert( std::vector< std::unique_ptr<ContentEventNotifier> >
     }
 }
 
-
-void
-TaskManager::notifyContentDeleted( std::vector< std::unique_ptr< ContentEventNotifier> > listeners )
+void TaskManager::notifyContentDeleted(
+    const std::vector<std::unique_ptr<ContentEventNotifier>>& listeners)
 {
     for( auto const & l : listeners )
     {
@@ -2639,10 +2637,8 @@ TaskManager::notifyContentDeleted( std::vector< std::unique_ptr< ContentEventNot
     }
 }
 
-
-void
-TaskManager::notifyContentRemoved( std::vector< std::unique_ptr<ContentEventNotifier> > listeners,
-                             const OUString& aChildName )
+void TaskManager::notifyContentRemoved(
+    const std::vector<std::unique_ptr<ContentEventNotifier>>& listeners, const OUString& aChildName)
 {
     for( auto const & l : listeners )
     {
@@ -2672,10 +2668,9 @@ TaskManager::getPropertySetListeners( const OUString& aName )
     return listeners;
 }
 
-
-void
-TaskManager::notifyPropertyAdded( std::vector< std::unique_ptr< PropertySetInfoChangeNotifier > > listeners,
-                            const OUString& aPropertyName )
+void TaskManager::notifyPropertyAdded(
+    const std::vector<std::unique_ptr<PropertySetInfoChangeNotifier>>& listeners,
+    const OUString& aPropertyName)
 {
     for( auto const & l : listeners )
     {
@@ -2683,10 +2678,9 @@ TaskManager::notifyPropertyAdded( std::vector< std::unique_ptr< PropertySetInfoC
     }
 }
 
-
-void
-TaskManager::notifyPropertyRemoved( std::vector< std::unique_ptr< PropertySetInfoChangeNotifier > > listeners,
-                              const OUString& aPropertyName )
+void TaskManager::notifyPropertyRemoved(
+    const std::vector<std::unique_ptr<PropertySetInfoChangeNotifier>>& listeners,
+    const OUString& aPropertyName)
 {
     for( auto const & l : listeners )
     {
@@ -2781,9 +2775,8 @@ TaskManager::getContentExchangedEventListeners( const OUString& aOldPrefix,
     return aVector;
 }
 
-
-void
-TaskManager::notifyContentExchanged( std::vector< std::unique_ptr< ContentEventNotifier > > listeners_vec )
+void TaskManager::notifyContentExchanged(
+    const std::vector<std::unique_ptr<ContentEventNotifier>>& listeners_vec)
 {
     for( auto & l : listeners_vec)
     {
@@ -2813,9 +2806,9 @@ TaskManager::getPropertyChangeNotifier( const OUString& aName )
     return listeners;
 }
 
-
-void TaskManager::notifyPropertyChanges( std::vector< std::unique_ptr< PropertyChangeNotifier > > listeners,
-                                            const uno::Sequence< beans::PropertyChangeEvent >& seqChanged )
+void TaskManager::notifyPropertyChanges(
+    const std::vector<std::unique_ptr<PropertyChangeNotifier>>& listeners,
+    const uno::Sequence<beans::PropertyChangeEvent>& seqChanged)
 {
     for( auto const & l : listeners )
     {
diff --git a/ucb/source/ucp/file/filtask.hxx b/ucb/source/ucp/file/filtask.hxx
index 6b151c2d45f3..6b0e5963ad04 100644
--- a/ucb/source/ucp/file/filtask.hxx
+++ b/ucb/source/ucp/file/filtask.hxx
@@ -536,30 +536,30 @@ namespace fileaccess
         /********************************************************************************/
 
         static void notifyPropertyChanges(
-            std::vector< std::unique_ptr< PropertyChangeNotifier > > listeners,
-            const css::uno::Sequence< css::beans::PropertyChangeEvent >& seqChanged );
+            const std::vector<std::unique_ptr<PropertyChangeNotifier>>& listeners,
+            const css::uno::Sequence<css::beans::PropertyChangeEvent>& seqChanged);
 
         static void notifyContentExchanged(
-            std::vector< std::unique_ptr< ContentEventNotifier > > listeners_vec );
+            const std::vector<std::unique_ptr<ContentEventNotifier>>& listeners_vec);
 
-        static void notifyInsert(
-            std::vector< std::unique_ptr< ContentEventNotifier > > listeners, const OUString& aChildName );
+        static void
+        notifyInsert(const std::vector<std::unique_ptr<ContentEventNotifier>>& listeners,
+                     const OUString& aChildName);
 
-        static void notifyContentDeleted(
-            std::vector< std::unique_ptr< ContentEventNotifier > > listeners );
+        static void
+        notifyContentDeleted(const std::vector<std::unique_ptr<ContentEventNotifier>>& listeners);
 
-        static void notifyContentRemoved(
-            std::vector< std::unique_ptr< ContentEventNotifier > > listeners,
-            const OUString& aChildName );
+        static void
+        notifyContentRemoved(const std::vector<std::unique_ptr<ContentEventNotifier>>& listeners,
+                             const OUString& aChildName);
 
         static void notifyPropertyAdded(
-            std::vector< std::unique_ptr< PropertySetInfoChangeNotifier > > listeners,
-            const OUString& aPropertyName );
+            const std::vector<std::unique_ptr<PropertySetInfoChangeNotifier>>& listeners,
+            const OUString& aPropertyName);
 
         static void notifyPropertyRemoved(
-            std::vector< std::unique_ptr< PropertySetInfoChangeNotifier > > listeners,
-            const OUString& aPropertyName );
-
+            const std::vector<std::unique_ptr<PropertySetInfoChangeNotifier>>& listeners,
+            const OUString& aPropertyName);
 
         /********************************************************************************/
         /*                       remove persistent propertyset                          */