loplugin:sequenceloop in ucb..unotools

Change-Id: Ie52d993c185ba43386b494baad0a484d5b365499
Reviewed-on: https://gerrit.libreoffice.org/77532
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

10 files changed, 16 insertions, 16 deletions

diff --git a/ucb/source/core/FileAccess.cxx b/ucb/source/core/FileAccess.cxx
index 3f501ee576b8..0a6ec8759b2f 100644
--- a/ucb/source/core/FileAccess.cxx
+++ b/ucb/source/core/FileAccess.cxx
@@ -354,7 +354,7 @@ void OFileAccess::createFolder( const OUString& NewFolderURL )
 
     ucbhelper::Content aCnt( aURL.GetMainURL( INetURLObject::DecodeMechanism::NONE ), mxEnvironment.get(), comphelper::getProcessComponentContext() );
 
-    Sequence< ContentInfo > aInfo = aCnt.queryCreatableContentsInfo();
+    const Sequence< ContentInfo > aInfo = aCnt.queryCreatableContentsInfo();
 
     for ( const ContentInfo & rCurr : aInfo )
     {
@@ -586,7 +586,7 @@ bool OFileAccess::createNewFile( const OUString & rParentURL,
 {
     ucbhelper::Content aParentCnt( rParentURL, mxEnvironment.get(), comphelper::getProcessComponentContext() );
 
-    Sequence< ContentInfo > aInfo = aParentCnt.queryCreatableContentsInfo();
+    const Sequence< ContentInfo > aInfo = aParentCnt.queryCreatableContentsInfo();
 
     for ( const ContentInfo & rCurr : aInfo )
     {
diff --git a/ucb/source/core/ucb.cxx b/ucb/source/core/ucb.cxx
index 6e28cd18fc9a..84eb2f61fe24 100644
--- a/ucb/source/core/ucb.cxx
+++ b/ucb/source/core/ucb.cxx
@@ -864,7 +864,7 @@ bool UniversalContentBroker::getContentProviderData(
         uno::Reference< container::XNameAccess > xNameAccess(
                                             xInterface, uno::UNO_QUERY_THROW );
 
-        uno::Sequence< OUString > aElems = xNameAccess->getElementNames();
+        const uno::Sequence< OUString > aElems = xNameAccess->getElementNames();
 
         if ( aElems.hasElements() )
         {
diff --git a/ucb/source/core/ucbstore.cxx b/ucb/source/core/ucbstore.cxx
index 010418323eae..23299e1fa348 100644
--- a/ucb/source/core/ucbstore.cxx
+++ b/ucb/source/core/ucbstore.cxx
@@ -701,7 +701,7 @@ void PropertySetRegistry::renamePropertySet( const OUString& rOldKey,
                     }
 
                     // Obtain property names.
-                    Sequence< OUString > aElems
+                    const Sequence< OUString > aElems
                                     = xOldNameAccess->getElementNames();
                     if ( aElems.hasElements() )
                     {
diff --git a/ucb/source/ucp/cmis/cmis_content.cxx b/ucb/source/ucp/cmis/cmis_content.cxx
index c51459a4b417..e71d077727fc 100644
--- a/ucb/source/ucp/cmis/cmis_content.cxx
+++ b/ucb/source/ucp/cmis/cmis_content.cxx
@@ -589,7 +589,7 @@ namespace cmis
         iCmisProps >>= aPropsSeq;
         map< string, libcmis::PropertyPtr > aProperties;
 
-        for ( const auto& rProp : aPropsSeq )
+        for ( const auto& rProp : std::as_const(aPropsSeq) )
         {
             std::string id = OUSTR_TO_STDSTR( rProp.Id );
             libcmis::PropertyPtr prop = lcl_unoToCmisProperty( rProp );
diff --git a/ucb/source/ucp/ext/ucpext_datasupplier.cxx b/ucb/source/ucp/ext/ucpext_datasupplier.cxx
index 1f4543b22959..4fdfef7bbc49 100644
--- a/ucb/source/ucp/ext/ucpext_datasupplier.cxx
+++ b/ucb/source/ucp/ext/ucpext_datasupplier.cxx
@@ -126,7 +126,7 @@ namespace ucb { namespace ucp { namespace ext
             {
             case E_ROOT:
             {
-                Sequence< Sequence< OUString > > aExtensionInfo( xPackageInfo->getExtensionList() );
+                const Sequence< Sequence< OUString > > aExtensionInfo( xPackageInfo->getExtensionList() );
                 for ( auto const & extInfo : aExtensionInfo )
                 {
                     if ( !extInfo.hasElements() )
diff --git a/ucb/source/ucp/file/bc.cxx b/ucb/source/ucp/file/bc.cxx
index 9e17496bd7d9..7bc6e9d1d93a 100644
--- a/ucb/source/ucp/file/bc.cxx
+++ b/ucb/source/ucp/file/bc.cxx
@@ -1243,7 +1243,7 @@ BaseContent::cPCL()
     if (!m_pPropertyListener)
         return nullptr;
 
-    Sequence< OUString > seqNames = m_pPropertyListener->getContainedTypes();
+    const Sequence< OUString > seqNames = m_pPropertyListener->getContainedTypes();
 
     std::unique_ptr<PropertyChangeNotifier> p;
 
diff --git a/ucb/source/ucp/file/filnot.cxx b/ucb/source/ucp/file/filnot.cxx
index 6c199770e59b..ba33e6662bfa 100644
--- a/ucb/source/ucp/file/filnot.cxx
+++ b/ucb/source/ucp/file/filnot.cxx
@@ -220,7 +220,7 @@ void PropertyChangeNotifier::notifyPropertyChanged(
     // notify listeners for all Events
 
     uno::Sequence< uno::Reference< uno::XInterface > > seqList = (*m_pListeners)[ OUString() ];
-    for( const auto& rListener : seqList )
+    for( const auto& rListener : std::as_const(seqList) )
     {
         uno::Reference< beans::XPropertiesChangeListener > aListener( rListener,uno::UNO_QUERY );
         if( aListener.is() )
@@ -230,12 +230,12 @@ void PropertyChangeNotifier::notifyPropertyChanged(
     }
 
     uno::Sequence< beans::PropertyChangeEvent > seq(1);
-    for( const auto& rChange : Changes )
+    for( const auto& rChange : std::as_const(Changes) )
     {
         seq[0] = rChange;
         seqList = (*m_pListeners)[ rChange.PropertyName ];
 
-        for( const auto& rListener : seqList )
+        for( const auto& rListener : std::as_const(seqList) )
         {
             uno::Reference< beans::XPropertiesChangeListener > aListener( rListener,uno::UNO_QUERY );
             if( aListener.is() )
diff --git a/ucb/source/ucp/file/filtask.cxx b/ucb/source/ucp/file/filtask.cxx
index 432d18b4bb9a..633b7d2c87b9 100644
--- a/ucb/source/ucp/file/filtask.cxx
+++ b/ucb/source/ucp/file/filtask.cxx
@@ -2212,7 +2212,7 @@ TaskManager::load( const ContentMap::iterator& it, bool create )
             // Now put in all values in the storage in the local hash;
 
             PropertySet& properties = it->second.properties;
-            uno::Sequence< beans::Property > seq = xS->getPropertySetInfo()->getProperties();
+            const uno::Sequence< beans::Property > seq = xS->getPropertySetInfo()->getProperties();
 
             for( const auto& rProp : seq )
             {
@@ -2821,7 +2821,7 @@ TaskManager::erasePersistentSet( const OUString& aUnqPath,
     }
 
     uno::Reference< container::XNameAccess > xName( m_xFileRegistry,uno::UNO_QUERY );
-    uno::Sequence< OUString > seqNames = xName->getElementNames();
+    const uno::Sequence< OUString > seqNames = xName->getElementNames();
 
     OUString old_Name = aUnqPath;
 
@@ -2853,7 +2853,7 @@ TaskManager::copyPersistentSetWithoutChildren( const OUString& srcUnqPath,
     if( ! x_src.is() )
         return;
 
-    uno::Sequence< beans::Property > seqProperty =
+    const uno::Sequence< beans::Property > seqProperty =
         x_src->getPropertySetInfo()->getProperties();
 
     if( ! seqProperty.hasElements() )
@@ -2890,7 +2890,7 @@ TaskManager::copyPersistentSet( const OUString& srcUnqPath,
     }
 
     uno::Reference< container::XNameAccess > xName( m_xFileRegistry,uno::UNO_QUERY );
-    uno::Sequence< OUString > seqNames = xName->getElementNames();
+    const uno::Sequence< OUString > seqNames = xName->getElementNames();
 
     OUString new_Name;
 
diff --git a/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx b/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx
index fa2a36483891..f0576e049aad 100644
--- a/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx
+++ b/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx
@@ -1081,7 +1081,7 @@ void DAVResourceAccess::getUserRequestHeaders(
 
         if ( xDAVEnv.is() )
         {
-            uno::Sequence< beans::StringPair > aRequestHeaders
+            const uno::Sequence< beans::StringPair > aRequestHeaders
                 = xDAVEnv->getUserRequestHeaders( rURI, eMethod );
 
             for ( const auto& rRequestHeader : aRequestHeaders )
diff --git a/ucb/source/ucp/webdav-neon/webdavcontent.cxx b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
index 92534b376201..b360f300265a 100644
--- a/ucb/source/ucp/webdav-neon/webdavcontent.cxx
+++ b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
@@ -2958,7 +2958,7 @@ Content::ResourceType Content::resourceTypeForLocks(
             if ( m_xCachedProps->getValue( DAVProperties::SUPPORTEDLOCK )
                  >>= aSupportedLocks )            //get the cached value for supportedlock
             {
-                for ( const auto& rSupportedLock : aSupportedLocks )
+                for ( const auto& rSupportedLock : std::as_const(aSupportedLocks) )
                 {
                     if ( rSupportedLock.Scope
                          == ucb::LockScope_EXCLUSIVE &&