diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-25 13:56:25 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-26 08:31:29 +0200 |
| commit | ee025b744ac9efafe7c083ed80f8e2cc7cb3e2c1 (patch) | |
| tree | 8f0cfa9aa54a3d1ada4596851782db6439bfffd7 /tools | |
| parent | 1c56d5fec2ddd9f68aaaf21e9dbe287db893c092 (diff) | |
loplugin:returnconstant in tools,comphelper,unotools
Change-Id: Iabc3c67b4cdcd0344a37c533bf92dd00cd4700d8
Reviewed-on: https://gerrit.libreoffice.org/57974
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/source/fsys/urlobj.cxx | 5 | ||||
| -rw-r--r-- | tools/source/generic/b3dtrans.cxx | 6 | ||||
| -rw-r--r-- | tools/source/stream/stream.cxx | 3 |
3 files changed, 5 insertions, 9 deletions
diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx index c8719b6732b3..7c326a601911 100644 --- a/tools/source/fsys/urlobj.cxx +++ b/tools/source/fsys/urlobj.cxx @@ -3304,17 +3304,16 @@ bool INetURLObject::insertName(OUString const & rTheName, RTL_TEXTENCODING_UTF8); } -bool INetURLObject::clearQuery() +void INetURLObject::clearQuery() { if (HasError()) - return false; + return; if (m_aQuery.isPresent()) { lcl_Erase(m_aAbsURIRef, m_aQuery.getBegin() - 1, m_aQuery.getLength() + 1); m_aFragment += m_aQuery.clear() - 1; } - return false; } bool INetURLObject::setQuery(OUString const & rTheQuery, diff --git a/tools/source/generic/b3dtrans.cxx b/tools/source/generic/b3dtrans.cxx index f2210705112a..184b6a1ff8bc 100644 --- a/tools/source/generic/b3dtrans.cxx +++ b/tools/source/generic/b3dtrans.cxx @@ -429,8 +429,7 @@ void B3dCamera::CalcNewViewportValues() aNewVUV.normalize(); SetViewportValues(aPosition, aNewVPN, aNewVUV); - if(CalcFocalLength()) - SetViewportValues(aCorrectedPosition, aNewVPN, aNewVUV); + CalcFocalLength(); if(fBankAngle != 0.0) { @@ -444,7 +443,7 @@ void B3dCamera::CalcNewViewportValues() } } -bool B3dCamera::CalcFocalLength() +void B3dCamera::CalcFocalLength() { double fWidth = GetDeviceRectangleWidth(); @@ -455,7 +454,6 @@ bool B3dCamera::CalcFocalLength() fFocalLength = aOldPosition.getZ() / fWidth * 35.0; if(fFocalLength < 5.0) fFocalLength = 5.0; - return false; } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/tools/source/stream/stream.cxx b/tools/source/stream/stream.cxx index a51a25dff991..e5a36ac893c5 100644 --- a/tools/source/stream/stream.cxx +++ b/tools/source/stream/stream.cxx @@ -1500,7 +1500,7 @@ std::size_t SvStream::CryptAndWriteBuffer( const void* pStart, std::size_t nLen) return nCount; } -bool SvStream::EncryptBuffer(void* pStart, std::size_t nLen) const +void SvStream::EncryptBuffer(void* pStart, std::size_t nLen) const { unsigned char* pTemp = static_cast<unsigned char*>(pStart); unsigned char nMask = m_nCryptMask; @@ -1512,7 +1512,6 @@ bool SvStream::EncryptBuffer(void* pStart, std::size_t nLen) const aCh ^= nMask; *pTemp = aCh; } - return true; } static unsigned char implGetCryptMask(const sal_Char* pStr, sal_Int32 nLen, long nVersion) |