summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2011-12-21 10:30:10 +0000
committerCaolán McNamara <caolanm@redhat.com>2011-12-21 10:30:10 +0000
commit6708977331c933b3483b9fe5f66d981b51fd8d49 (patch)
tree150a2ad7ed1b49df70ee7c814edf60d5147c043d /tools
parentfffae28952f20fed693df4de8b8645cf0aedabfa (diff)
needs more work first
Diffstat (limited to 'tools')
-rw-r--r--tools/inc/tools/inetmsg.hxx96
-rw-r--r--tools/inc/tools/stream.hxx59
-rw-r--r--tools/qa/cppunit/test_stream.cxx59
-rw-r--r--tools/source/inet/inetmsg.cxx18
-rw-r--r--tools/source/inet/inetstrm.cxx2
-rw-r--r--tools/source/stream/stream.cxx36
6 files changed, 101 insertions, 169 deletions
diff --git a/tools/inc/tools/inetmsg.hxx b/tools/inc/tools/inetmsg.hxx
index 7c88b9c3aa7a..610b804e7502 100644
--- a/tools/inc/tools/inetmsg.hxx
+++ b/tools/inc/tools/inetmsg.hxx
@@ -51,7 +51,7 @@ class INetMessageHeader
ByteString m_aValue;
public:
- INetMessageHeader()
+ INetMessageHeader (void)
{}
INetMessageHeader (
@@ -64,7 +64,7 @@ public:
: m_aName (rHdr.m_aName), m_aValue (rHdr.m_aValue)
{}
- ~INetMessageHeader()
+ ~INetMessageHeader (void)
{}
INetMessageHeader& operator= (const INetMessageHeader& rHdr)
@@ -74,22 +74,22 @@ public:
return *this;
}
- const ByteString& GetName() const { return m_aName; }
- const ByteString& GetValue() const { return m_aValue; }
+ const ByteString& GetName (void) const { return m_aName; }
+ const ByteString& GetValue (void) const { return m_aValue; }
friend SvStream& operator<< (
SvStream& rStrm, const INetMessageHeader& rHdr)
{
- write_lenPrefixed_uInt8s_FromOString(rStrm, rHdr.m_aName);
- write_lenPrefixed_uInt8s_FromOString(rStrm, rHdr.m_aValue);
+ rStrm.WriteByteString (rHdr.m_aName);
+ rStrm.WriteByteString (rHdr.m_aValue);
return rStrm;
}
friend SvStream& operator>> (
SvStream& rStrm, INetMessageHeader& rHdr)
{
- rHdr.m_aName = read_lenPrefixed_uInt8s_ToOString(rStrm);
- rHdr.m_aValue = read_lenPrefixed_uInt8s_ToOString(rStrm);
+ rStrm.ReadByteString (rHdr.m_aName);
+ rStrm.ReadByteString (rHdr.m_aValue);
return rStrm;
}
};
@@ -108,7 +108,7 @@ class INetMessage
UniString m_aDocName;
SvLockBytesRef m_xDocLB;
- void ListCleanup_Impl();
+ void ListCleanup_Impl (void);
void ListCopy (const INetMessage& rMsg);
protected:
@@ -158,8 +158,8 @@ protected:
virtual SvStream& operator>> (SvStream& rStrm);
public:
- INetMessage() : m_nDocSize(0) {}
- virtual ~INetMessage();
+ INetMessage (void) : m_nDocSize(0) {}
+ virtual ~INetMessage (void);
INetMessage (const INetMessage& rMsg)
: m_nDocSize (rMsg.m_nDocSize),
@@ -178,7 +178,7 @@ public:
return *this;
}
- sal_uIntPtr GetHeaderCount() const { return m_aHeaderList.size(); }
+ sal_uIntPtr GetHeaderCount (void) const { return m_aHeaderList.size(); }
UniString GetHeaderName (sal_uIntPtr nIndex) const
{
@@ -204,13 +204,13 @@ public:
sal_uIntPtr nIndex = ((sal_uIntPtr)-1)
);
- sal_uIntPtr GetDocumentSize() const { return m_nDocSize; }
+ sal_uIntPtr GetDocumentSize (void) const { return m_nDocSize; }
void SetDocumentSize (sal_uIntPtr nSize) { m_nDocSize = nSize; }
- const UniString& GetDocumentName() const { return m_aDocName; }
+ const UniString& GetDocumentName (void) const { return m_aDocName; }
void SetDocumentName (const UniString& rName) { m_aDocName = rName; }
- SvLockBytes* GetDocumentLB() const { return m_xDocLB; }
+ SvLockBytes* GetDocumentLB (void) const { return m_xDocLB; }
void SetDocumentLB (SvLockBytes *pDocLB) { m_xDocLB = pDocLB; }
friend SvStream& operator<< (
@@ -260,9 +260,9 @@ protected:
virtual SvStream& operator>> (SvStream& rStrm);
public:
- INetRFC822Message();
+ INetRFC822Message (void);
INetRFC822Message (const INetRFC822Message& rMsg);
- virtual ~INetRFC822Message();
+ virtual ~INetRFC822Message (void);
INetRFC822Message& operator= (const INetRFC822Message& rMsg);
@@ -277,105 +277,105 @@ public:
/** Header fields.
*/
- UniString GetBCC() const
+ UniString GetBCC (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_BCC],
INetMIME::HEADER_FIELD_ADDRESS);
}
- UniString GetCC() const
+ UniString GetCC (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_CC],
INetMIME::HEADER_FIELD_ADDRESS);
}
- UniString GetComments() const
+ UniString GetComments (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_COMMENTS],
INetMIME::HEADER_FIELD_TEXT);
}
- UniString GetDate() const
+ UniString GetDate (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_DATE],
INetMIME::HEADER_FIELD_STRUCTURED);
}
- UniString GetFrom() const
+ UniString GetFrom (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_FROM],
INetMIME::HEADER_FIELD_ADDRESS);
}
- UniString GetInReplyTo() const
+ UniString GetInReplyTo (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_IN_REPLY_TO],
INetMIME::HEADER_FIELD_ADDRESS); // ??? MESSAGE_ID ???
}
- UniString GetKeywords() const
+ UniString GetKeywords (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_KEYWORDS],
INetMIME::HEADER_FIELD_PHRASE);
}
- UniString GetMessageID() const
+ UniString GetMessageID (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_MESSAGE_ID],
INetMIME::HEADER_FIELD_MESSAGE_ID);
}
- UniString GetReferences() const
+ UniString GetReferences (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_REFERENCES],
INetMIME::HEADER_FIELD_ADDRESS);
}
- UniString GetReplyTo() const
+ UniString GetReplyTo (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_REPLY_TO],
INetMIME::HEADER_FIELD_ADDRESS);
}
- UniString GetReturnPath() const
+ UniString GetReturnPath (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_RETURN_PATH],
INetMIME::HEADER_FIELD_ADDRESS);
}
- UniString GetReturnReceiptTo() const
+ UniString GetReturnReceiptTo (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_RETURN_RECEIPT_TO],
INetMIME::HEADER_FIELD_ADDRESS);
}
- UniString GetSender() const
+ UniString GetSender (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_SENDER],
INetMIME::HEADER_FIELD_ADDRESS);
}
- UniString GetSubject() const
+ UniString GetSubject (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_SUBJECT],
INetMIME::HEADER_FIELD_TEXT);
}
- UniString GetTo() const
+ UniString GetTo (void) const
{
return GetHeaderValue_Impl (
m_nIndex[INETMSG_RFC822_TO],
@@ -430,15 +430,15 @@ class TOOLS_DLLPUBLIC INetMIMEMessage : public INetRFC822Message
INetMIMEMessage* pParent;
INetMIMEMessgeList_impl aChildren;
- rtl::OString m_aBoundary;
+ ByteString m_aBoundary;
sal_Bool bHeaderParsed;
friend class INetMIMEMessageStream;
- const rtl::OString& GetMultipartBoundary() const { return m_aBoundary; }
- void SetMultipartBoundary (const rtl::OString& rBnd) { m_aBoundary = rBnd; }
+ const ByteString& GetMultipartBoundary (void) const { return m_aBoundary; }
+ void SetMultipartBoundary (const ByteString& rBnd) { m_aBoundary = rBnd; }
- void CleanupImp();
+ void CleanupImp (void);
void CopyImp (const INetMIMEMessage& rMsg);
void SetHeaderParsed() { bHeaderParsed = sal_True; }
@@ -447,9 +447,9 @@ protected:
virtual SvStream& operator>> (SvStream& rStrm);
public:
- INetMIMEMessage();
+ INetMIMEMessage (void);
INetMIMEMessage (const INetMIMEMessage& rMsg);
- virtual ~INetMIMEMessage();
+ virtual ~INetMIMEMessage (void);
INetMIMEMessage& operator= (const INetMIMEMessage& rMsg);
@@ -467,35 +467,35 @@ public:
/** Header fields.
*/
void SetMIMEVersion (const UniString& rVersion);
- UniString GetMIMEVersion() const
+ UniString GetMIMEVersion (void) const
{
return GetHeaderValue (m_nIndex[INETMSG_MIME_VERSION]);
}
- UniString GetContentDescription() const
+ UniString GetContentDescription (void) const
{
return GetHeaderValue (m_nIndex[INETMSG_MIME_CONTENT_DESCRIPTION]);
}
void SetContentDisposition (const UniString& rDisposition);
- UniString GetContentDisposition() const
+ UniString GetContentDisposition (void) const
{
return GetHeaderValue (m_nIndex[INETMSG_MIME_CONTENT_DISPOSITION]);
}
- UniString GetContentID() const
+ UniString GetContentID (void) const
{
return GetHeaderValue (m_nIndex[INETMSG_MIME_CONTENT_ID]);
}
void SetContentType (const UniString& rType);
- UniString GetContentType() const
+ UniString GetContentType (void) const
{
return GetHeaderValue (m_nIndex[INETMSG_MIME_CONTENT_TYPE]);
}
void SetContentTransferEncoding (const UniString& rEncoding);
- UniString GetContentTransferEncoding() const
+ UniString GetContentTransferEncoding (void) const
{
return GetHeaderValue (m_nIndex[INETMSG_MIME_CONTENT_TRANSFER_ENCODING]);
}
@@ -504,16 +504,16 @@ public:
/** Message container methods.
*/
- sal_Bool IsContainer() const
+ sal_Bool IsContainer (void) const
{
return (IsMessage() || IsMultipart());
}
- sal_Bool IsMessage() const
+ sal_Bool IsMessage (void) const
{
UniString aType (GetContentType());
return (aType.CompareIgnoreCaseToAscii("message/", 8) == 0);
}
- sal_Bool IsMultipart() const
+ sal_Bool IsMultipart (void) const
{
UniString aType (GetContentType());
return (aType.CompareIgnoreCaseToAscii("multipart/", 10) == 0);
@@ -523,7 +523,7 @@ public:
{
return ( nIndex < aChildren.size() ) ? aChildren[ nIndex ] : NULL;
}
- INetMIMEMessage* GetParent() const { return pParent; }
+ INetMIMEMessage* GetParent (void) const { return pParent; }
sal_Bool EnableAttachChild (
INetMessageContainerType eType = INETMSG_MULTIPART_MIXED);
diff --git a/tools/inc/tools/stream.hxx b/tools/inc/tools/stream.hxx
index e6e939bbbd1b..66312b76faaf 100644
--- a/tools/inc/tools/stream.hxx
+++ b/tools/inc/tools/stream.hxx
@@ -28,7 +28,6 @@
#ifndef _STREAM_HXX
#define _STREAM_HXX
-#include <limits>
#include "tools/toolsdllapi.h"
#include <tools/solar.h>
#include <tools/string.hxx>
@@ -365,8 +364,10 @@ public:
SvStream& ReadByteString( UniString& rStr, rtl_TextEncoding eSrcCharSet );
SvStream& ReadByteString( UniString& rStr ) { return ReadByteString( rStr, GetStreamCharSet() ); }
+ SvStream& ReadByteString( ByteString& rStr );
SvStream& WriteByteString( const UniString& rStr, rtl_TextEncoding eDestCharSet );
SvStream& WriteByteString( const UniString& rStr ) { return WriteByteString( rStr, GetStreamCharSet() ); }
+ SvStream& WriteByteString( const ByteString& rStr );
SvStream& WriteNumber( sal_uInt32 nUInt32 );
SvStream& WriteNumber( sal_Int32 nInt32 );
@@ -545,70 +546,22 @@ TOOLS_DLLPUBLIC SvStream& endlub( SvStream& rStr );
//Attempt to read nLen 8bit units to an OString, returned rtl::OString's length
//is number of units successfully read
-TOOLS_DLLPUBLIC rtl::OString read_uInt8s_ToOString(SvStream& rStrm, sal_Size nLen);
+TOOLS_DLLPUBLIC rtl::OString read_uInt8s_AsOString(SvStream& rStr, sal_Size nLen);
//Attempt to read nLen little endian 16bit units to an OUString, returned
//rtl::OUString's length is number of units successfully read
-TOOLS_DLLPUBLIC rtl::OUString read_LEuInt16s_ToOUString(SvStream& rStrm, sal_Size nLen);
+TOOLS_DLLPUBLIC rtl::OUString read_LEuInt16s_AsOUString(SvStream& rStr, sal_Size nLen);
//Attempt to read 8bit units to an OString until a zero terminator is
//encountered, returned rtl::OString's length is number of units *definitely*
//successfully read, check SvStream::good() to see if null terminator was
//sucessfully read
-TOOLS_DLLPUBLIC rtl::OString read_zeroTerminated_uInt8s_ToOString(SvStream& rStrm);
+TOOLS_DLLPUBLIC rtl::OString read_zeroTerminated_uInt8s_AsOString(SvStream& rStr);
//Attempt to read 8bit units assuming source encoding eEnc to an OUString until
//a zero terminator is encountered. Check SvStream::good() to see if null
//terminator was sucessfully read
-TOOLS_DLLPUBLIC rtl::OUString read_zeroTerminated_uInt8s_ToOUString(SvStream& rStrm, rtl_TextEncoding eEnc);
-
-//Attempt to read a pascal-style length (of type prefix) prefixed sequence of
-//8bit units to an OString, returned rtl::OString's length is number of units
-//successfully read.
-template<typename prefix=sal_uInt16> rtl::OString read_lenPrefixed_uInt8s_ToOString(SvStream& rStrm)
-{
- prefix nLen = 0;
- rStrm >> nLen;
- return read_uInt8s_ToOString(rStrm, nLen);
-}
-
-//Attempt to read a pascal-style length (of type prefix) prefixed sequence of
-//8bit units to an OUString
-template<typename prefix=sal_uInt16> rtl::OUString read_lenPrefixed_uInt8s_ToOUString(SvStream& rStrm,
- rtl_TextEncoding eEnc)
-{
- return rtl::OStringToOUString(read_lenPrefixed_uInt8s_ToOString<prefix>(rStrm), eEnc);
-}
-
-//Attempt to write a pascal-style length (of type prefix) prefixed sequence of
-//8bit units from an OString, returned value is number of bytes written (including
-//byte-count of prefix)
-template<typename prefix=sal_uInt16> sal_Size write_lenPrefixed_uInt8s_FromOString(SvStream& rStrm,
- const rtl::OString &rStr)
-{
- SAL_WARN_IF(rStr.getLength() > std::numeric_limits<prefix>::max(),
- "tools.stream",
- "string too long for prefix count to fit in output type");
-
- sal_Size nWritten = 0;
- prefix nLen = std::min<sal_Size>(rStr.getLength(), std::numeric_limits<prefix>::max());
- rStrm << nLen;
- if (rStrm.good())
- {
- nWritten += sizeof(prefix);
- nWritten += rStrm.Write(rStr.getStr(), nLen);
- }
- return nWritten;
-}
-
-//Attempt to write a pascal-style length (of type prefix) prefixed sequence of
-//8bit units from an OUString, returned value is number of bytes written (including
-//byte-count of prefix)
-template<typename prefix=sal_uInt16> sal_Size write_lenPrefixed_uInt8s_FromOUString(SvStream& rStrm,
- const rtl::OUString &rStr, rtl_TextEncoding eEnc)
-{
- return write_lenPrefixed_uInt8s_FromOString<prefix>(rStrm, rtl::OUStringToOString(rStr, eEnc));
-}
+TOOLS_DLLPUBLIC rtl::OUString read_zeroTerminated_uInt8s_AsOUString(SvStream& rStr, rtl_TextEncoding eEnc);
// --------------
// - FileStream -
diff --git a/tools/qa/cppunit/test_stream.cxx b/tools/qa/cppunit/test_stream.cxx
index 3e7580f40377..77c2b9ed75ae 100644
--- a/tools/qa/cppunit/test_stream.cxx
+++ b/tools/qa/cppunit/test_stream.cxx
@@ -47,13 +47,11 @@ namespace
void test_stdstream();
void test_fastostring();
void test_read_cstring();
- void test_read_pstring();
CPPUNIT_TEST_SUITE(Test);
CPPUNIT_TEST(test_stdstream);
CPPUNIT_TEST(test_fastostring);
CPPUNIT_TEST(test_read_cstring);
- CPPUNIT_TEST(test_read_pstring);
CPPUNIT_TEST_SUITE_END();
};
@@ -69,7 +67,7 @@ namespace
char tools_a(78);
aMemStream >> tools_a;
- CPPUNIT_ASSERT(tools_a == 'f');
+ CPPUNIT_ASSERT(std_a == 'f');
iss.seekg(0, std::ios_base::end);
//seeking to end doesn't set eof, reading past eof does
@@ -100,7 +98,7 @@ namespace
//a failed read doesn't change the data, it remains unchanged
CPPUNIT_ASSERT(tools_a == 78);
//nothing wrong with the stream, so not bad
- CPPUNIT_ASSERT(!aMemStream.bad());
+ CPPUNIT_ASSERT(!aMemStream.GetError());
//yet, the read didn't succeed
CPPUNIT_ASSERT(!aMemStream.good());
@@ -135,18 +133,18 @@ namespace
char foo[] = "foobar";
SvMemoryStream aMemStream(RTL_CONSTASCII_STRINGPARAM(foo), STREAM_READ);
- rtl::OString aOne = read_uInt8s_ToOString(aMemStream, 3);
+ rtl::OString aOne = read_uInt8s_AsOString(aMemStream, 3);
CPPUNIT_ASSERT(aOne.equalsL(RTL_CONSTASCII_STRINGPARAM("foo")));
- rtl::OString aTwo = read_uInt8s_ToOString(aMemStream, 3);
+ rtl::OString aTwo = read_uInt8s_AsOString(aMemStream, 3);
CPPUNIT_ASSERT(aTwo.equalsL(RTL_CONSTASCII_STRINGPARAM("bar")));
- rtl::OString aThree = read_uInt8s_ToOString(aMemStream, 3);
+ rtl::OString aThree = read_uInt8s_AsOString(aMemStream, 3);
CPPUNIT_ASSERT(!aThree.getLength());
aMemStream.Seek(0);
- rtl::OString aFour = read_uInt8s_ToOString(aMemStream, 100);
+ rtl::OString aFour = read_uInt8s_AsOString(aMemStream, 100);
CPPUNIT_ASSERT(aFour.equalsL(RTL_CONSTASCII_STRINGPARAM(foo)));
}
@@ -155,7 +153,7 @@ namespace
char foo[] = "foobar";
SvMemoryStream aMemStream(RTL_CONSTASCII_STRINGPARAM(foo), STREAM_READ);
- rtl::OString aOne = read_zeroTerminated_uInt8s_ToOString(aMemStream);
+ rtl::OString aOne = read_zeroTerminated_uInt8s_AsOString(aMemStream);
CPPUNIT_ASSERT(aOne.equalsL(RTL_CONSTASCII_STRINGPARAM("foobar")));
CPPUNIT_ASSERT(!aMemStream.good());
CPPUNIT_ASSERT(!aMemStream.bad());
@@ -163,52 +161,11 @@ namespace
aMemStream.Seek(0);
foo[3] = 0;
- rtl::OString aTwo = read_zeroTerminated_uInt8s_ToOString(aMemStream);
+ rtl::OString aTwo = read_zeroTerminated_uInt8s_AsOString(aMemStream);
CPPUNIT_ASSERT(aTwo.equalsL(RTL_CONSTASCII_STRINGPARAM("foo")));
CPPUNIT_ASSERT(aMemStream.good());
}
- void Test::test_read_pstring()
- {
- char foo[] = "\3foobar";
- SvMemoryStream aMemStream(RTL_CONSTASCII_STRINGPARAM(foo), STREAM_READ);
-
- rtl::OString aFoo = read_lenPrefixed_uInt8s_ToOString<sal_uInt8>(aMemStream);
- CPPUNIT_ASSERT(aFoo.equalsL(RTL_CONSTASCII_STRINGPARAM("foo")));
- CPPUNIT_ASSERT(aMemStream.good());
- CPPUNIT_ASSERT(!aMemStream.bad());
- CPPUNIT_ASSERT(!aMemStream.eof());
-
- aMemStream.Seek(0);
- foo[0] = 10;
- aFoo = read_lenPrefixed_uInt8s_ToOString<sal_uInt8>(aMemStream);
- CPPUNIT_ASSERT(aFoo.equalsL(RTL_CONSTASCII_STRINGPARAM("foobar")));
- CPPUNIT_ASSERT(!aMemStream.good());
- CPPUNIT_ASSERT(!aMemStream.bad());
- CPPUNIT_ASSERT(aMemStream.eof());
-
- aMemStream.SetNumberFormatInt(NUMBERFORMAT_INT_BIGENDIAN);
- aMemStream.Seek(0);
- foo[0] = 0;
- foo[1] = 3;
- aFoo = read_lenPrefixed_uInt8s_ToOString<sal_uInt16>(aMemStream);
- CPPUNIT_ASSERT(aFoo.equalsL(RTL_CONSTASCII_STRINGPARAM("oob")));
- CPPUNIT_ASSERT(aMemStream.good());
- CPPUNIT_ASSERT(!aMemStream.bad());
- CPPUNIT_ASSERT(!aMemStream.eof());
-
- aMemStream.SetNumberFormatInt(NUMBERFORMAT_INT_LITTLEENDIAN);
- aMemStream.Seek(0);
- foo[0] = 3;
- foo[1] = 0;
- foo[2] = 0;
- foo[3] = 0;
- aFoo = read_lenPrefixed_uInt8s_ToOString<sal_uInt32>(aMemStream);
- CPPUNIT_ASSERT(aFoo.equalsL(RTL_CONSTASCII_STRINGPARAM("bar")));
- CPPUNIT_ASSERT(aMemStream.good());
- CPPUNIT_ASSERT(!aMemStream.bad());
- CPPUNIT_ASSERT(!aMemStream.eof());
- }
CPPUNIT_TEST_SUITE_REGISTRATION(Test);
}
diff --git a/tools/source/inet/inetmsg.cxx b/tools/source/inet/inetmsg.cxx
index f626dcccd508..f5fa071ad15a 100644
--- a/tools/source/inet/inetmsg.cxx
+++ b/tools/source/inet/inetmsg.cxx
@@ -66,7 +66,7 @@ inline sal_Unicode ascii_toLowerCase( sal_Unicode ch )
/*
* ~INetMessage.
*/
-INetMessage::~INetMessage()
+INetMessage::~INetMessage (void)
{
ListCleanup_Impl();
}
@@ -74,7 +74,7 @@ INetMessage::~INetMessage()
/*
* ListCleanup_Impl.
*/
-void INetMessage::ListCleanup_Impl()
+void INetMessage::ListCleanup_Impl (void)
{
// Cleanup.
sal_uIntPtr i, n = m_aHeaderList.size();
@@ -243,7 +243,7 @@ enum _ImplINetRFC822MessageHeaderState
/*
* INetRFC822Message.
*/
-INetRFC822Message::INetRFC822Message()
+INetRFC822Message::INetRFC822Message (void)
: INetMessage()
{
for (sal_uInt16 i = 0; i < INETMSG_RFC822_NUMHDR; i++)
@@ -275,7 +275,7 @@ INetRFC822Message& INetRFC822Message::operator= (const INetRFC822Message& rMsg)
/*
* ~INetRFC822Message.
*/
-INetRFC822Message::~INetRFC822Message()
+INetRFC822Message::~INetRFC822Message (void)
{
}
@@ -753,7 +753,7 @@ enum _ImplINetMIMEMessageHeaderState
/*
* INetMIMEMessage.
*/
-INetMIMEMessage::INetMIMEMessage()
+INetMIMEMessage::INetMIMEMessage (void)
: INetRFC822Message (),
pParent (NULL),
bHeaderParsed (sal_False)
@@ -792,7 +792,7 @@ INetMIMEMessage& INetMIMEMessage::operator= (
/*
* ~INetMIMEMessage.
*/
-INetMIMEMessage::~INetMIMEMessage()
+INetMIMEMessage::~INetMIMEMessage (void)
{
// Cleanup.
CleanupImp();
@@ -801,7 +801,7 @@ INetMIMEMessage::~INetMIMEMessage()
/*
* CleanupImp.
*/
-void INetMIMEMessage::CleanupImp()
+void INetMIMEMessage::CleanupImp (void)
{
for( size_t i = 0, n = aChildren.size(); i < n; ++i ) {
delete aChildren[ i ];
@@ -1161,7 +1161,7 @@ SvStream& INetMIMEMessage::operator<< (SvStream& rStrm) const
for (sal_uInt16 i = 0; i < INETMSG_MIME_NUMHDR; i++)
rStrm << static_cast<sal_uInt32>(m_nIndex[i]);
- write_lenPrefixed_uInt8s_FromOString(rStrm, m_aBoundary);
+ rStrm.WriteByteString (m_aBoundary);
rStrm << static_cast<sal_uInt32>(aChildren.size());
return rStrm;
@@ -1181,7 +1181,7 @@ SvStream& INetMIMEMessage::operator>> (SvStream& rStrm)
m_nIndex[i] = nTemp;
}
- m_aBoundary = read_lenPrefixed_uInt8s_ToOString(rStrm);
+ rStrm.ReadByteString (m_aBoundary);
rStrm >> nTemp;
diff --git a/tools/source/inet/inetstrm.cxx b/tools/source/inet/inetstrm.cxx
index 5345067aa0f8..d70d84d2c30c 100644
--- a/tools/source/inet/inetstrm.cxx
+++ b/tools/source/inet/inetstrm.cxx
@@ -1608,7 +1608,7 @@ int INetMIMEMessageStream::PutMsgLine (const sal_Char *pData, sal_uIntPtr nSize)
// Multipart message body. Initialize multipart delimiters.
// Multipart message.
- if (pMsg->GetMultipartBoundary().getLength() == 0)
+ if (pMsg->GetMultipartBoundary().Len() == 0)
{
// Determine boundary.
rtl::OString aType(rtl::OUStringToOString(
diff --git a/tools/source/stream/stream.cxx b/tools/source/stream/stream.cxx
index b70195978008..5fa5b0e43380 100644
--- a/tools/source/stream/stream.cxx
+++ b/tools/source/stream/stream.cxx
@@ -806,7 +806,7 @@ sal_Bool SvStream::ReadUniOrByteStringLine( String& rStr, rtl_TextEncoding eSrcC
return ReadByteStringLine( rStr, eSrcCharSet );
}
-rtl::OString read_zeroTerminated_uInt8s_ToOString(SvStream& rStream)
+rtl::OString read_zeroTerminated_uInt8s_AsOString(SvStream& rStream)
{
rtl::OStringBuffer aOutput;
@@ -839,10 +839,10 @@ rtl::OString read_zeroTerminated_uInt8s_ToOString(SvStream& rStream)
return aOutput.makeStringAndClear();
}
-rtl::OUString read_zeroTerminated_uInt8s_ToOUString(SvStream& rStream, rtl_TextEncoding eEnc)
+rtl::OUString read_zeroTerminated_uInt8s_AsOUString(SvStream& rStream, rtl_TextEncoding eEnc)
{
return rtl::OStringToOUString(
- read_zeroTerminated_uInt8s_ToOString(rStream), eEnc);
+ read_zeroTerminated_uInt8s_AsOString(rStream), eEnc);
}
/*************************************************************************
@@ -1517,7 +1517,19 @@ SvStream& SvStream::ReadByteString( UniString& rStr, rtl_TextEncoding eSrcCharSe
return *this;
}
- rStr = read_lenPrefixed_uInt8s_ToOUString(*this, eSrcCharSet);
+ ByteString aStr;
+ ReadByteString( aStr );
+ rStr = UniString( aStr, eSrcCharSet );
+ return *this;
+}
+
+// -----------------------------------------------------------------------
+
+SvStream& SvStream::ReadByteString( ByteString& rStr )
+{
+ sal_uInt16 nLen = 0;
+ operator>>( nLen );
+ rStr = read_uInt8s_AsOString(*this, nLen);
return *this;
}
@@ -1551,7 +1563,17 @@ SvStream& SvStream::WriteByteString( const UniString& rStr, rtl_TextEncoding eDe
return *this;
}
- write_lenPrefixed_uInt8s_FromOUString(*this, rStr, eDestCharSet);
+ return WriteByteString(rtl::OUStringToOString(rStr, eDestCharSet));
+}
+
+// -----------------------------------------------------------------------
+
+SvStream& SvStream::WriteByteString( const ByteString& rStr)
+{
+ sal_uInt16 nLen = rStr.Len();
+ operator<< ( nLen );
+ if( nLen != 0 )
+ Write( rStr.GetBuffer(), nLen );
return *this;
}
@@ -2432,7 +2454,7 @@ void SvDataCopyStream::Assign( const SvDataCopyStream& )
}
//Create a OString of nLen bytes from rStream
-rtl::OString read_uInt8s_ToOString(SvStream& rStrm, sal_Size nLen)
+rtl::OString read_uInt8s_AsOString(SvStream& rStrm, sal_Size nLen)
{
using comphelper::string::rtl_string_alloc;
@@ -2459,7 +2481,7 @@ rtl::OString read_uInt8s_ToOString(SvStream& rStrm, sal_Size nLen)
}
//Create a OUString of nLen little endian sal_Unicodes from rStream
-rtl::OUString read_LEuInt16s_ToOUString(SvStream& rStrm, sal_Size nLen)
+rtl::OUString read_LEuInt16s_AsOUString(SvStream& rStrm, sal_Size nLen)
{
using comphelper::string::rtl_uString_alloc;