diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2015-06-17 15:18:10 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2015-06-17 15:24:19 +0200 |
| commit | 8e1ad966262932516b3368d9b5c44becb29524d4 (patch) | |
| tree | 4dbee378e3376712011631734195886fb41404e2 /toolkit/source/awt/vclxgraphics.cxx | |
| parent | 0f5b7dfea974c21b48843c3cbf7fdf344ad54a3a (diff) | |
Some missing SolarMutexGuard around VclPtr acquire/release
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so
apparently rely on the SolarMutex being locked whenever they are called. Fixed
those places that caused "make check" to fail for me when temporarily adding
DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is
that a class fails to ensure the SolarMutex is locked around the destruction of
non-null VclPtr members.)
Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5
Diffstat (limited to 'toolkit/source/awt/vclxgraphics.cxx')
| -rw-r--r-- | toolkit/source/awt/vclxgraphics.cxx | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/toolkit/source/awt/vclxgraphics.cxx b/toolkit/source/awt/vclxgraphics.cxx index 073afa5946fd..482e29c47021 100644 --- a/toolkit/source/awt/vclxgraphics.cxx +++ b/toolkit/source/awt/vclxgraphics.cxx @@ -80,6 +80,9 @@ VCLXGraphics::~VCLXGraphics() } delete mpClipRegion; + + SolarMutexGuard g; + mpOutputDevice.reset(); } void VCLXGraphics::SetOutputDevice( OutputDevice* pOutDev ) |