summaryrefslogtreecommitdiff
path: root/sw
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2016-05-11 17:09:13 +0200
committerStephan Bergmann <sbergman@redhat.com>2016-05-11 17:09:13 +0200
commit01f787a21a9dd0116545fbaa13d0a073db5b5d74 (patch)
tree62a0065ed2170174a79ccf05ef81943d4e665fe6 /sw
parent6356b3374788cc9e90e23dd17cc3ff536ac7fed8 (diff)
Mark dubious fallthrough cases as "SAL_FALLTHROUGH; //TODO ???"
Would be great if people knowing about the respective code areas could look into these, and either change them into plain "SAL_FALLTHROUGH;" or "break;". Change-Id: I6bd5e04bbb84452bea57d10946522b456c2ad5f0
Diffstat (limited to 'sw')
-rw-r--r--sw/source/filter/html/css1atr.cxx1
-rw-r--r--sw/source/filter/html/swhtml.cxx1
-rw-r--r--sw/source/uibase/shells/basesh.cxx1
-rw-r--r--sw/source/uibase/utlui/content.cxx1
4 files changed, 4 insertions, 0 deletions
diff --git a/sw/source/filter/html/css1atr.cxx b/sw/source/filter/html/css1atr.cxx
index 6f5ade66ee98..2394ed9c8765 100644
--- a/sw/source/filter/html/css1atr.cxx
+++ b/sw/source/filter/html/css1atr.cxx
@@ -1991,6 +1991,7 @@ void SwHTMLWriter::OutCSS1_FrameFormatOptions( const SwFrameFormat& rFrameFormat
}
break;
}
+ SAL_FALLTHROUGH; //TODO ???
case FLY_AT_PAGE:
case FLY_AT_FLY:
diff --git a/sw/source/filter/html/swhtml.cxx b/sw/source/filter/html/swhtml.cxx
index 6b0f99bb93c1..b419700de59c 100644
--- a/sw/source/filter/html/swhtml.cxx
+++ b/sw/source/filter/html/swhtml.cxx
@@ -1413,6 +1413,7 @@ void SwHTMLParser::NextToken( int nToken )
else
bGetIDOption = true;
// <BR>s in <PRE> resemble true LFs, hence no break
+ SAL_FALLTHROUGH; //TODO ???
case HTML_NEWPARA:
// CR in PRE/LISTING/XMP
diff --git a/sw/source/uibase/shells/basesh.cxx b/sw/source/uibase/shells/basesh.cxx
index 680da5088447..03572fcc3809 100644
--- a/sw/source/uibase/shells/basesh.cxx
+++ b/sw/source/uibase/shells/basesh.cxx
@@ -427,6 +427,7 @@ void SwBaseShell::StateClpbrd(SfxItemSet &rSet)
rSet.DisableItem( nWhich );
break;
}
+ SAL_FALLTHROUGH; //TODO ???
case SID_COPY:
if( !bCopy )
rSet.DisableItem( nWhich );
diff --git a/sw/source/uibase/utlui/content.cxx b/sw/source/uibase/utlui/content.cxx
index b0324efc7d67..a46822aa690c 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1791,6 +1791,7 @@ bool SwContentTree::FillTransferData( TransferDataContainer& rTransfer,
break;
else
rDragMode &= ~( DND_ACTION_MOVE | DND_ACTION_LINK );
+ SAL_FALLTHROUGH; //TODO ???
default:
sEntry = GetEntryText(pEntry);
}