Revert "crashtesting: frequent nulldef at end of SwTextFrame::ValidateFrame"

This reverts commit c5338e3ad116dbde0aed801f459173231716efa3.

The actual problem was fixed in previous commit for tdf#125475.

ValidateFrame() must only be called in text formatting with a
SwTextLineAccess keeping the corresponding SwTextLine alive.

Change-Id: I5b092b094f620f2dc2524aa5a83c673ec6b1fbbe
Reviewed-on: https://gerrit.libreoffice.org/73048
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

1 files changed, 5 insertions, 7 deletions

diff --git a/sw/source/core/text/frmform.cxx b/sw/source/core/text/frmform.cxx
index 3c018f0a702c..492a738941c3 100644
--- a/sw/source/core/text/frmform.cxx
+++ b/sw/source/core/text/frmform.cxx
@@ -107,13 +107,11 @@ void SwTextFrame::ValidateFrame()
     ValidateText( this );
 
     // We at least have to save the MustFit flag!
-    OSL_ENSURE( HasPara(), "ResetPreps(), missing ParaPortion." );
-    if (SwParaPortion *pPara = GetPara())
-    {
-        const bool bMustFit = pPara->IsPrepMustFit();
-        ResetPreps();
-        pPara->SetPrepMustFit( bMustFit );
-    }
+    assert(HasPara() && "ResetPreps(), missing ParaPortion, SwCache bug?");
+    SwParaPortion *pPara = GetPara();
+    const bool bMustFit = pPara->IsPrepMustFit();
+    ResetPreps();
+    pPara->SetPrepMustFit( bMustFit );
 }
 
 // After a RemoveFootnote the BodyFrame and all Frames contained within it, need to be