diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2023-09-11 15:28:11 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2023-09-11 17:14:08 +0200 |
| commit | 0867f7f3a955549079722d61e0c13e233e0af150 (patch) | |
| tree | b427d773a0a89f8652a9bf98ec8e131c70662b1c /sw/qa/core/text/text.cxx | |
| parent | cea165a3ebdb5f2a2b172004ff1b3848f303d78a (diff) | |
In test, use char from older Unicode version, supported by older ICU
3af30bafbedb8eb481024efb35cb7876c63d26dc "sw: Handle surrogate pairs when
tweaking script info" had added a test involving U+10EFD ARABIC SMALL LOW WORD,
which was only introduced in Unicode 15 (cf.
<https://util.unicode.org/UnicodeJsps/character.jsp?a=10EFD>), which is only
supported since ICU 72 (cf. <https://icu.unicode.org/download/72>). But at
least the Flathub builds with org.freedesktop.Sdk//22.08 are done against
ICU 71, and those builds failed with
> Test name: testScriptinfosurrogatePairs::TestBody
> equality assertion failed
> - Expected: 11
> - Actual : 11◌
> - In <>, attribute 'portion' of '//txt[1]/SwParaPortion/SwLineLayout/SwLinePortion[1]' incorrect value.
U+10A01 KHAROSHTHI VOWEL SIGN I appears to be a character with similar
properties (it would make the test fail in the expected way when
sw/source/core/text/porlay.cxx is rolled back to before
3af30bafbedb8eb481024efb35cb7876c63d26dc), but is already present since Unicode
4.1 (cf. <https://util.unicode.org/UnicodeJsps/character.jsp?a=10A01>), so
should be less problematic.
Change-Id: I61f6e32069b895720cbee5e3d2ce1295727cfd51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156825
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'sw/qa/core/text/text.cxx')
| -rw-r--r-- | sw/qa/core/text/text.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sw/qa/core/text/text.cxx b/sw/qa/core/text/text.cxx index 123be460df8c..45198e0aaa9a 100644 --- a/sw/qa/core/text/text.cxx +++ b/sw/qa/core/text/text.cxx @@ -1477,7 +1477,7 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testScriptinfosurrogatePairs) // - Actual : 11◌ assertXPath(pXmlDoc, "//txt[1]/SwParaPortion/SwLineLayout/SwLinePortion[1]", "portion", u"11"); assertXPath(pXmlDoc, "//txt[1]/SwParaPortion/SwLineLayout/SwLinePortion[2]", "portion", - u"\u25CC\U00010EFD"); + u"\u25CC\U00010A01"); // Without the fix this would crash because we got a lone surrogate that // can’t be converted to UTF-8, but if it were not for that it might fail |