SfxHint: convert home-grown RTTI to normal C++ RTTI

Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.

Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>

3 files changed, 15 insertions, 15 deletions

diff --git a/svx/source/accessibility/AccessibleEmptyEditSource.cxx b/svx/source/accessibility/AccessibleEmptyEditSource.cxx
index d2d0ac252d42..043718365ae8 100644
--- a/svx/source/accessibility/AccessibleEmptyEditSource.cxx
+++ b/svx/source/accessibility/AccessibleEmptyEditSource.cxx
@@ -316,7 +316,7 @@ namespace accessibility
 
     void AccessibleEmptyEditSource::Notify( SfxBroadcaster& /*rBC*/, const SfxHint& rHint )
     {
-        const SdrHint* pSdrHint = PTR_CAST( SdrHint, &rHint );
+        const SdrHint* pSdrHint = dynamic_cast<const SdrHint*>( &rHint );
 
         if( pSdrHint && pSdrHint->GetKind() == HINT_BEGEDIT &&
             &mrObj == pSdrHint->GetObject() && mpEditSource.get() )
diff --git a/svx/source/accessibility/AccessibleTextHelper.cxx b/svx/source/accessibility/AccessibleTextHelper.cxx
index f73bceeaba77..32444e634ffe 100644
--- a/svx/source/accessibility/AccessibleTextHelper.cxx
+++ b/svx/source/accessibility/AccessibleTextHelper.cxx
@@ -1064,8 +1064,8 @@ namespace accessibility
                 mnParasChanged != -1 )
             {
                 // determine hint type
-                const TextHint* pTextHint = PTR_CAST( TextHint, pEvent );
-                const SvxEditSourceHint* pEditSourceHint = PTR_CAST( SvxEditSourceHint, pEvent );
+                const TextHint* pTextHint = dynamic_cast<const TextHint*>( pEvent );
+                const SvxEditSourceHint* pEditSourceHint = dynamic_cast<const SvxEditSourceHint*>( pEvent );
 
                 if( !pEditSourceHint && pTextHint &&
                     (pTextHint->GetId() == TEXT_HINT_PARAINSERTED ||
@@ -1234,11 +1234,11 @@ namespace accessibility
                 const SfxHint& rHint = *(pHint.get());
 
                 // determine hint type
-                const SdrHint* pSdrHint = PTR_CAST( SdrHint, &rHint );
-                const SfxSimpleHint* pSimpleHint = PTR_CAST( SfxSimpleHint, &rHint );
-                const TextHint* pTextHint = PTR_CAST( TextHint, &rHint );
-                const SvxViewHint* pViewHint = PTR_CAST( SvxViewHint, &rHint );
-                const SvxEditSourceHint* pEditSourceHint = PTR_CAST( SvxEditSourceHint, &rHint );
+                const SdrHint* pSdrHint = dynamic_cast<const SdrHint*>( &rHint );
+                const SfxSimpleHint* pSimpleHint = dynamic_cast<const SfxSimpleHint*>( &rHint );
+                const TextHint* pTextHint = dynamic_cast<const TextHint*>( &rHint );
+                const SvxViewHint* pViewHint = dynamic_cast<const SvxViewHint*>( &rHint );
+                const SvxEditSourceHint* pEditSourceHint = dynamic_cast<const SvxEditSourceHint*>( &rHint );
 
                 try
                 {
@@ -1415,11 +1415,11 @@ namespace accessibility
         mbInNotify = true;
 
         // determine hint type
-        const SdrHint* pSdrHint = PTR_CAST( SdrHint, &rHint );
-        const SfxSimpleHint* pSimpleHint = PTR_CAST( SfxSimpleHint, &rHint );
-        const TextHint* pTextHint = PTR_CAST( TextHint, &rHint );
-        const SvxViewHint* pViewHint = PTR_CAST( SvxViewHint, &rHint );
-        const SvxEditSourceHint* pEditSourceHint = PTR_CAST( SvxEditSourceHint, &rHint );
+        const SdrHint* pSdrHint = dynamic_cast<const SdrHint*>( &rHint );
+        const SfxSimpleHint* pSimpleHint = dynamic_cast<const SfxSimpleHint*>( &rHint );
+        const TextHint* pTextHint = dynamic_cast<const TextHint*>( &rHint );
+        const SvxViewHint* pViewHint = dynamic_cast<const SvxViewHint*>( &rHint );
+        const SvxEditSourceHint* pEditSourceHint = dynamic_cast<const SvxEditSourceHint*>( &rHint );
 
         try
         {
diff --git a/svx/source/accessibility/GraphCtlAccessibleContext.cxx b/svx/source/accessibility/GraphCtlAccessibleContext.cxx
index 085bbb99dd46..0838e3138ffa 100644
--- a/svx/source/accessibility/GraphCtlAccessibleContext.cxx
+++ b/svx/source/accessibility/GraphCtlAccessibleContext.cxx
@@ -816,7 +816,7 @@ Rectangle SvxGraphCtrlAccessibleContext::GetBoundingBox( void ) throw( RuntimeEx
 
 void SvxGraphCtrlAccessibleContext::Notify( SfxBroadcaster& /*rBC*/, const SfxHint& rHint )
 {
-    const SdrHint* pSdrHint = PTR_CAST( SdrHint, &rHint );
+    const SdrHint* pSdrHint = dynamic_cast<const SdrHint*>( &rHint );
 
     if( pSdrHint )
     {
@@ -852,7 +852,7 @@ void SvxGraphCtrlAccessibleContext::Notify( SfxBroadcaster& /*rBC*/, const SfxHi
     }
     else
     {
-        const SfxSimpleHint* pSfxHint = PTR_CAST(SfxSimpleHint, &rHint );
+        const SfxSimpleHint* pSfxHint = dynamic_cast<const SfxSimpleHint*>( &rHint );
 
         // Has our SdDrawDocument just died?
         if(pSfxHint && pSfxHint->GetId() == SFX_HINT_DYING)